Skip to contentSkip to conversation

reset: qcom-aoss: Allow CONFIG_RESET_QCOM_AOSS to be a tristate

PATCH Superseded John Stultz 2 participants 2 messages Jan 7, 2020 – Jan 8, 2020

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 reset: qcom-aoss: Allow CONFIG_RESET_QCOM_AOSS to be a tristate

Allow CONFIG_RESET_QCOM_AOSS to be set as as =m to allow for the driver to be loaded from a modules.

Also replaces the builtin_platform_driver() line with module_platform_driver()

Cc Todd Kjos <[email protected]>
Cc Alistair Delva <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Amit Pundir <[email protected]>
Cc Philipp Zabel <[email protected]>

---
v2: Fix builtin_platform_driver line in driver code

---
 drivers/reset/Kconfig           | 2 +-
 drivers/reset/reset-qcom-aoss.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/reset/Kconfig +1 -1
index 3ad7817ce1f0..45e70524af36 100644
@@ -99,7 +99,7 @@ config RESET_PISTACHIO
 	  This enables the reset driver for ImgTec Pistachio SoCs.
 
 config RESET_QCOM_AOSS
-	bool "Qcom AOSS Reset Driver"
+	tristate "Qcom AOSS Reset Driver"
 	depends on ARCH_QCOM || COMPILE_TEST
 	help
 	  This enables the AOSS (always on subsystem) reset driver
drivers/reset/reset-qcom-aoss.c +1 -1
index 36db96750450..76367f17fc73 100644
@@ -127,7 +127,7 @@ static struct platform_driver qcom_aoss_reset_driver = {
 	},
 };
 
-builtin_platform_driver(qcom_aoss_reset_driver);
+module_platform_driver(qcom_aoss_reset_driver);
 
 MODULE_DESCRIPTION("Qualcomm AOSS Reset Driver");
 MODULE_LICENSE("GPL v2");
Signature · 1 line
2.17.1
#1 lore raw
Quoted 37 lines · John Stultz

Allow CONFIG_RESET_QCOM_AOSS to be set as as =m to allow for the driver to be loaded from a modules.

Also replaces the builtin_platform_driver() line with module_platform_driver()

Cc Todd Kjos <[email protected]>
Cc Alistair Delva <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Amit Pundir <[email protected]>
Cc Philipp Zabel <[email protected]>

---
v2: Fix builtin_platform_driver line in driver code

---
 drivers/reset/Kconfig           | 2 +-
 drivers/reset/reset-qcom-aoss.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/reset/Kconfig +1 -1
index 3ad7817ce1f0..45e70524af36 100644
@@ -99,7 +99,7 @@ config RESET_PISTACHIO
 	  This enables the reset driver for ImgTec Pistachio SoCs.
 
 config RESET_QCOM_AOSS
-	bool "Qcom AOSS Reset Driver"
+	tristate "Qcom AOSS Reset Driver"
 	depends on ARCH_QCOM || COMPILE_TEST
 	help
 	  This enables the AOSS (always on subsystem) reset driver
drivers/reset/reset-qcom-aoss.c +0 -0
index 36db96750450..76367f17fc73 100644

drivers/reset/reset-qcom-aoss.c static struct platform_driver qcom_aoss_reset_driver = { · line 130

Quoted 5 lines
drivers/reset/reset-qcom-aoss.c +1 -1
@@ -127,7 +127,7 @@ static struct platform_driver qcom_aoss_reset_driver = {
 	},
 };
 
-builtin_platform_driver(qcom_aoss_reset_driver);
+module_platform_driver(qcom_aoss_reset_driver);

Thought we had this covered already, sorry for missing it yesterday.

In addition to module_platform_driver() you also need a MODULE_DEVICE_TABLE(of, qcom_aoss_reset_of_match), or the driver won't be loaded automatically.

Regards,
Bjorn