Skip to contentSkip to conversation

selftests/ftrace: fix glob selftest

PATCH Superseded Sven Schnelle 3 participants 5 messages Jan 8, 2020 – Jan 28, 2020

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 selftests/ftrace: fix glob selftest

test.d/ftrace/func-filter-glob.tc is failing on s390 because it has ARCH_INLINE_SPIN_LOCK and friends set to 'y'. So the usual __raw_spin_lock symbol isn't in the ftrace function list. Change '*aw*lock' to '*spin*lock' which would hopefully match some of the locking functions on all platforms.

---

Changes in v3:
change '*spin*lock' to '*pin*lock' to not match the beginning

Changes in v2:
use '*spin*lock' instead of '*ktime*ns'

 .../testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc +1 -1
index 27a54a17da65..f4e92afab14b 100644
@@ -30,7 +30,7 @@ ftrace_filter_check '*schedule*' '^.*schedule.*$'
 ftrace_filter_check 'schedule*' '^schedule.*$'
 
 # filter by *mid*end
-ftrace_filter_check '*aw*lock' '.*aw.*lock$'
+ftrace_filter_check '*pin*lock' '.*pin.*lock$'
 
 # filter by start*mid*
 ftrace_filter_check 'mutex*try*' '^mutex.*try.*'
Signature · 1 line
2.17.1
maintainer Reviewed-by on v3 1/1
#1 lore raw

Shuah,

Want to take this through your tree?

https://lore.kernel.org/r/[email protected]

Thanks!

-- Steve

Quoted 31 lines · On Wed, 8 Jan 2020 08:40:43 +0100 Sven Schnelle <[email protected]> wrote:

test.d/ftrace/func-filter-glob.tc is failing on s390 because it has ARCH_INLINE_SPIN_LOCK and friends set to 'y'. So the usual __raw_spin_lock symbol isn't in the ftrace function list. Change '*aw*lock' to '*spin*lock' which would hopefully match some of the locking functions on all platforms.

---

Changes in v3:
change '*spin*lock' to '*pin*lock' to not match the beginning

Changes in v2:
use '*spin*lock' instead of '*ktime*ns'

 .../testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc +1 -1
index 27a54a17da65..f4e92afab14b 100644
@@ -30,7 +30,7 @@ ftrace_filter_check '*schedule*' '^.*schedule.*$'
 ftrace_filter_check 'schedule*' '^schedule.*$'
 
 # filter by *mid*end
-ftrace_filter_check '*aw*lock' '.*aw.*lock$'
+ftrace_filter_check '*pin*lock' '.*pin.*lock$'
 
 # filter by start*mid*
 ftrace_filter_check 'mutex*try*' '^mutex.*try.*'
#3 lore raw
Quoted 7 lines · Sven Schnelle

Hi Steve,

Quoted 3 lines · Steven Rostedt

Shuah,

Quoted 8 lines
Quoted 5 lines

Want to take this through your tree?

https://lore.kernel.org/r/[email protected]

As Shuah didn't reply, can you push that through your tree?

Hi Sven,

Did you run getmaintainers of this patch? You didn't send this to my email address listed in the get maintainers file and also didn't cc linux-kselftest.

I just happen to notice this now. Please resend with steve's Reviewed-by tag to the recipients suggested by get_maintainers.pl

I will take this through ksleftest tree.

thanks,
-- Shuah

#4 lore raw

Hi Shuah,

Quoted 14 lines · Shuah Khan
Quoted 13 lines · Sven Schnelle

Hi Steve,

Quoted 8 lines · Steven Rostedt

Shuah,

Want to take this through your tree?

https://lore.kernel.org/r/[email protected]

Quoted 8 lines
Quoted 2 lines

As Shuah didn't reply, can you push that through your tree?

Hi Sven,

Did you run getmaintainers of this patch? You didn't send this to my email address listed in the get maintainers file and also didn't cc linux-kselftest.

My fault, sorry.

Quoted 3 lines

I just happen to notice this now. Please resend with steve's Reviewed-by tag to the recipients suggested by get_maintainers.pl I will take this through ksleftest tree.

Ok, thanks.

Regards
Sven