Skip to contentSkip to conversation

selftests/ftrace: fix glob selftest

PATCH Superseded Sven Schnelle 2 participants 2 messages Jan 7, 2020

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 selftests/ftrace: fix glob selftest

test.d/ftrace/func-filter-glob.tc is failing on s390 because it has ARCH_INLINE_SPIN_LOCK and friends set to 'y'. So the usual __raw_spin_lock symbol isn't in the ftrace function list. Change '*aw*lock' to '*spin*lock' which would hopefully match some of the locking functions on all platforms.

---
 .../testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc +1 -1
index 27a54a17da65..cf296a3dd723 100644
@@ -30,7 +30,7 @@ ftrace_filter_check '*schedule*' '^.*schedule.*$'
 ftrace_filter_check 'schedule*' '^schedule.*$'
 
 # filter by *mid*end
-ftrace_filter_check '*aw*lock' '.*aw.*lock$'
+ftrace_filter_check '*spin*lock' '.*spin.*lock$'
 
 # filter by start*mid*
 ftrace_filter_check 'mutex*try*' '^mutex.*try.*'
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 16 lines · On Tue, 7 Jan 2020 10:40:47 +0100 Sven Schnelle <[email protected]> wrote:

test.d/ftrace/func-filter-glob.tc is failing on s390 because it has ARCH_INLINE_SPIN_LOCK and friends set to 'y'. So the usual __raw_spin_lock symbol isn't in the ftrace function list. Change '*aw*lock' to '*spin*lock' which would hopefully match some of the locking functions on all platforms.

---
 .../testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc +0 -0
index 27a54a17da65..cf296a3dd723 100644

tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc ftrace_filter_check '*schedule*' '^.*schedule.*$' · line 33

Quoted 5 lines
tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc +1 -1
@@ -30,7 +30,7 @@ ftrace_filter_check '*schedule*' '^.*schedule.*$'
 ftrace_filter_check 'schedule*' '^schedule.*$'
 
 # filter by *mid*end
-ftrace_filter_check '*aw*lock' '.*aw.*lock$'
+ftrace_filter_check '*spin*lock' '.*spin.*lock$'

Just to make it not check the beginning, can you remove the 's':

'*pin*lock' '.*pin.*lock$'

Thanks!

-- Steve

Quoted 3 lines
tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc +0 -0
 # filter by start*mid*
 ftrace_filter_check 'mutex*try*' '^mutex.*try.*'