Skip to contentSkip to conversation

ARM: dts: rockchip: add reg property to brcmf sub node for rk3188-bqedison2qc

PATCH In review Johan Jonker 2 participants 2 messages Jan 10, 2020 – Jan 13, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: rockchip: add reg property to brcmf sub node for rk3188-bqedison2qc

An experimental test with the command below gives this error:
rk3188-bqedison2qc.dt.yaml: dwmmc@10218000: wifi@1:
'reg' is a required property

So fix this by adding a reg property to the brcmf sub node. Also add #address-cells and #size-cells to prevent more warnings.

make ARCH=arm dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml

---
 arch/arm/boot/dts/rk3188-bqedison2qc.dts | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/boot/dts/rk3188-bqedison2qc.dts +3 -0
index c8b62bbd6..ad1afd403 100644
@@ -466,9 +466,12 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&sd1_clk>, <&sd1_cmd>, <&sd1_bus4>;
 	vmmcq-supply = <&vccio_wl>;
+	#address-cells = <1>;
+	#size-cells = <0>;
 	status = "okay";
 
 	brcmf: wifi@1 {
+		reg = <1>;
 		compatible = "brcm,bcm4329-fmac";
 		interrupt-parent = <&gpio3>;
 		interrupts = <RK_PD2 GPIO_ACTIVE_HIGH>;
Signature · 1 line
2.11.0
maintainer
#1 lore raw

Am Freitag, 10. Januar 2020, 14:44:20 CET schrieb Johan Jonker:

Quoted 11 lines

An experimental test with the command below gives this error:
rk3188-bqedison2qc.dt.yaml: dwmmc@10218000: wifi@1:
'reg' is a required property

So fix this by adding a reg property to the brcmf sub node. Also add #address-cells and #size-cells to prevent more warnings.

make ARCH=arm dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml

applied for 5.6

Thanks
Heiko