ASoC: atmel: fix build error with CONFIG_SND_ATMEL_SOC_DMA=m
PATCH 1/1 ASoC: atmel: fix build error with CONFIG_SND_ATMEL_SOC_DMA=m
If CONFIG_SND_ATMEL_SOC_DMA=m, build error:
sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio':
(.text+0x7cd): undefined reference to `atmel_pcm_dma_platform_register'
Function atmel_pcm_dma_platform_register is defined under CONFIG SND_ATMEL_SOC_DMA, so select SND_ATMEL_SOC_DMA in CONFIG SND_ATMEL_SOC_SSC, same to CONFIG_SND_ATMEL_SOC_PDC.
--- sound/soc/atmel/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/atmel/Kconfig +2 -0
@@ -19,6 +19,8 @@ config SND_ATMEL_SOC_DMA config SND_ATMEL_SOC_SSC tristate + select SND_ATMEL_SOC_DMA + select SND_ATMEL_SOC_PDC config SND_ATMEL_SOC_SSC_PDC tristate "SoC PCM DAI support for AT91 SSC controller using PDC"
Signature · 1 line
2.7.4
Mark Brown
maintainerQuoted 4 lines · Chen Zhou
If
CONFIG_SND_ATMEL_SOC_DMA=m, build error:
sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio':
(.text+0x7cd): undefined reference to `atmel_pcm_dma_platform_register'
You should make sure to CC maintainers on patches, that includes driver-specific maintainers (as is the case for this one), it's fine in this case so no need to resend but please bear this in mind in future.
Quoted 8 lines · Chen Zhou
If
CONFIG_SND_ATMEL_SOC_DMA=m, build error:
sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio':
(.text+0x7cd): undefined reference to `atmel_pcm_dma_platform_register'Function
atmel_pcm_dma_platform_registeris defined under CONFIGSND_ATMEL_SOC_DMA, so selectSND_ATMEL_SOC_DMAin CONFIGSND_ATMEL_SOC_SSC, same toCONFIG_SND_ATMEL_SOC_PDC.
Arnd sent a more complete patch for this issue:
https://lkml.org/lkml/2019/10/1/620
It wasn't merged due to some integration issues. Could you please try it and let us know if it fixes your issue?
Thanks and best regards,
Codrin
Quoted 23 lines
Reported-by Hulk Robot <[email protected]>Signed-off-by Chen Zhou <[email protected]>--- sound/soc/atmel/Kconfig | 2 ++ 1 file changed, 2 insertions(+)sound/soc/atmel/Kconfig +2
-1@@ -19,6 +19,8 @@ config SND_ATMEL_SOC_DMA config SND_ATMEL_SOC_SSC tristate + select SND_ATMEL_SOC_DMA + select SND_ATMEL_SOC_PDC config SND_ATMEL_SOC_SSC_PDC tristate "SoC PCM DAI support for AT91 SSC controller using PDC" --2.7.4