Skip to contentSkip to conversation

ASoC: atmel: fix build error with CONFIG_SND_ATMEL_SOC_DMA=m

PATCH In review Chen Zhou 3 participants 3 messages Jan 13, 2020

Subsystems (4)
lore
Share & tools
lore

Chen Zhou

author
#0 lore raw

PATCH 1/1 ASoC: atmel: fix build error with CONFIG_SND_ATMEL_SOC_DMA=m

If CONFIG_SND_ATMEL_SOC_DMA=m, build error:

sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio':
(.text+0x7cd): undefined reference to `atmel_pcm_dma_platform_register'

Function atmel_pcm_dma_platform_register is defined under CONFIG SND_ATMEL_SOC_DMA, so select SND_ATMEL_SOC_DMA in CONFIG SND_ATMEL_SOC_SSC, same to CONFIG_SND_ATMEL_SOC_PDC.

---
 sound/soc/atmel/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/atmel/Kconfig +2 -0
index f118c22..d1dc8e6 100644
@@ -19,6 +19,8 @@ config SND_ATMEL_SOC_DMA
 
 config SND_ATMEL_SOC_SSC
 	tristate
+	select SND_ATMEL_SOC_DMA
+	select SND_ATMEL_SOC_PDC
 
 config SND_ATMEL_SOC_SSC_PDC
 	tristate "SoC PCM DAI support for AT91 SSC controller using PDC"
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 4 lines · Chen Zhou

If CONFIG_SND_ATMEL_SOC_DMA=m, build error:

sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio':
(.text+0x7cd): undefined reference to `atmel_pcm_dma_platform_register'

You should make sure to CC maintainers on patches, that includes driver-specific maintainers (as is the case for this one), it's fine in this case so no need to resend but please bear this in mind in future.

#2 lore raw
In reply to Chen Zhou
Quoted 8 lines · Chen Zhou

If CONFIG_SND_ATMEL_SOC_DMA=m, build error:

sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio':
(.text+0x7cd): undefined reference to `atmel_pcm_dma_platform_register'

Function atmel_pcm_dma_platform_register is defined under CONFIG SND_ATMEL_SOC_DMA, so select SND_ATMEL_SOC_DMA in CONFIG SND_ATMEL_SOC_SSC, same to CONFIG_SND_ATMEL_SOC_PDC.

Arnd sent a more complete patch for this issue:
https://lkml.org/lkml/2019/10/1/620

It wasn't merged due to some integration issues. Could you please try it and let us know if it fixes your issue?

Thanks and best regards,
Codrin

Quoted 23 lines
---
  sound/soc/atmel/Kconfig | 2 ++
  1 file changed, 2 insertions(+)
sound/soc/atmel/Kconfig +2 -1
index f118c22..d1dc8e6 100644
@@ -19,6 +19,8 @@ config SND_ATMEL_SOC_DMA
 
  config SND_ATMEL_SOC_SSC
         tristate
+       select SND_ATMEL_SOC_DMA
+       select SND_ATMEL_SOC_PDC
 
  config SND_ATMEL_SOC_SSC_PDC
         tristate "SoC PCM DAI support for AT91 SSC controller using PDC"
--

2.7.4