Skip to contentSkip to conversation

arm: dts: i.mx8x: add #cooling-cells properties

PATCH New Anatolij Gustschin 4 participants 5 messages Jan 18, 2020 – Jan 20, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: dts: i.mx8x: add #cooling-cells properties

Fix dtb building warnings:
Warning (cooling_device_property): /thermal-zones/cpu-thermal0/cooling-maps/map0:
Missing property '#cooling-cells' in node /cpus/cpu at 0 or bad phandle (referred from cooling-device[0])

---
 arch/arm/dts/fsl-imx8-ca35.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/dts/fsl-imx8-ca35.dtsi +4 -0
index 28bc32c8b7..9af8b1511c 100644
@@ -18,6 +18,7 @@
 			reg = <0x0 0x0>;
 			enable-method = "psci";
 			next-level-cache = <&A35_L2>;
+			#cooling-cells = <2>;
 		};
 
 		A35_1: cpu at 1 {
@@ -26,6 +27,7 @@
 			reg = <0x0 0x1>;
 			enable-method = "psci";
 			next-level-cache = <&A35_L2>;
+			#cooling-cells = <2>;
 		};
 
 		A35_2: cpu at 2 {
@@ -34,6 +36,7 @@
 			reg = <0x0 0x2>;
 			enable-method = "psci";
 			next-level-cache = <&A35_L2>;
+			#cooling-cells = <2>;
 		};
 
 		A35_3: cpu at 3 {
@@ -42,6 +45,7 @@
 			reg = <0x0 0x3>;
 			enable-method = "psci";
 			next-level-cache = <&A35_L2>;
+			#cooling-cells = <2>;
 		};
 
 		A35_L2: l2-cache0 {
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 arm: dts: i.mx8x: add #cooling-cells properties

Quoted 4 lines · Anatolij Gustschin

Fix dtb building warnings:
Warning (cooling_device_property): /thermal-zones/cpu-thermal0/cooling-maps/map0:
Missing property '#cooling-cells' in node /cpus/cpu at 0 or bad phandle (referred from cooling-device[0])

Thanks for fixing this.

Quoted 35 lines
---
 arch/arm/dts/fsl-imx8-ca35.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/dts/fsl-imx8-ca35.dtsi +3 -0
index 28bc32c8b7..9af8b1511c 100644
@@ -18,6 +18,7 @@
 			reg = <0x0 0x0>;
 			enable-method = "psci";
 			next-level-cache = <&A35_L2>;
+			#cooling-cells = <2>;
 		};
 
 		A35_1: cpu at 1 {
@@ -26,6 +27,7 @@
 			reg = <0x0 0x1>;
 			enable-method = "psci";
 			next-level-cache = <&A35_L2>;
+			#cooling-cells = <2>;
 		};
 
 		A35_2: cpu at 2 {
@@ -34,6 +36,7 @@
 			reg = <0x0 0x2>;
 			enable-method = "psci";
 			next-level-cache = <&A35_L2>;
+			#cooling-cells = <2>;
 		};
 
 		A35_3: cpu at 3 {

arch/arm/dts/fsl-imx8-ca35.dtsi line 51

Quoted 7 lines
arch/arm/dts/fsl-imx8-ca35.dtsi +1 -0
@@ -42,6 +45,7 @@
 			reg = <0x0 0x3>;
 			enable-method = "psci";
 			next-level-cache = <&A35_L2>;
+			#cooling-cells = <2>;
 		};
 
 		A35_L2: l2-cache0 {

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
reviewer
#2 lore raw

PATCH 1/1 arm: dts: i.mx8x: add #cooling-cells properties

In reply to Anatolij Gustschin
Quoted 15 lines · Anatolij Gustschin

Fix dtb building warnings:
Warning (cooling_device_property): /thermal-zones/cpu-thermal0/cooling-maps/map0:
Missing property '#cooling-cells' in node /cpus/cpu at 0 or bad phandle (referred from cooling-device[0])

---
 arch/arm/dts/fsl-imx8-ca35.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/dts/fsl-imx8-ca35.dtsi +0 -0
index 28bc32c8b7..9af8b1511c 100644

arch/arm/dts/fsl-imx8-ca35.dtsi line 21

Quoted 4 lines
arch/arm/dts/fsl-imx8-ca35.dtsi +1 -0
@@ -18,6 +18,7 @@
                        reg = <0x0 0x0>;
                        enable-method = "psci";
                        next-level-cache = <&A35_L2>;
+                       #cooling-cells = <2>;

Yes, this matches arch/arm64/boot/dts/freescale/imx8qxp.dtsi upstream.

Maybe we should sync with upstream at some point.

#3 lore raw

PATCH 1/1 arm: dts: i.mx8x: add #cooling-cells properties

Quoted 27 lines

Subject: Re: [PATCH] arm: dts: i.mx8x: add #cooling-cells properties

Quoted 3 lines · Anatolij Gustschin

Fix dtb building warnings:
Warning (cooling_device_property):

/thermal-zones/cpu-thermal0/cooling-maps/map0:

Quoted 13 lines

Missing property '#cooling-cells' in node /cpus/cpu at 0 or bad phandle (referred from cooling-device[0])

---
 arch/arm/dts/fsl-imx8-ca35.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/arch/arm/dts/fsl-imx8-ca35.dtsi index 28bc32c8b7..9af8b1511c 100644

arch/arm/dts/fsl-imx8-ca35.dtsi line 21

Quoted 4 lines
arch/arm/dts/fsl-imx8-ca35.dtsi +1 -0
@@ -18,6 +18,7 @@
                        reg = <0x0 0x0>;
                        enable-method = "psci";
                        next-level-cache = <&A35_L2>;
+                       #cooling-cells = <2>;

Yes, this matches arch/arm64/boot/dts/freescale/imx8qxp.dtsi upstream.

Quoted 1 line

Maybe we should sync with upstream at some point.

I am still waiting Aisheng to finish the i.MX8QM and dts restructure, Aisheng did a big restructure. If import earlier, we have to import and adapt again.

Thanks,
Peng.

Quoted 2 lines
#4 lore raw

PATCH 1/1 arm: dts: i.mx8x: add #cooling-cells properties

In reply to Anatolij Gustschin
Quoted 6 lines

Fix dtb building warnings:
Warning (cooling_device_property): /thermal-zones/cpu-thermal0/cooling-maps/map0:
Missing property '#cooling-cells' in node /cpus/cpu at 0 or bad phandle (referred from cooling-device[0])

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================