Skip to contentSkip to conversation

arm: dts: imx7ulp-evk: remove mux value from pad configuration

PATCH New Jorge Ramirez-Ortiz 5 participants 7 messages Jan 15, 2020 – Jan 20, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: dts: imx7ulp-evk: remove mux value from pad configuration

The mux mode is embedded in the PAD definition and therefore there is no need to repeat it in the PAD configuration value (more over since this information will be masked out when the configuration value is applied).

---
 arch/arm/dts/imx7ulp-evk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/imx7ulp-evk.dts +1 -1
index 08a682f314..8f6a935e24 100644
@@ -156,7 +156,7 @@
 
 		pinctrl_backlight: backlight_grp {
 			fsl,pins = <
-				IMX7ULP_PAD_PTF2__PTF2		0x20100
+				IMX7ULP_PAD_PTF2__PTF2		0x20000
 			>;
 		};
 
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 arm: dts: imx7ulp-evk: remove mux value from pad configuration

Quoted 6 lines

Subject: [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration

The mux mode is embedded in the PAD definition and therefore there is no need to repeat it in the PAD configuration value (more over since this information will be masked out when the configuration value is applied).

Has this been accepted by Shawn?

Thanks,
Peng.

Quoted 21 lines
---
 arch/arm/dts/imx7ulp-evk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/imx7ulp-evk.dts +1 -2
index 08a682f314..8f6a935e24 100644
@@ -156,7 +156,7 @@
 
 		pinctrl_backlight: backlight_grp {
 			fsl,pins = <
-				IMX7ULP_PAD_PTF2__PTF2		0x20100
+				IMX7ULP_PAD_PTF2__PTF2		0x20000
 			>;
 		};
 
--

2.17.1

#2 lore raw

PATCH 1/1 arm: dts: imx7ulp-evk: remove mux value from pad configuration

Quoted 8 lines · Peng Fan
Quoted 6 lines

Subject: [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration

The mux mode is embedded in the PAD definition and therefore there is no need to repeat it in the PAD configuration value (more over since this information will be masked out when the configuration value is applied).

Has this been accepted by Shawn?

added to DL now

Quoted 26 lines

Thanks,
Peng.

Quoted 21 lines
---
 arch/arm/dts/imx7ulp-evk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/imx7ulp-evk.dts +1 -2
index 08a682f314..8f6a935e24 100644
@@ -156,7 +156,7 @@
 
 		pinctrl_backlight: backlight_grp {
 			fsl,pins = <
-				IMX7ULP_PAD_PTF2__PTF2		0x20100
+				IMX7ULP_PAD_PTF2__PTF2		0x20000
 			>;
 		};
 
--

2.17.1

reviewer
#3 lore raw

PATCH 1/1 arm: dts: imx7ulp-evk: remove mux value from pad configuration

Quoted 5 lines · Foundries
Quoted 3 lines · Peng Fan
Quoted 3 lines

Subject: [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

The mux mode is embedded in the PAD definition and therefore there is no need to repeat it in the PAD configuration value (more over since this information will be masked out when the configuration value is applied).

Has this been accepted by Shawn?

added to DL now

Mainline dts does not have backlight support, so this only affects U-Boot.

#4 lore raw

PATCH 1/1 arm: dts: imx7ulp-evk: remove mux value from pad configuration

Quoted 11 lines · Fabio Estevam
Quoted 9 lines · Foundries
Quoted 7 lines · Peng Fan
Quoted 6 lines

Subject: [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration

The mux mode is embedded in the PAD definition and therefore there is no need to repeat it in the PAD configuration value (more over since this information will be masked out when the configuration value is applied).

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Has this been accepted by Shawn?

added to DL now

Mainline dts does not have backlight support, so this only affects U-Boot.

yes, the dts is only incorrect in uboot (ie, any of the mux values that could be specified in the pad configuration field are just ignored)

reviewer
#5 lore raw

PATCH 1/1 arm: dts: imx7ulp-evk: remove mux value from pad configuration

In reply to Jorge Ramirez-Ortiz
Quoted 7 lines · Jorge Ramirez-Ortiz

The mux mode is embedded in the PAD definition and therefore there is no need to repeat it in the PAD configuration value (more over since this information will be masked out when the configuration value is applied).

#6 lore raw

PATCH 1/1 arm: dts: imx7ulp-evk: remove mux value from pad configuration

In reply to Jorge Ramirez-Ortiz
Quoted 6 lines

The mux mode is embedded in the PAD definition and therefore there is no need to repeat it in the PAD configuration value (more over since this information will be masked out when the configuration value is applied).

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================