Skip to contentSkip to conversation

ath11k: set TxBf parameters after vdev start

PATCH In review John Crispin 2 participants 3 messages Dec 17, 2019 – Jan 26, 2020 Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath11k: set TxBf parameters after vdev start

From: Bhagavathi Perumal S <[email protected]>

The channel info parameters are required by the firmware to process TxBf parameters. Currently TxBf is passed prior to the channel info. This patch moves TxBf setup after the channel setup.

---
 drivers/net/wireless/ath/ath11k/mac.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/net/wireless/ath/ath11k/mac.c +5 -6
index 9d0fed4034dd..a8ccb00d6072 100644
@@ -4216,12 +4216,6 @@ static int ath11k_mac_op_add_interface(struct ieee80211_hw *hw,
 			    arvif->vdev_id, ret);
 	}
 
-	ret = ath11k_mac_set_txbf_conf(arvif);
-	if (ret) {
-		ath11k_warn(ar->ab, "failed to set txbf conf for vdev %d: %d\n",
-			    arvif->vdev_id, ret);
-	}
-
 	ath11k_dp_vdev_tx_attach(ar, arvif);
 
 	mutex_unlock(&ar->conf_mutex);
@@ -4573,6 +4567,11 @@ ath11k_mac_vdev_start_restart(struct ath11k_vif *arvif,
 			   arg.channel.freq, arg.vdev_id);
 	}
 
+	ret = ath11k_mac_set_txbf_conf(arvif);
+	if (ret)
+		ath11k_warn(ab, "failed to set txbf conf for vdev %d: %d\n",
+			    arvif->vdev_id, ret);
+
 	return 0;
 }
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 7 lines · John Crispin

The channel info parameters are required by the firmware to process TxBf parameters. Currently TxBf is passed prior to the channel info. This patch moves TxBf setup after the channel setup.

Patch applied to ath-next branch of ath.git, thanks.

5815719dd271 ath11k: set TxBf parameters after vdev start

Signature · 3 lines
https://patchwork.kernel.org/patch/11298249/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#2 lore raw
In reply to John Crispin
Quoted 7 lines · John Crispin

The channel info parameters are required by the firmware to process TxBf parameters. Currently TxBf is passed prior to the channel info. This patch moves TxBf setup after the channel setup.

Patch applied to ath-next branch of ath.git, thanks.

5815719dd271 ath11k: set TxBf parameters after vdev start

Signature · 8 lines
https://patchwork.kernel.org/patch/11298249/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k