ethtool netlink interface, part 2
Subsystems (4)
cover ethtool netlink interface, part 2
This shorter series adds support for getting and setting of wake-on-lan settings and message mask (originally message level). Together with the code already in net-next, this will allow full implementation of "ethtool <dev>" and "ethtool -s <dev> ...".
Older versions of the ethtool netlink series allowed getting WoL settings by unprivileged users and only filtered out the password but this was a source of controversy so for now, ETHTOOL_MSG_WOL_GET request always requires CAP_NET_ADMIN as ETHTOOL_GWOL ioctl request does.
Michal Kubecek (7):
ethtool: fix kernel-doc descriptions
ethtool: provide message mask with DEBUG_GET request
ethtool: set message mask with DEBUG_SET request
ethtool: add DEBUG_NTF notification
ethtool: provide WoL settings with WOL_GET request
ethtool: set wake-on-lan settings with WOL_SET request
ethtool: add WOL_NTF notification
Documentation/networking/ethtool-netlink.rst | 110 +++++++++++- include/linux/netdevice.h | 56 ++++-- include/uapi/linux/ethtool.h | 6 + include/uapi/linux/ethtool_netlink.h | 33 ++++ net/ethtool/Makefile | 2 +- net/ethtool/common.c | 31 ++++ net/ethtool/common.h | 2 + net/ethtool/debug.c | 134 ++++++++++++++ net/ethtool/ioctl.c | 3 + net/ethtool/netlink.c | 57 ++++-- net/ethtool/netlink.h | 4 + net/ethtool/strset.c | 11 ++ net/ethtool/wol.c | 177 +++++++++++++++++++ 13 files changed, 592 insertions(+), 34 deletions(-) create mode 100644 net/ethtool/debug.c create mode 100644 net/ethtool/wol.c
Signature · 1 line
2.25.0
PATCH 1/7 ethtool: fix kernel-doc descriptions
Fix missing or incorrect function argument and struct member descriptions.
--- net/ethtool/netlink.c | 26 ++++++++++++++------------ net/ethtool/strset.c | 1 + 2 files changed, 15 insertions(+), 12 deletions(-)
net/ethtool/netlink.c +14 -12
@@ -134,11 +134,12 @@ int ethnl_fill_reply_header(struct sk_buff *skb, struct net_device *dev,/** * ethnl_reply_init() - Create skb for a reply and fill device identification -* @payload: payload length (without netlink and genetlink header) -* @dev: device the reply is about (may be null) -* @cmd: ETHTOOL_MSG_* message type for reply -* @info: genetlink info of the received packet we respond to -* @ehdrp: place to store payload pointer returned by genlmsg_new() +* @payload: payload length (without netlink and genetlink header) +* @dev: device the reply is about (may be null) +* @cmd: ETHTOOL_MSG_* message type for reply +* @hdr_attrtype: attribute type for common header +* @info: genetlink info of the received packet we respond to +* @ehdrp: place to store payload pointer returned by genlmsg_new() * * Return: pointer to allocated skb on success, NULL on error */
@@ -188,10 +189,11 @@ static int ethnl_multicast(struct sk_buff *skb, struct net_device *dev)/** * struct ethnl_dump_ctx - context structure for generic dumpit() callback -* @ops: request ops of currently processed message type -* @req_info: parsed request header of processed request -* @pos_hash: saved iteration position - hashbucket -* @pos_idx: saved iteration position - index +* @ops: request ops of currently processed message type +* @req_info: parsed request header of processed request +* @reply_data: data needed to compose the reply +* @pos_hash: saved iteration position - hashbucket +* @pos_idx: saved iteration position - index * * These parameters are kept in struct netlink_callback as context preserved * between iterations. They are initialized by ethnl_default_start() and used
@@ -268,9 +270,9 @@ static int ethnl_default_parse(struct ethnl_req_info *req_info,/** * ethnl_init_reply_data() - Initialize reply data for GET request -* @req_info: pointer to embedded struct ethnl_req_info -* @ops: instance of struct ethnl_request_ops describing the layout -* @dev: network device to initialize the reply for +* @reply_data: pointer to embedded struct ethnl_reply_data +* @ops: instance of struct ethnl_request_ops describing the layout +* @dev: network device to initialize the reply for * * Fills the reply data part with zeros and sets the dev member. Must be called * before calling the ->fill_reply() callback (for each iteration when handling
net/ethtool/strset.c +1 -0
@@ -85,6 +85,7 @@ get_stringset_policy[ETHTOOL_A_STRINGSET_MAX + 1] = {/** * strset_include() - test if a string set should be included in reply +* @info: parsed client request * @data: pointer to request data structure * @id: id of string set to check (ETH_SS_* constants) */
Signature · 1 line
2.25.0
PATCH 2/7 ethtool: provide message mask with DEBUG_GET request
In reply to Michal KubecekImplement DEBUG_GET request to get debugging settings for a device. At the moment, only message mask corresponding to message level as reported by ETHTOOL_GMSGLVL ioctl request is provided. (It is called message level in ioctl interface but almost all drivers interpret it as a bit mask.)
As part of the implementation, provide symbolic names for message mask bits as ETH_SS_MSG_CLASSES string set.
--- Documentation/networking/ethtool-netlink.rst | 34 ++++++++- include/linux/netdevice.h | 56 ++++++++++---- include/uapi/linux/ethtool.h | 2 + include/uapi/linux/ethtool_netlink.h | 14 ++++ net/ethtool/Makefile | 2 +- net/ethtool/common.c | 19 +++++ net/ethtool/common.h | 1 + net/ethtool/debug.c | 80 ++++++++++++++++++++ net/ethtool/netlink.c | 8 ++ net/ethtool/netlink.h | 1 + net/ethtool/strset.c | 5 ++ 11 files changed, 205 insertions(+), 17 deletions(-) create mode 100644 net/ethtool/debug.c
Documentation/networking/ethtool-netlink.rst +33 -1
@@ -185,6 +185,7 @@ Userspace to kernel: ``ETHTOOL_MSG_LINKMODES_GET`` get link modes info ``ETHTOOL_MSG_LINKMODES_SET`` set link modes info ``ETHTOOL_MSG_LINKSTATE_GET`` get link state + ``ETHTOOL_MSG_DEBUG_GET`` get debugging settings ===================================== ================================ Kernel to userspace:
@@ -196,6 +197,7 @@ Kernel to userspace: ``ETHTOOL_MSG_LINKMODES_GET_REPLY`` link modes info ``ETHTOOL_MSG_LINKMODES_NTF`` link modes notification ``ETHTOOL_MSG_LINKSTATE_GET_REPLY`` link state info + ``ETHTOOL_MSG_DEBUG_GET_REPLY`` debugging settings ===================================== ================================ ``GET`` requests are sent by userspace applications to retrieve device
@@ -423,6 +425,36 @@ define their own handler. devices supporting the request). +DEBUG_GET +========= + +Requests debugging settings of a device. At the moment, only message mask is +provided. + +Request contents: + + ==================================== ====== ========================== + ``ETHTOOL_A_DEBUG_HEADER`` nested request header + ==================================== ====== ========================== + +Kernel response contents: + + ==================================== ====== ========================== + ``ETHTOOL_A_DEBUG_HEADER`` nested reply header + ``ETHTOOL_A_DEBUG_MSGMASK`` bitset message mask + ==================================== ====== ========================== + +The message mask (``ETHTOOL_A_DEBUG_MSGMASK``) is equal to message level as +provided by ``ETHTOOL_GMSGLVL`` and set by ``ETHTOOL_SMSGLVL`` in ioctl +interface. While it is called message level there for historical reasons, most +drivers and almost all newer drivers use it as a mask of enabled message +classes (represented by ``NETIF_MSG_*`` constants); therefore netlink +interface follows its actual use in practice. + +``DEBUG_GET`` allows dump requests (kernel returns reply messages for all +devices supporting the request). + + Request translation ===================
@@ -441,7 +473,7 @@ have their netlink replacement yet. ``ETHTOOL_GREGS`` n/a ``ETHTOOL_GWOL`` n/a ``ETHTOOL_SWOL`` n/a - ``ETHTOOL_GMSGLVL`` n/a + ``ETHTOOL_GMSGLVL`` ``ETHTOOL_MSG_DEBUG_GET`` ``ETHTOOL_SMSGLVL`` n/a ``ETHTOOL_NWAY_RST`` n/a ``ETHTOOL_GLINK`` ``ETHTOOL_MSG_LINKSTATE_GET``
include/linux/netdevice.h +41 -15
63 lines not on this page · raw message
include/uapi/linux/ethtool.h +2 -0
@@ -594,6 +594,7 @@ struct ethtool_pauseparam {* @ETH_SS_PHY_STATS: Statistic names, for use with %ETHTOOL_GPHYSTATS * @ETH_SS_PHY_TUNABLES: PHY tunable names * @ETH_SS_LINK_MODES: link mode names +* @ETH_SS_MSG_CLASSES: debug message class names */ enum ethtool_stringset {ETH_SS_TEST =0 ,
@@ -606,6 +607,7 @@ enum ethtool_stringset {ETH_SS_PHY_STATS ,ETH_SS_PHY_TUNABLES ,ETH_SS_LINK_MODES , +ETH_SS_MSG_CLASSES ,/* add new constants above here */ ETH_SS_COUNT
include/uapi/linux/ethtool_netlink.h +14 -0
@@ -20,6 +20,7 @@ enum {ETHTOOL_MSG_LINKMODES_GET ,ETHTOOL_MSG_LINKMODES_SET ,ETHTOOL_MSG_LINKSTATE_GET , +ETHTOOL_MSG_DEBUG_GET ,/* add new constants above here */ __ETHTOOL_MSG_USER_CNT,
@@ -35,6 +36,7 @@ enum {ETHTOOL_MSG_LINKMODES_GET_REPLY ,ETHTOOL_MSG_LINKMODES_NTF ,ETHTOOL_MSG_LINKSTATE_GET_REPLY , +ETHTOOL_MSG_DEBUG_GET_REPLY ,/* add new constants above here */ __ETHTOOL_MSG_KERNEL_CNT,
@@ -195,6 +197,18 @@ enum { ETHTOOL_A_LINKSTATE_MAX = __ETHTOOL_A_LINKSTATE_CNT - 1 }; +/* DEBUG */ + +enum { +ETHTOOL_A_DEBUG_UNSPEC , +ETHTOOL_A_DEBUG_HEADER ,/* nest - _A_HEADER_* */ +ETHTOOL_A_DEBUG_MSGMASK ,/* bitset */ + +/* add new constants above here */ + __ETHTOOL_A_DEBUG_CNT, +ETHTOOL_A_DEBUG_MAX = __ETHTOOL_A_DEBUG_CNT -1 +}; +/* generic netlink info */ #define ETHTOOL_GENL_NAME "ethtool"#define ETHTOOL_GENL_VERSION 1
net/ethtool/Makefile +1 -1
@@ -5,4 +5,4 @@ obj-y += ioctl.o common.o obj-$(CONFIG_ETHTOOL_NETLINK) += ethtool_nl.o ethtool_nl-y := netlink.o bitset.o strset.o linkinfo.o linkmodes.o \ - linkstate.o + linkstate.o debug.o
net/ethtool/common.c +19 -0
@@ -170,6 +170,25 @@ const char link_mode_names[][ETH_GSTRING_LEN] = { };static_assert (ARRAY_SIZE (link_mode_names) == __ETHTOOL_LINK_MODE_MASK_NBITS); +const char netif_msg_class_names[][ETH_GSTRING_LEN ] = { + [NETIF_MSG_DRV_BIT ] ="drv" , + [NETIF_MSG_PROBE_BIT ] ="probe" , + [NETIF_MSG_LINK_BIT ] ="link" , + [NETIF_MSG_TIMER_BIT ] ="timer" , + [NETIF_MSG_IFDOWN_BIT ] ="ifdown" , + [NETIF_MSG_IFUP_BIT ] ="ifup" , + [NETIF_MSG_RX_ERR_BIT ] ="rx_err" , + [NETIF_MSG_TX_ERR_BIT ] ="tx_err" , + [NETIF_MSG_TX_QUEUED_BIT ] ="tx_queued" , + [NETIF_MSG_INTR_BIT ] ="intr" , + [NETIF_MSG_TX_DONE_BIT ] ="tx_done" , + [NETIF_MSG_RX_STATUS_BIT ] ="rx_status" , + [NETIF_MSG_PKTDATA_BIT ] ="pktdata" , + [NETIF_MSG_HW_BIT ] ="hw" , + [NETIF_MSG_WOL_BIT ] ="wol" , +}; +static_assert (ARRAY_SIZE (netif_msg_class_names) ==NETIF_MSG_CLASS_COUNT ); +/* return false if legacy contained non-0 deprecated fields * maxtxpkt/maxrxpkt. rest of ksettings always updated */
net/ethtool/common.h +1 -0
@@ -19,6 +19,7 @@ tunable_strings[__ETHTOOL_TUNABLE_COUNT][ETH_GSTRING_LEN];extern const char phy_tunable_strings[__ETHTOOL_PHY_TUNABLE_COUNT][ETH_GSTRING_LEN ];extern const char link_mode_names[][ETH_GSTRING_LEN ]; +extern const char netif_msg_class_names[][ETH_GSTRING_LEN ];int __ethtool_get_link (struct net_device *dev);
net/ethtool/debug.c new file +80 -0
80 lines not on this page · raw message
net/ethtool/netlink.c +8 -0
@@ -213,6 +213,7 @@ ethnl_default_requests[__ETHTOOL_MSG_USER_CNT] = { [ETHTOOL_MSG_LINKINFO_GET] = ðnl_linkinfo_request_ops, [ETHTOOL_MSG_LINKMODES_GET] = ðnl_linkmodes_request_ops, [ETHTOOL_MSG_LINKSTATE_GET] = ðnl_linkstate_request_ops, + [ETHTOOL_MSG_DEBUG_GET] = ðnl_debug_request_ops, };static struct ethnl_dump_ctx *ethnl_dump_context (struct netlink_callback *cb)
@@ -664,6 +665,13 @@ static const struct genl_ops ethtool_genl_ops[] = { .dumpit = ethnl_default_dumpit, .done = ethnl_default_done, }, + { + .cmd = ETHTOOL_MSG_DEBUG_GET, + .doit = ethnl_default_doit, + .start = ethnl_default_start, + .dumpit = ethnl_default_dumpit, + .done = ethnl_default_done, + }, };static const struct genl_multicast_group ethtool_nl_mcgrps[] = {
net/ethtool/netlink.h +1 -0
@@ -334,6 +334,7 @@ extern const struct ethnl_request_ops ethnl_strset_request_ops;extern const struct ethnl_request_ops ethnl_linkinfo_request_ops;extern const struct ethnl_request_ops ethnl_linkmodes_request_ops;extern const struct ethnl_request_ops ethnl_linkstate_request_ops; +extern const struct ethnl_request_ops ethnl_debug_request_ops;int ethnl_set_linkinfo (struct sk_buff *skb,struct genl_info *info);int ethnl_set_linkmodes (struct sk_buff *skb,struct genl_info *info);
net/ethtool/strset.c +5 -0
@@ -50,6 +50,11 @@ static const struct strset_info info_template[] = { .count = __ETHTOOL_LINK_MODE_MASK_NBITS, .strings = link_mode_names, }, + [ETH_SS_MSG_CLASSES] = { + .per_dev = false, + .count = NETIF_MSG_CLASS_COUNT, + .strings = netif_msg_class_names, + }, }; struct strset_req_info {
Signature · 1 line
2.25.0
Re: [PATCH net-next 2/7] ethtool: provide message mask with DEBUG_GET request
Quoted 9 lines · Michal Kubecek
Implement
DEBUG_GETrequest to get debugging settings for a device. At the moment, only message mask corresponding to message level as reported byETHTOOL_GMSGLVLioctl request is provided. (It is called message level in ioctl interface but almost all drivers interpret it as a bit mask.)As part of the implementation, provide symbolic names for message mask bits as
ETH_SS_MSG_CLASSESstring set.Signed-off-by Michal Kubecek <[email protected]>
Andrew
PATCH 3/7 ethtool: set message mask with DEBUG_SET request
In reply to Michal KubecekImplement DEBUG_SET netlink request to set debugging settings for a device. At the moment, only message mask corresponding to message level as set by ETHTOOL_SMSGLVL ioctl request can be set. (It is called message level in ioctl interface but almost all drivers interpret it as a bit mask.)
--- Documentation/networking/ethtool-netlink.rst | 20 +++++++- include/uapi/linux/ethtool_netlink.h | 1 + net/ethtool/debug.c | 53 ++++++++++++++++++++ net/ethtool/netlink.c | 5 ++ net/ethtool/netlink.h | 1 + 5 files changed, 79 insertions(+), 1 deletion(-)
Documentation/networking/ethtool-netlink.rst +19 -1
@@ -186,6 +186,7 @@ Userspace to kernel: ``ETHTOOL_MSG_LINKMODES_SET`` set link modes info ``ETHTOOL_MSG_LINKSTATE_GET`` get link state ``ETHTOOL_MSG_DEBUG_GET`` get debugging settings + ``ETHTOOL_MSG_DEBUG_SET`` set debugging settings ===================================== ================================ Kernel to userspace:
@@ -455,6 +456,23 @@ interface follows its actual use in practice. devices supporting the request). +DEBUG_SET +========= + +Set or update debugging settings of a device. At the moment, only message mask +is supported. + +Request contents: + + ==================================== ====== ========================== + ``ETHTOOL_A_DEBUG_HEADER`` nested request header + ``ETHTOOL_A_DEBUG_MSGMASK`` bitset message mask + ==================================== ====== ========================== + +``ETHTOOL_A_DEBUG_MSGMASK`` bit set allows setting or modifying mask of +enabled debugging message types for the device. + + Request translation ===================
@@ -474,7 +492,7 @@ have their netlink replacement yet. ``ETHTOOL_GWOL`` n/a ``ETHTOOL_SWOL`` n/a ``ETHTOOL_GMSGLVL`` ``ETHTOOL_MSG_DEBUG_GET`` - ``ETHTOOL_SMSGLVL`` n/a + ``ETHTOOL_SMSGLVL`` ``ETHTOOL_MSG_DEBUG_SET`` ``ETHTOOL_NWAY_RST`` n/a ``ETHTOOL_GLINK`` ``ETHTOOL_MSG_LINKSTATE_GET`` ``ETHTOOL_GEEPROM`` n/a
include/uapi/linux/ethtool_netlink.h +1 -0
@@ -21,6 +21,7 @@ enum {ETHTOOL_MSG_LINKMODES_SET ,ETHTOOL_MSG_LINKSTATE_GET ,ETHTOOL_MSG_DEBUG_GET , +ETHTOOL_MSG_DEBUG_SET ,/* add new constants above here */ __ETHTOOL_MSG_USER_CNT,
net/ethtool/debug.c +53 -0
56 lines not on this page · raw message
net/ethtool/netlink.c +5 -0
@@ -672,6 +672,11 @@ static const struct genl_ops ethtool_genl_ops[] = { .dumpit = ethnl_default_dumpit, .done = ethnl_default_done, }, + { + .cmd = ETHTOOL_MSG_DEBUG_SET, + .flags = GENL_UNS_ADMIN_PERM, + .doit = ethnl_set_debug, + }, };static const struct genl_multicast_group ethtool_nl_mcgrps[] = {
net/ethtool/netlink.h +1 -0
@@ -338,5 +338,6 @@ extern const struct ethnl_request_ops ethnl_debug_request_ops;int ethnl_set_linkinfo (struct sk_buff *skb,struct genl_info *info);int ethnl_set_linkmodes (struct sk_buff *skb,struct genl_info *info); +int ethnl_set_debug (struct sk_buff *skb,struct genl_info *info);#endif /* _NET_ETHTOOL_NETLINK_H */
Signature · 1 line
2.25.0
Re: [PATCH net-next 3/7] ethtool: set message mask with DEBUG_SET request
Quoted 17 lines · Michal Kubecek
Implement
DEBUG_SETnetlink request to set debugging settings for a device. At the moment, only message mask corresponding to message level as set byETHTOOL_SMSGLVLioctl request can be set. (It is called message level in ioctl interface but almost all drivers interpret it as a bit mask.)Signed-off-by Michal Kubecek <[email protected]>net/ethtool/debug.c +11
-0+int ethnl_set_debug (struct sk_buff *skb,struct genl_info *info) +{ +struct nlattr *tb[ETHTOOL_A_DEBUG_MAX +1 ]; +struct ethnl_req_info req_info = {}; +struct net_device *dev; +bool mod = false; +u32 msg_mask; +int ret; + + ret = nlmsg_parse(info->nlhdr, GENL_HDRLEN, tb, + ETHTOOL_A_DEBUG_MAX, debug_set_policy,
net/ethtool/debug.c const struct ethnl_request_ops ethnl_debug_request_ops = { · line 111
Quoted 10 lines
net/ethtool/debug.c +10
-0+ info->extack); +if (ret <0 ) +return ret; + ret =ethnl_parse_header (&req_info, tb[ETHTOOL_A_DEBUG_HEADER ], +genl_info_net (info), info->extack, true); +if (ret <0 ) +return ret; + dev = req_info.dev; +if (!dev->ethtool_ops->get_msglevel || !dev->ethtool_ops->set_msglevel) +return -EOPNOTSUPP ;
This seems like a new requirement, that both get and set callbacks are implemented. However, A quick look thought the code suggests all drivers already do have both get and set. So i think this is safe.
Andrew
Re: [PATCH net-next 3/7] ethtool: set message mask with DEBUG_SET request
Quoted 24 lines · Andrew Lunn
Quoted 23 lines · Michal Kubecek
Implement
DEBUG_SETnetlink request to set debugging settings for a device. At the moment, only message mask corresponding to message level as set byETHTOOL_SMSGLVLioctl request can be set. (It is called message level in ioctl interface but almost all drivers interpret it as a bit mask.)Signed-off-by Michal Kubecek <[email protected]>net/ethtool/debug.c +17
-0+int ethnl_set_debug (struct sk_buff *skb,struct genl_info *info) +{ +struct nlattr *tb[ETHTOOL_A_DEBUG_MAX +1 ]; +struct ethnl_req_info req_info = {}; +struct net_device *dev; +bool mod = false; +u32 msg_mask; +int ret; + + ret =nlmsg_parse (info->nlhdr,GENL_HDRLEN , tb, +ETHTOOL_A_DEBUG_MAX , debug_set_policy, + info->extack); +if (ret <0 ) +return ret; + ret =ethnl_parse_header (&req_info, tb[ETHTOOL_A_DEBUG_HEADER ], +genl_info_net (info), info->extack, true); +if (ret <0 )
Quoted 8 lines
net/ethtool/debug.c const struct ethnl_request_ops ethnl_debug_request_ops = { · line 111
Quoted 4 lines
net/ethtool/debug.c +4
-0+return ret; + dev = req_info.dev; +if (!dev->ethtool_ops->get_msglevel || !dev->ethtool_ops->set_msglevel) +return -EOPNOTSUPP ;This seems like a new requirement, that both get and set callbacks are implemented. However, A quick look thought the code suggests all drivers already do have both get and set. So i think this is safe.
Technically it's a new requirement but as ethtool (userspace utility) always issues ETHTOOL_GMSGLVL before ETHTOOL_SMSGLVL and does so even for command lines like "ethtool -s eth0 msglvl 5" where it's not really needed, providing ->set_msglevel() without ->get_msglevel() wouldn't be of much use even now.
Michal
Quoted 4 lines
Reviewed-by Andrew Lunn <[email protected]>Andrew
Andrew Lunn
maintainerRe: [PATCH net-next 3/7] ethtool: set message mask with DEBUG_SET request
In reply to Michal Kubeceknet/ethtool/debug.c const struct ethnl_request_ops ethnl_debug_request_ops = { · line 131
Quoted 4 lines
net/ethtool/debug.c +3
-0+ ret =ethnl_parse_header (&req_info, tb[ETHTOOL_A_DEBUG_HEADER ], +genl_info_net (info), info->extack, true); +dev_put (dev);
Hi Michal
While reviewing this patch i noticed this dev_put() and wondered where the dev_get() was. It is hiding inside ethnl_parse_header(). The documentation does make it clear it takes a reference on the device, but how many people read the documentation? I would not be too surprised if at some point in the future we have bugs from missing dev_put().
Could we make this a bit more explicit by calling it ethnl_parse_header_dev_get(). It is rather long though.
Andrew
Re: [PATCH net-next 3/7] ethtool: set message mask with DEBUG_SET request
Quoted 14 lines · Andrew Lunn
net/ethtool/debug.c const struct ethnl_request_ops ethnl_debug_request_ops = { · line 131
Quoted 4 lines
net/ethtool/debug.c +3
-0+ ret =ethnl_parse_header (&req_info, tb[ETHTOOL_A_DEBUG_HEADER ], +genl_info_net (info), info->extack, true); +dev_put (dev);Hi Michal
While reviewing this patch i noticed this
dev_put()and wondered where thedev_get()was. It is hiding insideethnl_parse_header(). The documentation does make it clear it takes a reference on the device, but how many people read the documentation? I would not be too surprised if at some point in the future we have bugs from missingdev_put().
Quoted 2 lines
Could we make this a bit more explicit by calling it
ethnl_parse_header_dev_get(). It is rather long though.
Good point, I'll think about the name some more and send a cleanup patch when net-next reopens.
Michal
PATCH 4/7 ethtool: add DEBUG_NTF notification
In reply to Michal KubecekSend ETHTOOL_MSG_DEBUG_NTF notification message whenever debugging message mask for a device are modified using ETHTOOL_MSG_DEBUG_SET netlink message or ETHTOOL_SMSGLVL ioctl request.
The notification message has the same format as reply to DEBUG_GET request. As with other ethtool notifications, netlink requests only trigger the notification if the mask is actually changed while ioctl request trigger it whenever the request results in calling the ethtool_ops handler.
--- Documentation/networking/ethtool-netlink.rst | 1 + include/uapi/linux/ethtool_netlink.h | 1 + net/ethtool/debug.c | 1 + net/ethtool/ioctl.c | 2 ++ net/ethtool/netlink.c | 2 ++ 5 files changed, 7 insertions(+)
Documentation/networking/ethtool-netlink.rst +1 -0
@@ -199,6 +199,7 @@ Kernel to userspace: ``ETHTOOL_MSG_LINKMODES_NTF`` link modes notification ``ETHTOOL_MSG_LINKSTATE_GET_REPLY`` link state info ``ETHTOOL_MSG_DEBUG_GET_REPLY`` debugging settings + ``ETHTOOL_MSG_DEBUG_NTF`` debugging settings notification ===================================== ================================ ``GET`` requests are sent by userspace applications to retrieve device
include/uapi/linux/ethtool_netlink.h +1 -0
@@ -38,6 +38,7 @@ enum {ETHTOOL_MSG_LINKMODES_NTF ,ETHTOOL_MSG_LINKSTATE_GET_REPLY ,ETHTOOL_MSG_DEBUG_GET_REPLY , +ETHTOOL_MSG_DEBUG_NTF ,/* add new constants above here */ __ETHTOOL_MSG_KERNEL_CNT,
net/ethtool/debug.c +1 -0
@@ -123,6 +123,7 @@ int ethnl_set_debug(struct sk_buff *skb, struct genl_info *info) goto out_ops; dev->ethtool_ops->set_msglevel (dev, msg_mask); +ethtool_notify (dev,ETHTOOL_MSG_DEBUG_NTF ,NULL ); out_ops:ethnl_ops_complete (dev);
net/ethtool/ioctl.c +2 -0
@@ -2545,6 +2545,8 @@ int dev_ethtool(struct net *net, struct ifreq *ifr)case ETHTOOL_SMSGLVL : rc =ethtool_set_value_void (dev, useraddr, dev->ethtool_ops->set_msglevel); +if (!rc) +ethtool_notify (dev,ETHTOOL_MSG_DEBUG_NTF ,NULL );break ;case ETHTOOL_GEEE : rc =ethtool_get_eee (dev, useraddr);
net/ethtool/netlink.c +2 -0
@@ -524,6 +524,7 @@ static const struct ethnl_request_ops * ethnl_default_notify_ops[ETHTOOL_MSG_KERNEL_MAX + 1] = { [ETHTOOL_MSG_LINKINFO_NTF] = ðnl_linkinfo_request_ops, [ETHTOOL_MSG_LINKMODES_NTF] = ðnl_linkmodes_request_ops, + [ETHTOOL_MSG_DEBUG_NTF] = ðnl_debug_request_ops, };/* default notification handler */
@@ -607,6 +608,7 @@ typedef void (*ethnl_notify_handler_t)(struct net_device *dev, unsigned int cmd,static const ethnl_notify_handler_t ethnl_notify_handlers[] = { [ETHTOOL_MSG_LINKINFO_NTF ] = ethnl_default_notify, [ETHTOOL_MSG_LINKMODES_NTF ] = ethnl_default_notify, + [ETHTOOL_MSG_DEBUG_NTF ] = ethnl_default_notify, };void ethtool_notify (struct net_device *dev,unsigned int cmd,const void *data)
Signature · 1 line
2.25.0
Re: [PATCH net-next 4/7] ethtool: add DEBUG_NTF notification
Quoted 10 lines · Michal Kubecek
Send
ETHTOOL_MSG_DEBUG_NTFnotification message whenever debugging message mask for a device are modified usingETHTOOL_MSG_DEBUG_SETnetlink message orETHTOOL_SMSGLVLioctl request.The notification message has the same format as reply to
DEBUG_GETrequest. As with other ethtool notifications, netlink requests only trigger the notification if the mask is actually changed while ioctl request trigger it whenever the request results in calling theethtool_opshandler.Signed-off-by Michal Kubecek <[email protected]>
Andrew
PATCH 5/7 ethtool: provide WoL settings with WOL_GET request
In reply to Michal KubecekImplement WOL_GET request to get wake-on-lan settings for a device, traditionally available via ETHTOOL_GWOL ioctl request.
As part of the implementation, provide symbolic names for wake-on-line modes as ETH_SS_WOL_MODES string set.
--- Documentation/networking/ethtool-netlink.rst | 30 +++++- include/uapi/linux/ethtool.h | 4 + include/uapi/linux/ethtool_netlink.h | 15 +++ net/ethtool/Makefile | 2 +- net/ethtool/common.c | 12 +++ net/ethtool/common.h | 1 + net/ethtool/netlink.c | 9 ++ net/ethtool/netlink.h | 1 + net/ethtool/strset.c | 5 + net/ethtool/wol.c | 99 ++++++++++++++++++++ 10 files changed, 176 insertions(+), 2 deletions(-) create mode 100644 net/ethtool/wol.c
Documentation/networking/ethtool-netlink.rst +29 -1
@@ -187,6 +187,7 @@ Userspace to kernel: ``ETHTOOL_MSG_LINKSTATE_GET`` get link state ``ETHTOOL_MSG_DEBUG_GET`` get debugging settings ``ETHTOOL_MSG_DEBUG_SET`` set debugging settings + ``ETHTOOL_MSG_WOL_GET`` get wake-on-lan settings ===================================== ================================ Kernel to userspace:
@@ -200,6 +201,7 @@ Kernel to userspace: ``ETHTOOL_MSG_LINKSTATE_GET_REPLY`` link state info ``ETHTOOL_MSG_DEBUG_GET_REPLY`` debugging settings ``ETHTOOL_MSG_DEBUG_NTF`` debugging settings notification + ``ETHTOOL_MSG_WOL_GET_REPLY`` wake-on-lan settings ===================================== ================================ ``GET`` requests are sent by userspace applications to retrieve device
@@ -474,6 +476,32 @@ Request contents: enabled debugging message types for the device. +WOL_GET +======= + +Query device wake-on-lan settings. Unlike most "GET" type requests, +``ETHTOOL_MSG_WOL_GET`` requires (netns) ``CAP_NET_ADMIN`` privileges as it +(potentially) provides SecureOn(tm) password which is confidential. + +Request contents: + + ==================================== ====== ========================== + ``ETHTOOL_A_WOL_HEADER`` nested request header + ==================================== ====== ========================== + +Kernel response contents: + + ==================================== ====== ========================== + ``ETHTOOL_A_WOL_HEADER`` nested reply header + ``ETHTOOL_A_WOL_MODES`` bitset mask of enabled WoL modes + ``ETHTOOL_A_WOL_SOPASS`` binary SecureOn(tm) password + ==================================== ====== ========================== + +In reply, ``ETHTOOL_A_WOL_MODES`` mask consists of modes supported by the +device, value of modes which are enabled. ``ETHTOOL_A_WOL_SOPASS`` is only +included in reply if ``WAKE_MAGICSECURE`` mode is supported. + + Request translation ===================
@@ -490,7 +518,7 @@ have their netlink replacement yet. ``ETHTOOL_MSG_LINKMODES_SET`` ``ETHTOOL_GDRVINFO`` n/a ``ETHTOOL_GREGS`` n/a - ``ETHTOOL_GWOL`` n/a + ``ETHTOOL_GWOL`` ``ETHTOOL_MSG_WOL_GET`` ``ETHTOOL_SWOL`` n/a ``ETHTOOL_GMSGLVL`` ``ETHTOOL_MSG_DEBUG_GET`` ``ETHTOOL_SMSGLVL`` ``ETHTOOL_MSG_DEBUG_SET``
include/uapi/linux/ethtool.h +4 -0
@@ -595,6 +595,7 @@ struct ethtool_pauseparam {* @ETH_SS_PHY_TUNABLES: PHY tunable names * @ETH_SS_LINK_MODES: link mode names * @ETH_SS_MSG_CLASSES: debug message class names +* @ETH_SS_WOL_MODES: wake-on-lan modes */ enum ethtool_stringset {ETH_SS_TEST =0 ,
@@ -608,6 +609,7 @@ enum ethtool_stringset {ETH_SS_PHY_TUNABLES ,ETH_SS_LINK_MODES ,ETH_SS_MSG_CLASSES , +ETH_SS_WOL_MODES ,/* add new constants above here */ ETH_SS_COUNT
@@ -1695,6 +1697,8 @@ static inline int ethtool_validate_duplex(__u8 duplex)#define WAKE_MAGICSECURE (1 << 6)/* only meaningful if WAKE_MAGIC */ #define WAKE_FILTER (1 << 7) +#define WOL_MODE_COUNT 8 +/* L2-L4 network traffic flow types */ #define TCP_V4_FLOW 0x01/* hash or spec (tcp_ip4_spec) */ #define UDP_V4_FLOW 0x02/* hash or spec (udp_ip4_spec) */
include/uapi/linux/ethtool_netlink.h +15 -0
@@ -22,6 +22,7 @@ enum {ETHTOOL_MSG_LINKSTATE_GET ,ETHTOOL_MSG_DEBUG_GET ,ETHTOOL_MSG_DEBUG_SET , +ETHTOOL_MSG_WOL_GET ,/* add new constants above here */ __ETHTOOL_MSG_USER_CNT,
@@ -39,6 +40,7 @@ enum {ETHTOOL_MSG_LINKSTATE_GET_REPLY ,ETHTOOL_MSG_DEBUG_GET_REPLY ,ETHTOOL_MSG_DEBUG_NTF , +ETHTOOL_MSG_WOL_GET_REPLY ,/* add new constants above here */ __ETHTOOL_MSG_KERNEL_CNT,
@@ -211,6 +213,19 @@ enum { ETHTOOL_A_DEBUG_MAX = __ETHTOOL_A_DEBUG_CNT - 1 }; +/* WOL */ + +enum { +ETHTOOL_A_WOL_UNSPEC , +ETHTOOL_A_WOL_HEADER ,/* nest - _A_HEADER_* */ +ETHTOOL_A_WOL_MODES ,/* bitset */ +ETHTOOL_A_WOL_SOPASS ,/* binary */ + +/* add new constants above here */ + __ETHTOOL_A_WOL_CNT, +ETHTOOL_A_WOL_MAX = __ETHTOOL_A_WOL_CNT -1 +}; +/* generic netlink info */ #define ETHTOOL_GENL_NAME "ethtool"#define ETHTOOL_GENL_VERSION 1
net/ethtool/Makefile +1 -1
@@ -5,4 +5,4 @@ obj-y += ioctl.o common.o obj-$(CONFIG_ETHTOOL_NETLINK) += ethtool_nl.o ethtool_nl-y := netlink.o bitset.o strset.o linkinfo.o linkmodes.o \ - linkstate.o debug.o + linkstate.o debug.o wol.o
net/ethtool/common.c +12 -0
@@ -189,6 +189,18 @@ const char netif_msg_class_names[][ETH_GSTRING_LEN] = { };static_assert (ARRAY_SIZE (netif_msg_class_names) ==NETIF_MSG_CLASS_COUNT ); +const char wol_mode_names[][ETH_GSTRING_LEN ] = { + [const_ilog2 (WAKE_PHY )] ="phy" , + [const_ilog2 (WAKE_UCAST )] ="ucast" , + [const_ilog2 (WAKE_MCAST )] ="mcast" , + [const_ilog2 (WAKE_BCAST )] ="bcast" , + [const_ilog2 (WAKE_ARP )] ="arp" , + [const_ilog2 (WAKE_MAGIC )] ="magic" , + [const_ilog2 (WAKE_MAGICSECURE )] ="magicsecure" , + [const_ilog2 (WAKE_FILTER )] ="filter" , +}; +static_assert (ARRAY_SIZE (wol_mode_names) ==WOL_MODE_COUNT ); +/* return false if legacy contained non-0 deprecated fields * maxtxpkt/maxrxpkt. rest of ksettings always updated */
net/ethtool/common.h +1 -0
@@ -20,6 +20,7 @@ extern const char phy_tunable_strings[__ETHTOOL_PHY_TUNABLE_COUNT][ETH_GSTRING_LEN ];extern const char link_mode_names[][ETH_GSTRING_LEN ];extern const char netif_msg_class_names[][ETH_GSTRING_LEN ]; +extern const char wol_mode_names[][ETH_GSTRING_LEN ];int __ethtool_get_link (struct net_device *dev);
net/ethtool/netlink.c +9 -0
@@ -214,6 +214,7 @@ ethnl_default_requests[__ETHTOOL_MSG_USER_CNT] = { [ETHTOOL_MSG_LINKMODES_GET] = ðnl_linkmodes_request_ops, [ETHTOOL_MSG_LINKSTATE_GET] = ðnl_linkstate_request_ops, [ETHTOOL_MSG_DEBUG_GET] = ðnl_debug_request_ops, + [ETHTOOL_MSG_WOL_GET] = ðnl_wol_request_ops, };static struct ethnl_dump_ctx *ethnl_dump_context (struct netlink_callback *cb)
@@ -679,6 +680,14 @@ static const struct genl_ops ethtool_genl_ops[] = { .flags = GENL_UNS_ADMIN_PERM, .doit = ethnl_set_debug, }, + { + .cmd = ETHTOOL_MSG_WOL_GET, + .flags = GENL_UNS_ADMIN_PERM, + .doit = ethnl_default_doit, + .start = ethnl_default_start, + .dumpit = ethnl_default_dumpit, + .done = ethnl_default_done, + }, };static const struct genl_multicast_group ethtool_nl_mcgrps[] = {
net/ethtool/netlink.h +1 -0
@@ -335,6 +335,7 @@ extern const struct ethnl_request_ops ethnl_linkinfo_request_ops;extern const struct ethnl_request_ops ethnl_linkmodes_request_ops;extern const struct ethnl_request_ops ethnl_linkstate_request_ops;extern const struct ethnl_request_ops ethnl_debug_request_ops; +extern const struct ethnl_request_ops ethnl_wol_request_ops;int ethnl_set_linkinfo (struct sk_buff *skb,struct genl_info *info);int ethnl_set_linkmodes (struct sk_buff *skb,struct genl_info *info);
net/ethtool/strset.c +5 -0
@@ -55,6 +55,11 @@ static const struct strset_info info_template[] = { .count = NETIF_MSG_CLASS_COUNT, .strings = netif_msg_class_names, }, + [ETH_SS_WOL_MODES] = { + .per_dev = false, + .count = WOL_MODE_COUNT, + .strings = wol_mode_names, + }, }; struct strset_req_info {
net/ethtool/wol.c new file +99 -0
99 lines not on this page · raw message
Signature · 1 line
2.25.0
Re: [PATCH net-next 5/7] ethtool: provide WoL settings with WOL_GET request
Quoted 4 lines · Michal Kubecek
Implement
WOL_GETrequest to get wake-on-lan settings for a device, traditionally available viaETHTOOL_GWOLioctl request.As part of the implementation, provide symbolic names for wake-on-line
Hi Michal
LAN, not line.
Quoted 1 line
modes as
ETH_SS_WOL_MODESstring set.
I think it would also be good to repeat here what you have in the cover note, that unlike the ioctl version, CAP_NET_ADMIN is required. The cover note does get committed to the git history, but it is a lot less likely to be seen than this patches commit message.
Documentation/networking/ethtool-netlink.rst Request contents: · line 484
Quoted 6 lines
Documentation/networking/ethtool-netlink.rst +6
-0+WOL_GET +======= + +Query device wake-on-lan settings. Unlike most "GET" type requests, +``ETHTOOL_MSG_WOL_GET`` requires (netns) ``CAP_NET_ADMIN`` privileges as it +(potentially) provides SecureOn(tm) password which is confidential.
provides _the_ SecureOn(tm)
Apart from that:
Andrew
PATCH 6/7 ethtool: set wake-on-lan settings with WOL_SET request
In reply to Michal KubecekImplement WOL_SET netlink request to set wake-on-lan settings. This is equivalent to ETHTOOL_SWOL ioctl request.
--- Documentation/networking/ethtool-netlink.rst | 20 +++++- include/uapi/linux/ethtool_netlink.h | 1 + net/ethtool/netlink.c | 5 ++ net/ethtool/netlink.h | 1 + net/ethtool/wol.c | 76 ++++++++++++++++++++ 5 files changed, 102 insertions(+), 1 deletion(-)
Documentation/networking/ethtool-netlink.rst +19 -1
@@ -188,6 +188,7 @@ Userspace to kernel: ``ETHTOOL_MSG_DEBUG_GET`` get debugging settings ``ETHTOOL_MSG_DEBUG_SET`` set debugging settings ``ETHTOOL_MSG_WOL_GET`` get wake-on-lan settings + ``ETHTOOL_MSG_WOL_SET`` set wake-on-lan settings ===================================== ================================ Kernel to userspace:
@@ -502,6 +503,23 @@ device, value of modes which are enabled. ``ETHTOOL_A_WOL_SOPASS`` is only included in reply if ``WAKE_MAGICSECURE`` mode is supported. +WOL_SET +======= + +Set or update wake-on-lan settings. + +Request contents: + + ==================================== ====== ========================== + ``ETHTOOL_A_WOL_HEADER`` nested request header + ``ETHTOOL_A_WOL_MODES`` bitset enabled WoL modes + ``ETHTOOL_A_WOL_SOPASS`` binary SecureOn(tm) password + ==================================== ====== ========================== + +``ETHTOOL_A_WOL_SOPASS`` is only allowed for devices supporting +``WAKE_MAGICSECURE`` mode. + + Request translation ===================
@@ -519,7 +537,7 @@ have their netlink replacement yet. ``ETHTOOL_GDRVINFO`` n/a ``ETHTOOL_GREGS`` n/a ``ETHTOOL_GWOL`` ``ETHTOOL_MSG_WOL_GET`` - ``ETHTOOL_SWOL`` n/a + ``ETHTOOL_SWOL`` ``ETHTOOL_MSG_WOL_SET`` ``ETHTOOL_GMSGLVL`` ``ETHTOOL_MSG_DEBUG_GET`` ``ETHTOOL_SMSGLVL`` ``ETHTOOL_MSG_DEBUG_SET`` ``ETHTOOL_NWAY_RST`` n/a
include/uapi/linux/ethtool_netlink.h +1 -0
@@ -23,6 +23,7 @@ enum {ETHTOOL_MSG_DEBUG_GET ,ETHTOOL_MSG_DEBUG_SET ,ETHTOOL_MSG_WOL_GET , +ETHTOOL_MSG_WOL_SET ,/* add new constants above here */ __ETHTOOL_MSG_USER_CNT,
net/ethtool/netlink.c +5 -0
@@ -688,6 +688,11 @@ static const struct genl_ops ethtool_genl_ops[] = { .dumpit = ethnl_default_dumpit, .done = ethnl_default_done, }, + { + .cmd = ETHTOOL_MSG_WOL_SET, + .flags = GENL_UNS_ADMIN_PERM, + .doit = ethnl_set_wol, + }, };static const struct genl_multicast_group ethtool_nl_mcgrps[] = {
net/ethtool/netlink.h +1 -0
@@ -340,5 +340,6 @@ extern const struct ethnl_request_ops ethnl_wol_request_ops;int ethnl_set_linkinfo (struct sk_buff *skb,struct genl_info *info);int ethnl_set_linkmodes (struct sk_buff *skb,struct genl_info *info);int ethnl_set_debug (struct sk_buff *skb,struct genl_info *info); +int ethnl_set_wol (struct sk_buff *skb,struct genl_info *info);#endif /* _NET_ETHTOOL_NETLINK_H */
net/ethtool/wol.c +76 -0
79 lines not on this page · raw message
Signature · 1 line
2.25.0
PATCH 7/7 ethtool: add WOL_NTF notification
In reply to Michal KubecekSend ETHTOOL_MSG_WOL_NTF notification whenever wake-on-lan settings of a device are modified using ETHTOOL_MSG_WOL_SET netlink message or ETHTOOL_SWOL ioctl request.
As notifications can be received by anyone, do not include SecureOn(tm) password in notification messages.
--- Documentation/networking/ethtool-netlink.rst | 5 +++-- include/uapi/linux/ethtool_netlink.h | 1 + net/ethtool/ioctl.c | 1 + net/ethtool/netlink.c | 2 ++ net/ethtool/wol.c | 4 +++- 5 files changed, 10 insertions(+), 3 deletions(-)
Documentation/networking/ethtool-netlink.rst +3 -2
@@ -193,7 +193,7 @@ Userspace to kernel: Kernel to userspace: - ===================================== ================================ + ===================================== ================================= ``ETHTOOL_MSG_STRSET_GET_REPLY`` string set contents ``ETHTOOL_MSG_LINKINFO_GET_REPLY`` link settings ``ETHTOOL_MSG_LINKINFO_NTF`` link settings notification
@@ -203,7 +203,8 @@ Kernel to userspace: ``ETHTOOL_MSG_DEBUG_GET_REPLY`` debugging settings ``ETHTOOL_MSG_DEBUG_NTF`` debugging settings notification ``ETHTOOL_MSG_WOL_GET_REPLY`` wake-on-lan settings - ===================================== ================================ + ``ETHTOOL_MSG_WOL_NTF`` wake-on-lan settings notification + ===================================== ================================= ``GET`` requests are sent by userspace applications to retrieve device information. They usually do not contain any message specific attributes.
include/uapi/linux/ethtool_netlink.h +1 -0
@@ -42,6 +42,7 @@ enum {ETHTOOL_MSG_DEBUG_GET_REPLY ,ETHTOOL_MSG_DEBUG_NTF ,ETHTOOL_MSG_WOL_GET_REPLY , +ETHTOOL_MSG_WOL_NTF ,/* add new constants above here */ __ETHTOOL_MSG_KERNEL_CNT,
net/ethtool/ioctl.c +1 -0
@@ -1316,6 +1316,7 @@ static int ethtool_set_wol(struct net_device *dev, char __user *useraddr)return ret; dev->wol_enabled = !!wol.wolopts; +ethtool_notify (dev,ETHTOOL_MSG_WOL_NTF ,NULL );return 0 ; }
net/ethtool/netlink.c +2 -0
@@ -526,6 +526,7 @@ ethnl_default_notify_ops[ETHTOOL_MSG_KERNEL_MAX + 1] = { [ETHTOOL_MSG_LINKINFO_NTF] = ðnl_linkinfo_request_ops, [ETHTOOL_MSG_LINKMODES_NTF] = ðnl_linkmodes_request_ops, [ETHTOOL_MSG_DEBUG_NTF] = ðnl_debug_request_ops, + [ETHTOOL_MSG_WOL_NTF] = ðnl_wol_request_ops, };/* default notification handler */
@@ -610,6 +611,7 @@ static const ethnl_notify_handler_t ethnl_notify_handlers[] = { [ETHTOOL_MSG_LINKINFO_NTF] = ethnl_default_notify, [ETHTOOL_MSG_LINKMODES_NTF] = ethnl_default_notify, [ETHTOOL_MSG_DEBUG_NTF] = ethnl_default_notify, + [ETHTOOL_MSG_WOL_NTF] = ethnl_default_notify, };void ethtool_notify (struct net_device *dev,unsigned int cmd,const void *data)
net/ethtool/wol.c +3 -1
@@ -41,7 +41,8 @@ static int wol_prepare_data(const struct ethnl_req_info *req_base,return ret; dev->ethtool_ops->get_wol (dev, &data->wol);ethnl_ops_complete (dev); - data->show_sopass = data->wol.supported &WAKE_MAGICSECURE ; +/* do not include password in notifications */ + data->show_sopass = info && (data->wol.supported &WAKE_MAGICSECURE );return 0 ; }
@@ -165,6 +166,7 @@ int ethnl_set_wol(struct sk_buff *skb, struct genl_info *info)if (ret) goto out_ops; dev->wol_enabled = !!wol.wolopts; +ethtool_notify (dev,ETHTOOL_MSG_WOL_NTF ,NULL ); out_ops:ethnl_ops_complete (dev);
Signature · 1 line
2.25.0
Andrew Lunn
maintainerQuoted 4 lines · Michal Kubecek
This shorter series adds support for getting and setting of wake-on-lan settings and message mask (originally message level). Together with the code already in net-next, this will allow full implementation of "ethtool <dev>" and "ethtool -s <dev> ...".
Hi Michal
It is nice to see more of this work being posted. But what about the user space side? Do you plan to post that soon?
Thanks
Andrew
Quoted 10 lines · Andrew Lunn
Quoted 4 lines · Michal Kubecek
This shorter series adds support for getting and setting of wake-on-lan settings and message mask (originally message level). Together with the code already in net-next, this will allow full implementation of "ethtool <dev>" and "ethtool -s <dev> ...".
Hi Michal
It is nice to see more of this work being posted. But what about the user space side? Do you plan to post that soon?
Yes, once I get it into presentable shape. I definitely want ethtool 5.6 to support what kernel 5.6 will.
Michal
David Miller
maintainerFrom: Michal Kubecek <[email protected]>
Date: Sun, 26 Jan 2020 23:10:58 +0100 (CET)
Quoted 9 lines
This shorter series adds support for getting and setting of wake-on-lan settings and message mask (originally message level). Together with the code already in net-next, this will allow full implementation of "ethtool <dev>" and "ethtool -s <dev> ...".
Older versions of the ethtool netlink series allowed getting WoL settings by unprivileged users and only filtered out the password but this was a source of controversy so for now,
ETHTOOL_MSG_WOL_GETrequest always requiresCAP_NET_ADMINasETHTOOL_GWOLioctl request does.
It looks like this will need to be respun at least once, and net-next is closing today so....
Quoted 8 lines · David Miller
From: Michal Kubecek <[email protected]>
Date: Sun, 26 Jan 2020 23:10:58 +0100 (CET)Quoted 5 lines
This shorter series adds support for getting and setting of wake-on-lan settings and message mask (originally message level). Together with the code already in net-next, this will allow full implementation of "ethtool <dev>" and "ethtool -s <dev> ...".
Quoted 7 lines
Quoted 4 lines
Older versions of the ethtool netlink series allowed getting WoL settings by unprivileged users and only filtered out the password but this was a source of controversy so for now,
ETHTOOL_MSG_WOL_GETrequest always requiresCAP_NET_ADMINasETHTOOL_GWOLioctl request does.It looks like this will need to be respun at least once, and net-next is closing today so....
The problem with ethnl_parse_header() name not making it obvious that it takes a reference is not introduced in this series, the function is already in net-next so that it does not matter if this series is merged or not. Other than that, there is only the missing "the" in documentation.
Michal
David Miller
maintainerFrom: Michal Kubecek <[email protected]>
Date: Mon, 27 Jan 2020 10:57:44 +0100
Quoted 14 lines · David Miller
Quoted 13 lines
From: Michal Kubecek <[email protected]>
Date: Sun, 26 Jan 2020 23:10:58 +0100 (CET)Quoted 9 lines
This shorter series adds support for getting and setting of wake-on-lan settings and message mask (originally message level). Together with the code already in net-next, this will allow full implementation of "ethtool <dev>" and "ethtool -s <dev> ...".
Older versions of the ethtool netlink series allowed getting WoL settings by unprivileged users and only filtered out the password but this was a source of controversy so for now,
ETHTOOL_MSG_WOL_GETrequest always requiresCAP_NET_ADMINasETHTOOL_GWOLioctl request does.
Quoted 8 lines
Quoted 2 lines
It looks like this will need to be respun at least once, and net-next is closing today so....
The problem with
ethnl_parse_header()name not making it obvious that it takes a reference is not introduced in this series, the function is already in net-next so that it does not matter if this series is merged or not. Other than that, there is only the missing "the" in documentation.
Ok, I'll reconsider, thanks.
From: Michal Kubecek <[email protected]>
Date: Mon, 27 Jan 2020 10:57:44 +0100
Quoted 14 lines · David Miller
Quoted 13 lines
From: Michal Kubecek <[email protected]>
Date: Sun, 26 Jan 2020 23:10:58 +0100 (CET)Quoted 9 lines
This shorter series adds support for getting and setting of wake-on-lan settings and message mask (originally message level). Together with the code already in net-next, this will allow full implementation of "ethtool <dev>" and "ethtool -s <dev> ...".
Older versions of the ethtool netlink series allowed getting WoL settings by unprivileged users and only filtered out the password but this was a source of controversy so for now,
ETHTOOL_MSG_WOL_GETrequest always requiresCAP_NET_ADMINasETHTOOL_GWOLioctl request does.
Quoted 8 lines
Quoted 2 lines
It looks like this will need to be respun at least once, and net-next is closing today so....
The problem with
ethnl_parse_header()name not making it obvious that it takes a reference is not introduced in this series, the function is already in net-next so that it does not matter if this series is merged or not. Other than that, there is only the missing "the" in documentation.
Ok, looks good, series applied.
Thanky you.
Andrew Lunn
maintainerQuoted 20 lines · David Miller
From: Michal Kubecek <[email protected]>
Date: Mon, 27 Jan 2020 10:57:44 +0100Quoted 17 lines · David Miller
Quoted 15 lines
From: Michal Kubecek <[email protected]>
Date: Sun, 26 Jan 2020 23:10:58 +0100 (CET)Quoted 9 lines
This shorter series adds support for getting and setting of wake-on-lan settings and message mask (originally message level). Together with the code already in net-next, this will allow full implementation of "ethtool <dev>" and "ethtool -s <dev> ...".
Older versions of the ethtool netlink series allowed getting WoL settings by unprivileged users and only filtered out the password but this was a source of controversy so for now,
ETHTOOL_MSG_WOL_GETrequest always requiresCAP_NET_ADMINasETHTOOL_GWOLioctl request does.It looks like this will need to be respun at least once, and net-next is closing today so....
Quoted 7 lines
Quoted 5 lines
The problem with
ethnl_parse_header()name not making it obvious that it takes a reference is not introduced in this series, the function is already in net-next so that it does not matter if this series is merged or not. Other than that, there is only the missing "the" in documentation.Ok, looks good, series applied.
Yes, i don't see anything here which cannot be fixed up later. So i agree with merging it.
Andrew