Skip to content

ethtool netlink interface, part 2

Michal Kubecek lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7ethtool: fix kernel-doc descriptionsnet/ethtool/netlink.c net/ethtool/strset.c+15 -120 replies
2/7ethtool: provide message mask with DEBUG_GET requestDocumentation/networking/ethtool-netlink.rst include/linux/netdevice.h include/uapi/linux/ethtool.h +8 more+205 -171 reply
3/7ethtool: set message mask with DEBUG_SET requestDocumentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool_netlink.h net/ethtool/debug.c +2 more+79 -14 replies
4/7ethtool: add DEBUG_NTF notificationDocumentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool_netlink.h net/ethtool/debug.c +2 more+7 -01 reply
5/7ethtool: provide WoL settings with WOL_GET requestDocumentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool.h include/uapi/linux/ethtool_netlink.h +7 more+176 -21 reply
6/7ethtool: set wake-on-lan settings with WOL_SET requestDocumentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool_netlink.h net/ethtool/netlink.c +2 more+102 -10 replies
7/7ethtool: add WOL_NTF notificationDocumentation/networking/ethtool-netlink.rst include/uapi/linux/ethtool_netlink.h net/ethtool/ioctl.c +2 more+10 -30 replies

Reviews trailers per patch

4 of 7 patches have a Reviewed-by or Acked-by.

PatchAndrew Lunn
1/7
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/7] ethtool netlink interface, part 2

This shorter series adds support for getting and setting of wake-on-lan settings and message mask (originally message level). Together with the code already in net-next, this will allow full implementation of "ethtool <dev>" and "ethtool -s <dev> ...".

Older versions of the ethtool netlink series allowed getting WoL settings by unprivileged users and only filtered out the password but this was a source of controversy so for now, ETHTOOL_MSG_WOL_GET request always requires CAP_NET_ADMIN as ETHTOOL_GWOL ioctl request does.

Michal Kubecek (7):
ethtool: fix kernel-doc descriptions
ethtool: provide message mask with DEBUG_GET request
ethtool: set message mask with DEBUG_SET request
ethtool: add DEBUG_NTF notification
ethtool: provide WoL settings with WOL_GET request
ethtool: set wake-on-lan settings with WOL_SET request
ethtool: add WOL_NTF notification

 Documentation/networking/ethtool-netlink.rst | 110 +++++++++++-
 include/linux/netdevice.h                    |  56 ++++--
 include/uapi/linux/ethtool.h                 |   6 +
 include/uapi/linux/ethtool_netlink.h         |  33 ++++
 net/ethtool/Makefile                         |   2 +-
 net/ethtool/common.c                         |  31 ++++
 net/ethtool/common.h                         |   2 +
 net/ethtool/debug.c                          | 134 ++++++++++++++
 net/ethtool/ioctl.c                          |   3 +
 net/ethtool/netlink.c                        |  57 ++++--
 net/ethtool/netlink.h                        |   4 +
 net/ethtool/strset.c                         |  11 ++
 net/ethtool/wol.c                            | 177 +++++++++++++++++++
 13 files changed, 592 insertions(+), 34 deletions(-)
 create mode 100644 net/ethtool/debug.c
 create mode 100644 net/ethtool/wol.c
Signature · 1 line
2.25.0