ethtool netlink interface, part 2
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 14 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | ethtool: fix kernel-doc descriptionsnet/ net/ | +15 | 0 replies | |
| 2/7 | ethtool: provide message mask with DEBUG_GET requestDocumentation/ include/ include/ +8 more | +205 | 1 reply | |
| 3/7 | ethtool: set message mask with DEBUG_SET requestDocumentation/ include/ net/ +2 more | +79 | 4 replies | |
| 4/7 | ethtool: add DEBUG_NTF notificationDocumentation/ include/ net/ +2 more | +7 | 1 reply | |
| 5/7 | ethtool: provide WoL settings with WOL_GET requestDocumentation/ include/ include/ +7 more | +176 | 1 reply | |
| 6/7 | ethtool: set wake-on-lan settings with WOL_SET requestDocumentation/ include/ net/ +2 more | +102 | 0 replies | |
| 7/7 | ethtool: add WOL_NTF notificationDocumentation/ include/ net/ +2 more | +10 | 0 replies |
Reviews trailers per patch
4 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Andrew Lunn |
|---|---|
| 1/7 | |
| 2/7 | R-b |
| 3/7 | R-b |
| 4/7 | R-b |
| 5/7 | R-b |
| 6/7 | |
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next 0/7] ethtool netlink interface, part 2
This shorter series adds support for getting and setting of wake-on-lan settings and message mask (originally message level). Together with the code already in net-next, this will allow full implementation of "ethtool <dev>" and "ethtool -s <dev> ...".
Older versions of the ethtool netlink series allowed getting WoL settings by unprivileged users and only filtered out the password but this was a source of controversy so for now, ETHTOOL_MSG_WOL_GET request always requires CAP_NET_ADMIN as ETHTOOL_GWOL ioctl request does.
Michal Kubecek (7):
ethtool: fix kernel-doc descriptions
ethtool: provide message mask with DEBUG_GET request
ethtool: set message mask with DEBUG_SET request
ethtool: add DEBUG_NTF notification
ethtool: provide WoL settings with WOL_GET request
ethtool: set wake-on-lan settings with WOL_SET request
ethtool: add WOL_NTF notification
Documentation/networking/ethtool-netlink.rst | 110 +++++++++++- include/linux/netdevice.h | 56 ++++-- include/uapi/linux/ethtool.h | 6 + include/uapi/linux/ethtool_netlink.h | 33 ++++ net/ethtool/Makefile | 2 +- net/ethtool/common.c | 31 ++++ net/ethtool/common.h | 2 + net/ethtool/debug.c | 134 ++++++++++++++ net/ethtool/ioctl.c | 3 + net/ethtool/netlink.c | 57 ++++-- net/ethtool/netlink.h | 4 + net/ethtool/strset.c | 11 ++ net/ethtool/wol.c | 177 +++++++++++++++++++ 13 files changed, 592 insertions(+), 34 deletions(-) create mode 100644 net/ethtool/debug.c create mode 100644 net/ethtool/wol.c
Signature · 1 line
2.25.0