Skip to contentSkip to conversation

gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

PATCH New Fabio Estevam 3 participants 8 messages Jan 29, 2020 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

Since commit bcee8d6764f9 ("dm: gpio: Allow control of GPIO uclass in SPL") the CONFIG_DM_74X164 is no longer built for mx7dsabresd_defconfig, as this target does not use CONFIG_SPL_GPIO.

Remove such dependency and let the the 74X164 GPIO driver be built again.

This restores Ethernet functionality on the imx7-sdb board as the Ethernet reset PHY comes from a GPIO driven by a 74LV595PW I/O expander.

Fixes bcee8d6764f9 ("dm: gpio: Allow control of GPIO uclass in SPL")
---
 drivers/gpio/Makefile | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpio/Makefile +1 -3
index 449046b64c..aa41a24cd0 100644
@@ -10,13 +10,11 @@ endif
 obj-$(CONFIG_$(SPL_TPL_)DM_GPIO) += gpio-uclass.o
 
 obj-$(CONFIG_$(SPL_)DM_PCA953X)	+= pca953x_gpio.o
-ifdef CONFIG_$(SPL_TPL_)GPIO
-obj-$(CONFIG_DM_74X164)		+= 74x164_gpio.o
-endif
 
 obj-$(CONFIG_AT91_GPIO)	+= at91_gpio.o
 obj-$(CONFIG_ATMEL_PIO4)	+= atmel_pio4.o
 obj-$(CONFIG_BCM6345_GPIO)	+= bcm6345_gpio.o
+obj-$(CONFIG_DM_74X164)		+= 74x164_gpio.o
 obj-$(CONFIG_INTEL_GPIO)	+= intel_gpio.o
 obj-$(CONFIG_INTEL_ICH6_GPIO)	+= intel_ich6_gpio.o
 obj-$(CONFIG_INTEL_BROADWELL_GPIO)	+= intel_broadwell_gpio.o
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

Quoted 26 lines · Fabio Estevam

Since commit bcee8d6764f9 ("dm: gpio: Allow control of GPIO uclass in SPL") the CONFIG_DM_74X164 is no longer built for mx7dsabresd_defconfig, as this target does not use CONFIG_SPL_GPIO.

Remove such dependency and let the the 74X164 GPIO driver be built again.

This restores Ethernet functionality on the imx7-sdb board as the Ethernet reset PHY comes from a GPIO driven by a 74LV595PW I/O expander.

Fixes bcee8d6764f9 ("dm: gpio: Allow control of GPIO uclass in SPL")
---
 drivers/gpio/Makefile | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpio/Makefile +0 -1
index 449046b64c..aa41a24cd0 100644
@@ -10,13 +10,11 @@ endif
 obj-$(CONFIG_$(SPL_TPL_)DM_GPIO) += gpio-uclass.o
 
 obj-$(CONFIG_$(SPL_)DM_PCA953X)	+= pca953x_gpio.o
-ifdef CONFIG_$(SPL_TPL_)GPIO

drivers/gpio/Makefile endif · line 20

Quoted 10 lines
drivers/gpio/Makefile +1 -2
-obj-$(CONFIG_DM_74X164)		+= 74x164_gpio.o
-endif
 
 obj-$(CONFIG_AT91_GPIO)	+= at91_gpio.o
 obj-$(CONFIG_ATMEL_PIO4)	+= atmel_pio4.o
 obj-$(CONFIG_BCM6345_GPIO)	+= bcm6345_gpio.o
+obj-$(CONFIG_DM_74X164)		+= 74x164_gpio.o
 obj-$(CONFIG_INTEL_GPIO)	+= intel_gpio.o
 obj-$(CONFIG_INTEL_ICH6_GPIO)	+= intel_ich6_gpio.o
 obj-$(CONFIG_INTEL_BROADWELL_GPIO)	+= intel_broadwell_gpio.o

OK, why is the fix to do what you did here and NOT enable CONFIG_SPL_GPIO on the platform(s) in question to match the rest of bcee8d6764f9 and make the obj- line above look like the pca953x_gpio.o one? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200129/56887f41/attachment.sig>
#2 lore raw

PATCH 1/1 gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

Quoted 2 lines · Tom Rini

OK, why is the fix to do what you did here and NOT enable CONFIG_SPL_GPIO on the platform(s) in question to match the rest of

Because mx7dsabresd_defconfig does not support SPL.

#3 lore raw

PATCH 1/1 gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

Quoted 6 lines · Fabio Estevam
Quoted 2 lines · Tom Rini

OK, why is the fix to do what you did here and NOT enable CONFIG_SPL_GPIO on the platform(s) in question to match the rest of

Because mx7dsabresd_defconfig does not support SPL.

Ah. But it is DM_GPIO? I think looking at bcee8d6764f9 there's a few other i.MX boards that are also broken something needs to be moved to Kconfig / updated still.

In fact, uh, there's a good bit of confusion around that line in the Makefile. The test on 'CONFIG_$(SPL_TPL_)GPIO' will never be true as there is only 'DM_GPIO' (and SPL/TPL variants) and 'SPL/TPL_GPIO_SUPPORT' and no 'GPIO' itself. So everyone using 74x164_gpio.o is broken right now.

Do you want to take a pass at trying to unpack and fix this mess or should I? Thanks again!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200129/0fdb8f97/attachment.sig>
#4 lore raw

PATCH 1/1 gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

Quoted 1 line · Tom Rini

Ah. But it is DM_GPIO? I think looking at bcee8d6764f9 there's a few

Yes, CONFIG_DM_GPIO is selected in mx7dsabresd_defconfig.

Quoted 2 lines

other i.MX boards that are also broken something needs to be moved to Kconfig / updated still.

I can submit a patch moving CONFIG_DM_74X164 from include/confiinclude/configs/mx6ul_14x14_evk.h to defconfig.

Quoted 5 lines

In fact, uh, there's a good bit of confusion around that line in the Makefile. The test on 'CONFIG_$(SPL_TPL_)GPIO' will never be true as there is only 'DM_GPIO' (and SPL/TPL variants) and 'SPL/TPL_GPIO_SUPPORT' and no 'GPIO' itself. So everyone using 74x164_gpio.o is broken right now.

Yes, that's the reason I came up with this patch.

Quoted 2 lines

Do you want to take a pass at trying to unpack and fix this mess or should I? Thanks again!

I am glad to fix this, but what exactly needs to be done?

This patch plus another one that moves CONFIG_DM_74X164 from include/confiinclude/configs/mx6ul_14x14_evk.h to defconfig is all we need, no?

Please clarify.

#5 lore raw

PATCH 1/1 gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

Quoted 5 lines · Fabio Estevam
Quoted 1 line · Tom Rini

Ah. But it is DM_GPIO? I think looking at bcee8d6764f9 there's a few

Yes, CONFIG_DM_GPIO is selected in mx7dsabresd_defconfig.

OK, good.

Quoted 6 lines
Quoted 3 lines

other i.MX boards that are also broken something needs to be moved to Kconfig / updated still.

I can submit a patch moving CONFIG_DM_74X164 from include/confiinclude/configs/mx6ul_14x14_evk.h to defconfig.

OK, please do.

Quoted 8 lines
Quoted 5 lines

In fact, uh, there's a good bit of confusion around that line in the Makefile. The test on 'CONFIG_$(SPL_TPL_)GPIO' will never be true as there is only 'DM_GPIO' (and SPL/TPL variants) and 'SPL/TPL_GPIO_SUPPORT' and no 'GPIO' itself. So everyone using 74x164_gpio.o is broken right now.

Yes, that's the reason I came up with this patch.

Quoted 8 lines
Quoted 2 lines

Do you want to take a pass at trying to unpack and fix this mess or should I? Thanks again!

I am glad to fix this, but what exactly needs to be done?

This patch plus another one that moves CONFIG_DM_74X164 from include/confiinclude/configs/mx6ul_14x14_evk.h to defconfig is all we need, no?

Lets see. Yup, talking this all out as gotten me to seeing that yes, your patch is correct and all we need in the Makefile. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200129/fa170583/attachment.sig>
#6 lore raw

PATCH 1/1 gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

Hi Tom,

Quoted 4 lines · Tom Rini

Lets see. Yup, talking this all out as gotten me to seeing that yes, your patch is correct and all we need in the Makefile. Thanks!

I have just sent v2 that places it inside the ifndef CONFIG_SPL_BUILD block.

This way we don't have issues on SPL targets, such as mx6ul_14x14_evk_defconfig.

Thanks

#7 lore raw

PATCH 1/1 gpio: Let DM_74X164 be built without CONFIG_SPL_GPIO

In reply to Tom Rini

Hi Fabio,

Le 29/01/2020 à 17:10, Tom Rini a écrit :

Quoted 24 lines · Fabio Estevam
Quoted 4 lines · Tom Rini
Quoted 2 lines

Ah. But it is DM_GPIO? I think looking at bcee8d6764f9 there's a few

Yes, CONFIG_DM_GPIO is selected in mx7dsabresd_defconfig.

OK, good.

Quoted 4 lines
Quoted 2 lines

other i.MX boards that are also broken something needs to be moved to Kconfig / updated still.

I can submit a patch moving CONFIG_DM_74X164 from include/confiinclude/configs/mx6ul_14x14_evk.h to defconfig.

OK, please do.

Quoted 11 lines
Quoted 5 lines

In fact, uh, there's a good bit of confusion around that line in the Makefile. The test on 'CONFIG_$(SPL_TPL_)GPIO' will never be true as there is only 'DM_GPIO' (and SPL/TPL variants) and 'SPL/TPL_GPIO_SUPPORT' and no 'GPIO' itself. So everyone using 74x164_gpio.o is broken right now.

Yes, that's the reason I came up with this patch.

Quoted 2 lines

Do you want to take a pass at trying to unpack and fix this mess or should I? Thanks again!

I am glad to fix this, but what exactly needs to be done?

Quoted 8 lines
Quoted 3 lines

This patch plus another one that moves CONFIG_DM_74X164 from include/confiinclude/configs/mx6ul_14x14_evk.h to defconfig is all we need, no?

Lets see. Yup, talking this all out as gotten me to seeing that yes, your patch is correct and all we need in the Makefile. Thanks!

It works on my side :

U-Boot 2020.04-rc1-00849-ge7ab1cb3f0-dirty (Jan 29 2020 - 20:15:47 +0100)

CPU:   Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz) CPU:   Commercial temperature grade (0C to 95C) at 32C Reset cause: POR
Model: Freescale i.MX7 SabreSD Board
Board: i.MX7D SABRESD in secure mode
DRAM:  1 GiB
PMIC: PFUZE3000 DEV_ID=0x30 REV_ID=0x11
MMC:   FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2 Loading Environment from MMC... OK
Video: 480x272x24
In:    serial
Out:   serial
Err:   serial
Net:
Warning: ethernet at 30be0000 using MAC address from ROM
eth0: ethernet at 30be0000
Hit any key to stop autoboot:  0

thanks

Best regards,

Joris