Skip to contentSkip to conversation

dell-smm-hwmon: Add XPS 13 9360 to supported devices list

PATCH In review Haochen Tong 2 participants 4 messages Feb 2, 2020 – Feb 4, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover dell-smm-hwmon: Add XPS 13 9360 to supported devices list

This patch adds Dell XPS 13 9360 to supported devices list in dell-smm-hwmon.

I have tested this on one such device and verified that the fan speed is correctly reported, and can be controlled through pwm1{,_enable}.

Haochen Tong (2):
dell-smm-hwmon: add XPS 13 9360 to supported devices list
dell-smm-hwmon: add XPS 13 9360 to fan control whitelist

 drivers/hwmon/dell-smm-hwmon.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

base-commit: 46d6b7becb1d5a8e697db786590c19e4067a975a

Signature · 1 line
2.25.0
#1 lore raw

PATCH v2 1/2 dell-smm-hwmon: add XPS 13 9360 to supported devices list

Tests have shown that this module works fine on XPS 13 9360: it can successfully detect and report fan status.

---
 drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/hwmon/dell-smm-hwmon.c +7 -0
index 17583bf8c2dc..c8f2182ba969 100644
@@ -1118,6 +1118,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9570"),
 		},
 	},
+	{
+		.ident = "Dell XPS 13 9360",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),
+		},
+	},
 	{ }
 };
 
Signature · 1 line
2.25.0
#2 lore raw

PATCH v2 2/2 dell-smm-hwmon: add XPS 13 9360 to fan control whitelist

In reply to Haochen Tong

Tests have shown that fan control works fine on XPS 13 9360.

---
 drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/hwmon/dell-smm-hwmon.c +8 -0
index c8f2182ba969..f79e10a55840 100644
@@ -1225,6 +1225,14 @@ static struct dmi_system_id i8k_whitelist_fan_control[] __initdata = {
 		},
 		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
 	},
+	{
+		.ident = "Dell XPS 13 9360",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),
+		},
+		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
+	},
 	{ }
 };
 
Signature · 1 line
2.25.0
Reviewed-by on the v2 series
#3 lore raw
In reply to Haochen Tong
Quoted 10 lines · On Monday 03 February 2020 00:31:49 Haochen Tong wrote:

This patch adds Dell XPS 13 9360 to supported devices list in dell-smm-hwmon.

I have tested this on one such device and verified that the fan speed is correctly reported, and can be controlled through pwm1{,_enable}.

Haochen Tong (2):
dell-smm-hwmon: add XPS 13 9360 to supported devices list
dell-smm-hwmon: add XPS 13 9360 to fan control whitelist

Quoted 5 lines
 drivers/hwmon/dell-smm-hwmon.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

base-commit: 46d6b7becb1d5a8e697db786590c19e4067a975a

Hello, both patches now look good, you can add my:

Signature · 2 lines
Pali Rohár
[email protected]