Skip to contentSkip to conversation

dell-smm-hwmon: Add XPS 13 9360 to supported devices list

PATCH Superseded Haochen Tong 2 participants 5 messages Jan 29, 2020 – Jan 31, 2020

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover dell-smm-hwmon: Add XPS 13 9360 to supported devices list

This patch adds Dell XPS 13 9360 to supported devices list in dell-smm-hwmon.

I have tested this on one such device and verified that the fan speed is correctly reported, and can be controlled through pwm1{,_enable}.

Haochen Tong (2):
dell-smm-hwmon: add XPS 13 9360 to supported devices list
dell-smm-hwmon: add XPS 13 9360 to fan control whitelist

 drivers/hwmon/dell-smm-hwmon.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

base-commit: b3a6082223369203d7e7db7e81253ac761377644

Signature · 1 line
2.25.0
#1 lore raw

PATCH 1/2 dell-smm-hwmon: add XPS 13 9360 to supported devices list

Tests have shown that this module works fine on XPS 13 9360: it can successfully detect and report fan status.

---
 drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/hwmon/dell-smm-hwmon.c +7 -0
index 17583bf8c2dc..d9f6394c08d6 100644
@@ -1104,6 +1104,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = {
 		},
 		.driver_data = (void *)&i8k_config_data[DELL_XPS],
 	},
+	{
+		.ident = "Dell XPS 13 9360",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),
+		},
+	},
 	{
 		.ident = "Dell XPS 15 9560",
 		.matches = {
Signature · 1 line
2.25.0
#2 lore raw

Re: [PATCH 1/2] dell-smm-hwmon: add XPS 13 9360 to supported devices list

Quoted 13 lines · On Wednesday 29 January 2020 16:08:38 Haochen Tong wrote:

Tests have shown that this module works fine on XPS 13 9360: it can successfully detect and report fan status.

---
 drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/hwmon/dell-smm-hwmon.c +0 -0
index 17583bf8c2dc..d9f6394c08d6 100644

drivers/hwmon/dell-smm-hwmon.c static const struct dmi_system_id i8k_dmi_table[] __initconst = { · line 1111

Quoted 8 lines
drivers/hwmon/dell-smm-hwmon.c +5 -0
@@ -1104,6 +1104,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = {
 		},
 		.driver_data = (void *)&i8k_config_data[DELL_XPS],
 	},
+	{
+		.ident = "Dell XPS 13 9360",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),

Hello! In patch 2/2 you are using DMI_EXACT_MATCH. I think it does not make sense to use substring match in one case and exact match in another case for one specific machine. I would suggest to use one type of match for both cases.

Quoted 5 lines
drivers/hwmon/dell-smm-hwmon.c +2 -0
+		},
+	},
 	{
 		.ident = "Dell XPS 15 9560",
 		.matches = {
Signature · 2 lines
Pali Rohár
[email protected]
#3 lore raw

Re: [PATCH 1/2] dell-smm-hwmon: add XPS 13 9360 to supported devices list

Quoted 19 lines · Pali Rohár
Quoted 18 lines · On Wednesday 29 January 2020 16:08:38 Haochen Tong wrote:

Tests have shown that this module works fine on XPS 13 9360: it can successfully detect and report fan status.

---
 drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/hwmon/dell-smm-hwmon.c +2 -0
index 17583bf8c2dc..d9f6394c08d6 100644
@@ -1104,6 +1104,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = {
 		},
 		.driver_data = (void *)&i8k_config_data[DELL_XPS],
 	},
+	{
+		.ident = "Dell XPS 13 9360",
Quoted 9 lines

drivers/hwmon/dell-smm-hwmon.c static const struct dmi_system_id i8k_dmi_table[] __initconst = { · line 1111

Quoted 3 lines
drivers/hwmon/dell-smm-hwmon.c +3 -0
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),

Hello! In patch 2/2 you are using DMI_EXACT_MATCH. I think it does not make sense to use substring match in one case and exact match in another case for one specific machine. I would suggest to use one type of match for both cases.

Sure, will fix.

#4 lore raw

PATCH 2/2 dell-smm-hwmon: add XPS 13 9360 to fan control whitelist

In reply to Haochen Tong

Tests have shown that fan control works fine on XPS 13 9360.

---
 drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/hwmon/dell-smm-hwmon.c +8 -0
index d9f6394c08d6..f20a7ea050e1 100644
@@ -1225,6 +1225,14 @@ static struct dmi_system_id i8k_whitelist_fan_control[] __initdata = {
 		},
 		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
 	},
+	{
+		.ident = "Dell XPS 13 9360",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9360"),
+		},
+		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
+	},
 	{ }
 };
 
Signature · 1 line
2.25.0