Skip to contentSkip to conversation

x265: add x265 recipe

PATCH Superseded Scott Branden 3 participants 11 messages Feb 8, 2020 – Feb 10, 2020

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 x265: add x265 recipe

Add x265 recipe from latest revision of stable branch.

---
 meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 meta/recipes-multimedia/x265/x265_git.bb
meta/recipes-multimedia/x265/x265_git.bb new file +20 -0
new file mode 100644
index 0000000000..796fbbc13a
@@ -0,0 +1,20 @@
+SUMMARY = "H.265/HEVC video encoder"
+DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format."
+HOMEPAGE = "http://www.videolan.org/developers/x265.html"
+
+LICENSE = "GPLv2"
+LICENSE_FLAGS = "commercial"
+LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"
+
+DEPENDS = "gnutls zlib libpcre"
+
+SRC_URI = "git://github.com/videolan/x265;branch=stable \
+          "
+
+SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
+
+S = "${WORKDIR}/git/source"
+
+inherit lib_package pkgconfig cmake
+
+AS[unexport] = "1"
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 2/2 ffmpeg: add PACKAGECONFIG support for x265

Add PACKAGECONFIG support for x265 in ffmpeg.

---
 meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.2.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.2.bb +2 -1
index a3cf0c1a37..0c27663cf6 100644
@@ -43,7 +43,7 @@ DEPENDS = "nasm-native"
 inherit autotools pkgconfig
 
 PACKAGECONFIG ??= "avdevice avfilter avcodec avformat swresample swscale postproc avresample \
-                   alsa bzlib gpl lzma theora x264 zlib \
+                   alsa bzlib gpl lzma theora x264 x265 zlib \
                    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xv xcb', '', d)}"
 
 # libraries to build in addition to avutil
@@ -74,6 +74,7 @@ PACKAGECONFIG[vaapi] = "--enable-vaapi,--disable-vaapi,libva"
 PACKAGECONFIG[vdpau] = "--enable-vdpau,--disable-vdpau,libvdpau"
 PACKAGECONFIG[vpx] = "--enable-libvpx,--disable-libvpx,libvpx"
 PACKAGECONFIG[x264] = "--enable-libx264,--disable-libx264,x264"
+PACKAGECONFIG[x265] = "--enable-libx265,--disable-libx265,x265"
 PACKAGECONFIG[xcb] = "--enable-libxcb,--disable-libxcb,libxcb"
 PACKAGECONFIG[xv] = "--enable-outdev=xv,--disable-outdev=xv,libxv"
 PACKAGECONFIG[zlib] = "--enable-zlib,--disable-zlib,zlib"
Signature · 1 line
2.17.1
#2 lore raw
In reply to Scott Branden
Quoted 1 line · Scott Branden via Openembedded-core

Add x265 recipe from latest revision of stable branch.

I wonder if it belongs to core are there deps on it that we need in common metadata

Quoted 46 lines
---
 meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 meta/recipes-multimedia/x265/x265_git.bb
meta/recipes-multimedia/x265/x265_git.bb new file +2 -0
new file mode 100644
index 0000000000..796fbbc13a
@@ -0,0 +1,20 @@
+SUMMARY = "H.265/HEVC video encoder"
+DESCRIPTION = "A free software library and application for encoding video

streams into the H.265/HEVC format."

meta/recipes-multimedia/x265/x265_git.bb new file +5 -0
+HOMEPAGE = "http://www.videolan.org/developers/x265.html"
+
+LICENSE = "GPLv2"
+LICENSE_FLAGS = "commercial"
+LIC_FILES_CHKSUM =

"file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"

meta/recipes-multimedia/x265/x265_git.bb new file +13 -1
+
+DEPENDS = "gnutls zlib libpcre"
+
+SRC_URI = "git://github.com/videolan/x265;branch=stable \
+          "
+
+SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
+
+S = "${WORKDIR}/git/source"
+
+inherit lib_package pkgconfig cmake
+
+AS[unexport] = "1"
--

2.17.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw

Hi Khem,

Quoted 8 lines · Khem Raj

On Fri, Feb 7, 2020 at 4:01 PM Scott Branden via Openembedded-core <[email protected] <mailto:[email protected]>> wrote:

Add x265 recipe from latest revision of stable branch.

I wonder if it belongs to core are there deps on it that we need in common metadata

I simply followed where x264 recipe is located and placed x265 beside it. Both are needed when enabled in ffmpeg.

I don't know if that answers your question as to where they should be located.

Quoted 53 lines


    Signed-off-by: Scott Branden <[email protected]
    <mailto:[email protected]>>
    ---
     meta/recipes-multimedia/x265/x265_git.bb <http://x265_git.bb> |
    20 ++++++++++++++++++++
     1 file changed, 20 insertions(+)
     create mode 100644 meta/recipes-multimedia/x265/x265_git.bb
    <http://x265_git.bb>

    diff --git a/meta/recipes-multimedia/x265/x265_git.bb
    <http://x265_git.bb> b/meta/recipes-multimedia/x265/x265_git.bb
    <http://x265_git.bb>
    new file mode 100644
    index 0000000000..796fbbc13a
    --- /dev/null
    +++ b/meta/recipes-multimedia/x265/x265_git.bb <http://x265_git.bb>
    @@ -0,0 +1,20 @@
    +SUMMARY = "H.265/HEVC video encoder"
    +DESCRIPTION = "A free software library and application for
    encoding video streams into the H.265/HEVC format."
    +HOMEPAGE = "http://www.videolan.org/developers/x265.html"
    +
    +LICENSE = "GPLv2"
    +LICENSE_FLAGS = "commercial"
    +LIC_FILES_CHKSUM =
    "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"
    +
    +DEPENDS = "gnutls zlib libpcre"
    +
    +SRC_URI = "git://github.com/videolan/x265;branch=stable
    <http://github.com/videolan/x265;branch=stable> \
    +          "
    +
    +SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
    +
    +S = "${WORKDIR}/git/source"
    +
    +inherit lib_package pkgconfig cmake
    +
    +AS[unexport] = "1"
    -- 
    2.17.1

    -- 
    _______________________________________________
    Openembedded-core mailing list
    [email protected]
    <mailto:[email protected]>
    http://lists.openembedded.org/mailman/listinfo/openembedded-core
#4 lore raw
Quoted 12 lines · Scott Branden

Hi Khem,

On 2020-02-07 5:12 p.m., Khem Raj wrote:

Quoted 2 lines · Scott Branden via Openembedded-core

Add x265 recipe from latest revision of stable branch.

Quoted 7 lines

I wonder if it belongs to core are there deps on it that we need in common metadata

I simply followed where x264 recipe is located and placed x265 beside it. Both are needed when enabled in ffmpeg.

I don't know if that answers your question as to where they should be located.

Quoted 1 line

idea is to keep small and therefore we should assess the inclusions in core we have many packageconfigs which require packages from other layers so if ffmpeg needs it and is optional then it should be fine to keep it in meta-multimedia and packageconfig in ffmpeg disabled by default.

Quoted 44 lines
Quoted 42 lines
---
 meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 meta/recipes-multimedia/x265/x265_git.bb
meta/recipes-multimedia/x265/x265_git.bb new file +20 -1
new file mode 100644
index 0000000000..796fbbc13a
@@ -0,0 +1,20 @@
+SUMMARY = "H.265/HEVC video encoder"
+DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format."
+HOMEPAGE = "http://www.videolan.org/developers/x265.html"
+
+LICENSE = "GPLv2"
+LICENSE_FLAGS = "commercial"
+LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"
+
+DEPENDS = "gnutls zlib libpcre"
+
+SRC_URI = "git://github.com/videolan/x265;branch=stable \
+          "
+
+SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
+
+S = "${WORKDIR}/git/source"
+
+inherit lib_package pkgconfig cmake
+
+AS[unexport] = "1"
--

2.17.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#5 lore raw
Quoted 12 lines · Khem Raj
Quoted 11 lines · Scott Branden

Hi Khem,

On 2020-02-07 5:12 p.m., Khem Raj wrote:

Quoted 1 line · Scott Branden via Openembedded-core

Add x265 recipe from latest revision of stable branch.

I wonder if it belongs to core are there deps on it that we need in common metadata

Quoted 8 lines
Quoted 4 lines

I simply followed where x264 recipe is located and placed x265 beside it. Both are needed when enabled in ffmpeg.

I don't know if that answers your question as to where they should be located.

idea is to keep small and therefore we should assess the inclusions in core we have many packageconfigs which require packages from other layers so if ffmpeg needs it and is optional then it should be fine to keep it in meta-multimedia and packageconfig in ffmpeg disabled by default.

I don't see why x264 would be in core and x265 in meta-multimedia. Both should be moved to meta-multimedia then?

I think you would also require a bbappend to fffmpeg recipe to add x264 and x265 to ffmpeg packageconfig. if that is the case, why not move ffmpeg to meta-multimedia as well?

Quoted 43 lines
Quoted 43 lines
Quoted 42 lines
---
  meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++
  1 file changed, 20 insertions(+)

create mode 100644 meta/recipes-multimedia/x265/x265_git.bb

meta/recipes-multimedia/x265/x265_git.bb new file +20 -1
new file mode 100644
index 0000000000..796fbbc13a
@@ -0,0 +1,20 @@
+SUMMARY = "H.265/HEVC video encoder"
+DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format."
+HOMEPAGE = "http://www.videolan.org/developers/x265.html"
+
+LICENSE = "GPLv2"
+LICENSE_FLAGS = "commercial"
+LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"
+
+DEPENDS = "gnutls zlib libpcre"
+
+SRC_URI = "git://github.com/videolan/x265;branch=stable \
+          "
+
+SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
+
+S = "${WORKDIR}/git/source"
+
+inherit lib_package pkgconfig cmake
+
+AS[unexport] = "1"
--

2.17.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#6 lore raw
Quoted 19 lines · Scott Branden
Quoted 15 lines · Khem Raj
Quoted 14 lines · Scott Branden

Hi Khem,

On 2020-02-07 5:12 p.m., Khem Raj wrote:

Quoted 1 line · Scott Branden via Openembedded-core

Add x265 recipe from latest revision of stable branch.

I wonder if it belongs to core are there deps on it that we need in common metadata

I simply followed where x264 recipe is located and placed x265 beside it. Both are needed when enabled in ffmpeg.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

I don't know if that answers your question as to where they should be located.

idea is to keep small and therefore we should assess the inclusions in core we have many packageconfigs which require packages from other layers so if ffmpeg needs it and is optional then it should be fine to keep it in meta-multimedia and packageconfig in ffmpeg disabled by default.

I don't see why x264 would be in core and x265 in meta-multimedia. Both should be moved to meta-multimedia then?

I followed the thread a bit and I see there are followups where usecase for other recipes in core is now
established, where this seemed a leaf package being added to oe-core, So perhaps it should be added
to validation loops as well like x264.

Quoted 4 lines

I think you would also require a bbappend to fffmpeg recipe to add x264 and x265 to ffmpeg packageconfig.
if that is the case, why not move ffmpeg to meta-multimedia as well?

You would not go down that line of thought since these packages are in the dependency chain for validating reference
images in core along with they being used by other packages from other layers.

Quoted 44 lines
Quoted 43 lines
Quoted 43 lines
Quoted 42 lines
---
  meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++
  1 file changed, 20 insertions(+)

create mode 100644 meta/recipes-multimedia/x265/x265_git.bb

meta/recipes-multimedia/x265/x265_git.bb new file +20 -1
new file mode 100644
index 0000000000..796fbbc13a
@@ -0,0 +1,20 @@
+SUMMARY = "H.265/HEVC video encoder"
+DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format."
+HOMEPAGE = "http://www.videolan.org/developers/x265.html"
+
+LICENSE = "GPLv2"
+LICENSE_FLAGS = "commercial"
+LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"
+
+DEPENDS = "gnutls zlib libpcre"
+
+SRC_URI = "git://github.com/videolan/x265;branch=stable \
+          "
+
+SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
+
+S = "${WORKDIR}/git/source"
+
+inherit lib_package pkgconfig cmake
+
+AS[unexport] = "1"
--

2.17.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#7 lore raw
Quoted 24 lines · Khem Raj
Quoted 22 lines · Scott Branden
Quoted 19 lines · Khem Raj
Quoted 6 lines · Scott Branden

Hi Khem,

On 2020-02-07 5:12 p.m., Khem Raj wrote:

Quoted 8 lines
Quoted 1 line · Scott Branden via Openembedded-core

Add x265 recipe from latest revision of stable branch.

I wonder if it belongs to core are there deps on it that we need in common metadata

I simply followed where x264 recipe is located and placed x265 beside it. Both are needed when enabled in ffmpeg.

I don't know if that answers your question as to where they should be located.

idea is to keep small and therefore we should assess the inclusions in core we have many packageconfigs which require packages from other layers so if ffmpeg needs it and is optional then it should be fine to keep it in meta-multimedia and packageconfig in ffmpeg disabled by default.

Quoted 8 lines
Quoted 3 lines

I don't see why x264 would be in core and x265 in meta-multimedia. Both should be moved to meta-multimedia then?

I followed the thread a bit and I see there are followups where usecase for other recipes in core is now
established, where this seemed a leaf package being added to oe-core, So perhaps it should be added
to validation loops as well like x264.

I leave it to the powers that be to decide where to place this recipe.

Quoted 49 lines
Quoted 5 lines

I think you would also require a bbappend to fffmpeg recipe to add x264 and x265 to ffmpeg packageconfig.
if that is the case, why not move ffmpeg to meta-multimedia as well?

You would not go down that line of thought since these packages are in the dependency chain for validating reference
images in core along with they being used by other packages from other layers.

Quoted 40 lines
Quoted 40 lines
Quoted 40 lines
Quoted 40 lines
---
   meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++
   1 file changed, 20 insertions(+)

create mode 100644 meta/recipes-multimedia/x265/x265_git.bb

meta/recipes-multimedia/x265/x265_git.bb new file +20 -1
new file mode 100644
index 0000000000..796fbbc13a
@@ -0,0 +1,20 @@
+SUMMARY = "H.265/HEVC video encoder"
+DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format."
+HOMEPAGE = "http://www.videolan.org/developers/x265.html"
+
+LICENSE = "GPLv2"
+LICENSE_FLAGS = "commercial"
+LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"
+
+DEPENDS = "gnutls zlib libpcre"
+
+SRC_URI = "git://github.com/videolan/x265;branch=stable \
+          "
+
+SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
+
+S = "${WORKDIR}/git/source"
+
+inherit lib_package pkgconfig cmake
+
+AS[unexport] = "1"
--

2.17.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#8 lore raw

As long as we're consistent, I'm ok with either option. I think it's ultimately up to RP to make the call.

Alex

Quoted 103 lines · Scott Branden via Openembedded-core
Quoted 6 lines · Khem Raj
Quoted 4 lines · Scott Branden
Quoted 1 line · Khem Raj

On Fri, Feb 7, 2020 at 8:02 PM Scott Branden <

Quoted 7 lines · [email protected]> wrote:
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

Hi Khem,

On 2020-02-07 5:12 p.m., Khem Raj wrote:

On Fri, Feb 7, 2020 at 4:01 PM Scott Branden via Openembedded-core <

Quoted 2 lines · [email protected]> wrote:
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 1 line

Add x265 recipe from latest revision of stable branch.

I wonder if it belongs to core are there deps on it that we need in

common metadata

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

I simply followed where x264 recipe is located and placed x265 beside

it.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Both are needed when enabled in ffmpeg.

I don't know if that answers your question as to where they should be

located.

Quoted 1 line
Quoted 1 line
Quoted 1 line

idea is to keep small and therefore we should assess the inclusions in

core

Quoted 11 lines
Quoted 6 lines
Quoted 3 lines

we have many packageconfigs which require packages from other layers so if ffmpeg needs it and is optional then it should be fine to keep it in meta-multimedia and packageconfig in ffmpeg disabled by default.

I don't see why x264 would be in core and x265 in meta-multimedia. Both should be moved to meta-multimedia then?

I followed the thread a bit and I see there are followups where usecase for other recipes in core is now
established, where this seemed a leaf package being added to oe-core, So perhaps it should be added
to validation loops as well like x264.

I leave it to the powers that be to decide where to place this recipe.

Quoted 8 lines
Quoted 5 lines

I think you would also require a bbappend to fffmpeg recipe to add x264 and x265 to ffmpeg packageconfig.
if that is the case, why not move ffmpeg to meta-multimedia as well?

You would not go down that line of thought since these packages are in the dependency chain for validating reference
images in core along with they being used by other packages from other

layers.

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
---
   meta/recipes-multimedia/x265/x265_git.bb | 20

++++++++++++++++++++

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

Review

Quoted 4 lines
   1 file changed, 20 insertions(+)

create mode 100644 meta/recipes-multimedia/x265/x265_git.bb

(quoted diff) +0 -0

b/meta/recipes-multimedia/x265/x265_git.bb

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

meta/recipes-multimedia/x265/x265_git.bb line 2

Quoted 7 lines

new file mode 100644
index 0000000000..796fbbc13a

meta/recipes-multimedia/x265/x265_git.bb new file +2 -0
@@ -0,0 +1,20 @@
+SUMMARY = "H.265/HEVC video encoder"
+DESCRIPTION = "A free software library and application for encoding

video streams into the H.265/HEVC format."

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

meta/recipes-multimedia/x265/x265_git.bb line 7

Quoted 5 lines
meta/recipes-multimedia/x265/x265_git.bb new file +5 -0
+HOMEPAGE = "http://www.videolan.org/developers/x265.html"
+
+LICENSE = "GPLv2"
+LICENSE_FLAGS = "commercial"
+LIC_FILES_CHKSUM =

"file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"

Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
meta/recipes-multimedia/x265/x265_git.bb new file +13 -1
+
+DEPENDS = "gnutls zlib libpcre"
+
+SRC_URI = "git://github.com/videolan/x265;branch=stable \
+          "
+
+SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
+
+S = "${WORKDIR}/git/source"
+
+inherit lib_package pkgconfig cmake
+
+AS[unexport] = "1"
--

2.17.1

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#9 lore raw
Quoted 4 lines · Alexander Kanavin

As long as we're consistent, I'm ok with either option. I think it's ultimately up to RP to make the call.

The usecase is fine, as long as we add x265 support to gst plugins and ffmeg and it gets tested via reference
images, I see no issues adding it.

Quoted 95 lines

Alex

Quoted 92 lines · Scott Branden via Openembedded-core
Quoted 24 lines · Khem Raj
Quoted 22 lines · Scott Branden
Quoted 19 lines · Khem Raj
Quoted 6 lines · Scott Branden

Hi Khem,

On 2020-02-07 5:12 p.m., Khem Raj wrote:

Quoted 8 lines
Quoted 1 line · Scott Branden via Openembedded-core

Add x265 recipe from latest revision of stable branch.

I wonder if it belongs to core are there deps on it that we need in common metadata

I simply followed where x264 recipe is located and placed x265 beside it. Both are needed when enabled in ffmpeg.

I don't know if that answers your question as to where they should be located.

idea is to keep small and therefore we should assess the inclusions in core we have many packageconfigs which require packages from other layers so if ffmpeg needs it and is optional then it should be fine to keep it in meta-multimedia and packageconfig in ffmpeg disabled by default.

Quoted 8 lines
Quoted 3 lines

I don't see why x264 would be in core and x265 in meta-multimedia. Both should be moved to meta-multimedia then?

I followed the thread a bit and I see there are followups where usecase for other recipes in core is now
established, where this seemed a leaf package being added to oe-core, So perhaps it should be added
to validation loops as well like x264.

I leave it to the powers that be to decide where to place this recipe.

Quoted 44 lines
Quoted 5 lines

I think you would also require a bbappend to fffmpeg recipe to add x264 and x265 to ffmpeg packageconfig.
if that is the case, why not move ffmpeg to meta-multimedia as well?

You would not go down that line of thought since these packages are in the dependency chain for validating reference
images in core along with they being used by other packages from other layers.

Quoted 35 lines
Quoted 35 lines
Quoted 35 lines
Quoted 35 lines
---
   meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++
   1 file changed, 20 insertions(+)

create mode 100644 meta/recipes-multimedia/x265/x265_git.bb

meta/recipes-multimedia/x265/x265_git.bb new file +20 -1
new file mode 100644
index 0000000000..796fbbc13a
@@ -0,0 +1,20 @@
+SUMMARY = "H.265/HEVC video encoder"
+DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format."
+HOMEPAGE = "http://www.videolan.org/developers/x265.html"
+
+LICENSE = "GPLv2"
+LICENSE_FLAGS = "commercial"
+LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"
+
+DEPENDS = "gnutls zlib libpcre"
+
+SRC_URI = "git://github.com/videolan/x265;branch=stable \
+          "
+
+SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
+
+S = "${WORKDIR}/git/source"
+
+inherit lib_package pkgconfig cmake
+
+AS[unexport] = "1"
--

2.17.1

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#10 lore raw
Quoted 8 lines · Khem Raj
Quoted 3 lines · Alexander Kanavin

As long as we're consistent, I'm ok with either option. I think it's ultimately up to RP to make the call.

The usecase is fine, as long as we add x265 support to gst plugins and ffmeg and it gets tested via reference
images, I see no issues adding it.

I'm changing my opinion now and leaning toward meta-multimedia as Khem originally suggested. For the simple reason that I think x265 only builds (easily) for x86 based platforms.

That being the case:
we only add the packageconfig option to ffmpeg but don't enable by default in the PACKAGECONFIG default in the ffmpeg recipe. PACKAGECONFIG[x265] = "--enable-libx265,--disable-libx265,x265"

And add the x265 recipe to meta-multimedia and limit to x86 at this time. Is this what I would set in the x265 recipe?

COMPATIBLE_MACHINE_x86 = "(.*)"
COMPATIBLE_MACHINE_x86-64 = "(.*)"

Quoted 91 lines
Quoted 91 lines

Alex

Quoted 88 lines · Scott Branden via Openembedded-core
Quoted 23 lines · Khem Raj
Quoted 21 lines · Scott Branden
Quoted 19 lines · Khem Raj
Quoted 6 lines · Scott Branden

Hi Khem,

On 2020-02-07 5:12 p.m., Khem Raj wrote:

Quoted 8 lines
Quoted 1 line · Scott Branden via Openembedded-core

Add x265 recipe from latest revision of stable branch.

I wonder if it belongs to core are there deps on it that we need in common metadata

I simply followed where x264 recipe is located and placed x265 beside it. Both are needed when enabled in ffmpeg.

I don't know if that answers your question as to where they should be located.

idea is to keep small and therefore we should assess the inclusions in core we have many packageconfigs which require packages from other layers so if ffmpeg needs it and is optional then it should be fine to keep it in meta-multimedia and packageconfig in ffmpeg disabled by default.

Quoted 8 lines
Quoted 3 lines

I don't see why x264 would be in core and x265 in meta-multimedia. Both should be moved to meta-multimedia then?

I followed the thread a bit and I see there are followups where usecase for other recipes in core is now
established, where this seemed a leaf package being added to oe-core, So perhaps it should be added
to validation loops as well like x264.

I leave it to the powers that be to decide where to place this recipe.

Quoted 43 lines
Quoted 4 lines

I think you would also require a bbappend to fffmpeg recipe to add x264 and x265 to ffmpeg packageconfig.
if that is the case, why not move ffmpeg to meta-multimedia as well?

You would not go down that line of thought since these packages are in the dependency chain for validating reference
images in core along with they being used by other packages from other layers.

Quoted 35 lines
Quoted 35 lines
Quoted 35 lines
Quoted 35 lines
---
    meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++
    1 file changed, 20 insertions(+)
    create mode 100644 meta/recipes-multimedia/x265/x265_git.bb
meta/recipes-multimedia/x265/x265_git.bb new file +20 -1
new file mode 100644
index 0000000000..796fbbc13a
@@ -0,0 +1,20 @@
+SUMMARY = "H.265/HEVC video encoder"
+DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format."
+HOMEPAGE = "http://www.videolan.org/developers/x265.html"
+
+LICENSE = "GPLv2"
+LICENSE_FLAGS = "commercial"
+LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"
+
+DEPENDS = "gnutls zlib libpcre"
+
+SRC_URI = "git://github.com/videolan/x265;branch=stable \
+          "
+
+SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
+
+S = "${WORKDIR}/git/source"
+
+inherit lib_package pkgconfig cmake
+
+AS[unexport] = "1"
--

2.17.1

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core