Skip to contentSkip to conversation

x265: add x265 recipe

PATCH Superseded Scott Branden 3 participants 8 messages Feb 7, 2020 – Feb 9, 2020

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x265: add x265 recipe

Add x265 recipe from latest revision of stable branch.

---
 meta/recipes-multimedia/x265/x265_git.bb | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 meta/recipes-multimedia/x265/x265_git.bb
meta/recipes-multimedia/x265/x265_git.bb new file +21 -0
new file mode 100644
index 0000000000..7c230e2b1e
@@ -0,0 +1,21 @@
+SUMMARY = "H.265/HEVC video encoder"
+DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format."
+HOMEPAGE = "http://www.videolan.org/developers/x265.html"
+
+LICENSE = "GPLv2"
+LICENSE_FLAGS = "commercial"
+LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"
+
+DEPENDS = "nasm-native"
+DEPENDS = "gnutls zlib libpcre"
+
+SRC_URI = "git://github.com/videolan/x265;branch=stable \
+          "
+
+SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
+
+S = "${WORKDIR}/git/source"
+
+inherit lib_package pkgconfig cmake
+
+AS[unexport] = "1"
Signature · 1 line
2.17.1
#1 lore raw

Can you also enable x265 in ffmpeg and gstreamer plugins recipes, so there would be actual users of the codec in oe-core?

Also, x265 git repo does have tagged releases, and so PV/SRCREV in recipe should be set to match a release tag.

Alex

Quoted 47 lines · Scott Branden via Openembedded-core

Add x265 recipe from latest revision of stable branch.

---
 meta/recipes-multimedia/x265/x265_git.bb | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 meta/recipes-multimedia/x265/x265_git.bb
meta/recipes-multimedia/x265/x265_git.bb new file +2 -0
new file mode 100644
index 0000000000..7c230e2b1e
@@ -0,0 +1,21 @@
+SUMMARY = "H.265/HEVC video encoder"
+DESCRIPTION = "A free software library and application for encoding video

streams into the H.265/HEVC format."

meta/recipes-multimedia/x265/x265_git.bb new file +5 -0
+HOMEPAGE = "http://www.videolan.org/developers/x265.html"
+
+LICENSE = "GPLv2"
+LICENSE_FLAGS = "commercial"
+LIC_FILES_CHKSUM =

"file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"

meta/recipes-multimedia/x265/x265_git.bb new file +14 -1
+
+DEPENDS = "nasm-native"
+DEPENDS = "gnutls zlib libpcre"
+
+SRC_URI = "git://github.com/videolan/x265;branch=stable \
+          "
+
+SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
+
+S = "${WORKDIR}/git/source"
+
+inherit lib_package pkgconfig cmake
+
+AS[unexport] = "1"
--

2.17.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw

HI Alex,

Quoted 1 line · Alexander Kanavin

Can you also enable x265 in ffmpeg and gstreamer plugins recipes, so there would be actual users of the codec in oe-core?

I do have a patch for ffmpeg and have tested that works.  I'll add that to the patch series.

Quoted 2 lines

Also, x265 git repo does have tagged releases, and so PV/SRCREV in recipe should be set to match a release tag.

You'll have to help me out a little here on exactly what you want.

This is based off the stable tag.
I already specified the SRCREV in the recipe.

Do you want PV to be:
PV = "stable+git${SRCPV}"

?

Quoted 58 lines

Alex

On Fri, 7 Feb 2020 at 22:35, Scott Branden via Openembedded-core <[email protected] <mailto:[email protected]>> wrote:

    Add x265 recipe from latest revision of stable branch.

    Signed-off-by: Scott Branden <[email protected]
    <mailto:[email protected]>>
    ---
     meta/recipes-multimedia/x265/x265_git.bb <http://x265_git.bb> |
    21 +++++++++++++++++++++
     1 file changed, 21 insertions(+)
     create mode 100644 meta/recipes-multimedia/x265/x265_git.bb
    <http://x265_git.bb>

    diff --git a/meta/recipes-multimedia/x265/x265_git.bb
    <http://x265_git.bb> b/meta/recipes-multimedia/x265/x265_git.bb
    <http://x265_git.bb>
    new file mode 100644
    index 0000000000..7c230e2b1e
    --- /dev/null
    +++ b/meta/recipes-multimedia/x265/x265_git.bb <http://x265_git.bb>
    @@ -0,0 +1,21 @@
    +SUMMARY = "H.265/HEVC video encoder"
    +DESCRIPTION = "A free software library and application for
    encoding video streams into the H.265/HEVC format."
    +HOMEPAGE = "http://www.videolan.org/developers/x265.html"
    +
    +LICENSE = "GPLv2"
    +LICENSE_FLAGS = "commercial"
    +LIC_FILES_CHKSUM =
    "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"
    +
    +DEPENDS = "nasm-native"
    +DEPENDS = "gnutls zlib libpcre"
    +
    +SRC_URI = "git://github.com/videolan/x265;branch=stable
    <http://github.com/videolan/x265;branch=stable> \
    +          "
    +
    +SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
    +
    +S = "${WORKDIR}/git/source"
    +
    +inherit lib_package pkgconfig cmake
    +
    +AS[unexport] = "1"
    -- 
    2.17.1

    -- 
    _______________________________________________
    Openembedded-core mailing list
    [email protected]
    <mailto:[email protected]>
    http://lists.openembedded.org/mailman/listinfo/openembedded-core
#3 lore raw

Hi Alex,

more comment below about PV.

Quoted 9 lines · Scott Branden

HI Alex,

Quoted 1 line · Alexander Kanavin

Can you also enable x265 in ffmpeg and gstreamer plugins recipes, so there would be actual users of the codec in oe-core?

I do have a patch for ffmpeg and have tested that works.  I'll add that to the patch series.

Quoted 2 lines

Also, x265 git repo does have tagged releases, and so PV/SRCREV in recipe should be set to match a release tag.

You'll have to help me out a little here on exactly what you want.

Quoted 7 lines

This is based off the stable tag.
I already specified the SRCREV in the recipe.

Do you want PV to be:
PV = "stable+git${SRCPV}"

?

I was trying to follow the x264 recipe.

Do you want me do something like name the recipe x265_stable.bb instead and not specify PV?

Quoted 59 lines
Quoted 58 lines

Alex

On Fri, 7 Feb 2020 at 22:35, Scott Branden via Openembedded-core <[email protected] <mailto:[email protected]>> wrote:

    Add x265 recipe from latest revision of stable branch.

    Signed-off-by: Scott Branden <[email protected]
    <mailto:[email protected]>>
    ---
     meta/recipes-multimedia/x265/x265_git.bb <http://x265_git.bb> |
    21 +++++++++++++++++++++
     1 file changed, 21 insertions(+)
     create mode 100644 meta/recipes-multimedia/x265/x265_git.bb
    <http://x265_git.bb>

    diff --git a/meta/recipes-multimedia/x265/x265_git.bb
    <http://x265_git.bb> b/meta/recipes-multimedia/x265/x265_git.bb
    <http://x265_git.bb>
    new file mode 100644
    index 0000000000..7c230e2b1e
    --- /dev/null
    +++ b/meta/recipes-multimedia/x265/x265_git.bb <http://x265_git.bb>
    @@ -0,0 +1,21 @@
    +SUMMARY = "H.265/HEVC video encoder"
    +DESCRIPTION = "A free software library and application for
    encoding video streams into the H.265/HEVC format."
    +HOMEPAGE = "http://www.videolan.org/developers/x265.html"
    +
    +LICENSE = "GPLv2"
    +LICENSE_FLAGS = "commercial"
    +LIC_FILES_CHKSUM =
    "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"
    +
    +DEPENDS = "nasm-native"
    +DEPENDS = "gnutls zlib libpcre"
    +
    +SRC_URI = "git://github.com/videolan/x265;branch=stable
    <http://github.com/videolan/x265;branch=stable> \
    +          "
    +
    +SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
    +
    +S = "${WORKDIR}/git/source"
    +
    +inherit lib_package pkgconfig cmake
    +
    +AS[unexport] = "1"
    -- 
    2.17.1

    -- 
    _______________________________________________
    Openembedded-core mailing list
    [email protected]
    <mailto:[email protected]>
    http://lists.openembedded.org/mailman/listinfo/openembedded-core
#4 lore raw

What I meant is that upstream is actually tagging releases:
https://github.com/videolan/x265/releases
and therefore we should package the latest release, rather than a random commit.

Which means you should name the recipe x265_3.1.2.bb and set SRCREV to match the 3.1.2 tag. Going forward, the recipe should be updated the same
way: rename file to the new version, update SRCREV.

Another problem is that github is not synced properly with the original x265 repo, and is several months behind. SRC_URI should probably refer to
https://bitbucket.org/multicoreware/x265/src/default/
Alternatively, don't use git at all and fetch tarballs:
http://ftp.videolan.org/pub/videolan/x265/

Alex

Quoted 91 lines · Scott Branden

Hi Alex,

more comment below about PV.

On 2020-02-07 2:26 p.m., Scott Branden wrote:

HI Alex,

On 2020-02-07 2:09 p.m., Alexander Kanavin wrote:

Can you also enable x265 in ffmpeg and gstreamer plugins recipes, so there would be actual users of the codec in oe-core?

I do have a patch for ffmpeg and have tested that works. I'll add that to the patch series.

Also, x265 git repo does have tagged releases, and so PV/SRCREV in recipe should be set to match a release tag.

You'll have to help me out a little here on exactly what you want.

This is based off the stable tag.
I already specified the SRCREV in the recipe.

Do you want PV to be:
PV = "stable+git${SRCPV}"

?

I was trying to follow the x264 recipe.

Do you want me do something like name the recipe x265_stable.bb instead and not specify PV?

Alex

Quoted 47 lines · Scott Branden via Openembedded-core

Add x265 recipe from latest revision of stable branch.

---
 meta/recipes-multimedia/x265/x265_git.bb | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 meta/recipes-multimedia/x265/x265_git.bb
meta/recipes-multimedia/x265/x265_git.bb new file +2 -0
new file mode 100644
index 0000000000..7c230e2b1e
@@ -0,0 +1,21 @@
+SUMMARY = "H.265/HEVC video encoder"
+DESCRIPTION = "A free software library and application for encoding

video streams into the H.265/HEVC format."

meta/recipes-multimedia/x265/x265_git.bb new file +5 -0
+HOMEPAGE = "http://www.videolan.org/developers/x265.html"
+
+LICENSE = "GPLv2"
+LICENSE_FLAGS = "commercial"
+LIC_FILES_CHKSUM =

"file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"

meta/recipes-multimedia/x265/x265_git.bb new file +14 -1
+
+DEPENDS = "nasm-native"
+DEPENDS = "gnutls zlib libpcre"
+
+SRC_URI = "git://github.com/videolan/x265;branch=stable \
+          "
+
+SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
+
+S = "${WORKDIR}/git/source"
+
+inherit lib_package pkgconfig cmake
+
+AS[unexport] = "1"
--

2.17.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#5 lore raw

Hi Alex,

Thanks for the pointers.

Yes, too bad - the github mirror is out of date, it would be nice to have commit history.

I will setup x265_3.2.1.bb recipe use tarballs to fetch.

Quoted 104 lines · Alexander Kanavin

What I meant is that upstream is actually tagging releases:
https://github.com/videolan/x265/releases
and therefore we should package the latest release, rather than a random commit.

Which means you should name the recipe x265_3.1.2.bb <http://x265_3.1.2.bb> and set SRCREV to match the 3.1.2 tag. Going forward, the recipe should be updated the same way: rename file to the new version, update SRCREV.

Another problem is that github is not synced properly with the original x265 repo, and is several months behind. SRC_URI should probably refer to https://bitbucket.org/multicoreware/x265/src/default/
Alternatively, don't use git at all and fetch tarballs: http://ftp.videolan.org/pub/videolan/x265/

Alex

On Sat, 8 Feb 2020 at 00:28, Scott Branden <[email protected] <mailto:[email protected]>> wrote:

Hi Alex,

more comment below about PV.

Quoted 12 lines · Scott Branden
    HI Alex,

    On 2020-02-07 2:09 p.m., Alexander Kanavin wrote:
Quoted 2 lines

Can you also enable x265 in ffmpeg and gstreamer plugins recipes, so there would be actual users of the codec in oe-core?

I do have a patch for ffmpeg and have tested that works. I'll add that to the patch series.

Quoted 3 lines

Also, x265 git repo does have tagged releases, and so PV/SRCREV in recipe should be set to match a release tag.

You'll have to help me out a little here on exactly what you want.

Quoted 7 lines

This is based off the stable tag.
I already specified the SRCREV in the recipe.

Do you want PV to be:
PV = "stable+git${SRCPV}"

?

I was trying to follow the x264 recipe.

Do you want me do something like name the recipe x265_stable.bb
<http://x265_stable.bb> instead and not specify PV?

Quoted 62 lines
Quoted 61 lines
    Alex

    On Fri, 7 Feb 2020 at 22:35, Scott Branden via Openembedded-core
    <[email protected]
    <mailto:[email protected]>> wrote:

        Add x265 recipe from latest revision of stable branch.

        Signed-off-by: Scott Branden <[email protected]
        <mailto:[email protected]>>
        ---
         meta/recipes-multimedia/x265/x265_git.bb
        <http://x265_git.bb> | 21 +++++++++++++++++++++
         1 file changed, 21 insertions(+)
         create mode 100644 meta/recipes-multimedia/x265/x265_git.bb
        <http://x265_git.bb>

        diff --git a/meta/recipes-multimedia/x265/x265_git.bb
        <http://x265_git.bb>
        b/meta/recipes-multimedia/x265/x265_git.bb <http://x265_git.bb>
        new file mode 100644
        index 0000000000..7c230e2b1e
        --- /dev/null
        +++ b/meta/recipes-multimedia/x265/x265_git.bb
        <http://x265_git.bb>
        @@ -0,0 +1,21 @@
        +SUMMARY = "H.265/HEVC video encoder"
        +DESCRIPTION = "A free software library and application for
        encoding video streams into the H.265/HEVC format."
        +HOMEPAGE = "http://www.videolan.org/developers/x265.html"
        +
        +LICENSE = "GPLv2"
        +LICENSE_FLAGS = "commercial"
        +LIC_FILES_CHKSUM =
        "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"
        +
        +DEPENDS = "nasm-native"
        +DEPENDS = "gnutls zlib libpcre"
        +
        +SRC_URI = "git://github.com/videolan/x265;branch=stable
        <http://github.com/videolan/x265;branch=stable> \
        +          "
        +
        +SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
        +
        +S = "${WORKDIR}/git/source"
        +
        +inherit lib_package pkgconfig cmake
        +
        +AS[unexport] = "1"
        -- 
        2.17.1

        -- 
        _______________________________________________
        Openembedded-core mailing list
        [email protected]
        <mailto:[email protected]>
        http://lists.openembedded.org/mailman/listinfo/openembedded-core
#6 lore raw
In reply to Scott Branden
Quoted 15 lines · Scott Branden via Openembedded-core

Add x265 recipe from latest revision of stable branch.

---
 meta/recipes-multimedia/x265/x265_git.bb | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 meta/recipes-multimedia/x265/x265_git.bb
meta/recipes-multimedia/x265/x265_git.bb new file +0 -0
new file mode 100644
index 0000000000..7c230e2b1e

meta/recipes-multimedia/x265/x265_git.bb line 10

Quoted 10 lines
meta/recipes-multimedia/x265/x265_git.bb new file +10 -0
@@ -0,0 +1,21 @@
+SUMMARY = "H.265/HEVC video encoder"
+DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format."
+HOMEPAGE = "http://www.videolan.org/developers/x265.html"
+
+LICENSE = "GPLv2"
+LICENSE_FLAGS = "commercial"
+LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"
+
+DEPENDS = "nasm-native"
+DEPENDS = "gnutls zlib libpcre"

What's the final value of DEPENDS you are expecting here?

Quoted 18 lines
meta/recipes-multimedia/x265/x265_git.bb new file +10 -1
+SRC_URI = "git://github.com/videolan/x265;branch=stable \
+          "
+
+SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
+
+S = "${WORKDIR}/git/source"
+
+inherit lib_package pkgconfig cmake
+
+AS[unexport] = "1"
--

2.17.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#7 lore raw
Quoted 19 lines · Andre McCurdy
Quoted 17 lines · Scott Branden via Openembedded-core

Add x265 recipe from latest revision of stable branch.

---
  meta/recipes-multimedia/x265/x265_git.bb | 21 +++++++++++++++++++++
  1 file changed, 21 insertions(+)

create mode 100644 meta/recipes-multimedia/x265/x265_git.bb

meta/recipes-multimedia/x265/x265_git.bb new file +3 -0
new file mode 100644
index 0000000000..7c230e2b1e
@@ -0,0 +1,21 @@
+SUMMARY = "H.265/HEVC video encoder"
+DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format."
+HOMEPAGE = "http://www.videolan.org/developers/x265.html"
Quoted 8 lines

meta/recipes-multimedia/x265/x265_git.bb line 10

Quoted 7 lines
meta/recipes-multimedia/x265/x265_git.bb new file +7 -0
+
+LICENSE = "GPLv2"
+LICENSE_FLAGS = "commercial"
+LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091"
+
+DEPENDS = "nasm-native"
+DEPENDS = "gnutls zlib libpcre"

What's the final value of DEPENDS you are expecting here?

Started from the x264 recipe - will remove "nasm-native".  Thanks for noticing this.

Quoted 19 lines
Quoted 19 lines
meta/recipes-multimedia/x265/x265_git.bb new file +10 -1
+SRC_URI = "git://github.com/videolan/x265;branch=stable \
+          "
+
+SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526"
+
+S = "${WORKDIR}/git/source"
+
+inherit lib_package pkgconfig cmake
+
+AS[unexport] = "1"
--

2.17.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core