Skip to contentSkip to conversation

imx8qxp_mek: Fix the console command line string

PATCH New Fabio Estevam 2 participants 4 messages Feb 17, 2020 – Mar 10, 2020 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 imx8qxp_mek: Fix the console command line string

Currently the expansion of the console variable leads to the following kernel command line:

console=ttyLP0,${baudrate} earlycon root=/dev/mmcblk1p2 rootwait rw

, which causes the console to not show characters after the LPUART driver is probed as the 'baudrate' variable is not properly translated.

Fix it by splitting the console variable in two parts: one for the ttyLP0 part and the other one for the baudrate, which matches the way it is done on other i.MX targets.

Tested by successfully booting a mainline kernel on a i.MX8QXP MEK board.

---
Anatolij's patch is needed for booting:
https://lists.denx.de/pipermail/u-boot/2020-February/400417.html

 include/configs/imx8qxp_mek.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
include/configs/imx8qxp_mek.h +3 -3
index 81ac4b52f3..0aaca3325b 100644
@@ -65,7 +65,7 @@
 	"script=boot.scr\0" \
 	"image=Image\0" \
 	"panel=NULL\0" \
-	"console=ttyLP0,${baudrate} earlycon\0" \
+	"console=ttyLP0\0" \
 	"fdt_addr=0x83000000\0"			\
 	"fdt_high=0xffffffffffffffff\0"		\
 	"boot_fdt=try\0" \
@@ -76,7 +76,7 @@
 	"mmcpart=" __stringify(CONFIG_SYS_MMC_IMG_LOAD_PART) "\0" \
 	"mmcroot=" CONFIG_MMCROOT " rootwait rw\0" \
 	"mmcautodetect=yes\0" \
-	"mmcargs=setenv bootargs console=${console} root=${mmcroot}\0 " \
+	"mmcargs=setenv bootargs console=${console},${baudrate} root=${mmcroot}\0 " \
 	"loadbootscript=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
 	"bootscript=echo Running bootscript from mmc ...; " \
 		"source\0" \
@@ -104,7 +104,7 @@
 				"echo wait for boot; " \
 			"fi;" \
 		"fi;\0" \
-	"netargs=setenv bootargs console=${console} " \
+	"netargs=setenv bootargs console=${console},${baudrate} " \
 		"root=/dev/nfs " \
 		"ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \
 	"netboot=echo Booting from net ...; " \
Signature · 1 line
2.17.1
author reviewer
#1 lore raw

PATCH 1/1 imx8qxp_mek: Fix the console command line string

Hi Stefano,

Quoted 13 lines · Fabio Estevam

Currently the expansion of the console variable leads to the following kernel command line:

console=ttyLP0,${baudrate} earlycon root=/dev/mmcblk1p2 rootwait rw

, which causes the console to not show characters after the LPUART driver is probed as the 'baudrate' variable is not properly translated.

Fix it by splitting the console variable in two parts: one for the ttyLP0 part and the other one for the baudrate, which matches the way it is done on other i.MX targets.

Quoted 7 lines

Tested by successfully booting a mainline kernel on a i.MX8QXP MEK board.

---
Anatolij's patch is needed for booting:
https://lists.denx.de/pipermail/u-boot/2020-February/400417.html

Could you please apply this one and Anatolij's patch for the upcoming 2020.04 release?

Also, we have some pending i.MX6 patches converting drivers to DM that would be nice to be applied to 2020.04 as well.

We would like to have all i.MX6 NXP development boards converted to DM on 2020.04.

Thanks

#2 lore raw

PATCH 1/1 imx8qxp_mek: Fix the console command line string

Hi Fabio,

Quoted 24 lines · Fabio Estevam

Hi Stefano,

Quoted 13 lines · Fabio Estevam

Currently the expansion of the console variable leads to the following kernel command line:

console=ttyLP0,${baudrate} earlycon root=/dev/mmcblk1p2 rootwait rw

, which causes the console to not show characters after the LPUART driver is probed as the 'baudrate' variable is not properly translated.

Fix it by splitting the console variable in two parts: one for the ttyLP0 part and the other one for the baudrate, which matches the way it is done on other i.MX targets.

Quoted 7 lines

Tested by successfully booting a mainline kernel on a i.MX8QXP MEK board.

---
Anatolij's patch is needed for booting:
https://lists.denx.de/pipermail/u-boot/2020-February/400417.html

Quoted 9 lines

Could you please apply this one and Anatolij's patch for the upcoming 2020.04 release?

Also, we have some pending i.MX6 patches converting drivers to DM that would be nice to be applied to 2020.04 as well.

We would like to have all i.MX6 NXP development boards converted to DM on 2020.04.

Yes, I will take care of it.

Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH 1/1 imx8qxp_mek: Fix the console command line string

In reply to Fabio Estevam
Quoted 11 lines

Currently the expansion of the console variable leads to
the following kernel command line:
console=ttyLP0,${baudrate} earlycon root=/dev/mmcblk1p2 rootwait rw , which causes the console to not show characters after the LPUART driver is probed as the 'baudrate' variable is not properly translated. Fix it by splitting the console variable in two parts: one for the ttyLP0 part and the other one for the baudrate, which matches the way it is done on other i.MX targets.
Tested by successfully booting a mainline kernel on a i.MX8QXP MEK board.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================