usb: core: Use ACPI_SUCCESS() at appropriate places

PATCH New Andy Shevchenko 1 participant 1 message Feb 18, 2020 USB

lore

Share & tools

lore

Andy Shevchenko

author

2020-02-18 19:17 UTC #0 lore raw

PATCH v2 1/1 usb: core: Use ACPI_SUCCESS() at appropriate places

Use ACPI_SUCCESS() to replace !ACPI_FAILURE(), this avoids additional operation.

Signed-off-by Andy Shevchenko <[email protected]>

---
v2: Fix subject line FAILURE -> SUCCESS

 drivers/usb/core/usb-acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/usb/core/usb-acpi.c +1 -1

index 99d41dc26e08..50b2fc7fcc0e 100644
@@ -187,7 +187,7 @@ usb_acpi_find_companion_for_port(struct usb_port *port_dev)
 
 	handle = adev->handle;
 	status = acpi_get_physical_device_location(handle, &pld);
-	if (!ACPI_FAILURE(status) && pld) {
+	if (ACPI_SUCCESS(status) && pld) {
 		port_dev->location = USB_ACPI_LOCATION_VALID
 			| pld->group_token << 8 | pld->group_position;
 		port_dev->connect_type = usb_acpi_get_connect_type(handle, pld);

Signature · 1 line

2.25.0