Skip to contentSkip to conversation

usb: core: Use ACPI_FAILURE at appropriate places

PATCH Superseded Andy Shevchenko 1 participant 1 message Feb 18, 2020 USB

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: core: Use ACPI_FAILURE at appropriate places

Use ACPI_SUCCESS() to replace !ACPI_FAILURE(), this avoids !! operation.

---
 drivers/usb/core/usb-acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/core/usb-acpi.c +1 -1
index 41b91f4c207d..9b31d658ab14 100644
@@ -188,7 +188,7 @@ usb_acpi_find_companion_for_port(struct usb_port *port_dev)
 
 	handle = adev->handle;
 	status = acpi_get_physical_device_location(handle, &pld);
-	if (!ACPI_FAILURE(status) && pld) {
+	if (ACPI_SUCCESS(status) && pld) {
 		port_dev->location = USB_ACPI_LOCATION_VALID
 			| pld->group_token << 8 | pld->group_position;
 		port_dev->connect_type = usb_acpi_get_connect_type(handle, pld);
Signature · 1 line
2.25.0