dma-buf: free dmabuf->name in dma_buf_release()
Subsystems (2)
PATCH 1/1 dma-buf: free dmabuf->name in dma_buf_release()
dma-buff name can be set via DMA_BUF_SET_NAME ioctl, but once set it never gets freed.
Free it in dma_buf_release().
--- drivers/dma-buf/dma-buf.c | 1 + 1 file changed, 1 insertion(+)
drivers/dma-buf/dma-buf.c +1 -0
@@ -108,6 +108,7 @@ static int dma_buf_release(struct inode *inode, struct file *file)dma_resv_fini (dmabuf->resv);module_put (dmabuf->owner); +kfree (dmabuf->name);kfree (dmabuf);return 0 ; }
Signature · 1 line
2.21.1
Quoted 10 lines · On Tue, 25 Feb 2020 12:44:46 -0800 Cong Wang <[email protected]> wrote:
dma-buff name can be set via
DMA_BUF_SET_NAMEioctl, but once set it never gets freed.Free it in
dma_buf_release()....
drivers/dma-buf/dma-buf.c static int dma_buf_release(struct inode *inode, struct file *file) · line 114
Quoted 7 lines
drivers/dma-buf/dma-buf.c +1
-0@@ -108,6 +108,7 @@ static int dma_buf_release(struct inode *inode, struct file *file)dma_resv_fini (dmabuf->resv);module_put (dmabuf->owner); +kfree (dmabuf->name);kfree (dmabuf);return 0 ; }
ow. Is that ioctl privileged?
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 15 lines · Andrew Morton
Quoted 12 lines · On Tue, 25 Feb 2020 12:44:46 -0800 Cong Wang <[email protected]> wrote:
dma-buff name can be set via
DMA_BUF_SET_NAMEioctl, but once set it never gets freed.Free it in
dma_buf_release()....
drivers/dma-buf/dma-buf.c +0
-0@@ -108,6 +108,7 @@ static int dma_buf_release(struct inode *inode, struct file *file)dma_resv_fini (dmabuf->resv);
Quoted 7 lines
drivers/dma-buf/dma-buf.c static int dma_buf_release(struct inode *inode, struct file *file) · line 114
Quoted 5 lines
drivers/dma-buf/dma-buf.c +1
-0module_put (dmabuf->owner); +kfree (dmabuf->name);kfree (dmabuf);return 0 ; }ow. Is that ioctl privileged?
It looks unprivileged to me, as I don't see capable() called along the path.
Thanks.
Quoted 24 lines · On Thu, 27 Feb 2020 13:38:03 -0800 Cong Wang <[email protected]> wrote:
Quoted 15 lines · Andrew Morton
Quoted 12 lines · On Tue, 25 Feb 2020 12:44:46 -0800 Cong Wang <[email protected]> wrote:
dma-buff name can be set via
DMA_BUF_SET_NAMEioctl, but once set it never gets freed.Free it in
dma_buf_release()....
drivers/dma-buf/dma-buf.c +0
-0@@ -108,6 +108,7 @@ static int dma_buf_release(struct inode *inode, struct file *file)dma_resv_fini (dmabuf->resv);Quoted 7 lines
drivers/dma-buf/dma-buf.c static int dma_buf_release(struct inode *inode, struct file *file) · line 114
Quoted 5 lines
drivers/dma-buf/dma-buf.c +1
-0module_put (dmabuf->owner); +kfree (dmabuf->name);kfree (dmabuf);return 0 ; }ow. Is that ioctl privileged?
Quoted 3 lines
It looks unprivileged to me, as I don't see
capable()called along the path.
OK, thanks. I added cc:stable to my copy.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel