Skip to contentSkip to conversation

dma-buf: free dmabuf->name in dma_buf_release()

PATCH Applied Cong Wang 2 participants 4 messages Feb 25, 2020 – Feb 27, 2020

Subsystems (2)
lore
Share & tools
lore

Cong Wang

author
#0 lore raw

PATCH 1/1 dma-buf: free dmabuf->name in dma_buf_release()

dma-buff name can be set via DMA_BUF_SET_NAME ioctl, but once set it never gets freed.

Free it in dma_buf_release().

Fixes bb2bb9030425 ("dma-buf: add DMA_BUF_SET_NAME ioctls")
Reported-by [email protected]
Cc Sumit Semwal <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Linus Torvalds <[email protected]>
---
 drivers/dma-buf/dma-buf.c | 1 +
 1 file changed, 1 insertion(+)
drivers/dma-buf/dma-buf.c +1 -0
index d4097856c86b..c343c7c10b4c 100644
@@ -108,6 +108,7 @@ static int dma_buf_release(struct inode *inode, struct file *file)
 		dma_resv_fini(dmabuf->resv);
 
 	module_put(dmabuf->owner);
+	kfree(dmabuf->name);
 	kfree(dmabuf);
 	return 0;
 }
Signature · 1 line
2.21.1
#1 lore raw
Quoted 10 lines · On Tue, 25 Feb 2020 12:44:46 -0800 Cong Wang <[email protected]> wrote:

dma-buff name can be set via DMA_BUF_SET_NAME ioctl, but once set it never gets freed.

Free it in dma_buf_release().

...

drivers/dma-buf/dma-buf.c static int dma_buf_release(struct inode *inode, struct file *file) · line 114

Quoted 7 lines
drivers/dma-buf/dma-buf.c +1 -0
@@ -108,6 +108,7 @@ static int dma_buf_release(struct inode *inode, struct file *file)
 		dma_resv_fini(dmabuf->resv);
 
 	module_put(dmabuf->owner);
+	kfree(dmabuf->name);
 	kfree(dmabuf);
 	return 0;
 }

ow. Is that ioctl privileged?
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author
#2 lore raw
Quoted 15 lines · Andrew Morton
Quoted 12 lines · On Tue, 25 Feb 2020 12:44:46 -0800 Cong Wang <[email protected]> wrote:

dma-buff name can be set via DMA_BUF_SET_NAME ioctl, but once set it never gets freed.

Free it in dma_buf_release().

...

drivers/dma-buf/dma-buf.c +0 -0
@@ -108,6 +108,7 @@ static int dma_buf_release(struct inode *inode, struct file *file)
              dma_resv_fini(dmabuf->resv);
 
Quoted 7 lines

drivers/dma-buf/dma-buf.c static int dma_buf_release(struct inode *inode, struct file *file) · line 114

Quoted 5 lines
drivers/dma-buf/dma-buf.c +1 -0
      module_put(dmabuf->owner);
+     kfree(dmabuf->name);
      kfree(dmabuf);
      return 0;
 }

ow. Is that ioctl privileged?

It looks unprivileged to me, as I don't see capable() called along the path.

Thanks.

#3 lore raw
Quoted 24 lines · On Thu, 27 Feb 2020 13:38:03 -0800 Cong Wang <[email protected]> wrote:
Quoted 15 lines · Andrew Morton
Quoted 12 lines · On Tue, 25 Feb 2020 12:44:46 -0800 Cong Wang <[email protected]> wrote:

dma-buff name can be set via DMA_BUF_SET_NAME ioctl, but once set it never gets freed.

Free it in dma_buf_release().

...

drivers/dma-buf/dma-buf.c +0 -0
@@ -108,6 +108,7 @@ static int dma_buf_release(struct inode *inode, struct file *file)
              dma_resv_fini(dmabuf->resv);
 
Quoted 7 lines

drivers/dma-buf/dma-buf.c static int dma_buf_release(struct inode *inode, struct file *file) · line 114

Quoted 5 lines
drivers/dma-buf/dma-buf.c +1 -0
      module_put(dmabuf->owner);
+     kfree(dmabuf->name);
      kfree(dmabuf);
      return 0;
 }

ow. Is that ioctl privileged?

Quoted 3 lines

It looks unprivileged to me, as I don't see capable() called along the path.

OK, thanks. I added cc:stable to my copy.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel