kunit: create a centralized executor to dispatch all KUnit tests
Subsystems (5)
v3 cover kunit: create a centralized executor to dispatch all KUnit tests
## TL;DR
This patchset adds a centralized executor to dispatch tests rather than relying on late_initcall to schedule each test suite separately along with a couple of new features that depend on it.
Also, sorry for the delay in getting this new revision out. I have been really busy for the past couple weeks.
## What am I trying to do?
Conceptually, I am trying to provide a mechanism by which test suites can be grouped together so that they can be reasoned about collectively. The last two of three patches in this series add features which depend on this:
PATCH 5/7 Prints out a test plan[1] right before KUnit tests are run;
this is valuable because it makes it possible for a test harness to detect whether the number of tests run matches the number of tests expected to be run, ensuring that no tests silently failed. The test plan includes a count of tests that will run. With the centralized executor, the tests are located in a single data structure and thus can be counted.
PATCH 6/7 Add a new kernel command-line option which allows the user to
specify that the kernel poweroff, halt, or reboot after completing all KUnit tests; this is very handy for running KUnit tests on UML or a VM so that the UML/VM process exits cleanly immediately after running all tests without needing a special initramfs. The centralized executor provides a definitive point when all tests have completed and the poweroff, halt, or reboot could occur.
In addition, by dispatching tests from a single location, we can guarantee that all KUnit tests run after late_init is complete, which was a concern during the initial KUnit patchset review (this has not been a problem in practice, but resolving with certainty is nevertheless desirable).
Other use cases for this exist, but the above features should provide an idea of the value that this could provide.
## Changes since last revision:
- On patch 7/7, I added some additional wording around the kunit_shutdown command line option explaining that it runs after built-in tests as suggested by Frank.
- On the coverletter, I improved some wording and added a missing link. I also specified the base-commit for the series.
- Frank asked for some changes to the documentation; however, David is taking care of that in a separate patch[2], so I did not make those changes here. There will be some additional changes necessary after David's patch is applied.
Alan Maguire (1):
kunit: test: create a single centralized executor for all tests
Brendan Higgins (5):
vmlinux.lds.h: add linker section for KUnit test suites
arch: um: add linker section for KUnit test suites
init: main: add KUnit to kernel init
kunit: test: add test plan to KUnit TAP format
Documentation: Add kunit_shutdown to kernel-parameters.txt
David Gow (1):
kunit: Add 'kunit_shutdown' option
.../admin-guide/kernel-parameters.txt | 8 ++ arch/um/include/asm/common.lds.S | 4 + include/asm-generic/vmlinux.lds.h | 8 ++ include/kunit/test.h | 82 ++++++++++++------- init/main.c | 4 + lib/kunit/Makefile | 3 +- lib/kunit/executor.c | 71 ++++++++++++++++ lib/kunit/test.c | 11 --- tools/testing/kunit/kunit_kernel.py | 2 +- tools/testing/kunit/kunit_parser.py | 76 ++++++++++++++--- .../test_is_test_passed-all_passed.log | 1 + .../test_data/test_is_test_passed-crash.log | 1 + .../test_data/test_is_test_passed-failure.log | 1 + 13 files changed, 218 insertions(+), 54 deletions(-) create mode 100644 lib/kunit/executor.c
base-commit: a2f0b878c3ca531a1706cb2a8b079cea3b17bafc
[1] https://github.com/isaacs/testanything.github.io/blob/tap14/tap-version-14-specification.md#the-plan
[2] https://patchwork.kernel.org/patch/11383635/
Signature · 1 line
2.25.1.481.gfbce0eb801-goog
PATCH v3 1/7 vmlinux.lds.h: add linker section for KUnit test suites
Add a linker section where KUnit can put references to its test suites. This patch is the first step in transitioning to dispatching all KUnit tests from a centralized executor rather than having each as its own separate late_initcall.
--- include/asm-generic/vmlinux.lds.h | 8 ++++++++ 1 file changed, 8 insertions(+)
include/asm-generic/vmlinux.lds.h +8 -0
@@ -856,6 +856,13 @@ KEEP(*(.con_initcall.init)) \ __con_initcall_end = .; +/* Alignment must be consistent with (kunit_suite *) in include/kunit/test.h */ +#define KUNIT_TEST_SUITES \ + . = ALIGN(8); \ + __kunit_suites_start = .; \ + KEEP(*(.kunit_test_suites)) \ + __kunit_suites_end = .; +#ifdef CONFIG_BLK_DEV_INITRD #define INIT_RAM_FS \ . = ALIGN(4); \
@@ -1024,6 +1031,7 @@INIT_CALLS \ CON_INITCALL \INIT_RAM_FS \ + KUNIT_TEST_SUITES \ }#define BSS_SECTION (sbss_align, bss_align, stop_align) \
Signature · 1 line
2.25.1.481.gfbce0eb801-goog
Re: [PATCH v3 1/7] vmlinux.lds.h: add linker section for KUnit test suites
Quoted 19 lines · Brendan Higgins
Add a linker section where KUnit can put references to its test suites. This patch is the first step in transitioning to dispatching all KUnit tests from a centralized executor rather than having each as its own separate
late_initcall.Co-developed-by Iurii Zaikin <[email protected]>Signed-off-by Iurii Zaikin <[email protected]>Signed-off-by Brendan Higgins <[email protected]>Reviewed-by Stephen Boyd <[email protected]>--- include/asm-generic/vmlinux.lds.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/asm-generic/vmlinux.lds.h +0
-0
include/asm-generic/vmlinux.lds.h line 861
Quoted 6 lines
include/asm-generic/vmlinux.lds.h +3
-0@@ -856,6 +856,13 @@ KEEP(*(.con_initcall.init)) \ __con_initcall_end = .; +/* Alignment must be consistent with (kunit_suite *) in include/kunit/test.h */ +#define KUNIT_TEST_SUITES \ + . = ALIGN(8); \
After posting this, I saw I had gotten an email from 0day[1]. After some investigation, I discovered that this 8 byte alignment works for x86 64 bit fine, but only *sometimes* for 32 bit. 4 byte alignment seems to work in all cases (so far). I am not sure why we went with such a large alignment in hindsight. In any case, I should have a fixed revision out pretty soon.
Quoted 8 lines
include/asm-generic/vmlinux.lds.h +4
-0+ __kunit_suites_start = .; \ + KEEP(*(.kunit_test_suites)) \ + __kunit_suites_end = .; +#ifdef CONFIG_BLK_DEV_INITRD #define INIT_RAM_FS \ . = ALIGN(4); \
include/asm-generic/vmlinux.lds.h
Quoted 8 lines
include/asm-generic/vmlinux.lds.h +1
-1@@ -1024,6 +1031,7 @@INIT_CALLS \ CON_INITCALL \INIT_RAM_FS \ + KUNIT_TEST_SUITES \ }#define BSS_SECTION (sbss_align, bss_align, stop_align) \ --
[1] https://lists.01.org/hyperkitty/list/[email protected]/thread/4I4UW4OAT63ETMIEUJQTOF3BFTMO6ROD/
Re: [PATCH v3 1/7] vmlinux.lds.h: add linker section for KUnit test suites
We went with this alignment precisely because it's the largest that any supported arch may possibly need. The problem as I understood it was that the compiler, seeing a bunch of pointers decided to put them at the memory-access efficient alignment rather than at the section start. Remember that the section start used to be unaligned for some reason. Note that the alignment that is a multiple of smaller alignment is still aligned wrt the smaller alignment, so the compiler shouldn't need to put the pointers elsewhere.
I wonder if there's a more robust way of forcing the compiler to put the pointers right at the section start and insert no gaps between them than playing with alignment.
Quoted 54 lines · Brendan Higgins
Quoted 19 lines · Brendan Higgins
Add a linker section where KUnit can put references to its test suites. This patch is the first step in transitioning to dispatching all KUnit tests from a centralized executor rather than having each as its own separate
late_initcall.Co-developed-by Iurii Zaikin <[email protected]>Signed-off-by Iurii Zaikin <[email protected]>Signed-off-by Brendan Higgins <[email protected]>Reviewed-by Stephen Boyd <[email protected]>--- include/asm-generic/vmlinux.lds.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/asm-generic/vmlinux.lds.h +0
-0include/asm-generic/vmlinux.lds.h line 861
Quoted 6 lines
include/asm-generic/vmlinux.lds.h +3
-0@@ -856,6 +856,13 @@ KEEP(*(.con_initcall.init)) \ __con_initcall_end = .; +/* Alignment must be consistent with (kunit_suite *) in include/kunit/test.h */ +#define KUNIT_TEST_SUITES \ + . = ALIGN(8); \After posting this, I saw I had gotten an email from 0day[1]. After some investigation, I discovered that this 8 byte alignment works for x86 64 bit fine, but only *sometimes* for 32 bit. 4 byte alignment seems to work in all cases (so far). I am not sure why we went with such a large alignment in hindsight. In any case, I should have a fixed revision out pretty soon.
Quoted 8 lines
include/asm-generic/vmlinux.lds.h +4
-0+ __kunit_suites_start = .; \ + KEEP(*(.kunit_test_suites)) \ + __kunit_suites_end = .; +#ifdef CONFIG_BLK_DEV_INITRD #define INIT_RAM_FS \ . = ALIGN(4); \include/asm-generic/vmlinux.lds.h
Quoted 8 lines
include/asm-generic/vmlinux.lds.h +1
-1@@ -1024,6 +1031,7 @@INIT_CALLS \ CON_INITCALL \INIT_RAM_FS \ + KUNIT_TEST_SUITES \ }#define BSS_SECTION (sbss_align, bss_align, stop_align) \ --[1] https://lists.01.org/hyperkitty/list/[email protected]/thread/4I4UW4OAT63ETMIEUJQTOF3BFTMO6ROD/
PATCH v3 2/7 arch: um: add linker section for KUnit test suites
In reply to Brendan HigginsAdd a linker section to UML where KUnit can put references to its test suites. This patch is an early step in transitioning to dispatching all KUnit tests from a centralized executor rather than having each as its own separate late_initcall.
--- arch/um/include/asm/common.lds.S | 4 ++++ 1 file changed, 4 insertions(+)
arch/um/include/asm/common.lds.S +4 -0
@@ -52,6 +52,10 @@ CON_INITCALL } + .kunit_test_suites : { + KUNIT_TEST_SUITES + } + .exitcall : { __exitcall_begin = .; *(.exitcall.exit)
Signature · 1 line
2.25.1.481.gfbce0eb801-goog
PATCH v3 3/7 kunit: test: create a single centralized executor for all tests
In reply to Brendan HigginsFrom: Alan Maguire <[email protected]>
Add a centralized executor to dispatch tests rather than relying on late_initcall to schedule each test suite separately. Centralized execution is for built-in tests only; modules will execute tests when loaded.
--- include/kunit/test.h | 73 +++++++++++++++++++++++++++----------------- lib/kunit/Makefile | 3 +- lib/kunit/executor.c | 36 ++++++++++++++++++++++ 3 files changed, 83 insertions(+), 29 deletions(-) create mode 100644 lib/kunit/executor.c
include/kunit/test.h +45 -28
@@ -197,46 +197,63 @@ void kunit_init_test(struct kunit *test, const char *name);int kunit_run_tests (struct kunit_suite *suite); -/** -* kunit_test_suites() - used to register one or more &struct kunit_suite -* with KUnit. -* -* @suites: a statically allocated list of &struct kunit_suite. -* -* Registers @suites with the test framework. See &struct kunit_suite for -* more information. -* -* When builtin, KUnit tests are all run as late_initcalls; this means -* that they cannot test anything where tests must run at a different init -* phase. One significant restriction resulting from this is that KUnit -* cannot reliably test anything that is initialize in the late_init phase; -* another is that KUnit is useless to test things that need to be run in -* an earlier init phase. -* -* An alternative is to build the tests as a module. Because modules -* do not support multiple late_initcall()s, we need to initialize an -* array of suites for a module. -* -* TODO([email protected]): Don't run all KUnit tests as -* late_initcalls. I have some future work planned to dispatch all KUnit -* tests from the same place, and at the very least to do so after -* everything else is definitely initialized. +/* +* If a test suite is built-in, module_init() gets translated into +* an initcall which we don't want as the idea is that for builtins +* the executor will manage execution. So ensure we do not define +* module_{init|exit} functions for the builtin case when registering +* suites via kunit_test_suites() below. */ -#define kunit_test_suites (...) \ - static struct kunit_suite *suites[] = { __VA_ARGS__, NULL}; \ - static int kunit_test_suites_init(void) \ +#ifdef MODULE +#define kunit_test_suites_for_module (__suites) \ + static int __init kunit_test_suites_init(void) \ { \ + struct kunit_suite *suites[] = (__suites); \ unsigned int i; \ + \ for (i = 0; suites[i] != NULL; i++) \ kunit_run_tests(suites[i]); \ return 0; \ } \ - late_initcall(kunit_test_suites_init); \ + module_init(kunit_test_suites_init); \ + \ static void __exit kunit_test_suites_exit(void) \ { \ return; \ } \ module_exit(kunit_test_suites_exit) +#else +#define kunit_test_suites_for_module (__suites) +#endif /* MODULE */ + +#define __kunit_test_suites (unique_array, unique_suites, ...) \ + static struct kunit_suite *unique_array[] = { __VA_ARGS__, NULL }; \ + kunit_test_suites_for_module(unique_array); \ + static struct kunit_suite **unique_suites \ + __used __aligned(8) __section(.kunit_test_suites) = unique_array + +/** +* kunit_test_suites() - used to register one or more &struct kunit_suite +* with KUnit. +* +* @suites: a statically allocated list of &struct kunit_suite. +* +* Registers @suites with the test framework. See &struct kunit_suite for +* more information. +* +* When builtin, KUnit tests are all run via executor; this is done +* by placing the array of struct kunit_suite * in the .kunit_test_suites +* ELF section. +* +* An alternative is to build the tests as a module. Because modules do not +* support multiple initcall()s, we need to initialize an array of suites for a +* module. +* +*/ +#define kunit_test_suites (...) \ + __kunit_test_suites(__UNIQUE_ID(array), \ + __UNIQUE_ID(suites), \ + __VA_ARGS__)#define kunit_test_suite (suite) kunit_test_suites(&suite)
lib/kunit/Makefile +2 -1
@@ -3,7 +3,8 @@ obj-$(CONFIG_KUNIT) += kunit.o kunit-objs += test.o \ string-stream.o \ assert.o \ - try-catch.o + try-catch.o \ + executor.o obj-$(CONFIG_KUNIT_TEST) += kunit-test.o
lib/kunit/executor.c new file +36 -0
@@ -0,0 +1,36 @@ +// SPDX-License-Identifier: GPL-2.0 + +#include <kunit/test.h> + +/* +* These symbols point to the .kunit_test_suites section and are defined in +* include/asm-generic/vmlinux.lds.h, and consequently must be extern. +*/ +extern struct kunit_suite *const *const __kunit_suites_start[]; +extern struct kunit_suite *const *const __kunit_suites_end[]; + +#if IS_BUILTIN (CONFIG_KUNIT ) + +static int kunit_run_all_tests (void ) +{ +struct kunit_suite *const *const *suites, *const *subsuite; +bool has_test_failed = false; + +for (suites = __kunit_suites_start; + suites < __kunit_suites_end; + suites++) { +for (subsuite = *suites; *subsuite !=NULL ; subsuite++) { +if (kunit_run_tests (*subsuite)) + has_test_failed = true; + } + } + +if (has_test_failed) +return -EFAULT ; + +return 0 ; +} + +late_initcall (kunit_run_all_tests); + +#endif /* IS_BUILTIN(CONFIG_KUNIT) */
Signature · 1 line
2.25.1.481.gfbce0eb801-goog
kbuild test robot
build botRe: [PATCH v3 3/7] kunit: test: create a single centralized executor for all tests
Thank you for the patch! Perhaps something to improve:
Hi Brendan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on a2f0b878c3ca531a1706cb2a8b079cea3b17bafc]
url: https://github.com/0day-ci/linux/commits/Brendan-Higgins/kunit-create-a-centralized-executor-to-dispatch-all-KUnit-tests/20200229-043150 base: a2f0b878c3ca531a1706cb2a8b079cea3b17bafc config: microblaze-randconfig-a001-20200229 (attached as .config) compiler: microblaze-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=microblaze
If you fix the issue, kindly add following tag
All warnings (new ones prefixed by >>):
In file included from lib/kunit/kunit-test.c:8:0:
lib/kunit/kunit-test.c: In function 'kunit_test_suites_init':
include/kunit/test.h:211:34: error: invalid initializer
struct kunit_suite *suites[] = (__suites); \
^
include/kunit/test.h:231:2: note: in expansion of macro 'kunit_test_suites_for_module'
kunit_test_suites_for_module(unique_array); \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/kunit/test.h:254:2: note: in expansion of macro '__kunit_test_suites'
__kunit_test_suites(__UNIQUE_ID(array), \
^~~~~~~~~~~~~~~~~~~
>> lib/kunit/kunit-test.c:332:1: note: in expansion of macro 'kunit_test_suites'
kunit_test_suites(&kunit_try_catch_test_suite, &kunit_resource_test_suite);
^~~~~~~~~~~~~~~~~vim +/kunit_test_suites +332 lib/kunit/kunit-test.c
73ba5aaf93b41e lib/kunit/test-test.c Avinash Kondareddy 2019-09-23 325
73ba5aaf93b41e lib/kunit/test-test.c Avinash Kondareddy 2019-09-23 326 static struct kunit_suite kunit_resource_test_suite = {
73ba5aaf93b41e lib/kunit/test-test.c Avinash Kondareddy 2019-09-23 327 .name = "kunit-resource-test",
73ba5aaf93b41e lib/kunit/test-test.c Avinash Kondareddy 2019-09-23 328 .init = kunit_resource_test_init,
73ba5aaf93b41e lib/kunit/test-test.c Avinash Kondareddy 2019-09-23 329 .exit = kunit_resource_test_exit,
73ba5aaf93b41e lib/kunit/test-test.c Avinash Kondareddy 2019-09-23 330 .test_cases = kunit_resource_test_cases,
73ba5aaf93b41e lib/kunit/test-test.c Avinash Kondareddy 2019-09-23 331 };c475c77d5b5639 lib/kunit/kunit-test.c Alan Maguire 2020-01-06 @332 kunit_test_suites(&kunit_try_catch_test_suite, &kunit_resource_test_suite);c475c77d5b5639 lib/kunit/kunit-test.c Alan Maguire 2020-01-06 333
:::::: The code at line 332 was first introduced by commit
:::::: c475c77d5b56398303e726969e81208196b3aab3 kunit: allow kunit tests to be loaded as a module
:::::: TO: Alan Maguire <[email protected]>
:::::: CC: Shuah Khan <[email protected]>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
kbuild test robot
build botRe: [PATCH v3 3/7] kunit: test: create a single centralized executor for all tests
In reply to Brendan HigginsThank you for the patch! Perhaps something to improve:
Hi Brendan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on a2f0b878c3ca531a1706cb2a8b079cea3b17bafc]
url: https://github.com/0day-ci/linux/commits/Brendan-Higgins/kunit-create-a-centralized-executor-to-dispatch-all-KUnit-tests/20200229-043150 base: a2f0b878c3ca531a1706cb2a8b079cea3b17bafc config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag
All warnings (new ones prefixed by >>):
In file included from fs/ext4/inode-test.c:7:0:
fs/ext4/inode-test.c: In function 'kunit_test_suites_init':
include/kunit/test.h:211:34: error: invalid initializer
struct kunit_suite *suites[] = (__suites); \
^
include/kunit/test.h:231:2: note: in expansion of macro 'kunit_test_suites_for_module'
kunit_test_suites_for_module(unique_array); \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/kunit/test.h:254:2: note: in expansion of macro '__kunit_test_suites'
__kunit_test_suites(__UNIQUE_ID(array), \
^~~~~~~~~~~~~~~~~~~
>> fs/ext4/inode-test.c:272:1: note: in expansion of macro 'kunit_test_suites'
kunit_test_suites(&ext4_inode_test_suite);
^~~~~~~~~~~~~~~~~vim +/kunit_test_suites +272 fs/ext4/inode-test.c
1cbeab1b242d16 Iurii Zaikin 2019-10-17 271c475c77d5b5639 Alan Maguire 2020-01-06 @272 kunit_test_suites(&ext4_inode_test_suite); c475c77d5b5639 Alan Maguire 2020-01-06 273
:::::: The code at line 272 was first introduced by commit
:::::: c475c77d5b56398303e726969e81208196b3aab3 kunit: allow kunit tests to be loaded as a module
:::::: TO: Alan Maguire <[email protected]>
:::::: CC: Shuah Khan <[email protected]>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
kbuild test robot
build botRe: [PATCH v3 3/7] kunit: test: create a single centralized executor for all tests
In reply to Brendan HigginsThank you for the patch! Perhaps something to improve:
Hi Brendan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on a2f0b878c3ca531a1706cb2a8b079cea3b17bafc]
url: https://github.com/0day-ci/linux/commits/Brendan-Higgins/kunit-create-a-centralized-executor-to-dispatch-all-KUnit-tests/20200229-043150 base: a2f0b878c3ca531a1706cb2a8b079cea3b17bafc reproduce: # apt-get install sparse # sparse version: v0.6.1-173-ge0787745-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
sparse warnings: (new ones prefixed by >>)
>> fs/ext4/inode-test.c:272:1: sparse: sparse: invalid initializer
vim +272 fs/ext4/inode-test.c
1cbeab1b242d16 Iurii Zaikin 2019-10-17 271c475c77d5b5639 Alan Maguire 2020-01-06 @272 kunit_test_suites(&ext4_inode_test_suite); c475c77d5b5639 Alan Maguire 2020-01-06 273
:::::: The code at line 272 was first introduced by commit
:::::: c475c77d5b56398303e726969e81208196b3aab3 kunit: allow kunit tests to be loaded as a module
:::::: TO: Alan Maguire <[email protected]>
:::::: CC: Shuah Khan <[email protected]>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
PATCH v3 4/7 init: main: add KUnit to kernel init
In reply to Brendan HigginsRemove KUnit from init calls entirely, instead call directly from kernel_init().
--- include/kunit/test.h | 9 +++++++++ init/main.c | 4 ++++ lib/kunit/executor.c | 4 +--- 3 files changed, 14 insertions(+), 3 deletions(-)
include/kunit/test.h +9 -0
@@ -197,6 +197,15 @@ void kunit_init_test(struct kunit *test, const char *name);int kunit_run_tests (struct kunit_suite *suite); +#if IS_BUILTIN (CONFIG_KUNIT ) +int kunit_run_all_tests (void ); +#else +static inline int kunit_run_all_tests (void ) +{ +return 0 ; +} +#endif /* IS_BUILTIN(CONFIG_KUNIT) */ +/* * If a test suite is built-in, module_init() gets translated into * an initcall which we don't want as the idea is that for builtins
init/main.c +4 -0
@@ -104,6 +104,8 @@#define CREATE_TRACE_POINTS #include <trace/events/initcall.h> +#include <kunit/test.h> +static int kernel_init (void *);extern void init_IRQ (void );
@@ -1444,6 +1446,8 @@ static noinline void __init kernel_init_freeable(void)do_basic_setup (); +kunit_run_all_tests (); +console_on_rootfs ();/*
lib/kunit/executor.c +1 -3
@@ -11,7 +11,7 @@ extern struct kunit_suite * const * const __kunit_suites_end[];#if IS_BUILTIN (CONFIG_KUNIT ) -static int kunit_run_all_tests (void ) +int kunit_run_all_tests (void ) {struct kunit_suite *const *const *suites, *const *subsuite;bool has_test_failed = false;
@@ -31,6 +31,4 @@ static int kunit_run_all_tests(void) return 0; } -late_initcall (kunit_run_all_tests); -#endif /* IS_BUILTIN(CONFIG_KUNIT) */
Signature · 1 line
2.25.1.481.gfbce0eb801-goog
Re: [PATCH v3 4/7] init: main: add KUnit to kernel init
Quoted 18 lines · Brendan Higgins
Remove KUnit from init calls entirely, instead call directly from
kernel_init().Co-developed-by Alan Maguire <[email protected]>Signed-off-by Alan Maguire <[email protected]>Signed-off-by Brendan Higgins <[email protected]>Reviewed-by Stephen Boyd <[email protected]>--- include/kunit/test.h | 9 +++++++++ init/main.c | 4 ++++ lib/kunit/executor.c | 4 +--- 3 files changed, 14 insertions(+), 3 deletions(-)include/kunit/test.h +0
-0
include/kunit/test.h void kunit_init_test(struct kunit *test, const char *name); · line 200
Quoted 4 lines
include/kunit/test.h +1
-0@@ -197,6 +197,15 @@ void kunit_init_test(struct kunit *test, const char *name);int kunit_run_tests (struct kunit_suite *suite); +#if IS_BUILTIN (CONFIG_KUNIT )
I suspected this would not work if a unittest was builtin but CONFIG_KUNIT was set to module.
So I decided to experiment a bit to verify my assumptions (before applying this patch series). I tried to set CONFIG_KUNIT to module, then set CONFIG_KUNIT_EXAMPLE_TEST to built in. Kconfig does not let me do this because KUNIT_EXAMPLE_TEST is inside a 'if KUNIT' in lib/kunit/Kconfig, but instead switches KUNIT_EXAMPLE_TEST to a module, and warns that it has done so. This was a bit of a surprise, but seems reasonable.
So my next assumption is that the architecture of KUnit expects each individual unit test config option to depend upon CONFIG_KUNIT. If this is the case, please clearly document that requirement in the KUnit documentation.
Quoted 54 lines
include/kunit/test.h +8
-0+int kunit_run_all_tests (void ); +#else +static inline int kunit_run_all_tests (void ) +{ +return 0 ; +} +#endif /* IS_BUILTIN(CONFIG_KUNIT) */ +/* * If a test suite is built-in, module_init() gets translated into * an initcall which we don't want as the idea is that for builtins init/main.c +4
-0@@ -104,6 +104,8 @@#define CREATE_TRACE_POINTS #include <trace/events/initcall.h> +#include <kunit/test.h> +static int kernel_init (void *);extern void init_IRQ (void );@@ -1444,6 +1446,8 @@ static noinline void __init kernel_init_freeable(void)do_basic_setup (); +kunit_run_all_tests (); +console_on_rootfs ();/* lib/kunit/executor.c +1
-3@@ -11,7 +11,7 @@ extern struct kunit_suite * const * const __kunit_suites_end[];#if IS_BUILTIN (CONFIG_KUNIT ) -static int kunit_run_all_tests (void ) +int kunit_run_all_tests (void ) {struct kunit_suite *const *const *suites, *const *subsuite;bool has_test_failed = false;@@ -31,6 +31,4 @@ static int kunit_run_all_tests(void) return 0; } -late_initcall (kunit_run_all_tests); -#endif /* IS_BUILTIN(CONFIG_KUNIT) */
Re: [PATCH v3 4/7] init: main: add KUnit to kernel init
On Mon, Mar 2, 2020 at 11:13 AM Frank Rowand <[email protected]> wrote:
Sorry it took so long to respond. I am reviving this patchset now, about to send out a new revision and I just saw this comment.
Quoted 34 lines · Brendan Higgins
Quoted 18 lines
Remove KUnit from init calls entirely, instead call directly from
kernel_init().Co-developed-by Alan Maguire <[email protected]>Signed-off-by Alan Maguire <[email protected]>Signed-off-by Brendan Higgins <[email protected]>Reviewed-by Stephen Boyd <[email protected]>--- include/kunit/test.h | 9 +++++++++ init/main.c | 4 ++++ lib/kunit/executor.c | 4 +--- 3 files changed, 14 insertions(+), 3 deletions(-)include/kunit/test.h +0
-0include/kunit/test.h void kunit_init_test(struct kunit *test, const char *name); · line 200
Quoted 4 lines
include/kunit/test.h +1
-0@@ -197,6 +197,15 @@ void kunit_init_test(struct kunit *test, const char *name);int kunit_run_tests (struct kunit_suite *suite); +#if IS_BUILTIN (CONFIG_KUNIT )I suspected this would not work if a unittest was builtin but
CONFIG_KUNITwas set to module.So I decided to experiment a bit to verify my assumptions (before applying this patch series). I tried to set
CONFIG_KUNITto module, then setCONFIG_KUNIT_EXAMPLE_TESTto built in.Kconfigdoes not let me do this becauseKUNIT_EXAMPLE_TESTis inside a 'if KUNIT' inlib/kunit/Kconfig, but instead switchesKUNIT_EXAMPLE_TESTto a module, and warns that it has done so. This was a bit of a surprise, but seems reasonable.
Quoted 4 lines
So my next assumption is that the architecture of KUnit expects each individual unit test config option to depend upon
CONFIG_KUNIT. If this is the case, please clearly document that requirement in the KUnit documentation.
Your assumption is correct. I will fix this in the Kconfig documentation in a separate patch.
Quoted 55 lines
Quoted 54 lines
include/kunit/test.h +8
-0+int kunit_run_all_tests (void ); +#else +static inline int kunit_run_all_tests (void ) +{ +return 0 ; +} +#endif /* IS_BUILTIN(CONFIG_KUNIT) */ +/* * If a test suite is built-in, module_init() gets translated into * an initcall which we don't want as the idea is that for builtins init/main.c +4
-0@@ -104,6 +104,8 @@#define CREATE_TRACE_POINTS #include <trace/events/initcall.h> +#include <kunit/test.h> +static int kernel_init (void *);extern void init_IRQ (void );@@ -1444,6 +1446,8 @@ static noinline void __init kernel_init_freeable(void)do_basic_setup (); +kunit_run_all_tests (); +console_on_rootfs ();/* lib/kunit/executor.c +1
-3@@ -11,7 +11,7 @@ extern struct kunit_suite * const * const __kunit_suites_end[];#if IS_BUILTIN (CONFIG_KUNIT ) -static int kunit_run_all_tests (void ) +int kunit_run_all_tests (void ) {struct kunit_suite *const *const *suites, *const *subsuite;bool has_test_failed = false;@@ -31,6 +31,4 @@ static int kunit_run_all_tests(void) return 0; } -late_initcall (kunit_run_all_tests); -#endif /* IS_BUILTIN(CONFIG_KUNIT) */
Re: [PATCH v3 4/7] init: main: add KUnit to kernel init
In reply to Brendan HigginsQuoted 22 lines · Brendan Higgins
Remove KUnit from init calls entirely, instead call directly from
kernel_init().Co-developed-by Alan Maguire <[email protected]>Signed-off-by Alan Maguire <[email protected]>Signed-off-by Brendan Higgins <[email protected]>Reviewed-by Stephen Boyd <[email protected]>[...]init/main.c +2
-0@@ -104,6 +104,8 @@#define CREATE_TRACE_POINTS #include <trace/events/initcall.h> +#include <kunit/test.h> +static int kernel_init (void *);extern void init_IRQ (void );
init/main.c static noinline void __init kernel_init_freeable(void) · line 1453
Quoted 8 lines
init/main.c +2
-0@@ -1444,6 +1446,8 @@ static noinline void __init kernel_init_freeable(void)do_basic_setup (); +kunit_run_all_tests (); +console_on_rootfs ();/*
I'm nervous about this happening before two key pieces of the kernel setup, which might lead to weird timing-sensitive bugs or false positives:
async_synchronize_full()
mark_readonly()
Now, I realize kunit tests _should_ be self-contained, but this seems like a possible robustness problem. Is there any reason this can't be moved after rcu_end_inkernel_boot() in kernel_init() instead?
Signature · 1 line
Kees Cook
Re: [PATCH v3 4/7] init: main: add KUnit to kernel init
On Mon, Mar 2, 2020 at 2:45 PM Kees Cook <[email protected]> wrote:
Sorry it took so long to respond. I am reviving this patchset now, about to send out a new revision and I just saw this comment.
Quoted 38 lines · Brendan Higgins
Quoted 22 lines
Remove KUnit from init calls entirely, instead call directly from
kernel_init().Co-developed-by Alan Maguire <[email protected]>Signed-off-by Alan Maguire <[email protected]>Signed-off-by Brendan Higgins <[email protected]>Reviewed-by Stephen Boyd <[email protected]>[...]init/main.c +2
-0@@ -104,6 +104,8 @@#define CREATE_TRACE_POINTS #include <trace/events/initcall.h> +#include <kunit/test.h> +static int kernel_init (void *);extern void init_IRQ (void );init/main.c static noinline void __init kernel_init_freeable(void) · line 1453
Quoted 8 lines
init/main.c +2
-0@@ -1444,6 +1446,8 @@ static noinline void __init kernel_init_freeable(void)do_basic_setup (); +kunit_run_all_tests (); +console_on_rootfs ();/* I'm nervous about this happening before two key pieces of the kernel setup, which might lead to weird timing-sensitive bugs or false positives:
async_synchronize_full()
mark_readonly()
Quoted 3 lines
Now, I realize kunit tests _should_ be self-contained, but this seems like a possible robustness problem. Is there any reason this can't be moved after
rcu_end_inkernel_boot()inkernel_init()instead?
I tried that, but it doesn't work without an initramfs. We could add an initramfs for KUnit at some point if highly desired, but I think that is outside the scope of this patchset. Additionally, this patch actually moves running tests to later in the init process, which is still an improvement over the way KUnit works today.
There are some other reasons I wouldn't want to make that change right now, which will become apparent in a patch that I will send out in short order.
Cheers
Re: [PATCH v3 4/7] init: main: add KUnit to kernel init
Quoted 6 lines · Brendan Higgins
Quoted 3 lines · Kees Cook
Now, I realize kunit tests _should_ be self-contained, but this seems like a possible robustness problem. Is there any reason this can't be moved after
rcu_end_inkernel_boot()inkernel_init()instead?I tried that, but it doesn't work without an initramfs. We could add
I'm curious to know what happened. To me it looks like it would be possible to do it in here:
system_state = SYSTEM_RUNNING;
numa_default_policy();
rcu_end_inkernel_boot();
do_sysctl_args();
put it here?
if (ramdisk_execute_command) {
ret = run_init_process(ramdisk_execute_command);That should be before anything happens with an initramfs. (i.e. boot the kernel without an initrd and it won't be required...)
Quoted 4 lines
an initramfs for KUnit at some point if highly desired, but I think that is outside the scope of this patchset. Additionally, this patch actually moves running tests to later in the init process, which is still an improvement over the way KUnit works today.
Later is better! :)
Quoted 3 lines
There are some other reasons I wouldn't want to make that change right now, which will become apparent in a patch that I will send out in short order.
Cool; I'll look for it.
Signature · 1 line
Kees Cook
PATCH v3 5/7 kunit: test: add test plan to KUnit TAP format
In reply to Brendan HigginsTAP 14 allows an optional test plan to be emitted before the start of the start of testing[1]; this is valuable because it makes it possible for a test harness to detect whether the number of tests run matches the number of tests expected to be run, ensuring that no tests silently failed.
Link[1]: https://github.com/isaacs/testanything.github.io/blob/tap14/tap-version-14-specification.md#the-plan
--- lib/kunit/executor.c | 17 +++++ lib/kunit/test.c | 11 --- tools/testing/kunit/kunit_parser.py | 74 ++++++++++++++++--- .../test_is_test_passed-all_passed.log | 1 + .../test_data/test_is_test_passed-crash.log | 1 + .../test_data/test_is_test_passed-failure.log | 1 + 6 files changed, 82 insertions(+), 23 deletions(-)
lib/kunit/executor.c +17 -0
@@ -11,11 +11,28 @@ extern struct kunit_suite * const * const __kunit_suites_end[];#if IS_BUILTIN (CONFIG_KUNIT ) +static void kunit_print_tap_header (void ) +{ +struct kunit_suite *const *const *suites, *const *subsuite; +int num_of_suites =0 ; + +for (suites = __kunit_suites_start; + suites < __kunit_suites_end; + suites++) +for (subsuite = *suites; *subsuite !=NULL ; subsuite++) + num_of_suites++; + +pr_info ("TAP version 14\n" ); +pr_info ("1..%d\n" , num_of_suites); +} +int kunit_run_all_tests (void ) {struct kunit_suite *const *const *suites, *const *subsuite;bool has_test_failed = false; +kunit_print_tap_header (); +for (suites = __kunit_suites_start; suites < __kunit_suites_end; suites++) {
lib/kunit/test.c +0 -11
@@ -18,16 +18,6 @@ static void kunit_set_failure(struct kunit *test)WRITE_ONCE (test->success, false); } -static void kunit_print_tap_version (void ) -{ -static bool kunit_has_printed_tap_version; - -if (!kunit_has_printed_tap_version) { -pr_info ("TAP version 14\n" ); - kunit_has_printed_tap_version = true; - } -} -static size_t kunit_test_cases_len (struct kunit_case *test_cases) {struct kunit_case *test_case;
@@ -41,7 +31,6 @@ static size_t kunit_test_cases_len(struct kunit_case *test_cases)static void kunit_print_subtest_start (struct kunit_suite *suite) { -kunit_print_tap_version ();pr_info ("\t# Subtest: %s\n" , suite->name);pr_info ("\t1..%zd\n" ,kunit_test_cases_len (suite->test_cases)); }
tools/testing/kunit/kunit_parser.py +62 -12
133 lines not on this page · raw message
tools/testing/kunit/test_data/test_is_test_passed-all_passed.log +1 -0
@@ -1,4 +1,5 @@ TAP version 14 +1..2 # Subtest: sysctl_test 1..8 # sysctl_test_dointvec_null_tbl_data: sysctl_test_dointvec_null_tbl_data passed
tools/testing/kunit/test_data/test_is_test_passed-crash.log +1 -0
@@ -1,6 +1,7 @@ printk: console [tty0] enabled printk: console [mc-1] enabled TAP version 14 +1..2 # Subtest: sysctl_test 1..8 # sysctl_test_dointvec_null_tbl_data: sysctl_test_dointvec_null_tbl_data passed
tools/testing/kunit/test_data/test_is_test_passed-failure.log +1 -0
@@ -1,4 +1,5 @@ TAP version 14 +1..2 # Subtest: sysctl_test 1..8 # sysctl_test_dointvec_null_tbl_data: sysctl_test_dointvec_null_tbl_data passed
Signature · 1 line
2.25.1.481.gfbce0eb801-goog
PATCH v3 6/7 kunit: Add 'kunit_shutdown' option
In reply to Brendan HigginsFrom: David Gow <[email protected]>
Add a new kernel command-line option, 'kunit_shutdown', which allows the user to specify that the kernel poweroff, halt, or reboot after completing all KUnit tests; this is very handy for running KUnit tests on UML or a VM so that the UML/VM process exits cleanly immediately after running all tests without needing a special initramfs.
--- lib/kunit/executor.c | 20 ++++++++++++++++++++ tools/testing/kunit/kunit_kernel.py | 2 +- tools/testing/kunit/kunit_parser.py | 2 +- 3 files changed, 22 insertions(+), 2 deletions(-)
lib/kunit/executor.c +20 -0
@@ -1,5 +1,6 @@// SPDX-License-Identifier: GPL-2.0 +#include <linux/reboot.h> #include <kunit/test.h> /*
@@ -11,6 +12,23 @@ extern struct kunit_suite * const * const __kunit_suites_end[];#if IS_BUILTIN (CONFIG_KUNIT ) +static char *kunit_shutdown; +core_param (kunit_shutdown, kunit_shutdown, charp,0644 ); + +static void kunit_handle_shutdown (void ) +{ +if (!kunit_shutdown) +return ; + +if (!strcmp (kunit_shutdown,"poweroff" )) +kernel_power_off (); +else if (!strcmp (kunit_shutdown,"halt" )) +kernel_halt (); +else if (!strcmp (kunit_shutdown,"reboot" )) +kernel_restart (NULL ); + +} +static void kunit_print_tap_header (void ) {struct kunit_suite *const *const *suites, *const *subsuite;
@@ -42,6 +60,8 @@ int kunit_run_all_tests(void) } } +kunit_handle_shutdown (); +if (has_test_failed)return -EFAULT ;
tools/testing/kunit/kunit_kernel.py +1 -1
@@ -145,7 +145,7 @@ class LinuxSourceTree(object): return self.validate_config(build_dir) def run_kernel(self, args=[], timeout=None, build_dir=''): - args.extend(['mem=256M']) + args.extend(['mem=256M', 'kunit_shutdown=halt']) process = self._ops.linux_bin(args, timeout, build_dir) with open(os.path.join(build_dir, 'test.log'), 'w') as f: for line in process.stdout:
tools/testing/kunit/kunit_parser.py +1 -1
@@ -48,7 +48,7 @@ class TestStatus(Enum): FAILURE_TO_PARSE_TESTS = auto() kunit_start_re = re.compile(r'^TAP version [0-9]+$') -kunit_end_re = re.compile('List of all partitions:') +kunit_end_re = re.compile(r'reboot: System halted') def isolate_kunit_output(kernel_output): started = False
Signature · 1 line
2.25.1.481.gfbce0eb801-goog
PATCH v3 7/7 Documentation: Add kunit_shutdown to kernel-parameters.txt
In reply to Brendan HigginsAdd kunit_shutdown, an option to specify that the kernel shutsdown after running KUnit tests, to the kernel-parameters.txt documentation.
--- Documentation/admin-guide/kernel-parameters.txt | 8 ++++++++ 1 file changed, 8 insertions(+)
Documentation/admin-guide/kernel-parameters.txt +8 -0
@@ -2099,6 +2099,14 @@ 0: force disabled 1: force enabled + kunit_shutdown [KERNEL UNIT TESTING FRAMEWORK] Shutdown kernel after + running built-in tests. Tests configured as modules will + not be run. + Default: (flag not present) don't shutdown + poweroff: poweroff the kernel after running tests + halt: halt the kernel after running tests + reboot: reboot the kernel after running tests + kvm.ignore_msrs=[KVM] Ignore guest accesses to unhandled MSRs. Default is 0 (don't ignore, but inject #GP)
Signature · 1 line
2.25.1.481.gfbce0eb801-goog
Randy Dunlap
reviewerRe: [PATCH v3 7/7] Documentation: Add kunit_shutdown to kernel-parameters.txt
Quoted 5 lines · Brendan Higgins
Add
kunit_shutdown, an option to specify that the kernel shutsdown after running KUnit tests, to the kernel-parameters.txt documentation.Signed-off-by Brendan Higgins <[email protected]>Reviewed-by Stephen Boyd <[email protected]>
Hi Brendan,
To be consistent with other parameters in this file:
Documentation/admin-guide/kernel-parameters.txt line 2102
Quoted 13 lines
--- Documentation/admin-guide/kernel-parameters.txt | 8 ++++++++ 1 file changed, 8 insertions(+)Documentation/admin-guide/kernel-parameters.txt +1
-0@@ -2099,6 +2099,14 @@ 0: force disabled 1: force enabled + kunit_shutdown [KERNEL UNIT TESTING FRAMEWORK] Shutdown kernel after
that line should have an '=' sign after the param name:
kunit_shutdown=
Documentation/admin-guide/kernel-parameters.txt line 2112
Quoted 11 lines
Documentation/admin-guide/kernel-parameters.txt +7
-0+ running built-in tests. Tests configured as modules will + not be run. + Default: (flag not present) don't shutdown + poweroff: poweroff the kernel after running tests + halt: halt the kernel after running tests + reboot: reboot the kernel after running tests + kvm.ignore_msrs=[KVM] Ignore guest accesses to unhandled MSRs. Default is 0 (don't ignore, but inject #GP)
thanks.
Signature · 1 line
~Randy
Quoted 49 lines · Brendan Higgins
## TL;DR
This patchset adds a centralized executor to dispatch tests rather than relying on
late_initcallto schedule each test suite separately along with a couple of new features that depend on it.Also, sorry for the delay in getting this new revision out. I have been really busy for the past couple weeks.
## What am I trying to do?
Conceptually, I am trying to provide a mechanism by which test suites can be grouped together so that they can be reasoned about collectively. The last two of three patches in this series add features which depend on this:
PATCH 5/7 Prints out a test plan[1] right before KUnit tests are run;
this is valuable because it makes it possible for a test harness to detect whether the number of tests run matches the number of tests expected to be run, ensuring that no tests silently failed. The test plan includes a count of tests that will run. With the centralized executor, the tests are located in a single data structure and thus can be counted.PATCH 6/7 Add a new kernel command-line option which allows the user to
specify that the kernel poweroff, halt, or reboot after completing all KUnit tests; this is very handy for running KUnit tests on UML or a VM so that the UML/VM process exits cleanly immediately after running all tests without needing a special initramfs. The centralized executor provides a definitive point when all tests have completed and the poweroff, halt, or reboot could occur.In addition, by dispatching tests from a single location, we can guarantee that all KUnit tests run after
late_initis complete, which was a concern during the initial KUnit patchset review (this has not been a problem in practice, but resolving with certainty is nevertheless desirable).Other use cases for this exist, but the above features should provide an idea of the value that this could provide.
## Changes since last revision:
- On patch 7/7, I added some additional wording around thekunit_shutdowncommand line option explaining that it runs after built-in tests as suggested by Frank.
- On the coverletter, I improved some wording and added a missing link. I also specified the base-commit for the series.
Quoted 4 lines
- Frank asked for some changes to the documentation; however, David is taking care of that in a separate patch[2], so I did not make those changes here. There will be some additional changes necessary after David's patch is applied.
Making the documentation changes after David's patches sounds like a good plan to me.
-Frank
Quoted 36 lines
Alan Maguire (1):
kunit: test: create a single centralized executor for all testsBrendan Higgins (5):
vmlinux.lds.h: add linker section for KUnit test suites
arch: um: add linker section for KUnit test suites
init: main: add KUnit to kernel init
kunit: test: add test plan to KUnit TAP format
Documentation: Addkunit_shutdownto kernel-parameters.txtDavid Gow (1):
kunit: Add 'kunit_shutdown' option.../admin-guide/kernel-parameters.txt | 8 ++ arch/um/include/asm/common.lds.S | 4 + include/asm-generic/vmlinux.lds.h | 8 ++ include/kunit/test.h | 82 ++++++++++++------- init/main.c | 4 + lib/kunit/Makefile | 3 +- lib/kunit/executor.c | 71 ++++++++++++++++ lib/kunit/test.c | 11 --- tools/testing/kunit/kunit_kernel.py | 2 +- tools/testing/kunit/kunit_parser.py | 76 ++++++++++++++--- .../test_is_test_passed-all_passed.log | 1 + .../test_data/test_is_test_passed-crash.log | 1 + .../test_data/test_is_test_passed-failure.log | 1 + 13 files changed, 218 insertions(+), 54 deletions(-) create mode 100644 lib/kunit/executor.cbase-commit:
a2f0b878c3ca531a1706cb2a8b079cea3b17bafc[1] https://github.com/isaacs/testanything.github.io/blob/tap14/tap-version-14-specification.md#the-plan
[2] https://patchwork.kernel.org/patch/11383635/
Guenter,
are you still running your cross-architecture tests? If so any chance you can try this for your build tests?
Brendan, do you have this code in a branch which can be merged into linux-next by any chance?
Luis
Quoted 3 lines · Luis Chamberlain
Guenter,
are you still running your cross-architecture tests? If so any chance
Yes
Quoted 2 lines
you can try this for your build tests?
I didn't have KUNIT_TEST enabled to start with. I did that now, and started a test run on mainline a minute ago. We'll see how that goes.
Afterwards, sure, I can run the series in a test branch. It would be great if I can pick it up from a repository somewhere.
Guenter
Quoted 6 lines · Guenter Roeck
Quoted 3 lines · Luis Chamberlain
Guenter,
are you still running your cross-architecture tests? If so any chance
Quoted 7 lines
Yes
Quoted 2 lines
you can try this for your build tests?
I didn't have
KUNIT_TESTenabled to start with. I did that now, and started a test run on mainline a minute ago. We'll see how that goes.
FYI, kbuild already found some architectures for which this change doesn't work.
So far, I need to fix:
- arm64 (32 bit seems to work fine)
- i386 in some cases.
Quoted 2 lines
Afterwards, sure, I can run the series in a test branch. It would be great if I can pick it up from a repository somewhere.
Cool, I will post my next revision to a branch somewhere.
Thanks!