Skip to content

kunit: create a centralized executor to dispatch all KUnit tests

Brendan Higgins linux-arch linux-doc linux-kselftest lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest5 patches 2 repliesIn review
  2. v512 patches 17 repliesSuperseded
  3. v411 patches 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v37 patches12 repliesSuperseded
v27 patches18 repliesSuperseded
v17 patches7 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5vmlinux.lds.h: add linker section for KUnit test suitesinclude/asm-generic/vmlinux.lds.h+9 -10 replies
2/5kunit: test: create a single centralized executor for all testsinclude/kunit/test.h lib/kunit/Makefile lib/kunit/executor.c +1 more+76 -241 reply
3/5init: main: add KUnit to kernel initinclude/kunit/test.h init/main.c lib/kunit/executor.c+14 -30 replies
4/5kunit: test: add test plan to KUnit TAP formatlib/kunit/executor.c lib/kunit/test.c tools/testing/kunit/kunit_parser.py +3 more+79 -250 replies
5/5Documentation: kunit: add a brief blurb about kunit_test_suiteDocumentation/dev-tools/kunit/usage.rst+5 -01 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchStephen BoydKees CookLuis Chamberlain
1/5R-b
2/5R-b R-b
3/5R-b R-b R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/5] kunit: create a centralized executor to dispatch all KUnit tests

## TL;DR

This patchset adds a centralized executor to dispatch tests rather than relying on late_initcall to schedule each test suite separately along with a couple of new features that depend on it.

## What am I trying to do?

Conceptually, I am trying to provide a mechanism by which test suites can be grouped together so that they can be reasoned about collectively. The second to last patch in this series add features which depend on this:

PATCH 04/05 Prints out a test plan[1] right before KUnit tests are run;
this is valuable because it makes it possible for a test harness to detect whether the number of tests run matches the number of tests expected to be run, ensuring that no tests silently failed. The test plan includes a count of tests that will run. With the centralized executor, the tests are located in a single data structure and thus can be counted.

In addition, by dispatching tests from a single location, we can guarantee that all KUnit tests run after late_init is complete, which was a concern during the initial KUnit patchset review (this has not been a problem in practice, but resolving with certainty is nevertheless desirable).

Other use cases for this exist, but the above features should provide an idea of the value that this could provide.

## Changes since last revision:
- Renamed the KUNIT_TEST_SUITES the KUNIT_TABLE section and moved it from INIT_DATA_SECTION to INIT_DATA; this had the additional consequence of making the first several architecture specific patches unnecessary - suggested by Kees.
- Dropped the kunit_shutdown patches; I think it makes more sense to reintroduce them in a later patchset.

Alan Maguire (1):
kunit: test: create a single centralized executor for all tests

Brendan Higgins (4):
vmlinux.lds.h: add linker section for KUnit test suites
init: main: add KUnit to kernel init
kunit: test: add test plan to KUnit TAP format
Documentation: kunit: add a brief blurb about kunit_test_suite

 Documentation/dev-tools/kunit/usage.rst       |   5 ++
 include/asm-generic/vmlinux.lds.h             |  10 ++-
 include/kunit/test.h                          |  76 +++++++++++++-----
 init/main.c                                   |   4 +
 lib/kunit/Makefile                            |   3 +-
 lib/kunit/executor.c                          |  43 ++++++++++
 lib/kunit/test.c                              |  13 +--
 tools/testing/kunit/kunit_parser.py           |  76 ++++++++++++++----
 .../test_is_test_passed-all_passed.log        | Bin 1562 -> 1567 bytes
 .../test_data/test_is_test_passed-crash.log   | Bin 3016 -> 3021 bytes
 .../test_data/test_is_test_passed-failure.log | Bin 1700 -> 1705 bytes
 11 files changed, 180 insertions(+), 50 deletions(-)
 create mode 100644 lib/kunit/executor.c

base-commit: 145ff1ec090dce9beb5a9590b5dc288e7bb2e65d

Signature · 1 line
2.28.0.163.g6104cc2f0b6-goog