Skip to contentSkip to conversation

MAINTAINERS: adjust to trusted keys subsystem creation

PATCH Superseded Lukas Bulwahn 2 participants 3 messages Mar 4, 2020 – Mar 5, 2020

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 MAINTAINERS: adjust to trusted keys subsystem creation

Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem") renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c to trusted-keys/trusted_tpm1.c in security/keys/.

Since then, ./scripts/get_maintainer.pl --self-test complains:

warning: no file matches F: security/keys/trusted.c
warning: no file matches F: include/keys/trusted.h

Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all files in security/keys/ are identified as part of KEYS-TRUSTED.

---
Changes to v1:
- use a global pattern for matching the whole security/keys/ directory. Sumit, please ack.
James or Jarkko, please pick this patch v2.

 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
MAINTAINERS +2 -2
index 5c755e03ddee..7f11ac752b91 100644
@@ -9276,8 +9276,8 @@ L:	[email protected]
 S:	Supported
 F:	Documentation/security/keys/trusted-encrypted.rst
 F:	include/keys/trusted-type.h
-F:	security/keys/trusted.c
-F:	include/keys/trusted.h
+F:	include/keys/trusted_tpm.h
+F:	security/keys/trusted-keys/
 
 KEYS/KEYRINGS
 M:	David Howells <[email protected]>
Signature · 1 line
2.17.1
#1 lore raw
Quoted 5 lines · Lukas Bulwahn

Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem") renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c to trusted-keys/trusted_tpm1.c in security/keys/.

Quoted 8 lines

Since then, ./scripts/get_maintainer.pl --self-test complains:

warning: no file matches F: security/keys/trusted.c
warning: no file matches F: include/keys/trusted.h

Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all files in security/keys/ are identified as part of KEYS-TRUSTED.

I guess you meant here security/keys/trusted-keys/ instead of security/keys/.

-Sumit

Quoted 30 lines

---
Changes to v1:
- use a global pattern for matching the whole security/keys/ directory. Sumit, please ack.
James or Jarkko, please pick this patch v2.

 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
MAINTAINERS +2 -3
index 5c755e03ddee..7f11ac752b91 100644
@@ -9276,8 +9276,8 @@ L:        [email protected]
 S:     Supported
 F:     Documentation/security/keys/trusted-encrypted.rst
 F:     include/keys/trusted-type.h
-F:     security/keys/trusted.c
-F:     include/keys/trusted.h
+F:     include/keys/trusted_tpm.h
+F:     security/keys/trusted-keys/
 
 KEYS/KEYRINGS
 M:     David Howells <[email protected]>
--

2.17.1

#2 lore raw
Quoted 8 lines · Sumit Garg
Quoted 7 lines · Lukas Bulwahn

Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem") renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c to trusted-keys/trusted_tpm1.c in security/keys/.

Since then, ./scripts/get_maintainer.pl --self-test complains:

Quoted 9 lines
Quoted 6 lines

warning: no file matches F: security/keys/trusted.c
warning: no file matches F: include/keys/trusted.h

Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all files in security/keys/ are identified as part of KEYS-TRUSTED.

I guess you meant here security/keys/trusted-keys/ instead of security/keys/.

Yes, that is what I meant. I rushed the patch v2 last night.

Here is hopefully now a PATCH v3 you can ack:

https://lore.kernel.org/linux-integrity/[email protected]/T/#u

Lukas