Skip to contentSkip to conversation

MAINTAINERS: adjust to trusted keys subsystem creation

PATCH In review Lukas Bulwahn 3 participants 5 messages Mar 5, 2020 – Mar 6, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 MAINTAINERS: adjust to trusted keys subsystem creation

Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem") renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c to trusted-keys/trusted_tpm1.c in security/keys/.

Since then, ./scripts/get_maintainer.pl --self-test complains:

warning: no file matches F: security/keys/trusted.c
warning: no file matches F: include/keys/trusted.h

Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all files in security/keys/trusted-keys/ are identified as part of KEYS-TRUSTED.

---
Changes to v1:
- use a global pattern for matching the whole security/keys/trusted-keys/ directory.
Changes to v2:
- name the correct directory in the commit message

Sumit, please ack.
Jarkko, please pick this patch v3.

 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
MAINTAINERS +2 -2
index 5c755e03ddee..7f11ac752b91 100644
@@ -9276,8 +9276,8 @@ L:	[email protected]
 S:	Supported
 F:	Documentation/security/keys/trusted-encrypted.rst
 F:	include/keys/trusted-type.h
-F:	security/keys/trusted.c
-F:	include/keys/trusted.h
+F:	include/keys/trusted_tpm.h
+F:	security/keys/trusted-keys/
 
 KEYS/KEYRINGS
 M:	David Howells <[email protected]>
Signature · 1 line
2.17.1
Acked-by on v3 1/1
#1 lore raw
Quoted 10 lines · Lukas Bulwahn

Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem") renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c to trusted-keys/trusted_tpm1.c in security/keys/.

Since then, ./scripts/get_maintainer.pl --self-test complains:

warning: no file matches F: security/keys/trusted.c
warning: no file matches F: include/keys/trusted.h

Quoted 7 lines

Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all files in security/keys/trusted-keys/ are identified as part of KEYS-TRUSTED.

Quoted 31 lines

---
Changes to v1:
- use a global pattern for matching the whole security/keys/trusted-keys/ directory.
Changes to v2:
- name the correct directory in the commit message

Sumit, please ack.
Jarkko, please pick this patch v3.

 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
MAINTAINERS +2 -3
index 5c755e03ddee..7f11ac752b91 100644
@@ -9276,8 +9276,8 @@ L:        [email protected]
 S:     Supported
 F:     Documentation/security/keys/trusted-encrypted.rst
 F:     include/keys/trusted-type.h
-F:     security/keys/trusted.c
-F:     include/keys/trusted.h
+F:     include/keys/trusted_tpm.h
+F:     security/keys/trusted-keys/
 
 KEYS/KEYRINGS
 M:     David Howells <[email protected]>
--

2.17.1

Reviewed-by on v3 1/1
#2 lore raw
In reply to Lukas Bulwahn
Quoted 9 lines · Lukas Bulwahn

Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem") renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c to trusted-keys/trusted_tpm1.c in security/keys/.

Since then, ./scripts/get_maintainer.pl --self-test complains:

warning: no file matches F: security/keys/trusted.c
warning: no file matches F: include/keys/trusted.h

Quoted 8 lines

Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all files in security/keys/trusted-keys/ are identified as part of KEYS-TRUSTED.

---

Quoted 8 lines

Changes to v1:
- use a global pattern for matching the whole security/keys/trusted-keys/ directory.
Changes to v2:
- name the correct directory in the commit message

Sumit, please ack.
Jarkko, please pick this patch v3.

Please tell me why you emphasize the moment when a patch that does not fix a critical bug is picked?

Do you have systems that break because the MAINTAINERS file is not updated?

It will end up in v5.7 PR for sure but saying things like that is same as saying that there would be some catastrophically urgent need to still squeeze the patch into v5.6. Unless you actually have something critical in your hand, please stop doing that.

/Jarkko

#3 lore raw
Quoted 33 lines · Jarkko Sakkinen
Quoted 9 lines · Lukas Bulwahn

Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem") renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c to trusted-keys/trusted_tpm1.c in security/keys/.

Since then, ./scripts/get_maintainer.pl --self-test complains:

warning: no file matches F: security/keys/trusted.c
warning: no file matches F: include/keys/trusted.h

Quoted 8 lines

Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all files in security/keys/trusted-keys/ are identified as part of KEYS-TRUSTED.

---

Quoted 8 lines

Changes to v1:
- use a global pattern for matching the whole security/keys/trusted-keys/ directory.
Changes to v2:
- name the correct directory in the commit message

Sumit, please ack.
Jarkko, please pick this patch v3.

Please tell me why you emphasize the moment when a patch that does not fix a critical bug is picked?

Quoted 8 lines

Do you have systems that break because the MAINTAINERS file is not updated?

It will end up in v5.7 PR for sure but saying things like that is same as saying that there would be some catastrophically urgent need to still squeeze the patch into v5.6. Unless you actually have something critical in your hand, please stop doing that.

Got it. I did not intend to emphasize any urgency; I will not continue to do that for patches of this clean-up type.

Lukas

#4 lore raw
Quoted 40 lines · Lukas Bulwahn
Quoted 36 lines · Jarkko Sakkinen
Quoted 9 lines · Lukas Bulwahn

Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem") renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c to trusted-keys/trusted_tpm1.c in security/keys/.

Since then, ./scripts/get_maintainer.pl --self-test complains:

warning: no file matches F: security/keys/trusted.c
warning: no file matches F: include/keys/trusted.h

Quoted 8 lines

Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all files in security/keys/trusted-keys/ are identified as part of KEYS-TRUSTED.

---

Quoted 8 lines

Changes to v1:
- use a global pattern for matching the whole security/keys/trusted-keys/ directory.
Changes to v2:
- name the correct directory in the commit message

Sumit, please ack.
Jarkko, please pick this patch v3.

Please tell me why you emphasize the moment when a patch that does not fix a critical bug is picked?

Do you have systems that break because the MAINTAINERS file is not updated?

Quoted 8 lines
Quoted 5 lines

It will end up in v5.7 PR for sure but saying things like that is same as saying that there would be some catastrophically urgent need to still squeeze the patch into v5.6. Unless you actually have something critical in your hand, please stop doing that.

Got it. I did not intend to emphasize any urgency; I will not continue to do that for patches of this clean-up type.

Anyway, thank you and I've applied your patch and will include it to my v5.7 PR.

/Jarkko