MAINTAINERS: adjust to trusted keys subsystem creation
Subsystems (3)
PATCH v3 1/1 MAINTAINERS: adjust to trusted keys subsystem creation
Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem") renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c to trusted-keys/trusted_tpm1.c in security/keys/.
Since then, ./scripts/get_maintainer.pl --self-test complains:
warning: no file matches F: security/keys/trusted.c
warning: no file matches F: include/keys/trusted.h
Rectify the KEYS-TRUSTED entry in MAINTAINERS now and ensure that all files in security/keys/trusted-keys/ are identified as part of KEYS-TRUSTED.
---
Changes to v1:
- use a global pattern for matching the whole security/keys/trusted-keys/ directory.
Changes to v2:
- name the correct directory in the commit message
Sumit, please ack.
Jarkko, please pick this patch v3.
MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
MAINTAINERS +2 -2
@@ -9276,8 +9276,8 @@ L: [email protected] S: Supported F: Documentation/security/keys/trusted-encrypted.rst F: include/keys/trusted-type.h -F: security/keys/trusted.c -F: include/keys/trusted.h +F: include/keys/trusted_tpm.h +F: security/keys/trusted-keys/ KEYS/KEYRINGS M: David Howells <[email protected]>
Signature · 1 line
2.17.1
Quoted 10 lines · Lukas Bulwahn
Commit
47f9c2796891("KEYS: trusted: Create trusted keys subsystem") renamedtrusted.htotrusted_tpm.hininclude/keys/, and movedtrusted.ctotrusted-keys/trusted_tpm1.cinsecurity/keys/.Since then,
./scripts/get_maintainer.pl--self-test complains:warning: no file matches F:
security/keys/trusted.c
warning: no file matches F:include/keys/trusted.h
Quoted 7 lines
Rectify the KEYS-TRUSTED entry in
MAINTAINERSnow and ensure that all files insecurity/keys/trusted-keys/are identified as part of KEYS-TRUSTED.Co-developed-by Sebastian Duda <[email protected]>Signed-off-by Sebastian Duda <[email protected]>Signed-off-by Lukas Bulwahn <[email protected]>
Quoted 31 lines
---
Changes to v1:
- use a global pattern for matching the wholesecurity/keys/trusted-keys/directory.
Changes to v2:
- name the correct directory in the commit messageSumit, please ack.
Jarkko, please pick this patch v3.MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)MAINTAINERS +2
-3@@ -9276,8 +9276,8 @@ L: [email protected] S: Supported F: Documentation/security/keys/trusted-encrypted.rst F: include/keys/trusted-type.h -F: security/keys/trusted.c -F: include/keys/trusted.h +F: include/keys/trusted_tpm.h +F: security/keys/trusted-keys/ KEYS/KEYRINGS M: David Howells <[email protected]> --2.17.1
Quoted 9 lines · Lukas Bulwahn
Commit
47f9c2796891("KEYS: trusted: Create trusted keys subsystem") renamedtrusted.htotrusted_tpm.hininclude/keys/, and movedtrusted.ctotrusted-keys/trusted_tpm1.cinsecurity/keys/.Since then,
./scripts/get_maintainer.pl--self-test complains:warning: no file matches F:
security/keys/trusted.c
warning: no file matches F:include/keys/trusted.h
Quoted 8 lines
Rectify the KEYS-TRUSTED entry in
MAINTAINERSnow and ensure that all files insecurity/keys/trusted-keys/are identified as part of KEYS-TRUSTED.Co-developed-by Sebastian Duda <[email protected]>Signed-off-by Sebastian Duda <[email protected]>Signed-off-by Lukas Bulwahn <[email protected]>---
Quoted 8 lines
Changes to v1:
- use a global pattern for matching the wholesecurity/keys/trusted-keys/directory.
Changes to v2:
- name the correct directory in the commit messageSumit, please ack.
Jarkko, please pick this patch v3.
Please tell me why you emphasize the moment when a patch that does not fix a critical bug is picked?
Do you have systems that break because the MAINTAINERS file is not updated?
It will end up in v5.7 PR for sure but saying things like that is same as saying that there would be some catastrophically urgent need to still squeeze the patch into v5.6. Unless you actually have something critical in your hand, please stop doing that.
/Jarkko
Quoted 33 lines · Jarkko Sakkinen
Quoted 9 lines · Lukas Bulwahn
Commit
47f9c2796891("KEYS: trusted: Create trusted keys subsystem") renamedtrusted.htotrusted_tpm.hininclude/keys/, and movedtrusted.ctotrusted-keys/trusted_tpm1.cinsecurity/keys/.Since then,
./scripts/get_maintainer.pl--self-test complains:warning: no file matches F:
security/keys/trusted.c
warning: no file matches F:include/keys/trusted.hQuoted 8 lines
Rectify the KEYS-TRUSTED entry in
MAINTAINERSnow and ensure that all files insecurity/keys/trusted-keys/are identified as part of KEYS-TRUSTED.Co-developed-by Sebastian Duda <[email protected]>Signed-off-by Sebastian Duda <[email protected]>Signed-off-by Lukas Bulwahn <[email protected]>---
Reviewed-by Jarkko Sakkinen <[email protected]>Quoted 8 lines
Changes to v1:
- use a global pattern for matching the wholesecurity/keys/trusted-keys/directory.
Changes to v2:
- name the correct directory in the commit messageSumit, please ack.
Jarkko, please pick this patch v3.Please tell me why you emphasize the moment when a patch that does not fix a critical bug is picked?
Quoted 8 lines
Do you have systems that break because the
MAINTAINERSfile is not updated?It will end up in v5.7 PR for sure but saying things like that is same as saying that there would be some catastrophically urgent need to still squeeze the patch into v5.6. Unless you actually have something critical in your hand, please stop doing that.
Got it. I did not intend to emphasize any urgency; I will not continue to do that for patches of this clean-up type.
Lukas
Quoted 40 lines · Lukas Bulwahn
Quoted 36 lines · Jarkko Sakkinen
Quoted 9 lines · Lukas Bulwahn
Commit
47f9c2796891("KEYS: trusted: Create trusted keys subsystem") renamedtrusted.htotrusted_tpm.hininclude/keys/, and movedtrusted.ctotrusted-keys/trusted_tpm1.cinsecurity/keys/.Since then,
./scripts/get_maintainer.pl--self-test complains:warning: no file matches F:
security/keys/trusted.c
warning: no file matches F:include/keys/trusted.hQuoted 8 lines
Rectify the KEYS-TRUSTED entry in
MAINTAINERSnow and ensure that all files insecurity/keys/trusted-keys/are identified as part of KEYS-TRUSTED.Co-developed-by Sebastian Duda <[email protected]>Signed-off-by Sebastian Duda <[email protected]>Signed-off-by Lukas Bulwahn <[email protected]>---
Reviewed-by Jarkko Sakkinen <[email protected]>Quoted 8 lines
Changes to v1:
- use a global pattern for matching the wholesecurity/keys/trusted-keys/directory.
Changes to v2:
- name the correct directory in the commit messageSumit, please ack.
Jarkko, please pick this patch v3.Please tell me why you emphasize the moment when a patch that does not fix a critical bug is picked?
Do you have systems that break because the
MAINTAINERSfile is not updated?
Quoted 8 lines
Quoted 5 lines
It will end up in v5.7 PR for sure but saying things like that is same as saying that there would be some catastrophically urgent need to still squeeze the patch into v5.6. Unless you actually have something critical in your hand, please stop doing that.
Got it. I did not intend to emphasize any urgency; I will not continue to do that for patches of this clean-up type.
Anyway, thank you and I've applied your patch and will include it to my v5.7 PR.
/Jarkko