Skip to contentSkip to conversation

net: rmnet: several code cleanup for rmnet module

PATCH In review Taehee Yoo 4 participants 4 messages Mar 4, 2020 – Mar 5, 2020

Subsystems (2)
lore
Share & tools
lore

Taehee Yoo

author
#0 lore raw

v2 cover net: rmnet: several code cleanup for rmnet module

This patchset is to cleanup rmnet module code.

1. The first patch is to add module alias
rmnet module can not be loaded automatically because there is no alias name.

2. The second patch is to add extack error message code. When rmnet netlink command fails, it doesn't print any error message. So, users couldn't know the exact reason.
In order to tell the exact reason to the user, the extack error message is used in this patch.

3. The third patch is to use GFP_KERNEL instead of GFP_ATOMIC. In the sleepable context, GFP_KERNEL can be used. So, in this patch, GFP_KERNEL is used instead of GFP_ATOMIC.

Change log:
- v1->v2: change error message in the second patch.

Taehee Yoo (3):
net: rmnet: add missing module alias
net: rmnet: print error message when command fails
net: rmnet: use GFP_KERNEL instead of GFP_ATOMIC

 .../ethernet/qualcomm/rmnet/rmnet_config.c    | 36 ++++++++++++-------
 .../net/ethernet/qualcomm/rmnet/rmnet_vnd.c   | 11 +++---
 .../net/ethernet/qualcomm/rmnet/rmnet_vnd.h   |  3 +-
 3 files changed, 32 insertions(+), 18 deletions(-)
Signature · 1 line
2.17.1
Acked-by on the v2 series
#1 lore raw
Quoted 24 lines · Taehee Yoo

This patchset is to cleanup rmnet module code.

1. The first patch is to add module alias
rmnet module can not be loaded automatically because there is no alias name.

2. The second patch is to add extack error message code. When rmnet netlink command fails, it doesn't print any error message. So, users couldn't know the exact reason.
In order to tell the exact reason to the user, the extack error message is used in this patch.

3. The third patch is to use GFP_KERNEL instead of GFP_ATOMIC. In the sleepable context, GFP_KERNEL can be used. So, in this patch, GFP_KERNEL is used instead of GFP_ATOMIC.

Change log:
- v1->v2: change error message in the second patch.

Taehee Yoo (3):
net: rmnet: add missing module alias
net: rmnet: print error message when command fails
net: rmnet: use GFP_KERNEL instead of GFP_ATOMIC

Quoted 4 lines
 .../ethernet/qualcomm/rmnet/rmnet_config.c    | 36 ++++++++++++-------
 .../net/ethernet/qualcomm/rmnet/rmnet_vnd.c   | 11 +++---
 .../net/ethernet/qualcomm/rmnet/rmnet_vnd.h   |  3 +-
 3 files changed, 32 insertions(+), 18 deletions(-)

For the series:

maintainer
#2 lore raw
Quoted 17 lines · On Wed, 04 Mar 2020 16:43:58 -0700 [email protected] wrote:
Quoted 16 lines · Taehee Yoo

This patchset is to cleanup rmnet module code.

1. The first patch is to add module alias
rmnet module can not be loaded automatically because there is no alias name.

2. The second patch is to add extack error message code. When rmnet netlink command fails, it doesn't print any error message. So, users couldn't know the exact reason.
In order to tell the exact reason to the user, the extack error message is used in this patch.

3. The third patch is to use GFP_KERNEL instead of GFP_ATOMIC. In the sleepable context, GFP_KERNEL can be used. So, in this patch, GFP_KERNEL is used instead of GFP_ATOMIC.

Quoted 6 lines
Quoted 2 lines

Change log:
- v1->v2: change error message in the second patch.

For the series:

LGTM as well, thanks!

maintainer
#3 lore raw
In reply to Taehee Yoo

From: Taehee Yoo <[email protected]>
Date: Wed, 4 Mar 2020 23:24:15 +0000

Quoted 12 lines

This patchset is to cleanup rmnet module code.

1. The first patch is to add module alias
rmnet module can not be loaded automatically because there is no alias name.

2. The second patch is to add extack error message code. When rmnet netlink command fails, it doesn't print any error message. So, users couldn't know the exact reason.
In order to tell the exact reason to the user, the extack error message is used in this patch.

Quoted 6 lines

3. The third patch is to use GFP_KERNEL instead of GFP_ATOMIC. In the sleepable context, GFP_KERNEL can be used. So, in this patch, GFP_KERNEL is used instead of GFP_ATOMIC.

Change log:
- v1->v2: change error message in the second patch.

Looks good, series applied, thanks.