Skip to content

net: rmnet: several code cleanup for rmnet module

Taehee Yoo netdev 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesIn review
  2. v13 patches 4 repliesSuperseded

Change log from the cover letter

- v1->v2: change error message in the second patch.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net: rmnet: add missing module aliasdrivers/net/ethernet/qualcomm/rmnet/rmnet_config.c+1 -00 replies
2/3net: rmnet: print error message when command failsdrivers/net/ethernet/qualcomm/rmnet/rmnet_config.c drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.h+29 -160 replies
3/3net: rmnet: use GFP_KERNEL instead of GFP_ATOMICdrivers/net/ethernet/qualcomm/rmnet/rmnet_config.c+2 -20 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSubash Abhinov Kasiviswanathan
SeriesA-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 0/3] net: rmnet: several code cleanup for rmnet module

This patchset is to cleanup rmnet module code.

1. The first patch is to add module alias
rmnet module can not be loaded automatically because there is no alias name.

2. The second patch is to add extack error message code. When rmnet netlink command fails, it doesn't print any error message. So, users couldn't know the exact reason.
In order to tell the exact reason to the user, the extack error message is used in this patch.

3. The third patch is to use GFP_KERNEL instead of GFP_ATOMIC. In the sleepable context, GFP_KERNEL can be used. So, in this patch, GFP_KERNEL is used instead of GFP_ATOMIC.

Change log:
- v1->v2: change error message in the second patch.

Taehee Yoo (3):
net: rmnet: add missing module alias
net: rmnet: print error message when command fails
net: rmnet: use GFP_KERNEL instead of GFP_ATOMIC

 .../ethernet/qualcomm/rmnet/rmnet_config.c    | 36 ++++++++++++-------
 .../net/ethernet/qualcomm/rmnet/rmnet_vnd.c   | 11 +++---
 .../net/ethernet/qualcomm/rmnet/rmnet_vnd.h   |  3 +-
 3 files changed, 32 insertions(+), 18 deletions(-)
Signature · 1 line
2.17.1