Skip to contentSkip to conversation

staging: greybus: i2c.c: remove commented out function

PATCH In review Lourdes Pedrajas 2 participants 2 messages Mar 9, 2020 – Mar 10, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: greybus: i2c.c: remove commented out function

Remove function gb_i2c_smbus_xfer() which is unused.

---
 drivers/staging/greybus/i2c.c | 14 --------------
 1 file changed, 14 deletions(-)
drivers/staging/greybus/i2c.c +0 -14
index ab06fc3b9e7e..c48fa1de89b0 100644
@@ -215,20 +215,6 @@ static int gb_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
 	return gb_i2c_transfer_operation(gb_i2c_dev, msgs, msg_count);
 }
 
-#if 0
-/* Later */
-static int gb_i2c_smbus_xfer(struct i2c_adapter *adap,
-			     u16 addr, unsigned short flags, char read_write,
-			     u8 command, int size, union i2c_smbus_data *data)
-{
-	struct gb_i2c_device *gb_i2c_dev;
-
-	gb_i2c_dev = i2c_get_adapdata(adap);
-
-	return 0;
-}
-#endif
-
 static u32 gb_i2c_functionality(struct i2c_adapter *adap)
 {
 	struct gb_i2c_device *gb_i2c_dev = i2c_get_adapdata(adap);
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 1 line · Lourdes Pedrajas

Remove function gb_i2c_smbus_xfer() which is unused.

Sure, why not. But please remove the out-commented pointer in gb_i2c_algorithm as well.

Also please drop the ".c" in the module prefix; "staging: greybus: i2c:" is enough to indicate which driver (component) is being modified.

Quoted 20 lines
---
 drivers/staging/greybus/i2c.c | 14 --------------
 1 file changed, 14 deletions(-)
drivers/staging/greybus/i2c.c +0 -7
index ab06fc3b9e7e..c48fa1de89b0 100644
@@ -215,20 +215,6 @@ static int gb_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
 	return gb_i2c_transfer_operation(gb_i2c_dev, msgs, msg_count);
 }
 
-#if 0
-/* Later */
-static int gb_i2c_smbus_xfer(struct i2c_adapter *adap,
-			     u16 addr, unsigned short flags, char read_write,
-			     u8 command, int size, union i2c_smbus_data *data)
-{
-	struct gb_i2c_device *gb_i2c_dev;

drivers/staging/greybus/i2c.c static int gb_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, · line 220

Quoted 10 lines
drivers/staging/greybus/i2c.c +0 -7
-
-	gb_i2c_dev = i2c_get_adapdata(adap);
-
-	return 0;
-}
-#endif
-
 static u32 gb_i2c_functionality(struct i2c_adapter *adap)
 {
 	struct gb_i2c_device *gb_i2c_dev = i2c_get_adapdata(adap);

Johan