staging: greybus: i2c.c: remove commented out function
Subsystems (3)
PATCH 1/1 staging: greybus: i2c.c: remove commented out function
Remove function gb_i2c_smbus_xfer() which is unused.
Signed-off-by Lourdes Pedrajas <[email protected]>
--- drivers/staging/greybus/i2c.c | 14 -------------- 1 file changed, 14 deletions(-)
drivers/staging/greybus/i2c.c +0 -14
@@ -215,20 +215,6 @@ static int gb_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,return gb_i2c_transfer_operation (gb_i2c_dev, msgs, msg_count); } -#if 0 -/* Later */ -static int gb_i2c_smbus_xfer (struct i2c_adapter *adap, -u16 addr,unsigned short flags,char read_write, -u8 command,int size,union i2c_smbus_data *data) -{ -struct gb_i2c_device *gb_i2c_dev; - - gb_i2c_dev =i2c_get_adapdata (adap); - -return 0 ; -} -#endif -static u32 gb_i2c_functionality (struct i2c_adapter *adap) {struct gb_i2c_device *gb_i2c_dev =i2c_get_adapdata (adap);
Signature · 1 line
2.17.1
Johan Hovold
maintainerQuoted 1 line · Lourdes Pedrajas
Remove function
gb_i2c_smbus_xfer()which is unused.
Sure, why not. But please remove the out-commented pointer in gb_i2c_algorithm as well.
Also please drop the ".c" in the module prefix; "staging: greybus: i2c:" is enough to indicate which driver (component) is being modified.
Quoted 20 lines
Signed-off-by Lourdes Pedrajas <[email protected]>--- drivers/staging/greybus/i2c.c | 14 -------------- 1 file changed, 14 deletions(-)drivers/staging/greybus/i2c.c +0
-7@@ -215,20 +215,6 @@ static int gb_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,return gb_i2c_transfer_operation (gb_i2c_dev, msgs, msg_count); } -#if 0 -/* Later */ -static int gb_i2c_smbus_xfer (struct i2c_adapter *adap, -u16 addr,unsigned short flags,char read_write, -u8 command,int size,union i2c_smbus_data *data) -{ -struct gb_i2c_device *gb_i2c_dev;
drivers/staging/greybus/i2c.c static int gb_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, · line 220
Quoted 10 lines
drivers/staging/greybus/i2c.c +0
-7- - gb_i2c_dev =i2c_get_adapdata (adap); - - return 0; -} -#endif -static u32 gb_i2c_functionality (struct i2c_adapter *adap) {struct gb_i2c_device *gb_i2c_dev =i2c_get_adapdata (adap);
Johan