mm/hugetlb: remove unnecessary memory fetch in PageHeadHuge()
Subsystems (2)
PATCH 1/1 mm/hugetlb: remove unnecessary memory fetch in PageHeadHuge()
Commit f1e61557f023 ("mm: pack compound_dtor and compound_order into one word in struct page") changed compound_dtor from a pointer to an array index in order to pack it. To check if page has the hugeltbfs compound_dtor, we can just compare the index directly without fetching the function pointer. Said commit did that with PageHuge() and we can do the same with PageHeadHuge() to make the code a bit smaller and faster.
--- mm/hugetlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/hugetlb.c +1 -1
@@ -1313,7 +1313,7 @@ int PageHeadHuge(struct page *page_head)if (!PageHead (page_head))return 0 ; -return get_compound_page_dtor (page_head) == free_huge_page; +return page_head[1 ].compound_dtor ==HUGETLB_PAGE_DTOR ; }pgoff_t __basepage_index (struct page *page)
Signature · 1 line
2.25.1
Quoted 10 lines · Vlastimil Babka
Commit
f1e61557f023("mm: packcompound_dtorandcompound_orderinto one word in struct page") changedcompound_dtorfrom a pointer to an array index in order to pack it. To check if page has the hugeltbfscompound_dtor, we can just compare the index directly without fetching the function pointer. Said commit did that withPageHuge()and we can do the same withPageHeadHuge()to make the code a bit smaller and faster.Signed-off-by Vlastimil Babka <[email protected]>Cc Mike Kravetz <[email protected]>Cc Kirill A. Shutemov <[email protected]>
Thanks!
Signature · 1 line
Mike Kravetz
Quoted 10 lines · Vlastimil Babka
Commit
f1e61557f023("mm: packcompound_dtorandcompound_orderinto one word in struct page") changedcompound_dtorfrom a pointer to an array index in order to pack it. To check if page has the hugeltbfscompound_dtor, we can just compare the index directly without fetching the function pointer. Said commit did that withPageHuge()and we can do the same withPageHeadHuge()to make the code a bit smaller and faster.Signed-off-by Vlastimil Babka <[email protected]>Cc Mike Kravetz <[email protected]>Cc Kirill A. Shutemov <[email protected]>
word in struct page")
[+nehaagarwal]
We've been running with this patch for a few years and it works as intended.
Quoted 17 lines
--- mm/hugetlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/hugetlb.c +1
-1@@ -1313,7 +1313,7 @@ int PageHeadHuge(struct page *page_head)if (!PageHead (page_head))return 0 ; -return get_compound_page_dtor (page_head) == free_huge_page; +return page_head[1 ].compound_dtor ==HUGETLB_PAGE_DTOR ; }pgoff_t __basepage_index (struct page *page)
Quoted 10 lines · Vlastimil Babka
Commit
f1e61557f023("mm: packcompound_dtorandcompound_orderinto one word in struct page") changedcompound_dtorfrom a pointer to an array index in order to pack it. To check if page has the hugeltbfscompound_dtor, we can just compare the index directly without fetching the function pointer. Said commit did that withPageHuge()and we can do the same withPageHeadHuge()to make the code a bit smaller and faster.Signed-off-by Vlastimil Babka <[email protected]>Cc Mike Kravetz <[email protected]>Cc Kirill A. Shutemov <[email protected]>
We use literaly the same check in the function next to this one -- PageHuge().
Signature · 1 line
Kirill A. Shutemov
Quoted 8 lines · Kirill A. Shutemov
Quoted 7 lines · Vlastimil Babka
Commit
f1e61557f023("mm: packcompound_dtorandcompound_orderinto one word in struct page") changedcompound_dtorfrom a pointer to an array index in order to pack it. To check if page has the hugeltbfscompound_dtor, we can just compare the index directly without fetching the function pointer. Said commit did that withPageHuge()and we can do the same withPageHeadHuge()to make the code a bit smaller and faster.
Quoted 8 lines
Quoted 3 lines
Signed-off-by Vlastimil Babka <[email protected]>Cc Mike Kravetz <[email protected]>Cc Kirill A. Shutemov <[email protected]>We use literaly the same check in the function next to this one --
PageHuge().
Ugh.. I have to read the commit message, not only the code :P
Signature · 1 line
Kirill A. Shutemov