Skip to contentSkip to conversation

mm/hugetlb: remove unnecessary memory fetch in PageHeadHuge()

PATCH Applied Vlastimil Babka 4 participants 5 messages Mar 11, 2020 – Mar 12, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/hugetlb: remove unnecessary memory fetch in PageHeadHuge()

Commit f1e61557f023 ("mm: pack compound_dtor and compound_order into one word in struct page") changed compound_dtor from a pointer to an array index in order to pack it. To check if page has the hugeltbfs compound_dtor, we can just compare the index directly without fetching the function pointer. Said commit did that with PageHuge() and we can do the same with PageHeadHuge() to make the code a bit smaller and faster.

Cc Mike Kravetz <[email protected]>
Cc Kirill A. Shutemov <[email protected]>
---
 mm/hugetlb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/hugetlb.c +1 -1
index dd8737a94bec..ba1ca452aa7f 100644
@@ -1313,7 +1313,7 @@ int PageHeadHuge(struct page *page_head)
 	if (!PageHead(page_head))
 		return 0;
 
-	return get_compound_page_dtor(page_head) == free_huge_page;
+	return page_head[1].compound_dtor == HUGETLB_PAGE_DTOR;
 }
 
 pgoff_t __basepage_index(struct page *page)
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Vlastimil Babka

Commit f1e61557f023 ("mm: pack compound_dtor and compound_order into one word in struct page") changed compound_dtor from a pointer to an array index in order to pack it. To check if page has the hugeltbfs compound_dtor, we can just compare the index directly without fetching the function pointer. Said commit did that with PageHuge() and we can do the same with PageHeadHuge() to make the code a bit smaller and faster.

Cc Mike Kravetz <[email protected]>
Cc Kirill A. Shutemov <[email protected]>

Thanks!

Signature · 1 line
Mike Kravetz
Acked-by on v1 1/1
#2 lore raw
In reply to Vlastimil Babka
Quoted 10 lines · Vlastimil Babka

Commit f1e61557f023 ("mm: pack compound_dtor and compound_order into one word in struct page") changed compound_dtor from a pointer to an array index in order to pack it. To check if page has the hugeltbfs compound_dtor, we can just compare the index directly without fetching the function pointer. Said commit did that with PageHuge() and we can do the same with PageHeadHuge() to make the code a bit smaller and faster.

Cc Mike Kravetz <[email protected]>
Cc Kirill A. Shutemov <[email protected]>
Fixes f1e61557f023 ("mm: pack compound_dtor and compound_order into one

word in struct page")

[+nehaagarwal]

We've been running with this patch for a few years and it works as intended.

Quoted 17 lines
---
 mm/hugetlb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/hugetlb.c +1 -1
index dd8737a94bec..ba1ca452aa7f 100644
@@ -1313,7 +1313,7 @@ int PageHeadHuge(struct page *page_head)
 	if (!PageHead(page_head))
 		return 0;
 
-	return get_compound_page_dtor(page_head) == free_huge_page;
+	return page_head[1].compound_dtor == HUGETLB_PAGE_DTOR;
 }
 
 pgoff_t __basepage_index(struct page *page)
Acked-by on v1 1/1
#3 lore raw
In reply to Vlastimil Babka
Quoted 10 lines · Vlastimil Babka

Commit f1e61557f023 ("mm: pack compound_dtor and compound_order into one word in struct page") changed compound_dtor from a pointer to an array index in order to pack it. To check if page has the hugeltbfs compound_dtor, we can just compare the index directly without fetching the function pointer. Said commit did that with PageHuge() and we can do the same with PageHeadHuge() to make the code a bit smaller and faster.

Cc Mike Kravetz <[email protected]>
Cc Kirill A. Shutemov <[email protected]>

We use literaly the same check in the function next to this one -- PageHuge().

Signature · 1 line
 Kirill A. Shutemov
#4 lore raw
Quoted 8 lines · Kirill A. Shutemov
Quoted 7 lines · Vlastimil Babka

Commit f1e61557f023 ("mm: pack compound_dtor and compound_order into one word in struct page") changed compound_dtor from a pointer to an array index in order to pack it. To check if page has the hugeltbfs compound_dtor, we can just compare the index directly without fetching the function pointer. Said commit did that with PageHuge() and we can do the same with PageHeadHuge() to make the code a bit smaller and faster.

Quoted 8 lines
Quoted 3 lines
Cc Mike Kravetz <[email protected]>
Cc Kirill A. Shutemov <[email protected]>

We use literaly the same check in the function next to this one -- PageHuge().

Ugh.. I have to read the commit message, not only the code :P

Signature · 1 line
 Kirill A. Shutemov