Skip to contentSkip to conversation

staging: rtl8712: Fix for long lines in Kconfig help

PATCH Superseded R Veera Kumar 2 participants 4 messages Mar 12, 2020 Staging

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8712: Fix for long lines in Kconfig help

Fixes two long line in Kconfig help.
Found using checkpatch.pl

---
 drivers/staging/rtl8712/Kconfig | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/staging/rtl8712/Kconfig +5 -2
index b6dcda77db1f..678bbeace823 100644
@@ -6,13 +6,16 @@ config R8712U
 	select WEXT_PRIV
 	select FW_LOADER
 	help
-	    This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130.
+	    This option adds the Realtek RTL8712 USB device such as the
+	    D-Link DWA-130.
+
 	    If built as a module, it will be called r8712u.
 
 config R8712_TX_AGGR
 	bool "Realtek RTL8712U Transmit Aggregation code"
 	depends on R8712U && BROKEN
 	help
-	    This option provides transmit aggregation for the Realtek RTL8712 USB device.
+	    This option provides transmit aggregation for the
+	    Realtek RTL8712 USB device.
 
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 20 lines · R Veera Kumar

Fixes two long line in Kconfig help.
Found using checkpatch.pl

---
 drivers/staging/rtl8712/Kconfig | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/staging/rtl8712/Kconfig +3 -1
index b6dcda77db1f..678bbeace823 100644
@@ -6,13 +6,16 @@ config R8712U
 	select WEXT_PRIV
 	select FW_LOADER
 	help
-	    This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130.
+	    This option adds the Realtek RTL8712 USB device such as the
+	    D-Link DWA-130.
+

drivers/staging/rtl8712/Kconfig config R8712U · line 20

Quoted 10 lines
drivers/staging/rtl8712/Kconfig +2 -1
 	    If built as a module, it will be called r8712u.
 
 config R8712_TX_AGGR
 	bool "Realtek RTL8712U Transmit Aggregation code"
 	depends on R8712U && BROKEN
 	help
-	    This option provides transmit aggregation for the Realtek RTL8712 USB device.
+	    This option provides transmit aggregation for the
+	    Realtek RTL8712 USB device.
 

Why did you pick two different line lengths to wrap at for these two options?

Please be consistent.

greg k-h

#2 lore raw
Quoted 35 lines · Greg Kroah-Hartman
Quoted 20 lines · R Veera Kumar

Fixes two long line in Kconfig help.
Found using checkpatch.pl

---
 drivers/staging/rtl8712/Kconfig | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/staging/rtl8712/Kconfig +3 -1
index b6dcda77db1f..678bbeace823 100644
@@ -6,13 +6,16 @@ config R8712U
 	select WEXT_PRIV
 	select FW_LOADER
 	help
-	    This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130.
+	    This option adds the Realtek RTL8712 USB device such as the
+	    D-Link DWA-130.
+

drivers/staging/rtl8712/Kconfig config R8712U · line 20

Quoted 10 lines
drivers/staging/rtl8712/Kconfig +2 -1
 	    If built as a module, it will be called r8712u.
 
 config R8712_TX_AGGR
 	bool "Realtek RTL8712U Transmit Aggregation code"
 	depends on R8712U && BROKEN
 	help
-	    This option provides transmit aggregation for the Realtek RTL8712 USB device.
+	    This option provides transmit aggregation for the
+	    Realtek RTL8712 USB device.
 

Why did you pick two different line lengths to wrap at for these two options?

Quoted 2 lines

Please be consistent.

So should I resend the patch.

Quoted 1 line

greg k-h

Regards,
Veera

#3 lore raw
Quoted 36 lines · R Veera Kumar
Quoted 35 lines · Greg Kroah-Hartman
Quoted 20 lines · R Veera Kumar

Fixes two long line in Kconfig help.
Found using checkpatch.pl

---
 drivers/staging/rtl8712/Kconfig | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/staging/rtl8712/Kconfig +3 -1
index b6dcda77db1f..678bbeace823 100644
@@ -6,13 +6,16 @@ config R8712U
 	select WEXT_PRIV
 	select FW_LOADER
 	help
-	    This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130.
+	    This option adds the Realtek RTL8712 USB device such as the
+	    D-Link DWA-130.
+

drivers/staging/rtl8712/Kconfig config R8712U · line 20

Quoted 10 lines
drivers/staging/rtl8712/Kconfig +2 -1
 	    If built as a module, it will be called r8712u.
 
 config R8712_TX_AGGR
 	bool "Realtek RTL8712U Transmit Aggregation code"
 	depends on R8712U && BROKEN
 	help
-	    This option provides transmit aggregation for the Realtek RTL8712 USB device.
+	    This option provides transmit aggregation for the
+	    Realtek RTL8712 USB device.
 

Why did you pick two different line lengths to wrap at for these two options?

Quoted 4 lines
Quoted 2 lines

Please be consistent.

So should I resend the patch.

I can not take it as-is, so why wouldn't you fix it up and resend it? :)

thanks,

greg k-h