spi: meson-spicc: add support for AXG and G12A variants
Subsystems (3)
cover spi: meson-spicc: add support for AXG and G12A variants
The SPICC controller in Amlogic AXG & G12A is capable of driving the CLK/MOSI/SS signal lines through the idle state which avoid the signals floating in unexpected state, is capable of using linear clock divider to reach a much fine tuned range of clocks, while the old controller only uses a power of two clock divider, result at a more coarse clock range and finally is capable of running at 80M clock.
The SPICC controller in Amlogic G12A takes the source clock from a specific clock instead of the bus clock and has a different FIFO size and doesn't handle the RX Half interrupt the same way as GXL & AXG variants. Thus the burst management is simplified and takes in account a variable FIFO size.
Now the controller can support frequencies higher than 30MHz, we need the setup the I/O line delays in regard of the SPI clock frequency.
Neil Armstrong (7):
spi: meson-spicc: remove unused variables
spi: meson-spicc: support max 80MHz clock
spi: meson-spicc: add min sclk for each compatible
spi: meson-spicc: setup IO line delay
spi: meson-spicc: adapt burst handling for G12A support
dt-bindings: spi: amlogic,meson-gx-spicc: add Amlogic G12A compatible
spi: meson-spicc: add support for Amlogic G12A
Sunny Luo (2):
spi: meson-spicc: enhance output enable feature
spi: meson-spicc: add a linear clock divider support
.../bindings/spi/amlogic,meson-gx-spicc.yaml | 22 + drivers/spi/Kconfig | 1 + drivers/spi/spi-meson-spicc.c | 496 +++++++++++++----- 3 files changed, 392 insertions(+), 127 deletions(-)
Signature · 1 line
2.22.0
PATCH 1/9 spi: meson-spicc: remove unused variables
Remove unused variables from spicc data struct.
--- drivers/spi/spi-meson-spicc.c | 2 -- 1 file changed, 2 deletions(-)
drivers/spi/spi-meson-spicc.c +0 -2
@@ -130,9 +130,7 @@ struct meson_spicc_device {u8 *rx_buf;unsigned int bytes_per_word;unsigned long tx_remain; -unsigned long txb_remain;unsigned long rx_remain; -unsigned long rxb_remain;unsigned long xfer_remain;bool is_burst_end;bool is_last_burst;
Signature · 1 line
2.22.0
Mark Brown
maintainerApplied "spi: meson-spicc: remove unused variables" to the spi tree
The patch
spi: meson-spicc: remove unused variables
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
b9dfb20eed5c7dab37d6267a985dbe16df9e4293Mon Sep 17 00:00:00 2001
From: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/[email protected]>
Date: Thu, 12 Mar 2020 14:31:23 +0100
Subject: [PATCH] spi: meson-spicc: remove unused variables
Remove unused variables from spicc data struct.
--- drivers/spi/spi-meson-spicc.c | 2 -- 1 file changed, 2 deletions(-)
drivers/spi/spi-meson-spicc.c +0 -2
@@ -130,9 +130,7 @@ struct meson_spicc_device {u8 *rx_buf;unsigned int bytes_per_word;unsigned long tx_remain; -unsigned long txb_remain;unsigned long rx_remain; -unsigned long rxb_remain;unsigned long xfer_remain;bool is_burst_end;bool is_last_burst;
Signature · 1 line
2.20.1
PATCH 2/9 spi: meson-spicc: enhance output enable feature
In reply to Neil ArmstrongFrom: Sunny Luo <[email protected]>
The SPICC controller in Meson-AXG is capable of driving the CLK/MOSI/SS signal lines through the idle state (between two transmission operation), which avoid the signals floating in unexpected state.
--- drivers/spi/spi-meson-spicc.c | 53 +++++++++++++++++++++++++++++++++-- 1 file changed, 51 insertions(+), 2 deletions(-)
drivers/spi/spi-meson-spicc.c +51 -2
@@ -9,11 +9,13 @@#include <linux/bitfield.h> #include <linux/clk.h> +#include <linux/clk-provider.h> #include <linux/device.h> #include <linux/io.h> #include <linux/kernel.h> #include <linux/module.h> #include <linux/of.h> +#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/spi/spi.h> #include <linux/types.h>
@@ -113,12 +115,23 @@#define SPICC_DWADDR 0x24/* Write Address of DMA */ +#define SPICC_ENH_CTL0 0x38/* Enhanced Feature */ +#define SPICC_ENH_MOSI_OEN BIT(25) +#define SPICC_ENH_CLK_OEN BIT(26) +#define SPICC_ENH_CS_OEN BIT(27) +#define SPICC_ENH_CLK_CS_DELAY_EN BIT(28) +#define SPICC_ENH_MAIN_CLK_AO BIT(29) +#define writel_bits_relaxed (mask, val, addr) \ writel_relaxed((readl_relaxed(addr) & ~(mask)) | (val), addr)#define SPICC_BURST_MAX 16#define SPICC_FIFO_HALF 10 +struct meson_spicc_data { +bool has_oen; +}; +struct meson_spicc_device {struct spi_master *master;struct platform_device *pdev;
@@ -126,6 +139,7 @@ struct meson_spicc_device {struct clk *core;struct spi_message *message;struct spi_transfer *xfer; +const struct meson_spicc_data *data;u8 *tx_buf;u8 *rx_buf;unsigned int bytes_per_word;
@@ -136,6 +150,19 @@ struct meson_spicc_device {bool is_last_burst; }; +static void meson_spicc_oen_enable (struct meson_spicc_device *spicc) +{ +u32 conf; + +if (!spicc->data->has_oen) +return ; + + conf =readl_relaxed (spicc->base +SPICC_ENH_CTL0 ) | +SPICC_ENH_MOSI_OEN |SPICC_ENH_CLK_OEN |SPICC_ENH_CS_OEN ; + +writel_relaxed (conf, spicc->base +SPICC_ENH_CTL0 ); +} +static inline bool meson_spicc_txfull (struct meson_spicc_device *spicc) { return !!FIELD_GET(SPICC_TF,
@@ -489,6 +516,13 @@ static int meson_spicc_probe(struct platform_device *pdev) spicc =spi_master_get_devdata (master); spicc->master = master; + spicc->data =of_device_get_match_data (&pdev->dev); +if (!spicc->data) { +dev_err (&pdev->dev,"failed to get match data\n" ); + ret = -EINVAL ; + goto out_master; + } + spicc->pdev = pdev;platform_set_drvdata (pdev, spicc);
@@ -548,6 +582,8 @@ static int meson_spicc_probe(struct platform_device *pdev)else master->max_speed_hz = rate >>2 ; +meson_spicc_oen_enable (spicc); + ret =devm_spi_register_master (&pdev->dev, master);if (ret) {dev_err (&pdev->dev,"spi master registration failed\n" );
@@ -577,9 +613,22 @@ static int meson_spicc_remove(struct platform_device *pdev)return 0 ; } +static const struct meson_spicc_data meson_spicc_gx_data = { +}; + +static const struct meson_spicc_data meson_spicc_axg_data = { + .has_oen = true, +}; +static const struct of_device_id meson_spicc_of_match[] = { - { .compatible ="amlogic,meson-gx-spicc" , }, - { .compatible ="amlogic,meson-axg-spicc" , }, + { + .compatible ="amlogic,meson-gx-spicc" , + .data = &meson_spicc_gx_data, + }, + { + .compatible ="amlogic,meson-axg-spicc" , + .data = &meson_spicc_axg_data, + }, {/* sentinel */ } };MODULE_DEVICE_TABLE (of, meson_spicc_of_match);
Signature · 1 line
2.22.0
Mark Brown
maintainerApplied "spi: meson-spicc: enhance output enable feature" to the spi tree
The patch
spi: meson-spicc: enhance output enable feature
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
a6cda1f905b4a5442eecce94bda1e136f7e1e539Mon Sep 17 00:00:00 2001
From: Sunny Luo <[email protected]>
Date: Thu, 12 Mar 2020 14:31:24 +0100
Subject: [PATCH] spi: meson-spicc: enhance output enable feature
The SPICC controller in Meson-AXG is capable of driving the CLK/MOSI/SS signal lines through the idle state (between two transmission operation), which avoid the signals floating in unexpected state.
--- drivers/spi/spi-meson-spicc.c | 53 +++++++++++++++++++++++++++++++++-- 1 file changed, 51 insertions(+), 2 deletions(-)
drivers/spi/spi-meson-spicc.c +51 -2
@@ -9,11 +9,13 @@#include <linux/bitfield.h> #include <linux/clk.h> +#include <linux/clk-provider.h> #include <linux/device.h> #include <linux/io.h> #include <linux/kernel.h> #include <linux/module.h> #include <linux/of.h> +#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/spi/spi.h> #include <linux/types.h>
@@ -113,12 +115,23 @@#define SPICC_DWADDR 0x24/* Write Address of DMA */ +#define SPICC_ENH_CTL0 0x38/* Enhanced Feature */ +#define SPICC_ENH_MOSI_OEN BIT(25) +#define SPICC_ENH_CLK_OEN BIT(26) +#define SPICC_ENH_CS_OEN BIT(27) +#define SPICC_ENH_CLK_CS_DELAY_EN BIT(28) +#define SPICC_ENH_MAIN_CLK_AO BIT(29) +#define writel_bits_relaxed (mask, val, addr) \ writel_relaxed((readl_relaxed(addr) & ~(mask)) | (val), addr)#define SPICC_BURST_MAX 16#define SPICC_FIFO_HALF 10 +struct meson_spicc_data { +bool has_oen; +}; +struct meson_spicc_device {struct spi_master *master;struct platform_device *pdev;
@@ -126,6 +139,7 @@ struct meson_spicc_device {struct clk *core;struct spi_message *message;struct spi_transfer *xfer; +const struct meson_spicc_data *data;u8 *tx_buf;u8 *rx_buf;unsigned int bytes_per_word;
@@ -136,6 +150,19 @@ struct meson_spicc_device {bool is_last_burst; }; +static void meson_spicc_oen_enable (struct meson_spicc_device *spicc) +{ +u32 conf; + +if (!spicc->data->has_oen) +return ; + + conf =readl_relaxed (spicc->base +SPICC_ENH_CTL0 ) | +SPICC_ENH_MOSI_OEN |SPICC_ENH_CLK_OEN |SPICC_ENH_CS_OEN ; + +writel_relaxed (conf, spicc->base +SPICC_ENH_CTL0 ); +} +static inline bool meson_spicc_txfull (struct meson_spicc_device *spicc) { return !!FIELD_GET(SPICC_TF,
@@ -489,6 +516,13 @@ static int meson_spicc_probe(struct platform_device *pdev) spicc =spi_master_get_devdata (master); spicc->master = master; + spicc->data =of_device_get_match_data (&pdev->dev); +if (!spicc->data) { +dev_err (&pdev->dev,"failed to get match data\n" ); + ret = -EINVAL ; + goto out_master; + } + spicc->pdev = pdev;platform_set_drvdata (pdev, spicc);
@@ -548,6 +582,8 @@ static int meson_spicc_probe(struct platform_device *pdev)else master->max_speed_hz = rate >>2 ; +meson_spicc_oen_enable (spicc); + ret =devm_spi_register_master (&pdev->dev, master);if (ret) {dev_err (&pdev->dev,"spi master registration failed\n" );
@@ -577,9 +613,22 @@ static int meson_spicc_remove(struct platform_device *pdev)return 0 ; } +static const struct meson_spicc_data meson_spicc_gx_data = { +}; + +static const struct meson_spicc_data meson_spicc_axg_data = { + .has_oen = true, +}; +static const struct of_device_id meson_spicc_of_match[] = { - { .compatible ="amlogic,meson-gx-spicc" , }, - { .compatible ="amlogic,meson-axg-spicc" , }, + { + .compatible ="amlogic,meson-gx-spicc" , + .data = &meson_spicc_gx_data, + }, + { + .compatible ="amlogic,meson-axg-spicc" , + .data = &meson_spicc_axg_data, + }, {/* sentinel */ } };MODULE_DEVICE_TABLE (of, meson_spicc_of_match);
Signature · 1 line
2.20.1
PATCH 3/9 spi: meson-spicc: add a linear clock divider support
In reply to Neil ArmstrongFrom: Sunny Luo <[email protected]>
The SPICC controller in Meson-AXG SoC is capable of using a linear clock divider to reach a much fine tuned range of clocks, while the old controller only use a power of two clock divider, result at a more coarse clock range.
Also convert the clock registration into Common Clock Framework.
--- drivers/spi/Kconfig | 1 + drivers/spi/spi-meson-spicc.c | 204 +++++++++++++++++++++++++++------- 2 files changed, 165 insertions(+), 40 deletions(-)
drivers/spi/Kconfig +1 -0
@@ -415,6 +415,7 @@ config SPI_FSL_ESPI config SPI_MESON_SPICC tristate "Amlogic Meson SPICC controller" + depends on COMMON_CLK depends on ARCH_MESON || COMPILE_TEST help This enables master mode support for the SPICC (SPI communication
drivers/spi/spi-meson-spicc.c +164 -40
270 lines not on this page · raw message
Signature · 1 line
2.22.0
Mark Brown
maintainerApplied "spi: meson-spicc: add a linear clock divider support" to the spi tree
The patch
spi: meson-spicc: add a linear clock divider support
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
3e0cf4d3fc2985beee011e9a1bbb8374fc02c0a0Mon Sep 17 00:00:00 2001
From: Sunny Luo <[email protected]>
Date: Thu, 12 Mar 2020 14:31:25 +0100
Subject: [PATCH] spi: meson-spicc: add a linear clock divider support
The SPICC controller in Meson-AXG SoC is capable of using a linear clock divider to reach a much fine tuned range of clocks, while the old controller only use a power of two clock divider, result at a more coarse clock range.
Also convert the clock registration into Common Clock Framework.
--- drivers/spi/Kconfig | 1 + drivers/spi/spi-meson-spicc.c | 204 +++++++++++++++++++++++++++------- 2 files changed, 165 insertions(+), 40 deletions(-)
drivers/spi/Kconfig +1 -0
@@ -428,6 +428,7 @@ config SPI_FSL_ESPI config SPI_MESON_SPICC tristate "Amlogic Meson SPICC controller" + depends on COMMON_CLK depends on ARCH_MESON || COMPILE_TEST help This enables master mode support for the SPICC (SPI communication
drivers/spi/spi-meson-spicc.c +164 -40
270 lines not on this page · raw message
Signature · 1 line
2.20.1
PATCH 4/9 spi: meson-spicc: support max 80MHz clock
In reply to Neil ArmstrongThe SPICC controller in Meson-AXG is capable of running at 80M clock. The ASIC IP is improved and the clock is actually running higher than previous old SoCs.
--- drivers/spi/spi-meson-spicc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/spi/spi-meson-spicc.c +6 -6
@@ -35,7 +35,6 @@* to have a CS go down over the full transfer */ -#define SPICC_MAX_FREQ 30000000#define SPICC_MAX_BURST 128/* Register Map */
@@ -132,6 +131,7 @@#define SPICC_FIFO_HALF 10struct meson_spicc_data { +unsigned int max_speed_hz;bool has_oen;bool has_enhance_clk_div; };
@@ -693,11 +693,9 @@ static int meson_spicc_probe(struct platform_device *pdev) master->transfer_one = meson_spicc_transfer_one; master->use_gpio_descriptors = true; -/* Setup max rate according to the Meson GX datasheet */ -if ((rate >>2 ) >SPICC_MAX_FREQ ) - master->max_speed_hz =SPICC_MAX_FREQ ; -else - master->max_speed_hz = rate >>2 ; +/* Setup max rate according to the Meson datasheet */ + master->max_speed_hz = min_t(unsigned int, rate >> 1, + spicc->data->max_speed_hz);meson_spicc_oen_enable (spicc);
@@ -737,9 +735,11 @@ static int meson_spicc_remove(struct platform_device *pdev) }static const struct meson_spicc_data meson_spicc_gx_data = { + .max_speed_hz =30000000 , };static const struct meson_spicc_data meson_spicc_axg_data = { + .max_speed_hz =80000000 , .has_oen = true, .has_enhance_clk_div = true, };
Signature · 1 line
2.22.0
Mark Brown
maintainerApplied "spi: meson-spicc: support max 80MHz clock" to the spi tree
The patch
spi: meson-spicc: support max 80MHz clock
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
3196816ff64bb3a21fbda89e7355b6b87c3f50a0Mon Sep 17 00:00:00 2001
From: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/[email protected]>
Date: Thu, 12 Mar 2020 14:31:26 +0100
Subject: [PATCH] spi: meson-spicc: support max 80MHz clock
The SPICC controller in Meson-AXG is capable of running at 80M clock. The ASIC IP is improved and the clock is actually running higher than previous old SoCs.
--- drivers/spi/spi-meson-spicc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/spi/spi-meson-spicc.c +6 -6
@@ -35,7 +35,6 @@* to have a CS go down over the full transfer */ -#define SPICC_MAX_FREQ 30000000#define SPICC_MAX_BURST 128/* Register Map */
@@ -132,6 +131,7 @@#define SPICC_FIFO_HALF 10struct meson_spicc_data { +unsigned int max_speed_hz;bool has_oen;bool has_enhance_clk_div; };
@@ -693,11 +693,9 @@ static int meson_spicc_probe(struct platform_device *pdev) master->transfer_one = meson_spicc_transfer_one; master->use_gpio_descriptors = true; -/* Setup max rate according to the Meson GX datasheet */ -if ((rate >>2 ) >SPICC_MAX_FREQ ) - master->max_speed_hz =SPICC_MAX_FREQ ; -else - master->max_speed_hz = rate >>2 ; +/* Setup max rate according to the Meson datasheet */ + master->max_speed_hz = min_t(unsigned int, rate >> 1, + spicc->data->max_speed_hz);meson_spicc_oen_enable (spicc);
@@ -737,9 +735,11 @@ static int meson_spicc_remove(struct platform_device *pdev) }static const struct meson_spicc_data meson_spicc_gx_data = { + .max_speed_hz =30000000 , };static const struct meson_spicc_data meson_spicc_axg_data = { + .max_speed_hz =80000000 , .has_oen = true, .has_enhance_clk_div = true, };
Signature · 1 line
2.20.1
PATCH 5/9 spi: meson-spicc: add min sclk for each compatible
In reply to Neil ArmstrongThe G12A SPICC controller variant takes the source clock from a specific clock instead of the bus clock.
The minimal clock calculus won't work with the G12A support, thus add the minimal supported clock for each variant and pass this to the SPI core.
--- drivers/spi/spi-meson-spicc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/spi/spi-meson-spicc.c +4 -1
@@ -132,6 +132,7 @@struct meson_spicc_data {unsigned int max_speed_hz; +unsigned int min_speed_hz;bool has_oen;bool has_enhance_clk_div; };
@@ -685,7 +686,7 @@ static int meson_spicc_probe(struct platform_device *pdev)SPI_BPW_MASK (16 ) |SPI_BPW_MASK (8 ); master->flags = (SPI_MASTER_MUST_RX |SPI_MASTER_MUST_TX ); - master->min_speed_hz = rate >>9 ; + master->min_speed_hz = spicc->data->min_speed_hz; master->setup = meson_spicc_setup; master->cleanup = meson_spicc_cleanup; master->prepare_message = meson_spicc_prepare_message;
@@ -736,10 +737,12 @@ static int meson_spicc_remove(struct platform_device *pdev)static const struct meson_spicc_data meson_spicc_gx_data = { .max_speed_hz =30000000 , + .min_speed_hz =325000 , };static const struct meson_spicc_data meson_spicc_axg_data = { .max_speed_hz =80000000 , + .min_speed_hz =325000 , .has_oen = true, .has_enhance_clk_div = true, };
Signature · 1 line
2.22.0
Mark Brown
maintainerApplied "spi: meson-spicc: add min sclk for each compatible" to the spi tree
The patch
spi: meson-spicc: add min sclk for each compatible
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
8791068dab979819e01f41736953b9b2e462867bMon Sep 17 00:00:00 2001
From: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/[email protected]>
Date: Thu, 12 Mar 2020 14:31:27 +0100
Subject: [PATCH] spi: meson-spicc: add min sclk for each compatible
The G12A SPICC controller variant takes the source clock from a specific clock instead of the bus clock.
The minimal clock calculus won't work with the G12A support, thus add the minimal supported clock for each variant and pass this to the SPI core.
--- drivers/spi/spi-meson-spicc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/spi/spi-meson-spicc.c +4 -1
@@ -132,6 +132,7 @@struct meson_spicc_data {unsigned int max_speed_hz; +unsigned int min_speed_hz;bool has_oen;bool has_enhance_clk_div; };
@@ -685,7 +686,7 @@ static int meson_spicc_probe(struct platform_device *pdev)SPI_BPW_MASK (16 ) |SPI_BPW_MASK (8 ); master->flags = (SPI_MASTER_MUST_RX |SPI_MASTER_MUST_TX ); - master->min_speed_hz = rate >>9 ; + master->min_speed_hz = spicc->data->min_speed_hz; master->setup = meson_spicc_setup; master->cleanup = meson_spicc_cleanup; master->prepare_message = meson_spicc_prepare_message;
@@ -736,10 +737,12 @@ static int meson_spicc_remove(struct platform_device *pdev)static const struct meson_spicc_data meson_spicc_gx_data = { .max_speed_hz =30000000 , + .min_speed_hz =325000 , };static const struct meson_spicc_data meson_spicc_axg_data = { .max_speed_hz =80000000 , + .min_speed_hz =325000 , .has_oen = true, .has_enhance_clk_div = true, };
Signature · 1 line
2.20.1
PATCH 6/9 spi: meson-spicc: setup IO line delay
In reply to Neil ArmstrongNow the controller can support frequencies higher than 30MHz, we need the setup the I/O line delays in regard of the SPI clock frequency.
--- drivers/spi/spi-meson-spicc.c | 61 ++++++++++++++++++++++++++++++++++- 1 file changed, 60 insertions(+), 1 deletion(-)
drivers/spi/spi-meson-spicc.c +60 -1
@@ -106,7 +106,21 @@#define SPICC_SWAP_RO BIT(14)/* RX FIFO Data Swap Read-Only */ #define SPICC_SWAP_W1 BIT(15)/* RX FIFO Data Swap Write-Only */ #define SPICC_DLYCTL_RO_MASK GENMASK(20, 15)/* Delay Control Read-Only */ -#define SPICC_DLYCTL_W1_MASK GENMASK(21, 16)/* Delay Control Write-Only */ +#define SPICC_MO_DELAY_MASK GENMASK(17, 16)/* Master Output Delay */ +#define SPICC_MO_NO_DELAY 0 +#define SPICC_MO_DELAY_1_CYCLE 1 +#define SPICC_MO_DELAY_2_CYCLE 2 +#define SPICC_MO_DELAY_3_CYCLE 3 +#define SPICC_MI_DELAY_MASK GENMASK(19, 18)/* Master Input Delay */ +#define SPICC_MI_NO_DELAY 0 +#define SPICC_MI_DELAY_1_CYCLE 1 +#define SPICC_MI_DELAY_2_CYCLE 2 +#define SPICC_MI_DELAY_3_CYCLE 3 +#define SPICC_MI_CAP_DELAY_MASK GENMASK(21, 20)/* Master Capture Delay */ +#define SPICC_CAP_AHEAD_2_CYCLE 0 +#define SPICC_CAP_AHEAD_1_CYCLE 1 +#define SPICC_CAP_NO_DELAY 2 +#define SPICC_CAP_DELAY_1_CYCLE 3#define SPICC_FIFORST_RO_MASK GENMASK(22, 21)/* FIFO Softreset Read-Only */ #define SPICC_FIFORST_W1_MASK GENMASK(23, 22)/* FIFO Softreset Write-Only */
@@ -328,6 +342,49 @@ static irqreturn_t meson_spicc_irq(int irq, void *data)return IRQ_HANDLED ; } +static void meson_spicc_auto_io_delay (struct meson_spicc_device *spicc) +{ +u32 div, hz; +u32 mi_delay, cap_delay; +u32 conf; + +if (spicc->data->has_enhance_clk_div) { + div =FIELD_GET (SPICC_ENH_DATARATE_MASK , +readl_relaxed (spicc->base +SPICC_ENH_CTL0 )); + div++; + div <<=1 ; + }else { + div =FIELD_GET (SPICC_DATARATE_MASK , +readl_relaxed (spicc->base +SPICC_CONREG )); + div +=2 ; + div =1 << div; + } + + mi_delay =SPICC_MI_NO_DELAY ; + cap_delay =SPICC_CAP_AHEAD_2_CYCLE ; + hz =clk_get_rate (spicc->clk); + +if (hz >=100000000 ) + cap_delay =SPICC_CAP_DELAY_1_CYCLE ; +else if (hz >=80000000 ) + cap_delay =SPICC_CAP_NO_DELAY ; +else if (hz >=40000000 ) + cap_delay =SPICC_CAP_AHEAD_1_CYCLE ; +else if (div >=16 ) + mi_delay =SPICC_MI_DELAY_3_CYCLE ; +else if (div >=8 ) + mi_delay =SPICC_MI_DELAY_2_CYCLE ; +else if (div >=6 ) + mi_delay =SPICC_MI_DELAY_1_CYCLE ; + + conf =readl_relaxed (spicc->base +SPICC_TESTREG ); + conf &= ~(SPICC_MO_DELAY_MASK |SPICC_MI_DELAY_MASK + |SPICC_MI_CAP_DELAY_MASK ); + conf |=FIELD_PREP (SPICC_MI_DELAY_MASK , mi_delay); + conf |=FIELD_PREP (SPICC_MI_CAP_DELAY_MASK , cap_delay); +writel_relaxed (conf, spicc->base +SPICC_TESTREG ); +} +static void meson_spicc_setup_xfer (struct meson_spicc_device *spicc,struct spi_transfer *xfer) {
@@ -346,6 +403,8 @@ static void meson_spicc_setup_xfer(struct meson_spicc_device *spicc,writel_relaxed (conf, spicc->base +SPICC_CONREG );clk_set_rate (spicc->clk, xfer->speed_hz); + +meson_spicc_auto_io_delay (spicc); } static int meson_spicc_transfer_one(struct spi_master *master,
Signature · 1 line
2.22.0
Mark Brown
maintainerApplied "spi: meson-spicc: setup IO line delay" to the spi tree
The patch
spi: meson-spicc: setup IO line delay
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
f27bff479ea3de9ca325d4f8e8c8b49a87d6b0c5Mon Sep 17 00:00:00 2001
From: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/[email protected]>
Date: Thu, 12 Mar 2020 14:31:28 +0100
Subject: [PATCH] spi: meson-spicc: setup IO line delay
Now the controller can support frequencies higher than 30MHz, we need the setup the I/O line delays in regard of the SPI clock frequency.
--- drivers/spi/spi-meson-spicc.c | 61 ++++++++++++++++++++++++++++++++++- 1 file changed, 60 insertions(+), 1 deletion(-)
drivers/spi/spi-meson-spicc.c +60 -1
@@ -106,7 +106,21 @@#define SPICC_SWAP_RO BIT(14)/* RX FIFO Data Swap Read-Only */ #define SPICC_SWAP_W1 BIT(15)/* RX FIFO Data Swap Write-Only */ #define SPICC_DLYCTL_RO_MASK GENMASK(20, 15)/* Delay Control Read-Only */ -#define SPICC_DLYCTL_W1_MASK GENMASK(21, 16)/* Delay Control Write-Only */ +#define SPICC_MO_DELAY_MASK GENMASK(17, 16)/* Master Output Delay */ +#define SPICC_MO_NO_DELAY 0 +#define SPICC_MO_DELAY_1_CYCLE 1 +#define SPICC_MO_DELAY_2_CYCLE 2 +#define SPICC_MO_DELAY_3_CYCLE 3 +#define SPICC_MI_DELAY_MASK GENMASK(19, 18)/* Master Input Delay */ +#define SPICC_MI_NO_DELAY 0 +#define SPICC_MI_DELAY_1_CYCLE 1 +#define SPICC_MI_DELAY_2_CYCLE 2 +#define SPICC_MI_DELAY_3_CYCLE 3 +#define SPICC_MI_CAP_DELAY_MASK GENMASK(21, 20)/* Master Capture Delay */ +#define SPICC_CAP_AHEAD_2_CYCLE 0 +#define SPICC_CAP_AHEAD_1_CYCLE 1 +#define SPICC_CAP_NO_DELAY 2 +#define SPICC_CAP_DELAY_1_CYCLE 3#define SPICC_FIFORST_RO_MASK GENMASK(22, 21)/* FIFO Softreset Read-Only */ #define SPICC_FIFORST_W1_MASK GENMASK(23, 22)/* FIFO Softreset Write-Only */
@@ -328,6 +342,49 @@ static irqreturn_t meson_spicc_irq(int irq, void *data)return IRQ_HANDLED ; } +static void meson_spicc_auto_io_delay (struct meson_spicc_device *spicc) +{ +u32 div, hz; +u32 mi_delay, cap_delay; +u32 conf; + +if (spicc->data->has_enhance_clk_div) { + div =FIELD_GET (SPICC_ENH_DATARATE_MASK , +readl_relaxed (spicc->base +SPICC_ENH_CTL0 )); + div++; + div <<=1 ; + }else { + div =FIELD_GET (SPICC_DATARATE_MASK , +readl_relaxed (spicc->base +SPICC_CONREG )); + div +=2 ; + div =1 << div; + } + + mi_delay =SPICC_MI_NO_DELAY ; + cap_delay =SPICC_CAP_AHEAD_2_CYCLE ; + hz =clk_get_rate (spicc->clk); + +if (hz >=100000000 ) + cap_delay =SPICC_CAP_DELAY_1_CYCLE ; +else if (hz >=80000000 ) + cap_delay =SPICC_CAP_NO_DELAY ; +else if (hz >=40000000 ) + cap_delay =SPICC_CAP_AHEAD_1_CYCLE ; +else if (div >=16 ) + mi_delay =SPICC_MI_DELAY_3_CYCLE ; +else if (div >=8 ) + mi_delay =SPICC_MI_DELAY_2_CYCLE ; +else if (div >=6 ) + mi_delay =SPICC_MI_DELAY_1_CYCLE ; + + conf =readl_relaxed (spicc->base +SPICC_TESTREG ); + conf &= ~(SPICC_MO_DELAY_MASK |SPICC_MI_DELAY_MASK + |SPICC_MI_CAP_DELAY_MASK ); + conf |=FIELD_PREP (SPICC_MI_DELAY_MASK , mi_delay); + conf |=FIELD_PREP (SPICC_MI_CAP_DELAY_MASK , cap_delay); +writel_relaxed (conf, spicc->base +SPICC_TESTREG ); +} +static void meson_spicc_setup_xfer (struct meson_spicc_device *spicc,struct spi_transfer *xfer) {
@@ -346,6 +403,8 @@ static void meson_spicc_setup_xfer(struct meson_spicc_device *spicc,writel_relaxed (conf, spicc->base +SPICC_CONREG );clk_set_rate (spicc->clk, xfer->speed_hz); + +meson_spicc_auto_io_delay (spicc); } static int meson_spicc_transfer_one(struct spi_master *master,
Signature · 1 line
2.20.1
PATCH 7/9 spi: meson-spicc: adapt burst handling for G12A support
In reply to Neil ArmstrongThe G12A SPICC controller variant has a different FIFO size and doesn't handle the RX Half interrupt the same way as GXL & AXG variants.
Thus simplify the burst management and take in account a variable FIFO size.
--- drivers/spi/spi-meson-spicc.c | 129 +++++++++++++--------------------- 1 file changed, 50 insertions(+), 79 deletions(-)
drivers/spi/spi-meson-spicc.c +50 -79
@@ -141,12 +141,10 @@#define writel_bits_relaxed (mask, val, addr) \ writel_relaxed((readl_relaxed(addr) & ~(mask)) | (val), addr) -#define SPICC_BURST_MAX 16 -#define SPICC_FIFO_HALF 10 -struct meson_spicc_data {unsigned int max_speed_hz;unsigned int min_speed_hz; +unsigned int fifo_size;bool has_oen;bool has_enhance_clk_div; };
@@ -166,8 +164,6 @@ struct meson_spicc_device {unsigned long tx_remain;unsigned long rx_remain;unsigned long xfer_remain; -bool is_burst_end; -bool is_last_burst; };static void meson_spicc_oen_enable (struct meson_spicc_device *spicc)
@@ -191,7 +187,7 @@ static inline bool meson_spicc_txfull(struct meson_spicc_device *spicc)static inline bool meson_spicc_rxready (struct meson_spicc_device *spicc) { -return FIELD_GET (SPICC_RH |SPICC_RR |SPICC_RF_EN , +return FIELD_GET (SPICC_RH |SPICC_RR |SPICC_RF ,readl_relaxed (spicc->base +SPICC_STATREG )); }
@@ -246,34 +242,22 @@ static inline void meson_spicc_tx(struct meson_spicc_device *spicc) spicc->base + SPICC_TXDATA); } -static inline u32 meson_spicc_setup_rx_irq (struct meson_spicc_device *spicc, -u32 irq_ctrl) +static inline void meson_spicc_setup_burst (struct meson_spicc_device *spicc) { -if (spicc->rx_remain >SPICC_FIFO_HALF ) - irq_ctrl |=SPICC_RH_EN ; -else - irq_ctrl |=SPICC_RR_EN ; - -return irq_ctrl; -} -static inline void meson_spicc_setup_burst (struct meson_spicc_device *spicc, -unsigned int burst_len) -{ + unsigned int burst_len = min_t(unsigned int, + spicc->xfer_remain / + spicc->bytes_per_word, + spicc->data->fifo_size);/* Setup Xfer variables */ spicc->tx_remain = burst_len; spicc->rx_remain = burst_len; spicc->xfer_remain -= burst_len * spicc->bytes_per_word; - spicc->is_burst_end = false; -if (burst_len <SPICC_BURST_MAX || !spicc->xfer_remain) - spicc->is_last_burst = true; -else - spicc->is_last_burst = false;/* Setup burst length */ writel_bits_relaxed (SPICC_BURSTLENGTH_MASK ,FIELD_PREP (SPICC_BURSTLENGTH_MASK , - burst_len), + burst_len -1 ), spicc->base +SPICC_CONREG );/* Fill TX FIFO */
@@ -283,61 +267,26 @@ static inline void meson_spicc_setup_burst(struct meson_spicc_device *spicc,static irqreturn_t meson_spicc_irq (int irq,void *data) {struct meson_spicc_device *spicc = (void *) data; -u32 ctrl =readl_relaxed (spicc->base +SPICC_INTREG ); -u32 stat =readl_relaxed (spicc->base +SPICC_STATREG ) & ctrl; - ctrl &= ~(SPICC_RH_EN |SPICC_RR_EN ); +writel_bits_relaxed (SPICC_TC ,SPICC_TC , spicc->base +SPICC_STATREG );/* Empty RX FIFO */ meson_spicc_rx (spicc); -/* Enable TC interrupt since we transferred everything */ -if (!spicc->tx_remain && !spicc->rx_remain) { - spicc->is_burst_end = true; - -/* Enable TC interrupt */ - ctrl |=SPICC_TC_EN ; - -/* Reload IRQ status */ - stat =readl_relaxed (spicc->base +SPICC_STATREG ) & ctrl; - } - -/* Check transfer complete */ -if ((stat &SPICC_TC ) && spicc->is_burst_end) { -unsigned int burst_len; - -/* Clear TC bit */ -writel_relaxed (SPICC_TC , spicc->base +SPICC_STATREG ); - -/* Disable TC interrupt */ - ctrl &= ~SPICC_TC_EN ; - -if (spicc->is_last_burst) { -/* Disable all IRQs */ -writel (0 , spicc->base +SPICC_INTREG ); - -spi_finalize_current_transfer (spicc->master); +if (!spicc->xfer_remain) { +/* Disable all IRQs */ +writel (0 , spicc->base +SPICC_INTREG ); -return IRQ_HANDLED ; - } +spi_finalize_current_transfer (spicc->master); - burst_len = min_t(unsigned int, - spicc->xfer_remain / spicc->bytes_per_word, -SPICC_BURST_MAX ); - -/* Setup burst */ -meson_spicc_setup_burst (spicc, burst_len); - -/* Restart burst */ -writel_bits_relaxed (SPICC_XCH ,SPICC_XCH , - spicc->base +SPICC_CONREG ); +return IRQ_HANDLED ; } -/* Setup RX interrupt trigger */ - ctrl =meson_spicc_setup_rx_irq (spicc, ctrl); +/* Setup burst */ +meson_spicc_setup_burst (spicc); -/* Reconfigure interrupts */ -writel (ctrl, spicc->base +SPICC_INTREG ); +/* Start burst */ +writel_bits_relaxed (SPICC_XCH ,SPICC_XCH , spicc->base +SPICC_CONREG );return IRQ_HANDLED ; }
@@ -405,6 +354,28 @@ static void meson_spicc_setup_xfer(struct meson_spicc_device *spicc,clk_set_rate (spicc->clk, xfer->speed_hz);meson_spicc_auto_io_delay (spicc); + +writel_relaxed (0 , spicc->base +SPICC_DMAREG ); +} + +static void meson_spicc_reset_fifo (struct meson_spicc_device *spicc) +{ +u32 data; + +if (spicc->data->has_oen) +writel_bits_relaxed (SPICC_ENH_MAIN_CLK_AO , +SPICC_ENH_MAIN_CLK_AO , + spicc->base +SPICC_ENH_CTL0 ); + +writel_bits_relaxed (SPICC_FIFORST_W1_MASK ,SPICC_FIFORST_W1_MASK , + spicc->base +SPICC_TESTREG ); + +while (meson_spicc_rxready (spicc)) + data =readl_relaxed (spicc->base +SPICC_RXDATA ); + +if (spicc->data->has_oen) +writel_bits_relaxed (SPICC_ENH_MAIN_CLK_AO ,0 , + spicc->base +SPICC_ENH_CTL0 ); } static int meson_spicc_transfer_one(struct spi_master *master,
@@ -412,8 +383,6 @@ static int meson_spicc_transfer_one(struct spi_master *master, struct spi_transfer *xfer) {struct meson_spicc_device *spicc =spi_master_get_devdata (master); -unsigned int burst_len; -u32 irq =0 ;/* Store current transfer */ spicc->xfer = xfer;
@@ -427,22 +396,22 @@ static int meson_spicc_transfer_one(struct spi_master *master, spicc->bytes_per_word =DIV_ROUND_UP (spicc->xfer->bits_per_word,8 ); +if (xfer->len % spicc->bytes_per_word) +return -EINVAL ; +/* Setup transfer parameters */ meson_spicc_setup_xfer (spicc, xfer); - burst_len = min_t(unsigned int, - spicc->xfer_remain / spicc->bytes_per_word, -SPICC_BURST_MAX ); - -meson_spicc_setup_burst (spicc, burst_len); +meson_spicc_reset_fifo (spicc); - irq =meson_spicc_setup_rx_irq (spicc, irq); +/* Setup burst */ +meson_spicc_setup_burst (spicc);/* Start burst */ writel_bits_relaxed (SPICC_XCH ,SPICC_XCH , spicc->base +SPICC_CONREG );/* Enable interrupts */ -writel_relaxed (irq, spicc->base +SPICC_INTREG ); +writel_relaxed (SPICC_TC_EN , spicc->base +SPICC_INTREG );return 1 ; }
@@ -499,7 +468,7 @@ static int meson_spicc_prepare_message(struct spi_master *master,/* Setup no wait cycles by default */ writel_relaxed (0 , spicc->base +SPICC_PERIODREG ); -writel_bits_relaxed (BIT (24 ),BIT (24 ), spicc->base +SPICC_TESTREG ); +writel_bits_relaxed (SPICC_LBC_W1 ,0 , spicc->base +SPICC_TESTREG );return 0 ; }
@@ -797,11 +766,13 @@ static int meson_spicc_remove(struct platform_device *pdev)static const struct meson_spicc_data meson_spicc_gx_data = { .max_speed_hz =30000000 , .min_speed_hz =325000 , + .fifo_size =16 , };static const struct meson_spicc_data meson_spicc_axg_data = { .max_speed_hz =80000000 , .min_speed_hz =325000 , + .fifo_size =16 , .has_oen = true, .has_enhance_clk_div = true, };
Signature · 1 line
2.22.0
Mark Brown
maintainerApplied "spi: meson-spicc: adapt burst handling for G12A support" to the spi tree
The patch
spi: meson-spicc: adapt burst handling for G12A support
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
0eb707ac7dd7a4329d93d47feada6c9bb5ea8ee9Mon Sep 17 00:00:00 2001
From: Neil Armstrong <[email protected]>
Date: Thu, 12 Mar 2020 14:31:29 +0100
Subject: [PATCH] spi: meson-spicc: adapt burst handling for G12A support
The G12A SPICC controller variant has a different FIFO size and doesn't handle the RX Half interrupt the same way as GXL & AXG variants.
Thus simplify the burst management and take in account a variable FIFO size.
--- drivers/spi/spi-meson-spicc.c | 129 +++++++++++++--------------------- 1 file changed, 50 insertions(+), 79 deletions(-)
drivers/spi/spi-meson-spicc.c +50 -79
@@ -141,12 +141,10 @@#define writel_bits_relaxed (mask, val, addr) \ writel_relaxed((readl_relaxed(addr) & ~(mask)) | (val), addr) -#define SPICC_BURST_MAX 16 -#define SPICC_FIFO_HALF 10 -struct meson_spicc_data {unsigned int max_speed_hz;unsigned int min_speed_hz; +unsigned int fifo_size;bool has_oen;bool has_enhance_clk_div; };
@@ -166,8 +164,6 @@ struct meson_spicc_device {unsigned long tx_remain;unsigned long rx_remain;unsigned long xfer_remain; -bool is_burst_end; -bool is_last_burst; };static void meson_spicc_oen_enable (struct meson_spicc_device *spicc)
@@ -191,7 +187,7 @@ static inline bool meson_spicc_txfull(struct meson_spicc_device *spicc)static inline bool meson_spicc_rxready (struct meson_spicc_device *spicc) { -return FIELD_GET (SPICC_RH |SPICC_RR |SPICC_RF_EN , +return FIELD_GET (SPICC_RH |SPICC_RR |SPICC_RF ,readl_relaxed (spicc->base +SPICC_STATREG )); }
@@ -246,34 +242,22 @@ static inline void meson_spicc_tx(struct meson_spicc_device *spicc) spicc->base + SPICC_TXDATA); } -static inline u32 meson_spicc_setup_rx_irq (struct meson_spicc_device *spicc, -u32 irq_ctrl) +static inline void meson_spicc_setup_burst (struct meson_spicc_device *spicc) { -if (spicc->rx_remain >SPICC_FIFO_HALF ) - irq_ctrl |=SPICC_RH_EN ; -else - irq_ctrl |=SPICC_RR_EN ; - -return irq_ctrl; -} -static inline void meson_spicc_setup_burst (struct meson_spicc_device *spicc, -unsigned int burst_len) -{ + unsigned int burst_len = min_t(unsigned int, + spicc->xfer_remain / + spicc->bytes_per_word, + spicc->data->fifo_size);/* Setup Xfer variables */ spicc->tx_remain = burst_len; spicc->rx_remain = burst_len; spicc->xfer_remain -= burst_len * spicc->bytes_per_word; - spicc->is_burst_end = false; -if (burst_len <SPICC_BURST_MAX || !spicc->xfer_remain) - spicc->is_last_burst = true; -else - spicc->is_last_burst = false;/* Setup burst length */ writel_bits_relaxed (SPICC_BURSTLENGTH_MASK ,FIELD_PREP (SPICC_BURSTLENGTH_MASK , - burst_len), + burst_len -1 ), spicc->base +SPICC_CONREG );/* Fill TX FIFO */
@@ -283,61 +267,26 @@ static inline void meson_spicc_setup_burst(struct meson_spicc_device *spicc,static irqreturn_t meson_spicc_irq (int irq,void *data) {struct meson_spicc_device *spicc = (void *) data; -u32 ctrl =readl_relaxed (spicc->base +SPICC_INTREG ); -u32 stat =readl_relaxed (spicc->base +SPICC_STATREG ) & ctrl; - ctrl &= ~(SPICC_RH_EN |SPICC_RR_EN ); +writel_bits_relaxed (SPICC_TC ,SPICC_TC , spicc->base +SPICC_STATREG );/* Empty RX FIFO */ meson_spicc_rx (spicc); -/* Enable TC interrupt since we transferred everything */ -if (!spicc->tx_remain && !spicc->rx_remain) { - spicc->is_burst_end = true; - -/* Enable TC interrupt */ - ctrl |=SPICC_TC_EN ; - -/* Reload IRQ status */ - stat =readl_relaxed (spicc->base +SPICC_STATREG ) & ctrl; - } - -/* Check transfer complete */ -if ((stat &SPICC_TC ) && spicc->is_burst_end) { -unsigned int burst_len; - -/* Clear TC bit */ -writel_relaxed (SPICC_TC , spicc->base +SPICC_STATREG ); - -/* Disable TC interrupt */ - ctrl &= ~SPICC_TC_EN ; - -if (spicc->is_last_burst) { -/* Disable all IRQs */ -writel (0 , spicc->base +SPICC_INTREG ); - -spi_finalize_current_transfer (spicc->master); +if (!spicc->xfer_remain) { +/* Disable all IRQs */ +writel (0 , spicc->base +SPICC_INTREG ); -return IRQ_HANDLED ; - } +spi_finalize_current_transfer (spicc->master); - burst_len = min_t(unsigned int, - spicc->xfer_remain / spicc->bytes_per_word, -SPICC_BURST_MAX ); - -/* Setup burst */ -meson_spicc_setup_burst (spicc, burst_len); - -/* Restart burst */ -writel_bits_relaxed (SPICC_XCH ,SPICC_XCH , - spicc->base +SPICC_CONREG ); +return IRQ_HANDLED ; } -/* Setup RX interrupt trigger */ - ctrl =meson_spicc_setup_rx_irq (spicc, ctrl); +/* Setup burst */ +meson_spicc_setup_burst (spicc); -/* Reconfigure interrupts */ -writel (ctrl, spicc->base +SPICC_INTREG ); +/* Start burst */ +writel_bits_relaxed (SPICC_XCH ,SPICC_XCH , spicc->base +SPICC_CONREG );return IRQ_HANDLED ; }
@@ -405,6 +354,28 @@ static void meson_spicc_setup_xfer(struct meson_spicc_device *spicc,clk_set_rate (spicc->clk, xfer->speed_hz);meson_spicc_auto_io_delay (spicc); + +writel_relaxed (0 , spicc->base +SPICC_DMAREG ); +} + +static void meson_spicc_reset_fifo (struct meson_spicc_device *spicc) +{ +u32 data; + +if (spicc->data->has_oen) +writel_bits_relaxed (SPICC_ENH_MAIN_CLK_AO , +SPICC_ENH_MAIN_CLK_AO , + spicc->base +SPICC_ENH_CTL0 ); + +writel_bits_relaxed (SPICC_FIFORST_W1_MASK ,SPICC_FIFORST_W1_MASK , + spicc->base +SPICC_TESTREG ); + +while (meson_spicc_rxready (spicc)) + data =readl_relaxed (spicc->base +SPICC_RXDATA ); + +if (spicc->data->has_oen) +writel_bits_relaxed (SPICC_ENH_MAIN_CLK_AO ,0 , + spicc->base +SPICC_ENH_CTL0 ); } static int meson_spicc_transfer_one(struct spi_master *master,
@@ -412,8 +383,6 @@ static int meson_spicc_transfer_one(struct spi_master *master, struct spi_transfer *xfer) {struct meson_spicc_device *spicc =spi_master_get_devdata (master); -unsigned int burst_len; -u32 irq =0 ;/* Store current transfer */ spicc->xfer = xfer;
@@ -427,22 +396,22 @@ static int meson_spicc_transfer_one(struct spi_master *master, spicc->bytes_per_word =DIV_ROUND_UP (spicc->xfer->bits_per_word,8 ); +if (xfer->len % spicc->bytes_per_word) +return -EINVAL ; +/* Setup transfer parameters */ meson_spicc_setup_xfer (spicc, xfer); - burst_len = min_t(unsigned int, - spicc->xfer_remain / spicc->bytes_per_word, -SPICC_BURST_MAX ); - -meson_spicc_setup_burst (spicc, burst_len); +meson_spicc_reset_fifo (spicc); - irq =meson_spicc_setup_rx_irq (spicc, irq); +/* Setup burst */ +meson_spicc_setup_burst (spicc);/* Start burst */ writel_bits_relaxed (SPICC_XCH ,SPICC_XCH , spicc->base +SPICC_CONREG );/* Enable interrupts */ -writel_relaxed (irq, spicc->base +SPICC_INTREG ); +writel_relaxed (SPICC_TC_EN , spicc->base +SPICC_INTREG );return 1 ; }
@@ -499,7 +468,7 @@ static int meson_spicc_prepare_message(struct spi_master *master,/* Setup no wait cycles by default */ writel_relaxed (0 , spicc->base +SPICC_PERIODREG ); -writel_bits_relaxed (BIT (24 ),BIT (24 ), spicc->base +SPICC_TESTREG ); +writel_bits_relaxed (SPICC_LBC_W1 ,0 , spicc->base +SPICC_TESTREG );return 0 ; }
@@ -797,11 +766,13 @@ static int meson_spicc_remove(struct platform_device *pdev)static const struct meson_spicc_data meson_spicc_gx_data = { .max_speed_hz =30000000 , .min_speed_hz =325000 , + .fifo_size =16 , };static const struct meson_spicc_data meson_spicc_axg_data = { .max_speed_hz =80000000 , .min_speed_hz =325000 , + .fifo_size =16 , .has_oen = true, .has_enhance_clk_div = true, };
Signature · 1 line
2.20.1
PATCH 8/9 dt-bindings: spi: amlogic,meson-gx-spicc: add Amlogic G12A compatible
In reply to Neil ArmstrongThe Amlogic G12A SPICC controllers uses a secondary clock used to feed the baud rate generator and the delay control logic.
--- .../bindings/spi/amlogic,meson-gx-spicc.yaml | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+)
Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml +22 -0
@@ -22,6 +22,7 @@ properties: enum: - amlogic,meson-gx-spicc # SPICC controller on Amlogic GX and compatible SoCs - amlogic,meson-axg-spicc # SPICC controller on Amlogic AXG and compatible SoCs + - amlogic,meson-g12a-spicc # SPICC controller on Amlogic G12A and compatible SoCs interrupts: maxItems: 1
@@ -40,6 +41,27 @@ properties: items: - const: core +if: + properties: + compatible: + contains: + enum: + - amlogic,meson-g12a-spicc + +then: + properties: + clocks: + contains: + items: + - description: controller register bus clock + - description: baud rate generator and delay control clock + + clock-names: + minItems: 2 + items: + - const: core + - const: pclk + required: - compatible - reg
Signature · 1 line
2.22.0
Mark Brown
maintainerApplied "spi: dt-bindings: amlogic, meson-gx-spicc: add Amlogic G12A compatible" to the spi tree
The patch
spi: dt-bindings: amlogic, meson-gx-spicc: add Amlogic G12A compatible
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
9ea7db818d9dcbbde581925b82bbe259e1926e20Mon Sep 17 00:00:00 2001
From: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/[email protected]>
Date: Thu, 12 Mar 2020 14:31:30 +0100
Subject: [PATCH] spi: dt-bindings: amlogic, meson-gx-spicc: add Amlogic G12A
compatible
The Amlogic G12A SPICC controllers uses a secondary clock used to feed the baud rate generator and the delay control logic.
--- .../bindings/spi/amlogic,meson-gx-spicc.yaml | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+)
Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml +22 -0
@@ -22,6 +22,7 @@ properties: enum: - amlogic,meson-gx-spicc # SPICC controller on Amlogic GX and compatible SoCs - amlogic,meson-axg-spicc # SPICC controller on Amlogic AXG and compatible SoCs + - amlogic,meson-g12a-spicc # SPICC controller on Amlogic G12A and compatible SoCs interrupts: maxItems: 1
@@ -40,6 +41,27 @@ properties: items: - const: core +if: + properties: + compatible: + contains: + enum: + - amlogic,meson-g12a-spicc + +then: + properties: + clocks: + contains: + items: + - description: controller register bus clock + - description: baud rate generator and delay control clock + + clock-names: + minItems: 2 + items: + - const: core + - const: pclk + required: - compatible - reg
Signature · 1 line
2.20.1
PATCH 9/9 spi: meson-spicc: add support for Amlogic G12A
In reply to Neil ArmstrongAdd support for the SPICC controllers on the Amlogic G12A SoCs family.
The G12A SPICC controllers inherit from the AXG enhanced registers but takes an external pclk for the baud rate generator and can achieve up to 166MHz SCLK.
--- drivers/spi/spi-meson-spicc.c | 54 +++++++++++++++++++++++++++++------ 1 file changed, 46 insertions(+), 8 deletions(-)
drivers/spi/spi-meson-spicc.c +46 -8
@@ -147,6 +147,7 @@ struct meson_spicc_data {unsigned int fifo_size;bool has_oen;bool has_enhance_clk_div; +bool has_pclk; };struct meson_spicc_device {
@@ -154,6 +155,7 @@ struct meson_spicc_device {struct platform_device *pdev;void __iomem *base;struct clk *core; +struct clk *pclk;struct clk *clk;struct spi_message *message;struct spi_transfer *xfer;
@@ -514,6 +516,10 @@ static void meson_spicc_cleanup(struct spi_device *spi)* Clk path for AXG series: * src -> pow2 fixed div -> pow2 div -> mux -> out * src -> enh fixed div -> enh div -> mux -> out +* +* Clk path for G12A series: +* pclk -> pow2 fixed div -> pow2 div -> mux -> out +* pclk -> enh fixed div -> enh div -> mux -> out */ static int meson_spicc_clk_init (struct meson_spicc_device *spicc)
@@ -542,7 +548,10 @@ static int meson_spicc_clk_init(struct meson_spicc_device *spicc) init.name = name; init.ops = &clk_fixed_factor_ops; init.flags =0 ; - parent_data[0 ].hw =__clk_get_hw (spicc->core); +if (spicc->data->has_pclk) + parent_data[0 ].hw =__clk_get_hw (spicc->pclk); +else + parent_data[0 ].hw =__clk_get_hw (spicc->core); init.num_parents =1 ; pow2_fixed_div->mult = 1,
@@ -589,7 +598,10 @@ static int meson_spicc_clk_init(struct meson_spicc_device *spicc) init.name = name; init.ops = &clk_fixed_factor_ops; init.flags =0 ; - parent_data[0 ].hw =__clk_get_hw (spicc->core); +if (spicc->data->has_pclk) + parent_data[0 ].hw =__clk_get_hw (spicc->pclk); +else + parent_data[0 ].hw =__clk_get_hw (spicc->core); init.num_parents =1 ; enh_fixed_div->mult = 1,
@@ -648,7 +660,7 @@ static int meson_spicc_probe(struct platform_device *pdev) {struct spi_master *master;struct meson_spicc_device *spicc; -int ret, irq, rate; +int ret, irq; master =spi_alloc_master (&pdev->dev,sizeof (*spicc));if (!master) {
@@ -697,12 +709,26 @@ static int meson_spicc_probe(struct platform_device *pdev) goto out_master; } +if (spicc->data->has_pclk) { + spicc->pclk =devm_clk_get (&pdev->dev,"pclk" ); +if (IS_ERR (spicc->pclk)) { +dev_err (&pdev->dev,"pclk clock request failed\n" ); + ret =PTR_ERR (spicc->pclk); + goto out_master; + } + } + ret =clk_prepare_enable (spicc->core);if (ret) {dev_err (&pdev->dev,"core clock enable failed\n" ); goto out_master; } - rate =clk_get_rate (spicc->core); + + ret =clk_prepare_enable (spicc->pclk); +if (ret) { +dev_err (&pdev->dev,"pclk clock enable failed\n" ); + goto out_master; + }device_reset_optional (&pdev->dev);
@@ -715,6 +741,7 @@ static int meson_spicc_probe(struct platform_device *pdev)SPI_BPW_MASK (8 ); master->flags = (SPI_MASTER_MUST_RX |SPI_MASTER_MUST_TX ); master->min_speed_hz = spicc->data->min_speed_hz; + master->max_speed_hz = spicc->data->max_speed_hz; master->setup = meson_spicc_setup; master->cleanup = meson_spicc_cleanup; master->prepare_message = meson_spicc_prepare_message;
@@ -722,10 +749,6 @@ static int meson_spicc_probe(struct platform_device *pdev) master->transfer_one = meson_spicc_transfer_one; master->use_gpio_descriptors = true; -/* Setup max rate according to the Meson datasheet */ - master->max_speed_hz = min_t(unsigned int, rate >> 1, - spicc->data->max_speed_hz); -meson_spicc_oen_enable (spicc); ret =meson_spicc_clk_init (spicc);
@@ -744,6 +767,7 @@ static int meson_spicc_probe(struct platform_device *pdev) out_clk:clk_disable_unprepare (spicc->core); +clk_disable_unprepare (spicc->pclk); out_master:spi_master_put (master);
@@ -759,6 +783,7 @@ static int meson_spicc_remove(struct platform_device *pdev)writel (0 , spicc->base +SPICC_CONREG );clk_disable_unprepare (spicc->core); +clk_disable_unprepare (spicc->pclk);return 0 ; }
@@ -777,6 +802,15 @@ static const struct meson_spicc_data meson_spicc_axg_data = { .has_enhance_clk_div = true, }; +static const struct meson_spicc_data meson_spicc_g12a_data = { + .max_speed_hz =166666666 , + .min_speed_hz =50000 , + .fifo_size =15 , + .has_oen = true, + .has_enhance_clk_div = true, + .has_pclk = true, +}; +static const struct of_device_id meson_spicc_of_match[] = { { .compatible ="amlogic,meson-gx-spicc" ,
@@ -786,6 +820,10 @@ static const struct of_device_id meson_spicc_of_match[] = { .compatible = "amlogic,meson-axg-spicc", .data = &meson_spicc_axg_data, }, + { + .compatible = "amlogic,meson-g12a-spicc", + .data = &meson_spicc_g12a_data, + }, {/* sentinel */ } };MODULE_DEVICE_TABLE (of, meson_spicc_of_match);
Signature · 1 line
2.22.0
Mark Brown
maintainerApplied "spi: meson-spicc: add support for Amlogic G12A" to the spi tree
The patch
spi: meson-spicc: add support for Amlogic G12A
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
4e3d322058a5e5afda100005a94ec7f0bf509d43Mon Sep 17 00:00:00 2001
From: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/[email protected]>
Date: Thu, 12 Mar 2020 14:31:31 +0100
Subject: [PATCH] spi: meson-spicc: add support for Amlogic G12A
Add support for the SPICC controllers on the Amlogic G12A SoCs family.
The G12A SPICC controllers inherit from the AXG enhanced registers but takes an external pclk for the baud rate generator and can achieve up to 166MHz SCLK.
--- drivers/spi/spi-meson-spicc.c | 54 +++++++++++++++++++++++++++++------ 1 file changed, 46 insertions(+), 8 deletions(-)
drivers/spi/spi-meson-spicc.c +46 -8
@@ -147,6 +147,7 @@ struct meson_spicc_data {unsigned int fifo_size;bool has_oen;bool has_enhance_clk_div; +bool has_pclk; };struct meson_spicc_device {
@@ -154,6 +155,7 @@ struct meson_spicc_device {struct platform_device *pdev;void __iomem *base;struct clk *core; +struct clk *pclk;struct clk *clk;struct spi_message *message;struct spi_transfer *xfer;
@@ -514,6 +516,10 @@ static void meson_spicc_cleanup(struct spi_device *spi)* Clk path for AXG series: * src -> pow2 fixed div -> pow2 div -> mux -> out * src -> enh fixed div -> enh div -> mux -> out +* +* Clk path for G12A series: +* pclk -> pow2 fixed div -> pow2 div -> mux -> out +* pclk -> enh fixed div -> enh div -> mux -> out */ static int meson_spicc_clk_init (struct meson_spicc_device *spicc)
@@ -542,7 +548,10 @@ static int meson_spicc_clk_init(struct meson_spicc_device *spicc) init.name = name; init.ops = &clk_fixed_factor_ops; init.flags =0 ; - parent_data[0 ].hw =__clk_get_hw (spicc->core); +if (spicc->data->has_pclk) + parent_data[0 ].hw =__clk_get_hw (spicc->pclk); +else + parent_data[0 ].hw =__clk_get_hw (spicc->core); init.num_parents =1 ; pow2_fixed_div->mult = 1,
@@ -589,7 +598,10 @@ static int meson_spicc_clk_init(struct meson_spicc_device *spicc) init.name = name; init.ops = &clk_fixed_factor_ops; init.flags =0 ; - parent_data[0 ].hw =__clk_get_hw (spicc->core); +if (spicc->data->has_pclk) + parent_data[0 ].hw =__clk_get_hw (spicc->pclk); +else + parent_data[0 ].hw =__clk_get_hw (spicc->core); init.num_parents =1 ; enh_fixed_div->mult = 1,
@@ -648,7 +660,7 @@ static int meson_spicc_probe(struct platform_device *pdev) {struct spi_master *master;struct meson_spicc_device *spicc; -int ret, irq, rate; +int ret, irq; master =spi_alloc_master (&pdev->dev,sizeof (*spicc));if (!master) {
@@ -697,12 +709,26 @@ static int meson_spicc_probe(struct platform_device *pdev) goto out_master; } +if (spicc->data->has_pclk) { + spicc->pclk =devm_clk_get (&pdev->dev,"pclk" ); +if (IS_ERR (spicc->pclk)) { +dev_err (&pdev->dev,"pclk clock request failed\n" ); + ret =PTR_ERR (spicc->pclk); + goto out_master; + } + } + ret =clk_prepare_enable (spicc->core);if (ret) {dev_err (&pdev->dev,"core clock enable failed\n" ); goto out_master; } - rate =clk_get_rate (spicc->core); + + ret =clk_prepare_enable (spicc->pclk); +if (ret) { +dev_err (&pdev->dev,"pclk clock enable failed\n" ); + goto out_master; + }device_reset_optional (&pdev->dev);
@@ -715,6 +741,7 @@ static int meson_spicc_probe(struct platform_device *pdev)SPI_BPW_MASK (8 ); master->flags = (SPI_MASTER_MUST_RX |SPI_MASTER_MUST_TX ); master->min_speed_hz = spicc->data->min_speed_hz; + master->max_speed_hz = spicc->data->max_speed_hz; master->setup = meson_spicc_setup; master->cleanup = meson_spicc_cleanup; master->prepare_message = meson_spicc_prepare_message;
@@ -722,10 +749,6 @@ static int meson_spicc_probe(struct platform_device *pdev) master->transfer_one = meson_spicc_transfer_one; master->use_gpio_descriptors = true; -/* Setup max rate according to the Meson datasheet */ - master->max_speed_hz = min_t(unsigned int, rate >> 1, - spicc->data->max_speed_hz); -meson_spicc_oen_enable (spicc); ret =meson_spicc_clk_init (spicc);
@@ -744,6 +767,7 @@ static int meson_spicc_probe(struct platform_device *pdev) out_clk:clk_disable_unprepare (spicc->core); +clk_disable_unprepare (spicc->pclk); out_master:spi_master_put (master);
@@ -759,6 +783,7 @@ static int meson_spicc_remove(struct platform_device *pdev)writel (0 , spicc->base +SPICC_CONREG );clk_disable_unprepare (spicc->core); +clk_disable_unprepare (spicc->pclk);return 0 ; }
@@ -777,6 +802,15 @@ static const struct meson_spicc_data meson_spicc_axg_data = { .has_enhance_clk_div = true, }; +static const struct meson_spicc_data meson_spicc_g12a_data = { + .max_speed_hz =166666666 , + .min_speed_hz =50000 , + .fifo_size =15 , + .has_oen = true, + .has_enhance_clk_div = true, + .has_pclk = true, +}; +static const struct of_device_id meson_spicc_of_match[] = { { .compatible ="amlogic,meson-gx-spicc" ,
@@ -786,6 +820,10 @@ static const struct of_device_id meson_spicc_of_match[] = { .compatible = "amlogic,meson-axg-spicc", .data = &meson_spicc_axg_data, }, + { + .compatible = "amlogic,meson-g12a-spicc", + .data = &meson_spicc_g12a_data, + }, {/* sentinel */ } };MODULE_DEVICE_TABLE (of, meson_spicc_of_match);
Signature · 1 line
2.20.1
This series was applied to khilman/linux-amlogic.git (refs/heads/for-next).
Hello:
This series was applied to khilman/linux-amlogic.git (refs/heads/for-next).
Quoted 8 lines · On Thu, 12 Mar 2020 14:31:22 +0100 you wrote:
The SPICC controller in Amlogic AXG & G12A is capable of driving the CLK/MOSI/SS signal lines through the idle state which avoid the signals floating in unexpected state, is capable of using linear clock divider to reach a much fine tuned range of clocks, while the old controller only uses a power of two clock divider, result at a more coarse clock range and finally is capable of running at 80M clock.
[...]
Here is a summary with links:
- [1/9] spi: meson-spicc: remove unused variables
https://git.kernel.org/khilman/linux-amlogic/c/b9dfb20eed5c7dab37d6267a985dbe16df9e4293 - [2/9] spi: meson-spicc: enhance output enable feature https://git.kernel.org/khilman/linux-amlogic/c/a6cda1f905b4a5442eecce94bda1e136f7e1e539 - [3/9] spi: meson-spicc: add a linear clock divider support https://git.kernel.org/khilman/linux-amlogic/c/3e0cf4d3fc2985beee011e9a1bbb8374fc02c0a0 - [4/9] spi: meson-spicc: support max 80MHz clock https://git.kernel.org/khilman/linux-amlogic/c/3196816ff64bb3a21fbda89e7355b6b87c3f50a0 - [5/9] spi: meson-spicc: add min sclk for each compatible https://git.kernel.org/khilman/linux-amlogic/c/8791068dab979819e01f41736953b9b2e462867b - [6/9] spi: meson-spicc: setup IO line delay https://git.kernel.org/khilman/linux-amlogic/c/f27bff479ea3de9ca325d4f8e8c8b49a87d6b0c5 - [7/9] spi: meson-spicc: adapt burst handling for G12A support https://git.kernel.org/khilman/linux-amlogic/c/0eb707ac7dd7a4329d93d47feada6c9bb5ea8ee9 - [8/9] dt-bindings: spi: amlogic, meson-gx-spicc: add Amlogic G12A compatible https://git.kernel.org/khilman/linux-amlogic/c/9ea7db818d9dcbbde581925b82bbe259e1926e20 - [9/9] spi: meson-spicc: add support for Amlogic G12A https://git.kernel.org/khilman/linux-amlogic/c/4e3d322058a5e5afda100005a94ec7f0bf509d43
You are awesome, thank you!
Signature · 7 lines
Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/pwbot _______________________________________________ linux-amlogic mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-amlogic