tc: m_action: introduce support for hw stats type
Subsystems (3)
Jiri Pirko
maintainerPATCH v4 1/1 tc: m_action: introduce support for hw stats type
From: Jiri Pirko <[email protected]>
Introduce support for per-action hw stats type config.
This patch allows user to specify one of the following types of HW stats for added action:
immediate - queried during dump time
delayed - polled from HW periodically or sent by HW in async manner disabled - no stats needed
Note that if "hw_stats" option is not passed, user does not care about the type, just expects any type of stats.
Examples:
$ tc filter add dev enp0s16np28 ingress proto ip handle 1 pref 1 flower skip_sw dst_ip 192.168.1.1 action drop hw_stats disabled
$ tc -s filter show dev enp0s16np28 ingress
filter protocol ip pref 1 flower chain 0
filter protocol ip pref 1 flower chain 0 handle 0x1
eth_type ipv4
dst_ip 192.168.1.1
skip_sw
in_hw in_hw_count 2
action order 1: gact action drop
random type none pass val 0
index 1 ref 1 bind 1 installed 7 sec used 2 sec
Action statistics:
Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
backlog 0b 0p requeues 0
hw_stats disabled$ tc filter add dev enp0s16np28 ingress proto ip handle 1 pref 1 flower skip_sw dst_ip 192.168.1.1 action drop hw_stats immediate
$ tc -s filter show dev enp0s16np28 ingress
filter protocol ip pref 1 flower chain 0
filter protocol ip pref 1 flower chain 0 handle 0x1
eth_type ipv4
dst_ip 192.168.1.1
skip_sw
in_hw in_hw_count 2
action order 1: gact action drop
random type none pass val 0
index 1 ref 1 bind 1 installed 11 sec used 4 sec
Action statistics:
Sent 102 bytes 1 pkt (dropped 1, overlimits 0 requeues 0)
Sent software 0 bytes 0 pkt
Sent hardware 102 bytes 1 pkt
backlog 0b 0p requeues 0
hw_stats immediate---v3->v4:
- added to "tc actions help" outputv2->v3:
- adjusted hw_stats_type_bf struct initialization
- added comment to "disable"v1->v2:
- added more description and examples
--- include/uapi/linux/pkt_cls.h | 22 ++++++++++++ man/man8/tc-actions.8 | 31 +++++++++++++++++ tc/m_action.c | 66 +++++++++++++++++++++++++++++++++++- 3 files changed, 118 insertions(+), 1 deletion(-)
include/uapi/linux/pkt_cls.h +22 -0
@@ -17,6 +17,7 @@ enum {TCA_ACT_PAD ,TCA_ACT_COOKIE ,TCA_ACT_FLAGS , +TCA_ACT_HW_STATS_TYPE , __TCA_ACT_MAX };
@@ -24,6 +25,27 @@ enum {* actions stats. */ +/* tca HW stats type +* When user does not pass the attribute, he does not care. +* It is the same as if he would pass the attribute with +* all supported bits set. +* In case no bits are set, user is not interested in getting any HW statistics. +*/ +#define TCA_ACT_HW_STATS_TYPE_IMMEDIATE (1 << 0)/* Means that in dump, user +* gets the current HW stats +* state from the device +* queried at the dump time. +*/ +#define TCA_ACT_HW_STATS_TYPE_DELAYED (1 << 1)/* Means that in dump, user gets +* HW stats that might be out +* of date for some time, maybe +* couple of seconds. This is +* the case when driver polls +* stats updates periodically +* or when it gets async stats update +* from the device. +*/ +#define TCA_ACT_MAX __TCA_ACT_MAX#define TCA_OLD_COMPAT (TCA_ACT_MAX+1)#define TCA_ACT_MAX_PRIO 32
man/man8/tc-actions.8 +31 -0
@@ -49,6 +49,8 @@ actions \- independently defined actions in tc ] [ .I FLAGS ] [ +.I HWSTATSSPEC +] [ .I CONTROL ]
@@ -77,6 +79,12 @@ ACTNAME := .I no_percpu +.I HWSTATSSPEC +:= +.BR hw_stats " {" +.IR immediate " | " delayed " | " disabled +.R } + .I ACTDETAIL := .I ACTNAME ACTPARAMS
@@ -200,6 +208,29 @@ which indicates that action is expected to have minimal software data-path traffic and doesn't need to allocate stat counters with percpu allocator. This option is intended to be used by hardware-offloaded actions. +.TP +.BI hw_stats " HW_STATS" +Speficies the type of HW stats of new action. If omitted, any stats counter type +is going to be used, according to driver and its resources. +The +.I HW_STATS +indicates the type. Any of the following are valid: +.RS +.TP +.B immediate +Means that in dump, user gets the current HW stats state from the device +queried at the dump time. +.TP +.B delayed +Means that in dump, user gets HW stats that might be out of date for +some time, maybe couple of seconds. This is the case when driver polls +stats updates periodically or when it gets async stats update +from the device. +.TP +.B disabled +No HW stats are going to be available in dump. +.RE + .TP .BI since " MSTIME" When dumping large number of actions, a millisecond time-filter can be
tc/m_action.c +65 -1
91 lines not on this page · raw message
Signature · 1 line
2.21.1
Jiri Pirko
maintainerFri, Mar 13, 2020 at 01:12:57PM CET, [email protected] wrote:
[...]
tc/m_action.c static void act_usage(void) · line 56
Quoted 12 lines
tc/m_action.c +2
-1@@ -51,8 +51,9 @@ static void act_usage(void)" FL := ls | list | flush | <ACTNAMESPEC>\n" " ACTNAMESPEC := action <ACTNAME>\n" " ACTISPEC := <ACTNAMESPEC> <INDEXSPEC>\n" -" ACTSPEC := action <ACTDETAIL> [INDEXSPEC]\n" +" ACTSPEC := action <ACTDETAIL> [INDEXSPEC] [HWSTATSSPEC]\n" " INDEXSPEC := index <32 bit indexvalue>\n" +" HWSTATSSPEC := hwstats [ immediate | delayed | disabled ]\n"
Sent v5 to fix this. Sorry.
Quoted 3 lines
tc/m_action.c +0
-0" ACTDETAIL := <ACTNAME> <ACTPARAMS>\n" " Example ACTNAME is gact, mirred, bpf, etc\n" " Each action has its own parameters (ACTPARAMS)\n"
[...]