Skip to contentSkip to conversation

staging: wlan-ng: Fix line going over 80 characters

PATCH Superseded John B. Wyatt IV 3 participants 7 messages Mar 16, 2020 Staging

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: wlan-ng: Fix line going over 80 characters

Added a newline before the second argument for style, readability, and consistency.

Please note checkpath reports the third argument as being over 80 characters, but not the second argument.

---
 drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/wlan-ng/hfa384x_usb.c +2 -1
index b71756ab0394..f8485601aead 100644
@@ -3317,7 +3317,8 @@ static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb)
 		break;
 
 	default:
-		netdev_warn(hw->wlandev->netdev, "Received frame on unsupported port=%d\n",
+		netdev_warn(hw->wlandev->netdev,
+			    "Received frame on unsupported port=%d\n",
 			    HFA384x_RXSTATUS_MACPORT_GET(usbin->rxfrm.desc.status));
 		break;
 	}
Signature · 1 line
2.25.1
#1 lore raw
Quoted 2 lines · John B. Wyatt IV

Added a newline before the second argument for style, readability, and consistency.

Added -> Add to make the comment be in the imperative.

Quoted 2 lines

Please note checkpath reports the third argument as being over 80 characters, but not the second argument.

I think that checkpatch is careful about strings, because while exceeding 80 characters is discouraged, adding newline in the middle of a strong or breakingup a string into two parts is even more discouraged. You made the right choice here though.

julia

Quoted 28 lines
---
 drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/wlan-ng/hfa384x_usb.c +2 -2
index b71756ab0394..f8485601aead 100644
@@ -3317,7 +3317,8 @@ static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb)
 		break;
 
 	default:
-		netdev_warn(hw->wlandev->netdev, "Received frame on unsupported port=%d\n",
+		netdev_warn(hw->wlandev->netdev,
+			    "Received frame on unsupported port=%d\n",
 			    HFA384x_RXSTATUS_MACPORT_GET(usbin->rxfrm.desc.status));
 		break;
 	}
--

2.25.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200316012148.1200745-1-jbwyatt4%40gmail.com.

#2 lore raw

PATCH v2 1/1 staging: wlan-ng: Fix line going over 80 characters

In reply to John B. Wyatt IV

Add a newline before the second argument for style, readability, and consistency.

Please note checkpath reports the third argument as being over 80 characters, but not the second argument.

---
[email protected]

 drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/wlan-ng/hfa384x_usb.c +2 -1
index b71756ab0394..f8485601aead 100644
@@ -3317,7 +3317,8 @@ static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb)
 		break;
 
 	default:
-		netdev_warn(hw->wlandev->netdev, "Received frame on unsupported port=%d\n",
+		netdev_warn(hw->wlandev->netdev,
+			    "Received frame on unsupported port=%d\n",
 			    HFA384x_RXSTATUS_MACPORT_GET(usbin->rxfrm.desc.status));
 		break;
 	}
Signature · 1 line
2.25.1
#3 lore raw
Quoted 5 lines · John B. Wyatt IV

Add a newline before the second argument for style, readability, and consistency.

Please note checkpath reports the third argument as being over 80 characters, but not the second argument.

checkpatch :)

julia

Quoted 26 lines

---
[email protected]

 drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/wlan-ng/hfa384x_usb.c +2 -2
index b71756ab0394..f8485601aead 100644
@@ -3317,7 +3317,8 @@ static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb)
 		break;
 
 	default:
-		netdev_warn(hw->wlandev->netdev, "Received frame on unsupported port=%d\n",
+		netdev_warn(hw->wlandev->netdev,
+			    "Received frame on unsupported port=%d\n",
 			    HFA384x_RXSTATUS_MACPORT_GET(usbin->rxfrm.desc.status));
 		break;
 	}
--

2.25.1

author
#4 lore raw
Quoted 11 lines · Julia Lawall
Quoted 6 lines · John B. Wyatt IV

Add a newline before the second argument for style, readability, and
consistency.

Please note checkpath reports the third argument as being over 80 characters, but not the second argument.

checkpatch :)

Thank you :)

For v3 (v2 is also missing the [Outreachy kernel] tag - did I reference the previous email properly for a v2 patch?

#5 lore raw
Quoted 11 lines · John Wyatt
Quoted 10 lines · Julia Lawall
Quoted 6 lines · John B. Wyatt IV

Add a newline before the second argument for style, readability, and
consistency.

Please note checkpath reports the third argument as being over 80 characters, but not the second argument.

Quoted 6 lines
Quoted 1 line

checkpatch :)

Thank you :)

For v3 (v2 is also missing the [Outreachy kernel] tag - did I reference the previous email properly for a v2 patch?

The [Outreachy kernel] tag comeswhen you receive the message throughthe mailing list. Don't worry about it.

julia

#6 lore raw
In reply to John Wyatt
Quoted 2 lines · On Mon, 16 Mar 2020 13:03:20 -0700 John Wyatt <[email protected]> wrote:

For v3 (v2 is also missing the [Outreachy kernel] tag - did I reference the previous email properly for a v2 patch?

Quoted 9 lines · On Mon, 16 Mar 2020 12:37:23 -0700 "John B. Wyatt IV" <[email protected]>…

Add a newline before the second argument for style, readability, and consistency.

Please note checkpath reports the third argument as being over 80 characters, but not the second argument.

---
[email protected]

No, that's not the idea :) You can use e.g. the Message-ID of the cover letter to post a patch as part of a patchset by setting the
In-Reply-To: and References: fields in the new message you're posting, and many years ago, for some subsystems, it was fashionable to
chain-Reply-to: subsequent patches (or even versions) -- I guess that's where you took this from, but I haven't seen that in ages.

What you need to specify after --- (and before it for patches on netdev) is a changelog like:

v3: Changed something else
v2: Changed this and that

see recent examples on this list.

Signature · 1 line
Stefano