Skip to contentSkip to conversation

staging: wlan-ng: Fix line going over 80 characters

PATCH In review John B. Wyatt IV 2 participants 2 messages Mar 16, 2020 – Mar 17, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: wlan-ng: Fix line going over 80 characters

Add a newline before the second argument for style, readability, and consistency.

Please note: checkpatch reports the third argument as being over 80 characters, but not the second argument.

---
v3: Fixed comment misspelling as suggested by Julia Lawall <[email protected]>
Also fixed missing colon ':'

v2: Fixed comment to be in the imperative as suggested by Julia Lawall <[email protected]>

 drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/wlan-ng/hfa384x_usb.c +2 -1
index b71756ab0394..f8485601aead 100644
@@ -3317,7 +3317,8 @@ static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb)
 		break;
 
 	default:
-		netdev_warn(hw->wlandev->netdev, "Received frame on unsupported port=%d\n",
+		netdev_warn(hw->wlandev->netdev,
+			    "Received frame on unsupported port=%d\n",
 			    HFA384x_RXSTATUS_MACPORT_GET(usbin->rxfrm.desc.status));
 		break;
 	}
Signature · 1 line
2.25.1
Reviewed-by on v3 1/1
#1 lore raw
Quoted 6 lines · On Mon, 16 Mar 2020 15:15:44 -0700 "John B. Wyatt IV" <[email protected]>…

Add a newline before the second argument for style, readability, and consistency.

Please note: checkpatch reports the third argument as being over 80 characters, but not the second argument.

Quoted 6 lines

---
v3: Fixed comment misspelling as suggested by Julia Lawall <[email protected]>
Also fixed missing colon ':'

v2: Fixed comment to be in the imperative as suggested by Julia Lawall <[email protected]>

...but, please, don't forget about the unnecessary HFA384x_RXSTATUS_MACPORT_GET() duplication here.

Signature · 1 line
Stefano