staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()
PATCH v6 1/1 staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()
printk() is deprecated, use netdev_warn() instead, which is a message printing function specific for network devices.
Issue found by checkpatch.
---
Changes since v5:
- Subject correction.
drivers/staging/rtl8192u/r8192U_wx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/r8192U_wx.c +1 -1
@@ -588,7 +588,7 @@ static int r8192_wx_set_enc(struct net_device *dev, hwkey); /* KeyContent */ }else { -printk ("wrong type in WEP, not WEP40 and WEP104\n" ); +netdev_warn (dev,"wrong type in WEP, not WEP40 and WEP104\n" ); } }
Signature · 1 line
2.17.1
Quoted 10 lines · Lourdes Pedrajas
printk()is deprecated, usenetdev_warn()instead, which is a message printing function specific for network devices.
Issue found by checkpatch.Suggested-by Julia Lawall <[email protected]>Suggested-by Stefano Brivio <[email protected]>Signed-off-by Lourdes Pedrajas <[email protected]>---
Changes since v5:
- Subject correction.
Thanks for sticking with this.
One further note, you should list _all_ the changes that have happened over the series, v1-v6, in this list. That makes it more obvious what has happened over time.
I've queued this patch up now, no need to do it this time.
thanks,
greg k-h
Quoted 18 lines · Greg KH
Quoted 10 lines · Lourdes Pedrajas
printk()is deprecated, usenetdev_warn()instead, which is a message printing function specific for network devices.
Issue found by checkpatch.Suggested-by Julia Lawall <[email protected]>Suggested-by Stefano Brivio <[email protected]>Signed-off-by Lourdes Pedrajas <[email protected]>---
Changes since v5:
- Subject correction.Thanks for sticking with this.
One further note, you should list _all_ the changes that have happened over the series, v1-v6, in this list. That makes it more obvious what has happened over time.
Quoted 5 lines
I've queued this patch up now, no need to do it this time.
thanks,
greg k-h
I will do so from now! :)
Thank you,
Lourdes