Skip to contentSkip to conversation

staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()

PATCH Superseded Lourdes Pedrajas 3 participants 3 messages Mar 13, 2020 – Mar 17, 2020 Staging

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 staging: rtl8192u: r8192U_wx: use netdev_warn() instead of printk()

printk() is deprecated, use netdev_warn() instead, which is a message printing function specific for network devices.
Issue found by checkpatch.

---
Changes since v4:
- Log message correction.

 drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/r8192U_wx.c +1 -1
index 0118edb0b9ab..100532598781 100644
@@ -588,7 +588,7 @@ static int r8192_wx_set_enc(struct net_device *dev,
 				hwkey);                 /* KeyContent */
 
 		} else {
-			printk("wrong type in WEP, not WEP40 and WEP104\n");
+			netdev_warn(dev, "wrong type in WEP, not WEP40 and WEP104\n");
 		}
 
 	}
Signature · 1 line
2.17.1
Reviewed-by on v5 1/1
#1 lore raw
Quoted 19 lines · On Fri, 13 Mar 2020 10:05:44 +0100 Lourdes Pedrajas <[email protected]> wrote:

printk() is deprecated, use netdev_warn() instead, which is a message printing function specific for network devices.
Issue found by checkpatch.

---
Changes since v4:
- Log message correction.

 drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/r8192U_wx.c +0 -0
index 0118edb0b9ab..100532598781 100644

drivers/staging/rtl8192u/r8192U_wx.c static int r8192_wx_set_enc(struct net_device *dev, · line 591

Quoted 5 lines
drivers/staging/rtl8192u/r8192U_wx.c +1 -1
@@ -588,7 +588,7 @@ static int r8192_wx_set_enc(struct net_device *dev,
 				hwkey);                 /* KeyContent */
 
 		} else {
-			printk("wrong type in WEP, not WEP40 and WEP104\n");
+			netdev_warn(dev, "wrong type in WEP, not WEP40 and WEP104\n");
Signature · 1 line
Stefano
maintainer
#2 lore raw
In reply to Lourdes Pedrajas
Quoted 11 lines · Lourdes Pedrajas

printk() is deprecated, use netdev_warn() instead, which is a message printing function specific for network devices.
Issue found by checkpatch.

---
Changes since v4:
- Log message correction.

You sent out 2 "v5" patches that were different :(

Please fix up and send out v6 properly.

thanks,

greg k-h