Staging: qlge: Add a blank line after variable declaration.
PATCH 1/1 Staging: qlge: Add a blank line after variable declaration.
Cleanup checkpatch.pl WARNINGS: Missing a blank line after declarations.
---
--- drivers/staging/qlge/qlge_dbg.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/staging/qlge/qlge_dbg.c +5 -0
@@ -497,6 +497,7 @@ static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 *buf, u32 offset, u32 count) { int i, status = 0; +for (i =0 ; i < count; i++, buf++) { status =ql_read_mpi_reg (qdev, offset + i, buf);if (status)
@@ -1330,6 +1331,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev) {int i;u32 value; +for (i =0 ; i < qdev->intr_count; i++) {ql_write32 (qdev,INTR_EN , qdev->intr_context[i].intr_read_mask); value =ql_read32 (qdev,INTR_EN );
@@ -1415,6 +1417,7 @@ void ql_dump_routing_entries(struct ql_adapter *qdev) {int i;u32 value; + i =ql_sem_spinlock (qdev,SEM_RT_IDX_MASK );if (i)return ;
@@ -1565,6 +1568,7 @@ void ql_dump_stat(struct ql_adapter *qdev)void ql_dump_qdev (struct ql_adapter *qdev) {int i; +DUMP_QDEV_FIELD (qdev,"%lx" , flags);DUMP_QDEV_FIELD (qdev,"%p" , vlgrp);DUMP_QDEV_FIELD (qdev,"%p" , pdev);
@@ -1650,6 +1654,7 @@ void ql_dump_tx_ring(struct tx_ring *tx_ring)void ql_dump_ricb (struct ricb *ricb) {int i; +pr_err ("===================== Dumping ricb ===============\n" );pr_err ("Dumping ricb stuff...\n" );
Signature · 1 line
2.20.1
Quoted 1 line · Sam Muhammed
Cleanup checkpatch.pl WARNINGS: Missing a blank line after declarations.
This is a revision of what you did before. So there should be v2 in the subject line. And under the --- there should be a description of what you did differently as compared to the previous version.
Quoted 4 lines
Signed-off-by Sam Muhammed <[email protected]>---
---
Only one --- is needed. Perhaps you added one and another one was added automatically?
julia
Quoted 55 lines
drivers/staging/qlge/qlge_dbg.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/staging/qlge/qlge_dbg.c +5
-1@@ -497,6 +497,7 @@ static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 *buf, u32 offset, u32 count) { int i, status = 0; +for (i =0 ; i < count; i++, buf++) { status =ql_read_mpi_reg (qdev, offset + i, buf);if (status)@@ -1330,6 +1331,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev) {int i;u32 value; +for (i =0 ; i < qdev->intr_count; i++) {ql_write32 (qdev,INTR_EN , qdev->intr_context[i].intr_read_mask); value =ql_read32 (qdev,INTR_EN );@@ -1415,6 +1417,7 @@ void ql_dump_routing_entries(struct ql_adapter *qdev) {int i;u32 value; + i =ql_sem_spinlock (qdev,SEM_RT_IDX_MASK );if (i)return ;@@ -1565,6 +1568,7 @@ void ql_dump_stat(struct ql_adapter *qdev)void ql_dump_qdev (struct ql_adapter *qdev) {int i; +DUMP_QDEV_FIELD (qdev,"%lx" , flags);DUMP_QDEV_FIELD (qdev,"%p" , vlgrp);DUMP_QDEV_FIELD (qdev,"%p" , pdev);@@ -1650,6 +1654,7 @@ void ql_dump_tx_ring(struct tx_ring *tx_ring)void ql_dump_ricb (struct ricb *ricb) {int i; +pr_err ("===================== Dumping ricb ===============\n" );pr_err ("Dumping ricb stuff...\n" ); --2.20.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200318200352.3497-1-jane.pnx9%40gmail.com.
Quoted 5 lines · Sam Muhammed
Cleanup checkpatch.pl WARNINGS: Missing a blank line after declarations.
Signed-off-by Sam Muhammed <[email protected]>---
---
duplicate :(, should i resend or revision?
Quoted 47 lines
drivers/staging/qlge/qlge_dbg.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/staging/qlge/qlge_dbg.c +5
-0@@ -497,6 +497,7 @@ static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 *buf, u32 offset, u32 count) { int i, status = 0; +for (i =0 ; i < count; i++, buf++) { status =ql_read_mpi_reg (qdev, offset + i, buf);if (status)@@ -1330,6 +1331,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev) {int i;u32 value; +for (i =0 ; i < qdev->intr_count; i++) {ql_write32 (qdev,INTR_EN , qdev->intr_context[i].intr_read_mask); value =ql_read32 (qdev,INTR_EN );@@ -1415,6 +1417,7 @@ void ql_dump_routing_entries(struct ql_adapter *qdev) {int i;u32 value; + i =ql_sem_spinlock (qdev,SEM_RT_IDX_MASK );if (i)return ;@@ -1565,6 +1568,7 @@ void ql_dump_stat(struct ql_adapter *qdev)void ql_dump_qdev (struct ql_adapter *qdev) {int i; +DUMP_QDEV_FIELD (qdev,"%lx" , flags);DUMP_QDEV_FIELD (qdev,"%p" , vlgrp);DUMP_QDEV_FIELD (qdev,"%p" , pdev);@@ -1650,6 +1654,7 @@ void ql_dump_tx_ring(struct tx_ring *tx_ring)void ql_dump_ricb (struct ricb *ricb) {int i; +pr_err ("===================== Dumping ricb ===============\n" );pr_err ("Dumping ricb stuff...\n" );
Greg Kroah-Hartman
maintainerQuoted 8 lines · Sam Muhammed
Quoted 5 lines · Sam Muhammed
Cleanup checkpatch.pl WARNINGS: Missing a blank line after declarations.
Signed-off-by Sam Muhammed <[email protected]>---
---duplicate :(, should i resend or revision?
I need a v2 of this please.
thanks,
greg k-h