Skip to contentSkip to conversation

kunit: tool: add missing test data file content

PATCH Superseded Brendan Higgins 2 participants 4 messages Mar 23, 2020

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kunit: tool: add missing test data file content

A test data file for one of the kunit_tool unit tests was missing; add it in so that unit tests can run properly.

---
Shuah, this is a fix for a broken test. Can you apply this for 5.7?

---
 .../testing/kunit/test_data/test_pound_sign.log  | Bin 0 -> 1656 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)
tools/testing/kunit/test_data/test_pound_sign.log binary +0 -0
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..28ffa5ba03bfa81ea02ea9d38e7de7acf3dd9e5d 100644
GIT binary patch

base-commit: 021ed9f551da33449a5238e45e849913422671d7

Signature · 1 line
2.25.1.696.g5e7596f4ac-goog
maintainer
#1 lore raw
Quoted 6 lines · Brendan Higgins

A test data file for one of the kunit_tool unit tests was missing; add it in so that unit tests can run properly.

---
Shuah, this is a fix for a broken test. Can you apply this for 5.7?

Can you please add more details on what kind of data this file supplies and which test fails if it doesn't exist.

Quoted 25 lines
---
  .../testing/kunit/test_data/test_pound_sign.log  | Bin 0 -> 1656 bytes
  1 file changed, 0 insertions(+), 0 deletions(-)
tools/testing/kunit/test_data/test_pound_sign.log binary +0 -0
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..28ffa5ba03bfa81ea02ea9d38e7de7acf3dd9e5d 100644
GIT binary patch
Quoted 2 lines

base-commit: 021ed9f551da33449a5238e45e849913422671d7

thanks,
-- Shuah

#2 lore raw
Quoted 11 lines · shuah
Quoted 6 lines · Brendan Higgins

A test data file for one of the kunit_tool unit tests was missing; add it in so that unit tests can run properly.

---
Shuah, this is a fix for a broken test. Can you apply this for 5.7?

Can you please add more details on what kind of data this file supplies and which test fails if it doesn't exist.

Sure,

This adds a raw dmesg test log to test the kunit_tool's dmesg parser. test_prefix_poundsign and test_output_with_prefix_isolated_correctly fail without this test log.

I will send a new revision with this information in the commit message.

Quoted 25 lines
Quoted 25 lines
---
  .../testing/kunit/test_data/test_pound_sign.log  | Bin 0 -> 1656 bytes
  1 file changed, 0 insertions(+), 0 deletions(-)
tools/testing/kunit/test_data/test_pound_sign.log binary +0 -0
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..28ffa5ba03bfa81ea02ea9d38e7de7acf3dd9e5d 100644
GIT binary patch
Quoted 5 lines
Quoted 2 lines

base-commit: 021ed9f551da33449a5238e45e849913422671d7

thanks,
-- Shuah

Cheers

#3 lore raw
Quoted 14 lines · Brendan Higgins
Quoted 11 lines · shuah
Quoted 6 lines · Brendan Higgins

A test data file for one of the kunit_tool unit tests was missing; add it in so that unit tests can run properly.

---
Shuah, this is a fix for a broken test. Can you apply this for 5.7?

Can you please add more details on what kind of data this file supplies and which test fails if it doesn't exist.

Quoted 7 lines

Sure,

This adds a raw dmesg test log to test the kunit_tool's dmesg parser. test_prefix_poundsign and test_output_with_prefix_isolated_correctly fail without this test log.

I will send a new revision with this information in the commit message.

I just sent a new revision with an updated message.