Skip to contentSkip to conversation

mm/vmscan.c: use update_lru_size() in update_lru_sizes()

PATCH Applied Wei Yang 3 participants 3 messages Mar 31, 2020 – Apr 1, 2020

Subsystems (3)
lore
Share & tools
lore

Wei Yang

author
#0 lore raw

PATCH 1/1 mm/vmscan.c: use update_lru_size() in update_lru_sizes()

We already defined the helper update_lru_size().

Let's use this to reduce code duplication.

---
 mm/vmscan.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
mm/vmscan.c +1 -4
index f92858e5c2e3..a4fdf3dc8887 100644
@@ -1603,10 +1603,7 @@ static __always_inline void update_lru_sizes(struct lruvec *lruvec,
 		if (!nr_zone_taken[zid])
 			continue;
 
-		__update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]);
-#ifdef CONFIG_MEMCG
-		mem_cgroup_update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]);
-#endif
+		update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]);
 	}
 
 }
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Wei Yang

We already defined the helper update_lru_size().

Let's use this to reduce code duplication.

---
 mm/vmscan.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
mm/vmscan.c +0 -0
index f92858e5c2e3..a4fdf3dc8887 100644

mm/vmscan.c static __always_inline void update_lru_sizes(struct lruvec *lruvec, · line 1606

Quoted 8 lines
mm/vmscan.c +1 -4
@@ -1603,10 +1603,7 @@ static __always_inline void update_lru_sizes(struct lruvec *lruvec,
 		if (!nr_zone_taken[zid])
 			continue;
 
-		__update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]);
-#ifdef CONFIG_MEMCG
-		mem_cgroup_update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]);
-#endif
+		update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]);

A nice clean up.

Quoted 7 lines
mm/vmscan.c +0 -0
 	}
 
 }
Signature · 1 line
2.23.0
reviewer Acked-by on v1 1/1
#2 lore raw
In reply to Wei Yang
Quoted 5 lines · Wei Yang

We already defined the helper update_lru_size().

Let's use this to reduce code duplication.

Quoted 23 lines
---
 mm/vmscan.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
mm/vmscan.c +1 -4
index f92858e5c2e3..a4fdf3dc8887 100644
@@ -1603,10 +1603,7 @@ static __always_inline void update_lru_sizes(struct lruvec *lruvec,
 		if (!nr_zone_taken[zid])
 			continue;
 
-		__update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]);
-#ifdef CONFIG_MEMCG
-		mem_cgroup_update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]);
-#endif
+		update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]);
 	}
 
 }
Signature · 1 line
2.23.0
Signature · 2 lines
Michal Hocko
SUSE Labs