mm/vmscan.c: use update_lru_size() in update_lru_sizes()
Subsystems (3)
PATCH 1/1 mm/vmscan.c: use update_lru_size() in update_lru_sizes()
We already defined the helper update_lru_size().
Let's use this to reduce code duplication.
Signed-off-by Wei Yang <[email protected]>
--- mm/vmscan.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
mm/vmscan.c +1 -4
@@ -1603,10 +1603,7 @@ static __always_inline void update_lru_sizes(struct lruvec *lruvec,if (!nr_zone_taken[zid])continue ; -__update_lru_size (lruvec, lru, zid, -nr_zone_taken[zid]); -#ifdef CONFIG_MEMCG -mem_cgroup_update_lru_size (lruvec, lru, zid, -nr_zone_taken[zid]); -#endif +update_lru_size (lruvec, lru, zid, -nr_zone_taken[zid]); } }
Signature · 1 line
2.23.0
Quoted 14 lines · Wei Yang
We already defined the helper
update_lru_size().Let's use this to reduce code duplication.
Signed-off-by Wei Yang <[email protected]>--- mm/vmscan.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)mm/vmscan.c +0
-0
mm/vmscan.c static __always_inline void update_lru_sizes(struct lruvec *lruvec, · line 1606
Quoted 8 lines
mm/vmscan.c +1
-4@@ -1603,10 +1603,7 @@ static __always_inline void update_lru_sizes(struct lruvec *lruvec,if (!nr_zone_taken[zid])continue ; -__update_lru_size (lruvec, lru, zid, -nr_zone_taken[zid]); -#ifdef CONFIG_MEMCG -mem_cgroup_update_lru_size (lruvec, lru, zid, -nr_zone_taken[zid]); -#endif +update_lru_size (lruvec, lru, zid, -nr_zone_taken[zid]);
A nice clean up.
Reviewed-by Baoquan He <[email protected]>
Quoted 7 lines
mm/vmscan.c +0
-0} }Signature · 1 line
2.23.0
Quoted 5 lines · Wei Yang
We already defined the helper
update_lru_size().Let's use this to reduce code duplication.
Signed-off-by Wei Yang <[email protected]>
Acked-by Michal Hocko <[email protected]>
Quoted 23 lines
--- mm/vmscan.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)mm/vmscan.c +1
-4@@ -1603,10 +1603,7 @@ static __always_inline void update_lru_sizes(struct lruvec *lruvec,if (!nr_zone_taken[zid])continue ; -__update_lru_size (lruvec, lru, zid, -nr_zone_taken[zid]); -#ifdef CONFIG_MEMCG -mem_cgroup_update_lru_size (lruvec, lru, zid, -nr_zone_taken[zid]); -#endif +update_lru_size (lruvec, lru, zid, -nr_zone_taken[zid]); } }Signature · 1 line
2.23.0
Signature · 2 lines
Michal Hocko SUSE Labs