Skip to contentSkip to conversation

KVM: PPC: Book3S HV: Remove NULL check before kfree

PATCH New Qiujun Huang 1 participant 1 message Apr 5, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KVM: PPC: Book3S HV: Remove NULL check before kfree

NULL check before kfree is unnecessary, so remove it.

This issue was detected by using the Coccinelle software.

---
 arch/powerpc/kvm/book3s_hv_nested.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/powerpc/kvm/book3s_hv_nested.c +1 -2
index dc97e5be76f6..cad324312040 100644
@@ -1416,8 +1416,7 @@ static long int __kvmhv_nested_page_fault(struct kvm_run *run,
 	rmapp = &memslot->arch.rmap[gfn - memslot->base_gfn];
 	ret = kvmppc_create_pte(kvm, gp->shadow_pgtable, pte, n_gpa, level,
 				mmu_seq, gp->shadow_lpid, rmapp, &n_rmap);
-	if (n_rmap)
-		kfree(n_rmap);
+	kfree(n_rmap);
 	if (ret = -EAGAIN)
 		ret = RESUME_GUEST;	/* Let the guest try again */
 
Signature · 1 line
2.17.1