Skip to contentSkip to conversation

Revert "Kernel selftests: tpm2: check for tpm support"

PATCH In review Jarkko Sakkinen 2 participants 6 messages Apr 12, 2020 – Apr 16, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "Kernel selftests: tpm2: check for tpm support"

This reverts commit b32694cd0724d4ceca2c62cc7c3d3a8d1ffa11fc.

The original comment was neither reviewed nor tested. Thus, this the *only* possible action to take.

---
 tools/testing/selftests/tpm2/test_smoke.sh | 13 ++-----------
 tools/testing/selftests/tpm2/test_space.sh |  9 +--------
 2 files changed, 3 insertions(+), 19 deletions(-)
tools/testing/selftests/tpm2/test_smoke.sh +2 -11
index b630c7b5950a..8155c2ea7ccb 100755
@@ -1,17 +1,8 @@
 #!/bin/bash
 # SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
-self.flags = flags
 
-# Kselftest framework requirement - SKIP code is 4.
-ksft_skip=4
-
-
-if [ -f /dev/tpm0 ] ; then
-	python -m unittest -v tpm2_tests.SmokeTest
-	python -m unittest -v tpm2_tests.AsyncTest
-else
-	exit $ksft_skip
-fi
+python -m unittest -v tpm2_tests.SmokeTest
+python -m unittest -v tpm2_tests.AsyncTest
 
 CLEAR_CMD=$(which tpm2_clear)
 if [ -n $CLEAR_CMD ]; then
tools/testing/selftests/tpm2/test_space.sh +1 -8
index 180b469c53b4..a6f5e346635e 100755
@@ -1,11 +1,4 @@
 #!/bin/bash
 # SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
 
-# Kselftest framework requirement - SKIP code is 4.
-ksft_skip=4
-
-if [ -f /dev/tpmrm0 ] ; then
-	python -m unittest -v tpm2_tests.SpaceTest
-else
-	exit $ksft_skip
-fi
+python -m unittest -v tpm2_tests.SpaceTest
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 3 lines · Jarkko Sakkinen

This reverts commit b32694cd0724d4ceca2c62cc7c3d3a8d1ffa11fc.

The original comment

commit I assume.

was neither reviewed nor tested. Thus, this the

Quoted 2 lines

*only* possible action to take.

Bummer. I will apply this right away.

Quoted 3 lines

---

thanks,
-- Shuah

#2 lore raw
Quoted 5 lines · shuah
Quoted 3 lines · Jarkko Sakkinen

This reverts commit b32694cd0724d4ceca2c62cc7c3d3a8d1ffa11fc.

The original comment

Quoted 7 lines

commit I assume.

was neither reviewed nor tested. Thus, this the

Quoted 2 lines

*only* possible action to take.

Bummer. I will apply this right away.

No worries, and fine with the change as long as I'm able to review and try it out :-) Sorry for the dull tone!

/Jarkko

#3 lore raw
Quoted 8 lines · Jarkko Sakkinen
Quoted 7 lines · shuah
Quoted 3 lines · Jarkko Sakkinen

This reverts commit b32694cd0724d4ceca2c62cc7c3d3a8d1ffa11fc.

The original comment

commit I assume.

Quoted 8 lines
Quoted 5 lines

was neither reviewed nor tested. Thus, this the

Quoted 2 lines

*only* possible action to take.

Bummer. I will apply this right away.

No worries, and fine with the change as long as I'm able to review and try it out :-) Sorry for the dull tone!

I mean refined change after this revert has been applied.

/Jarkko

maintainer
#4 lore raw
Quoted 9 lines · Jarkko Sakkinen
Quoted 8 lines · Jarkko Sakkinen
Quoted 7 lines · shuah
Quoted 3 lines · Jarkko Sakkinen

This reverts commit b32694cd0724d4ceca2c62cc7c3d3a8d1ffa11fc.

The original comment

commit I assume.

Quoted 9 lines
Quoted 8 lines
Quoted 5 lines

was neither reviewed nor tested. Thus, this the

Quoted 2 lines

*only* possible action to take.

Bummer. I will apply this right away.

No worries, and fine with the change as long as I'm able to review and try it out :-) Sorry for the dull tone!

I usually wait for test authors to do the review. This patch was sent a while back and I ended up picking it up. It stayed in next for a while. It is fixed now.

Quoted 2 lines

I mean refined change after this revert has been applied.

Of course. I applied your revert to for my next pull request to linux-kselftest next

thanks,
-- Shuah

#5 lore raw
Quoted 24 lines · shuah
Quoted 9 lines · Jarkko Sakkinen
Quoted 8 lines · Jarkko Sakkinen
Quoted 7 lines · shuah
Quoted 3 lines · Jarkko Sakkinen

This reverts commit b32694cd0724d4ceca2c62cc7c3d3a8d1ffa11fc.

The original comment

commit I assume.

Quoted 9 lines
Quoted 8 lines
Quoted 5 lines

was neither reviewed nor tested. Thus, this the

Quoted 2 lines

*only* possible action to take.

Bummer. I will apply this right away.

No worries, and fine with the change as long as I'm able to review and try it out :-) Sorry for the dull tone!

I usually wait for test authors to do the review. This patch was sent a while back and I ended up picking it up. It stayed in next for a while. It is fixed now.

Quoted 7 lines
Quoted 2 lines

I mean refined change after this revert has been applied.

Of course. I applied your revert to for my next pull request to linux-kselftest next

thanks,
-- Shuah

Thanks.

/Jarkko