Revert "Kernel selftests: tpm2: check for tpm support"
Subsystems (3)
PATCH 1/1 Revert "Kernel selftests: tpm2: check for tpm support"
This reverts commit b32694cd0724d4ceca2c62cc7c3d3a8d1ffa11fc.
The original comment was neither reviewed nor tested. Thus, this the *only* possible action to take.
--- tools/testing/selftests/tpm2/test_smoke.sh | 13 ++----------- tools/testing/selftests/tpm2/test_space.sh | 9 +-------- 2 files changed, 3 insertions(+), 19 deletions(-)
tools/testing/selftests/tpm2/test_smoke.sh +2 -11
@@ -1,17 +1,8 @@ #!/bin/bash # SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) -self.flags = flags -# Kselftest framework requirement - SKIP code is 4. -ksft_skip=4 - - -if [ -f /dev/tpm0 ] ; then - python -m unittest -v tpm2_tests.SmokeTest - python -m unittest -v tpm2_tests.AsyncTest -else - exit $ksft_skip -fi +python -m unittest -v tpm2_tests.SmokeTest +python -m unittest -v tpm2_tests.AsyncTest CLEAR_CMD=$(which tpm2_clear) if [ -n $CLEAR_CMD ]; then
tools/testing/selftests/tpm2/test_space.sh +1 -8
@@ -1,11 +1,4 @@ #!/bin/bash # SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) -# Kselftest framework requirement - SKIP code is 4. -ksft_skip=4 - -if [ -f /dev/tpmrm0 ] ; then - python -m unittest -v tpm2_tests.SpaceTest -else - exit $ksft_skip -fi +python -m unittest -v tpm2_tests.SpaceTest
Signature · 1 line
2.25.1
shuah
maintainerQuoted 3 lines · Jarkko Sakkinen
This reverts commit
b32694cd0724d4ceca2c62cc7c3d3a8d1ffa11fc.The original comment
commit I assume.
was neither reviewed nor tested. Thus, this the
Quoted 2 lines
*only* possible action to take.
Bummer. I will apply this right away.
Quoted 3 lines
Cc Nikita Sobolev <[email protected]>Signed-off-by Jarkko Sakkinen <[email protected]>---
thanks,
-- Shuah
Quoted 5 lines · shuah
Quoted 3 lines · Jarkko Sakkinen
This reverts commit
b32694cd0724d4ceca2c62cc7c3d3a8d1ffa11fc.The original comment
Quoted 7 lines
commit I assume.
was neither reviewed nor tested. Thus, this the
Quoted 2 lines
*only* possible action to take.
Bummer. I will apply this right away.
No worries, and fine with the change as long as I'm able to review and try it out :-) Sorry for the dull tone!
/Jarkko
Quoted 8 lines · Jarkko Sakkinen
Quoted 7 lines · shuah
Quoted 3 lines · Jarkko Sakkinen
This reverts commit
b32694cd0724d4ceca2c62cc7c3d3a8d1ffa11fc.The original comment
commit I assume.
Quoted 8 lines
Quoted 5 lines
was neither reviewed nor tested. Thus, this the
Quoted 2 lines
*only* possible action to take.
Bummer. I will apply this right away.
No worries, and fine with the change as long as I'm able to review and try it out :-) Sorry for the dull tone!
I mean refined change after this revert has been applied.
/Jarkko
shuah
maintainerQuoted 9 lines · Jarkko Sakkinen
Quoted 8 lines · Jarkko Sakkinen
Quoted 7 lines · shuah
Quoted 3 lines · Jarkko Sakkinen
This reverts commit
b32694cd0724d4ceca2c62cc7c3d3a8d1ffa11fc.The original comment
commit I assume.
Quoted 9 lines
Quoted 8 lines
Quoted 5 lines
was neither reviewed nor tested. Thus, this the
Quoted 2 lines
*only* possible action to take.
Bummer. I will apply this right away.
No worries, and fine with the change as long as I'm able to review and try it out :-) Sorry for the dull tone!
I usually wait for test authors to do the review. This patch was sent a while back and I ended up picking it up. It stayed in next for a while. It is fixed now.
Quoted 2 lines
I mean refined change after this revert has been applied.
Of course. I applied your revert to for my next pull request to linux-kselftest next
thanks,
-- Shuah
Quoted 24 lines · shuah
Quoted 9 lines · Jarkko Sakkinen
Quoted 8 lines · Jarkko Sakkinen
Quoted 7 lines · shuah
Quoted 3 lines · Jarkko Sakkinen
This reverts commit
b32694cd0724d4ceca2c62cc7c3d3a8d1ffa11fc.The original comment
commit I assume.
Quoted 9 lines
Quoted 8 lines
Quoted 5 lines
was neither reviewed nor tested. Thus, this the
Quoted 2 lines
*only* possible action to take.
Bummer. I will apply this right away.
No worries, and fine with the change as long as I'm able to review and try it out :-) Sorry for the dull tone!
I usually wait for test authors to do the review. This patch was sent a while back and I ended up picking it up. It stayed in next for a while. It is fixed now.
Quoted 7 lines
Quoted 2 lines
I mean refined change after this revert has been applied.
Of course. I applied your revert to for my next pull request to linux-kselftest next
thanks,
-- Shuah
Thanks.
/Jarkko