imx/genimage: Specify the volume-label for vfat
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/2 imx/genimage: Specify the volume-label for vfat
Currently the volume-label for the vfat partition is a string with the following pattern: 5934-861D.
Specify the volume-label as "boot" to make it easier to identify it.
--- board/freescale/common/imx/genimage.cfg.template | 1 + board/freescale/common/imx/genimage.cfg.template_imx8 | 1 + board/freescale/common/imx/genimage.cfg.template_spl | 1 + 3 files changed, 3 insertions(+)
board/freescale/common/imx/genimage.cfg.template +1 -0
@@ -9,6 +9,7 @@ image boot.vfat { vfat { + label = "boot" files = { %FILES% }
board/freescale/common/imx/genimage.cfg.template_imx8 +1 -0
@@ -9,6 +9,7 @@ image boot.vfat { vfat { + label = "boot" files = { %FILES% }
board/freescale/common/imx/genimage.cfg.template_spl +1 -0
@@ -9,6 +9,7 @@ image boot.vfat { vfat { + label = "boot" files = { %FILES% }
Signature · 1 line
2.17.1
Fabio Estevam
reviewerPATCH 2/2 fs/ext2: Pass a default string to filesystem label
Currently the volume-label for the root filesystem partition is a string wit the following pattern: ad09a287-46a9-4790-ba97-fbbb549e5e96.
Specify the volume-label as "rootfs" to make it easier to identify it.
--- fs/ext2/Config.in | 1 + 1 file changed, 1 insertion(+)
fs/ext2/Config.in +1 -0
@@ -43,6 +43,7 @@ config BR2_TARGET_ROOTFS_EXT2_REV config BR2_TARGET_ROOTFS_EXT2_LABEL string "filesystem label" + default "rootfs" config BR2_TARGET_ROOTFS_EXT2_SIZE string "exact size"
Signature · 1 line
2.17.1
PATCH 2/2 fs/ext2: Pass a default string to filesystem label
Hi Fabio,
Le 15/04/2020 ? 14:36, Fabio Estevam a ?crit?:
Quoted 7 lines
Currently the volume-label for the root filesystem partition is a string wit the following pattern: ad09a287-46a9-4790-ba97-fbbb549e5e96.
Specify the volume-label as "rootfs" to make it easier to identify it.
Suggested-by Arnout Vandecappelle <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Thanks !
Pierre-Jean
Quoted 17 lines
--- fs/ext2/Config.in | 1 + 1 file changed, 1 insertion(+)fs/ext2/Config.in +1
-0@@ -43,6 +43,7 @@ config BR2_TARGET_ROOTFS_EXT2_REV config BR2_TARGET_ROOTFS_EXT2_LABEL string "filesystem label" + default "rootfs" config BR2_TARGET_ROOTFS_EXT2_SIZE string "exact size"
Signature · 3 lines
Pierre-Jean Texier Embedded Linux Engineer https://koncepto.io
PATCH 1/2 imx/genimage: Specify the volume-label for vfat
In reply to Fabio EstevamHi Fabio,
Le 15/04/2020 ? 14:36, Fabio Estevam a ?crit?:
Quoted 6 lines
Currently the volume-label for the vfat partition is a string with the following pattern: 5934-861D.
Specify the volume-label as "boot" to make it easier to identify it.
Signed-off-by Fabio Estevam <[email protected]>
Works fine on my WaRP7.
Thanks !
Pierre-Jean
Quoted 43 lines
--- board/freescale/common/imx/genimage.cfg.template | 1 + board/freescale/common/imx/genimage.cfg.template_imx8 | 1 + board/freescale/common/imx/genimage.cfg.template_spl | 1 + 3 files changed, 3 insertions(+)board/freescale/common/imx/genimage.cfg.template +1
-0@@ -9,6 +9,7 @@ image boot.vfat { vfat { + label = "boot" files = { %FILES% }board/freescale/common/imx/genimage.cfg.template_imx8 +1
-0@@ -9,6 +9,7 @@ image boot.vfat { vfat { + label = "boot" files = { %FILES% }board/freescale/common/imx/genimage.cfg.template_spl +1
-0@@ -9,6 +9,7 @@ image boot.vfat { vfat { + label = "boot" files = { %FILES% }
Signature · 3 lines
Pierre-Jean Texier Embedded Linux Engineer https://koncepto.io
PATCH 1/2 imx/genimage: Specify the volume-label for vfat
In reply to Fabio EstevamQuoted 11 lines · On Wed, 15 Apr 2020 09:36:55 -0300 Fabio Estevam <[email protected]> wrote:
Currently the volume-label for the vfat partition is a string with the following pattern: 5934-861D.
Specify the volume-label as "boot" to make it easier to identify it.
Signed-off-by Fabio Estevam <[email protected]>--- board/freescale/common/imx/genimage.cfg.template | 1 + board/freescale/common/imx/genimage.cfg.template_imx8 | 1 + board/freescale/common/imx/genimage.cfg.template_spl | 1 + 3 files changed, 3 insertions(+)
Series applied, thanks. I've also added another patch that drops the useless BR2_TARGET_ROOTFS_EXT2_LABEL="rootfs" from a few defconfigs.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com