Skip to contentSkip to conversation

imx/genimage: Specify the volume-label for vfat

PATCH New Fabio Estevam 3 participants 5 messages Apr 15, 2020

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 imx/genimage: Specify the volume-label for vfat

Currently the volume-label for the vfat partition is a string with the following pattern: 5934-861D.

Specify the volume-label as "boot" to make it easier to identify it.

---
 board/freescale/common/imx/genimage.cfg.template      | 1 +
 board/freescale/common/imx/genimage.cfg.template_imx8 | 1 +
 board/freescale/common/imx/genimage.cfg.template_spl  | 1 +
 3 files changed, 3 insertions(+)
board/freescale/common/imx/genimage.cfg.template +1 -0
index 2a7036a7df..61b09bde9f 100644
@@ -9,6 +9,7 @@
 
 image boot.vfat {
   vfat {
+    label = "boot"
     files = {
       %FILES%
     }
board/freescale/common/imx/genimage.cfg.template_imx8 +1 -0
index bd5f6cdc73..84a812f986 100644
@@ -9,6 +9,7 @@
 
 image boot.vfat {
   vfat {
+    label = "boot"
     files = {
       %FILES%
     }
board/freescale/common/imx/genimage.cfg.template_spl +1 -0
index d2d810777b..3b0667c383 100644
@@ -9,6 +9,7 @@
 
 image boot.vfat {
   vfat {
+    label = "boot"
     files = {
       %FILES%
     }
Signature · 1 line
2.17.1
author reviewer
#1 lore raw

PATCH 2/2 fs/ext2: Pass a default string to filesystem label

Currently the volume-label for the root filesystem partition is a string wit the following pattern: ad09a287-46a9-4790-ba97-fbbb549e5e96.

Specify the volume-label as "rootfs" to make it easier to identify it.

---
 fs/ext2/Config.in | 1 +
 1 file changed, 1 insertion(+)
fs/ext2/Config.in +1 -0
index 74bacc1141..333ead95fe 100644
@@ -43,6 +43,7 @@ config BR2_TARGET_ROOTFS_EXT2_REV
 
 config BR2_TARGET_ROOTFS_EXT2_LABEL
 	string "filesystem label"
+	default "rootfs"
 
 config BR2_TARGET_ROOTFS_EXT2_SIZE
 	string "exact size"
Signature · 1 line
2.17.1
#3 lore raw

PATCH 1/2 imx/genimage: Specify the volume-label for vfat

In reply to Fabio Estevam

Hi Fabio,

Le 15/04/2020 ? 14:36, Fabio Estevam a ?crit?:

Quoted 6 lines

Currently the volume-label for the vfat partition is a string with the following pattern: 5934-861D.

Specify the volume-label as "boot" to make it easier to identify it.

Works fine on my WaRP7.

Thanks !

Pierre-Jean

Quoted 43 lines
---
  board/freescale/common/imx/genimage.cfg.template      | 1 +
  board/freescale/common/imx/genimage.cfg.template_imx8 | 1 +
  board/freescale/common/imx/genimage.cfg.template_spl  | 1 +
  3 files changed, 3 insertions(+)
board/freescale/common/imx/genimage.cfg.template +1 -0
index 2a7036a7df..61b09bde9f 100644
@@ -9,6 +9,7 @@
 
  image boot.vfat {
    vfat {
+    label = "boot"
      files = {
        %FILES%
      }
board/freescale/common/imx/genimage.cfg.template_imx8 +1 -0
index bd5f6cdc73..84a812f986 100644
@@ -9,6 +9,7 @@
 
  image boot.vfat {
    vfat {
+    label = "boot"
      files = {
        %FILES%
      }
board/freescale/common/imx/genimage.cfg.template_spl +1 -0
index d2d810777b..3b0667c383 100644
@@ -9,6 +9,7 @@
 
  image boot.vfat {
    vfat {
+    label = "boot"
      files = {
        %FILES%
      }
Signature · 3 lines
Pierre-Jean Texier
Embedded Linux Engineer
https://koncepto.io
#2 lore raw

PATCH 2/2 fs/ext2: Pass a default string to filesystem label

In reply to Fabio Estevam

Hi Fabio,

Le 15/04/2020 ? 14:36, Fabio Estevam a ?crit?:

Quoted 7 lines

Currently the volume-label for the root filesystem partition is a string wit the following pattern: ad09a287-46a9-4790-ba97-fbbb549e5e96.

Specify the volume-label as "rootfs" to make it easier to identify it.

Thanks !

Pierre-Jean

Quoted 17 lines
---
  fs/ext2/Config.in | 1 +
  1 file changed, 1 insertion(+)
fs/ext2/Config.in +1 -0
index 74bacc1141..333ead95fe 100644
@@ -43,6 +43,7 @@ config BR2_TARGET_ROOTFS_EXT2_REV
 
  config BR2_TARGET_ROOTFS_EXT2_LABEL
  	string "filesystem label"
+	default "rootfs"
 
  config BR2_TARGET_ROOTFS_EXT2_SIZE
  	string "exact size"
Signature · 3 lines
Pierre-Jean Texier
Embedded Linux Engineer
https://koncepto.io
#4 lore raw

PATCH 1/2 imx/genimage: Specify the volume-label for vfat

In reply to Fabio Estevam
Quoted 11 lines · On Wed, 15 Apr 2020 09:36:55 -0300 Fabio Estevam <[email protected]> wrote:

Currently the volume-label for the vfat partition is a string with the following pattern: 5934-861D.

Specify the volume-label as "boot" to make it easier to identify it.

---
 board/freescale/common/imx/genimage.cfg.template      | 1 +
 board/freescale/common/imx/genimage.cfg.template_imx8 | 1 +
 board/freescale/common/imx/genimage.cfg.template_spl  | 1 +
 3 files changed, 3 insertions(+)

Series applied, thanks. I've also added another patch that drops the useless BR2_TARGET_ROOTFS_EXT2_LABEL="rootfs" from a few defconfigs.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com