Skip to contentSkip to conversation

sifive: fu540: Add sample SD gpt partition layout

PATCH New Jagan Teki 3 participants 13 messages Apr 20, 2020 – Apr 29, 2020 SiFive drivers

lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH v2 1/3 sifive: fu540: Add sample SD gpt partition layout

This is a sample GPT partition layout for SD card, right now three important partitions are added to make the system bootable.

partition layout:

Part Start LBA End LBA Name
Attributes
Type GUID
Partition GUID
1 0x00000022 0x00000821 "loader1"

        attrs:  0x0000000000000000
        type:   5b193300-fc78-40cd-8002-e86c45580b47
        guid:   cbcbef44-e627-42bc-b134-93b6f3784b8c
  2     0x00000822      0x00002821      "loader2"
        attrs:  0x0000000000000000
        type:   2e54b353-1271-4842-806f-e436d6af6985
        guid:   f54eba28-d8de-4852-978d-1a673777e2ae
  3     0x00002822      0x00020821      "rootfs"
        attrs:  0x0000000000000004
        type:   0fc63daf-8483-4772-8e79-3d69d8477de4
        type:   linux
        guid:   9561df46-8d55-4799-a83b-cfee9ef6ff93

Note:
- loader1 would be fsbl or spl
- loader2 would be U-Boot or U-Boot proper

---
Changes for v2:
- update the partition table

Note: On top of https://patchwork.ozlabs.org/cover/1263480/

 board/sifive/fu540/Kconfig     |  2 ++
 include/configs/sifive-fu540.h | 13 +++++++++++++
 2 files changed, 15 insertions(+)
board/sifive/fu540/Kconfig +2 -0
index 5c67aab96a..43d01bab8d 100644
@@ -32,6 +32,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	imply CMD_EXT4
 	imply CMD_FAT
 	imply CMD_FS_GENERIC
+	imply CMD_GPT
+	imply PARTITION_TYPE_GUID
 	imply CMD_NET
 	imply CMD_PING
 	imply CLK_SIFIVE
include/configs/sifive-fu540.h +13 -0
index ef3ae9b650..72c841eb9b 100644
@@ -47,6 +47,15 @@
 
 #include <config_distro_bootcmd.h>
 
+#define TYPE_GUID_LOADER1	"5B193300-FC78-40CD-8002-E86C45580B47"
+#define TYPE_GUID_LOADER2	"2E54B353-1271-4842-806F-E436D6AF6985"
+#define TYPE_GUID_SYSTEM	"0FC63DAF-8483-4772-8E79-3D69D8477DE4"
+
+#define PARTS_DEFAULT \
+	"name=loader1,start=17K,size=1M,type=${type_guid_gpt_loader1};" \
+	"name=loader2,size=4MB,type=${type_guid_gpt_loader2};" \
+	"name=system,size=-,bootable,type=${type_guid_gpt_system};"
+
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"fdt_high=0xffffffffffffffff\0" \
 	"initrd_high=0xffffffffffffffff\0" \
@@ -55,6 +64,10 @@
 	"scriptaddr=0x88100000\0" \
 	"pxefile_addr_r=0x88200000\0" \
 	"ramdisk_addr_r=0x88300000\0" \
+	"type_guid_gpt_loader1=" TYPE_GUID_LOADER1 "\0" \
+	"type_guid_gpt_loader2=" TYPE_GUID_LOADER2 "\0" \
+	"type_guid_gpt_system=" TYPE_GUID_SYSTEM "\0" \
+	"partitions=" PARTS_DEFAULT "\0" \
 	BOOTENV
 
 #define CONFIG_PREBOOT \
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH v2 2/3 sifive: fu540: Add U-Boot proper sector start

Add U-Boot proper sector start offset for SiFive FU540. This value is based on the partition layout supported by SiFive FU540.

u-boot.itb need to write on this specific offset so-that the SPL will retrieve it from here and load.

---
Changes for v2:
- none

 common/spl/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
common/spl/Kconfig +2 -1
index 07eee56219..1ebb30344a 100644
@@ -308,7 +308,7 @@ config SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR
 		     ARCH_MX6 || ARCH_MX7 || \
 		     ARCH_ROCKCHIP || ARCH_MVEBU ||  ARCH_SOCFPGA || \
 		     ARCH_AT91 || ARCH_ZYNQ || ARCH_KEYSTONE || OMAP34XX || \
-		     OMAP44XX || OMAP54XX || AM33XX || AM43XX
+		     OMAP44XX || OMAP54XX || AM33XX || AM43XX || TARGET_SIFIVE_FU540
 	help
 	  Use sector number for specifying U-Boot location on MMC/SD in
 	  raw mode.
@@ -325,6 +325,7 @@ config SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR
 	default 0x300 if ARCH_ZYNQ || ARCH_KEYSTONE || OMAP34XX || OMAP44XX || \
 		         OMAP54XX || AM33XX || AM43XX || ARCH_K3
 	default 0x4000 if ARCH_ROCKCHIP
+	default 0x822 if TARGET_SIFIVE_FU540
 	help
 	  Address on the MMC to load U-Boot from, when the MMC is being used
 	  in raw mode. Units: MMC sectors (1 sector = 512 bytes).
Signature · 1 line
2.17.1
#2 lore raw

PATCH v2 2/3 sifive: fu540: Add U-Boot proper sector start

Hi Jagan,

Quoted 30 lines · Jagan Teki

Add U-Boot proper sector start offset for SiFive FU540. This value is based on the partition layout supported by SiFive FU540.

u-boot.itb need to write on this specific offset so-that the SPL will retrieve it from here and load.

---
Changes for v2:
- none

 common/spl/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
common/spl/Kconfig +1 -1
index 07eee56219..1ebb30344a 100644
@@ -308,7 +308,7 @@ config SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR
                     ARCH_MX6 || ARCH_MX7 || \
                     ARCH_ROCKCHIP || ARCH_MVEBU ||  ARCH_SOCFPGA || \
                     ARCH_AT91 || ARCH_ZYNQ || ARCH_KEYSTONE || OMAP34XX || \
-                    OMAP44XX || OMAP54XX || AM33XX || AM43XX
+                    OMAP44XX || OMAP54XX || AM33XX || AM43XX || TARGET_SIFIVE_FU540
        help
          Use sector number for specifying U-Boot location on MMC/SD in
          raw mode.

common/spl/Kconfig config SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR

Quoted 8 lines
common/spl/Kconfig +1 -1
@@ -325,6 +325,7 @@ config SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR
        default 0x300 if ARCH_ZYNQ || ARCH_KEYSTONE || OMAP34XX || OMAP44XX || \
                         OMAP54XX || AM33XX || AM43XX || ARCH_K3
        default 0x4000 if ARCH_ROCKCHIP
+       default 0x822 if TARGET_SIFIVE_FU540
        help
          Address on the MMC to load U-Boot from, when the MMC is being used
          in raw mode. Units: MMC sectors (1 sector = 512 bytes).
--

It looks my comments in v1 patch is not addressed?

Regards,
Bin

#3 lore raw

PATCH v2 2/3 sifive: fu540: Add U-Boot proper sector start

Hi Bin,

Quoted 60 lines

-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 29 April 2020 19:28
To: Jagan Teki <[email protected]>
Cc: Pragnesh Patel <[email protected]>; Rick Chen <[email protected]>; U-Boot Mailing List <[email protected]>; Sagar Kadam <[email protected]>; Paul Walmsley <[email protected]>; Troy Benjegerdes <[email protected]>; Palmer Dabbelt <[email protected]>; Anup Patel <[email protected]>; Atish Patra <[email protected]>; linux-amarula <linux-
amarula at amarulasolutions.com>
Subject: Re: [PATCH v2 2/3] sifive: fu540: Add U-Boot proper sector start

[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe

Hi Jagan,

common/spl/Kconfig config

Quoted 20 lines · Jagan Teki

Add U-Boot proper sector start offset for SiFive FU540. This value is based on the partition layout supported by SiFive FU540.

u-boot.itb need to write on this specific offset so-that the SPL will retrieve it from here and load.

---
Changes for v2:
- none

 common/spl/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
common/spl/Kconfig index renamed from common/spl/Kconfig +0 -0

07eee56219..1ebb30344a 100644

common/spl/Kconfig +0 -0
@@ -308,7 +308,7 @@ config

SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR

common/spl/Kconfig config SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR

Quoted 3 lines
common/spl/Kconfig +0 -0
                     ARCH_MX6 || ARCH_MX7 || \
                     ARCH_ROCKCHIP || ARCH_MVEBU ||  ARCH_SOCFPGA || \
                     ARCH_AT91 || ARCH_ZYNQ || ARCH_KEYSTONE || OMAP34XX ||

\

common/spl/Kconfig config SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR · line 325

Quoted 8 lines
common/spl/Kconfig +2 -1
-                    OMAP44XX || OMAP54XX || AM33XX || AM43XX
+                    OMAP44XX || OMAP54XX || AM33XX || AM43XX ||
+ TARGET_SIFIVE_FU540
        help
          Use sector number for specifying U-Boot location on MMC/SD in
          raw mode.
@@ -325,6 +325,7 @@ config SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR
        default 0x300 if ARCH_ZYNQ || ARCH_KEYSTONE || OMAP34XX ||

OMAP44XX || \

common/spl/Kconfig config SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR

Quoted 5 lines
common/spl/Kconfig +1 -0
                         OMAP54XX || AM33XX || AM43XX || ARCH_K3
        default 0x4000 if ARCH_ROCKCHIP
+       default 0x822 if TARGET_SIFIVE_FU540
        help
          Address on the MMC to load U-Boot from, when the MMC is being
Quoted 5 lines

used

common/spl/Kconfig config SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR

Quoted 2 lines
common/spl/Kconfig +0 -1
          in raw mode. Units: MMC sectors (1 sector = 512 bytes).
--

It looks my comments in v1 patch is not addressed?

@Bin Meng I did not see any comment from your side, please help me if I was wrong.

Quoted 3 lines

Regards,
Bin

#4 lore raw

PATCH v2 2/3 sifive: fu540: Add U-Boot proper sector start

Hi Pragnesh,

Quoted 63 lines · Pragnesh Patel

Hi Bin,

Quoted 60 lines

-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 29 April 2020 19:28
To: Jagan Teki <[email protected]>
Cc: Pragnesh Patel <[email protected]>; Rick Chen <[email protected]>; U-Boot Mailing List <[email protected]>; Sagar Kadam <[email protected]>; Paul Walmsley <[email protected]>; Troy Benjegerdes <[email protected]>; Palmer Dabbelt <[email protected]>; Anup Patel <[email protected]>; Atish Patra <[email protected]>; linux-amarula <linux-
amarula at amarulasolutions.com>
Subject: Re: [PATCH v2 2/3] sifive: fu540: Add U-Boot proper sector start

[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe

Hi Jagan,

common/spl/Kconfig config

Quoted 20 lines · Jagan Teki

Add U-Boot proper sector start offset for SiFive FU540. This value is based on the partition layout supported by SiFive FU540.

u-boot.itb need to write on this specific offset so-that the SPL will retrieve it from here and load.

---
Changes for v2:
- none

 common/spl/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
common/spl/Kconfig index renamed from common/spl/Kconfig +0 -0

07eee56219..1ebb30344a 100644

common/spl/Kconfig +0 -0
@@ -308,7 +308,7 @@ config

SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR

common/spl/Kconfig config SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR

Quoted 3 lines
common/spl/Kconfig +0 -0
                     ARCH_MX6 || ARCH_MX7 || \
                     ARCH_ROCKCHIP || ARCH_MVEBU ||  ARCH_SOCFPGA || \
                     ARCH_AT91 || ARCH_ZYNQ || ARCH_KEYSTONE || OMAP34XX ||

\

common/spl/Kconfig config SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR · line 325

Quoted 8 lines
common/spl/Kconfig +2 -1
-                    OMAP44XX || OMAP54XX || AM33XX || AM43XX
+                    OMAP44XX || OMAP54XX || AM33XX || AM43XX ||
+ TARGET_SIFIVE_FU540
        help
          Use sector number for specifying U-Boot location on MMC/SD in
          raw mode.
@@ -325,6 +325,7 @@ config SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR
        default 0x300 if ARCH_ZYNQ || ARCH_KEYSTONE || OMAP34XX ||

OMAP44XX || \

Quoted 5 lines
common/spl/Kconfig +1 -0
                         OMAP54XX || AM33XX || AM43XX || ARCH_K3
        default 0x4000 if ARCH_ROCKCHIP
+       default 0x822 if TARGET_SIFIVE_FU540
        help
          Address on the MMC to load U-Boot from, when the MMC is being
Quoted 7 lines
Quoted 5 lines

used

common/spl/Kconfig config SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR

Quoted 2 lines
common/spl/Kconfig +0 -1
          in raw mode. Units: MMC sectors (1 sector = 512 bytes).
--

It looks my comments in v1 patch is not addressed?

@Bin Meng I did not see any comment from your side, please help me if I was wrong.

Sorry, I was referring to another patch which is similar to this one:
https://lists.denx.de/pipermail/u-boot/2020-April/407627.html

Regards,
Bin

#5 lore raw

PATCH v2 2/3 sifive: fu540: Add U-Boot proper sector start

In reply to Jagan Teki
Quoted 53 lines

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: 20 April 2020 19:08
To: Pragnesh Patel <[email protected]>; rick at andestech.com; u- boot at lists.denx.de
Cc: bmeng.cn at gmail.com; Sagar Kadam <[email protected]>; Paul Walmsley <[email protected]>; Troy Benjegerdes <[email protected]>; palmerdabbelt at google.com; anup.patel at wdc.com; atish.patra at wdc.com; linux-
amarula at amarulasolutions.com; Jagan Teki <[email protected]>
Subject: [PATCH v2 2/3] sifive: fu540: Add U-Boot proper sector start

[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe

Add U-Boot proper sector start offset for SiFive FU540. This value is based on the partition layout supported by SiFive FU540.

u-boot.itb need to write on this specific offset so-that the SPL will retrieve it from here and load.

---
Changes for v2:
- none

common/spl/Kconfig | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)
common/spl/Kconfig index renamed from common/spl/Kconfig +0 -0

07eee56219..1ebb30344a 100644

common/spl/Kconfig +0 -0
@@ -308,7 +308,7 @@ config

SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR

                    ARCH_MX6 || ARCH_MX7 || \
                    ARCH_ROCKCHIP || ARCH_MVEBU ||  ARCH_SOCFPGA || \
                    ARCH_AT91 || ARCH_ZYNQ || ARCH_KEYSTONE || OMAP34XX || \
common/spl/Kconfig +3 -1
-                    OMAP44XX || OMAP54XX || AM33XX || AM43XX
+                    OMAP44XX || OMAP54XX || AM33XX || AM43XX ||
+ TARGET_SIFIVE_FU540
       help
         Use sector number for specifying U-Boot location on MMC/SD in
         raw mode.
@@ -325,6 +325,7 @@ config SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR
       default 0x300 if ARCH_ZYNQ || ARCH_KEYSTONE || OMAP34XX ||
 OMAP44XX || \
                        OMAP54XX || AM33XX || AM43XX || ARCH_K3
       default 0x4000 if ARCH_ROCKCHIP
+       default 0x822 if TARGET_SIFIVE_FU540
       help
         Address on the MMC to load U-Boot from, when the MMC is being used
Quoted 3 lines

in raw mode. Units: MMC sectors (1 sector = 512 bytes).
--
2.17.1

author
#6 lore raw

PATCH v2 3/3 doc: sifive: fu540: Document Boot from MMC

In reply to Jagan Teki

Document the Booting from MMC steps.

Detailed information about partitioning, flashing and etc.

---
Changes for v2:
- new patch

 doc/board/sifive/fu540.rst | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
doc/board/sifive/fu540.rst +28 -0
index 3937222c6c..691ef232e2 100644
@@ -363,3 +363,31 @@ load uImage.
 
    Please press Enter to activate this console.
    / #
+
+Booting from MMC
+----------------
+
+Use steps from "Building" section for building the U-Boot
+
+Format the SD card (make sure the disk has GPT, otherwise use gdisk to switch)
+
+.. code-block:: none
+
+   # sudo sgdisk --clear \
+   > --set-alignment=2 \
+   > --new=1:34:2081 --change-name=1:loader1 --typecode=1:5B193300-FC78-40CD-8002-E86C45580B47 \
+   > --new=2:2082:10273 --change-name=2:loader2 --typecode=2:2E54B353-1271-4842-806F-E436D6AF6985 \
+   > --new=3:10274: --change-name=3:rootfs --typecode=3:0FC63DAF-8483-4772-8E79-3D69D8477DE4 \
+   > /dev/sda
+
+Program the SD card
+
+.. code-block:: none
+
+   sudo dd if=spl/u-boot-spl.bin of=/dev/sda seek=34
+   sudo dd if=u-boot.itb of=/dev/sda seek=2082
+   sync
+
+Change DIP switches MSEL[3:0] are set to 1011
+
+Insert the SD card and power up the board.
Signature · 1 line
2.17.1
#7 lore raw

PATCH v2 3/3 doc: sifive: fu540: Document Boot from MMC

Quoted 5 lines · Jagan Teki

Document the Booting from MMC steps.

Detailed information about partitioning, flashing and etc.

Quoted 8 lines

---
Changes for v2:
- new patch

 doc/board/sifive/fu540.rst | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
#8 lore raw

PATCH v2 3/3 doc: sifive: fu540: Document Boot from MMC

In reply to Jagan Teki

Hi Jagan,

Quoted 19 lines

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: 20 April 2020 19:08
To: Pragnesh Patel <[email protected]>; rick at andestech.com; u- boot at lists.denx.de
Cc: bmeng.cn at gmail.com; Sagar Kadam <[email protected]>; Paul Walmsley <[email protected]>; Troy Benjegerdes <[email protected]>; palmerdabbelt at google.com; anup.patel at wdc.com; atish.patra at wdc.com; linux-
amarula at amarulasolutions.com; Jagan Teki <[email protected]>
Subject: [PATCH v2 3/3] doc: sifive: fu540: Document Boot from MMC

[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe

Document the Booting from MMC steps.

Detailed information about partitioning, flashing and etc.

Quoted 8 lines

---
Changes for v2:
- new patch

doc/board/sifive/fu540.rst | 28 ++++++++++++++++++++++++++++

1 file changed, 28 insertions(+)

This changes is not on top of https://patchwork.ozlabs.org/project/uboot/patch/20200329170538.25449-18-pragnesh.patel at sifive.com/ this.

If you don't mind, I will incorporate your changes in my v7 series which has a complete description for FSBL and SPL.

Quoted 42 lines
doc/board/sifive/fu540.rst index renamed from doc/board/sifive/fu540.rst +0 -0

3937222c6c..691ef232e2 100644

doc/board/sifive/fu540.rst +14 -0
@@ -363,3 +363,31 @@ load uImage.
 
   Please press Enter to activate this console.
   / #
+
+Booting from MMC
+----------------
+
+Use steps from "Building" section for building the U-Boot
+
+Format the SD card (make sure the disk has GPT, otherwise use gdisk to
+switch)
+
+.. code-block:: none
+
+   # sudo sgdisk --clear \
+   > --set-alignment=2 \
+   > --new=1:34:2081 --change-name=1:loader1 --typecode=1:5B193300-FC78-

40CD-8002-E86C45580B47 \
+ > --new=2:2082:10273 --change-name=2:loader2 --typecode=2:2E54B353-
1271-4842-806F-E436D6AF6985 \
+ > --new=3:10274: --change-name=3:rootfs --typecode=3:0FC63DAF-8483-
4772-8E79-3D69D8477DE4 \

doc/board/sifive/fu540.rst +13 -1
+   > /dev/sda
+
+Program the SD card
+
+.. code-block:: none
+
+   sudo dd if=spl/u-boot-spl.bin of=/dev/sda seek=34
+   sudo dd if=u-boot.itb of=/dev/sda seek=2082
+   sync
+
+Change DIP switches MSEL[3:0] are set to 1011
+
+Insert the SD card and power up the board.
--

2.17.1

author
#9 lore raw

PATCH v2 3/3 doc: sifive: fu540: Document Boot from MMC

Quoted 27 lines · Pragnesh Patel

Hi Jagan,

Quoted 24 lines

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: 20 April 2020 19:08
To: Pragnesh Patel <[email protected]>; rick at andestech.com; u- boot at lists.denx.de
Cc: bmeng.cn at gmail.com; Sagar Kadam <[email protected]>; Paul Walmsley <[email protected]>; Troy Benjegerdes <[email protected]>; palmerdabbelt at google.com; anup.patel at wdc.com; atish.patra at wdc.com; linux-
amarula at amarulasolutions.com; Jagan Teki <[email protected]>
Subject: [PATCH v2 3/3] doc: sifive: fu540: Document Boot from MMC

[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe

Document the Booting from MMC steps.

Detailed information about partitioning, flashing and etc.

---
Changes for v2:
- new patch

Quoted 8 lines
Quoted 3 lines

doc/board/sifive/fu540.rst | 28 ++++++++++++++++++++++++++++

1 file changed, 28 insertions(+)

This changes is not on top of https://patchwork.ozlabs.org/project/uboot/patch/20200329170538.25449-18-pragnesh.patel at sifive.com/ this.

If you don't mind, I will incorporate your changes in my v7 series which has a complete description for FSBL and SPL.

Better take it in a patch where you enable SPL MMC. and have another patch before that with existing FSBL availability. This way changes look easy to understand.

Jagan.

#10 lore raw

PATCH v2 3/3 doc: sifive: fu540: Document Boot from MMC

Hi Jagan,

Quoted 54 lines

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: 29 April 2020 21:26
To: Pragnesh Patel <[email protected]>
Cc: rick at andestech.com; u-boot at lists.denx.de; bmeng.cn at gmail.com; Sagar Kadam <[email protected]>; Paul Walmsley <[email protected]>; Troy Benjegerdes <[email protected]>; palmerdabbelt at google.com; anup.patel at wdc.com; atish.patra at wdc.com; linux-
amarula at amarulasolutions.com
Subject: Re: [PATCH v2 3/3] doc: sifive: fu540: Document Boot from MMC

[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe

Quoted 13 lines · Pragnesh Patel

Hi Jagan,

Quoted 10 lines

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: 20 April 2020 19:08
To: Pragnesh Patel <[email protected]>; rick at andestech.com; u- boot at lists.denx.de
Cc: bmeng.cn at gmail.com; Sagar Kadam <[email protected]>; Paul Walmsley <[email protected]>; Troy Benjegerdes <[email protected]>; palmerdabbelt at google.com; anup.patel at wdc.com; atish.patra at wdc.com; linux- amarula at amarulasolutions.com; Jagan Teki

<[email protected]>

Quoted 23 lines
Quoted 9 lines

Subject: [PATCH v2 3/3] doc: sifive: fu540: Document Boot from MMC

[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe

Document the Booting from MMC steps.

Detailed information about partitioning, flashing and etc.

Quoted 8 lines

---
Changes for v2:
- new patch

doc/board/sifive/fu540.rst | 28 ++++++++++++++++++++++++++++

1 file changed, 28 insertions(+)

This changes is not on top of
https://patchwork.ozlabs.org/project/uboot/patch/20200329170538.25449-
18-pragnesh.patel at sifive.com/
this.

Quoted 6 lines
Quoted 1 line

If you don't mind, I will incorporate your changes in my v7 series which has a

complete description for FSBL and SPL.

Better take it in a patch where you enable SPL MMC. and have another patch before that with existing FSBL availability. This way changes look easy to understand.

Nice suggestion, I will incorporate this changes in my v7 series and also add your Signed-off-by.

Can you please drop this patch in v3.

Quoted 2 lines

Jagan.

#11 lore raw

PATCH v2 1/3 sifive: fu540: Add sample SD gpt partition layout

In reply to Jagan Teki

Hi Jagan,

Quoted 92 lines

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: 20 April 2020 19:08
To: Pragnesh Patel <[email protected]>; rick at andestech.com; u- boot at lists.denx.de
Cc: bmeng.cn at gmail.com; Sagar Kadam <[email protected]>; Paul Walmsley <[email protected]>; Troy Benjegerdes <[email protected]>; palmerdabbelt at google.com; anup.patel at wdc.com; atish.patra at wdc.com; linux-
amarula at amarulasolutions.com; Jagan Teki <[email protected]>
Subject: [PATCH v2 1/3] sifive: fu540: Add sample SD gpt partition layout

[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe

This is a sample GPT partition layout for SD card, right now three important partitions are added to make the system bootable.

partition layout:

Part Start LBA End LBA Name
Attributes
Type GUID
Partition GUID
1 0x00000022 0x00000821 "loader1"

       attrs:  0x0000000000000000
       type:   5b193300-fc78-40cd-8002-e86c45580b47
       guid:   cbcbef44-e627-42bc-b134-93b6f3784b8c
 2     0x00000822      0x00002821      "loader2"
       attrs:  0x0000000000000000
       type:   2e54b353-1271-4842-806f-e436d6af6985
       guid:   f54eba28-d8de-4852-978d-1a673777e2ae
 3     0x00002822      0x00020821      "rootfs"
       attrs:  0x0000000000000004
       type:   0fc63daf-8483-4772-8e79-3d69d8477de4
       type:   linux
       guid:   9561df46-8d55-4799-a83b-cfee9ef6ff93

Note:
- loader1 would be fsbl or spl
- loader2 would be U-Boot or U-Boot proper

---
Changes for v2:
- update the partition table

Note: On top of https://patchwork.ozlabs.org/cover/1263480/

board/sifive/fu540/Kconfig | 2 ++
include/configs/sifive-fu540.h | 13 +++++++++++++

2 files changed, 15 insertions(+)
board/sifive/fu540/Kconfig index renamed from board/sifive/fu540/Kconfig +0 -0

5c67aab96a..43d01bab8d 100644

board/sifive/fu540/Kconfig +2 -0
@@ -32,6 +32,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy
       imply CMD_EXT4
       imply CMD_FAT
       imply CMD_FS_GENERIC
+       imply CMD_GPT
+       imply PARTITION_TYPE_GUID
       imply CMD_NET
       imply CMD_PING
       imply CLK_SIFIVE
include/configs/sifive-fu540.h +1 -0
index ef3ae9b650..72c841eb9b 100644
@@ -47,6 +47,15 @@
 
 #include <config_distro_bootcmd.h>
 
+#define TYPE_GUID_LOADER1      "5B193300-FC78-40CD-8002-

E86C45580B47"
+#define TYPE_GUID_LOADER2 "2E54B353-1271-4842-806F-
E436D6AF6985"
+#define TYPE_GUID_SYSTEM "0FC63DAF-8483-4772-8E79-
3D69D8477DE4"

include/configs/sifive-fu540.h +6 -0
+
+#define PARTS_DEFAULT \
+       "name=loader1,start=17K,size=1M,type=${type_guid_gpt_loader1};" \
+       "name=loader2,size=4MB,type=${type_guid_gpt_loader2};" \
+       "name=system,size=-,bootable,type=${type_guid_gpt_system};"
+
#define CONFIG_EXTRA_ENV_SETTINGS \
       "fdt_high=0xffffffffffffffff\0" \
       "initrd_high=0xffffffffffffffff\0" \ @@ -55,6 +64,10 @@
       "scriptaddr=0x88100000\0" \
       "pxefile_addr_r=0x88200000\0" \
       "ramdisk_addr_r=0x88300000\0" \

include/configs/sifive-fu540.h line 70

Quoted 4 lines
include/configs/sifive-fu540.h +4 -0
+       "type_guid_gpt_loader1=" TYPE_GUID_LOADER1 "\0" \
+       "type_guid_gpt_loader2=" TYPE_GUID_LOADER2 "\0" \
+       "type_guid_gpt_system=" TYPE_GUID_SYSTEM "\0" \
+       "partitions=" PARTS_DEFAULT "\0" \
Quoted 5 lines

BOOTENV

#define CONFIG_PREBOOT \
--
2.17.1

#12 lore raw

PATCH v2 1/3 sifive: fu540: Add sample SD gpt partition layout

In reply to Jagan Teki
Quoted 34 lines · Jagan Teki

This is a sample GPT partition layout for SD card, right now three important partitions are added to make the system bootable.

partition layout:

Part Start LBA End LBA Name
Attributes
Type GUID
Partition GUID
1 0x00000022 0x00000821 "loader1"

        attrs:  0x0000000000000000
        type:   5b193300-fc78-40cd-8002-e86c45580b47
        guid:   cbcbef44-e627-42bc-b134-93b6f3784b8c
  2     0x00000822      0x00002821      "loader2"
        attrs:  0x0000000000000000
        type:   2e54b353-1271-4842-806f-e436d6af6985
        guid:   f54eba28-d8de-4852-978d-1a673777e2ae
  3     0x00002822      0x00020821      "rootfs"
        attrs:  0x0000000000000004
        type:   0fc63daf-8483-4772-8e79-3d69d8477de4
        type:   linux
        guid:   9561df46-8d55-4799-a83b-cfee9ef6ff93

Note:
- loader1 would be fsbl or spl
- loader2 would be U-Boot or U-Boot proper

---
Changes for v2:
- update the partition table

Quoted 6 lines

Note: On top of https://patchwork.ozlabs.org/cover/1263480/

 board/sifive/fu540/Kconfig     |  2 ++
 include/configs/sifive-fu540.h | 13 +++++++++++++
 2 files changed, 15 insertions(+)