usb: dwc3-meson-g12a: add power-on/off of the PHYs
Subsystems (3)
PATCH 1/1 usb: dwc3-meson-g12a: add power-on/off of the PHYs
Power on/off the PHYs to enable power to the USB ports, fixing USB support on Khadas VIM3/VIM3L boards.
--- drivers/usb/dwc3/dwc3-meson-g12a.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
drivers/usb/dwc3/dwc3-meson-g12a.c +16 -0
@@ -408,6 +408,15 @@ static int dwc3_meson_g12a_probe(struct udevice *dev) goto err_phy_init; } +for (i =0 ; i <PHY_COUNT ; ++i) { +if (!priv->phys[i].dev) +continue ; + + ret =generic_phy_power_on (&priv->phys[i]); +if (ret) + goto err_phy_init; + } +return 0 ; err_phy_init:
@@ -430,6 +439,13 @@ static int dwc3_meson_g12a_remove(struct udevice *dev)clk_release_all (&priv->clk,1 ); +for (i =0 ; i <PHY_COUNT ; ++i) { +if (!priv->phys[i].dev) +continue ; + +generic_phy_power_off (&priv->phys[i]); + } +for (i =0 ; i <PHY_COUNT ; ++i) {if (!priv->phys[i].dev)continue ;
Signature · 1 line
2.22.0
PATCH 1/1 usb: dwc3-meson-g12a: add power-on/off of the PHYs
Quoted 13 lines · Neil Armstrong
Power on/off the PHYs to enable power to the USB ports, fixing USB support on Khadas VIM3/VIM3L boards.
Signed-off-by Neil Armstrong <[email protected]>--- drivers/usb/dwc3/dwc3-meson-g12a.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/usb/dwc3/dwc3-meson-g12a.c +0
-0
drivers/usb/dwc3/dwc3-meson-g12a.c static int dwc3_meson_g12a_probe(struct udevice *dev) · line 411
Quoted 4 lines
drivers/usb/dwc3/dwc3-meson-g12a.c +1
-0@@ -408,6 +408,15 @@ static int dwc3_meson_g12a_probe(struct udevice *dev) goto err_phy_init; } +for (i =0 ; i <PHY_COUNT ; ++i) {
Doesn't checkpatch complain about this extra space before semicolon ?
drivers/usb/dwc3/dwc3-meson-g12a.c static int dwc3_meson_g12a_probe(struct udevice *dev) · line 415
Quoted 4 lines
drivers/usb/dwc3/dwc3-meson-g12a.c +4
-0+if (!priv->phys[i].dev) +continue ; + + ret =generic_phy_power_on (&priv->phys[i]);
Do we really need to turn on all the PHYs ?
PATCH 1/1 usb: dwc3-meson-g12a: add power-on/off of the PHYs
Quoted 17 lines · Marek Vasut
Quoted 16 lines · Neil Armstrong
Power on/off the PHYs to enable power to the USB ports, fixing USB support on Khadas VIM3/VIM3L boards.
Signed-off-by Neil Armstrong <[email protected]>--- drivers/usb/dwc3/dwc3-meson-g12a.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/usb/dwc3/dwc3-meson-g12a.c +0
-0@@ -408,6 +408,15 @@ static int dwc3_meson_g12a_probe(struct udevice *dev) goto err_phy_init; }
Quoted 3 lines
drivers/usb/dwc3/dwc3-meson-g12a.c static int dwc3_meson_g12a_probe(struct udevice *dev) · line 411
Quoted 1 line
drivers/usb/dwc3/dwc3-meson-g12a.c +1
-0+for (i =0 ; i <PHY_COUNT ; ++i) {Doesn't checkpatch complain about this extra space before semicolon ?
Nop, even in --strict
Quoted 8 lines
drivers/usb/dwc3/dwc3-meson-g12a.c static int dwc3_meson_g12a_probe(struct udevice *dev) · line 415
Quoted 5 lines
drivers/usb/dwc3/dwc3-meson-g12a.c +4
-0+if (!priv->phys[i].dev) +continue ; + + ret =generic_phy_power_on (&priv->phys[i]);Do we really need to turn on all the PHYs ?
Yes
Neil
PATCH 1/1 usb: dwc3-meson-g12a: add power-on/off of the PHYs
Quoted 18 lines · Neil Armstrong
Quoted 17 lines · Marek Vasut
Quoted 16 lines · Neil Armstrong
Power on/off the PHYs to enable power to the USB ports, fixing USB support on Khadas VIM3/VIM3L boards.
Signed-off-by Neil Armstrong <[email protected]>--- drivers/usb/dwc3/dwc3-meson-g12a.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/usb/dwc3/dwc3-meson-g12a.c +0
-0@@ -408,6 +408,15 @@ static int dwc3_meson_g12a_probe(struct udevice *dev) goto err_phy_init; }
Quoted 5 lines
Quoted 3 lines
drivers/usb/dwc3/dwc3-meson-g12a.c static int dwc3_meson_g12a_probe(struct udevice *dev) · line 411
Quoted 1 line
drivers/usb/dwc3/dwc3-meson-g12a.c +1
-0+for (i =0 ; i <PHY_COUNT ; ++i) {Doesn't checkpatch complain about this extra space before semicolon ?
Nop, even in --strict
Shouldn't it though ? I thought this extra space was forbidden.
Quoted 10 lines
Quoted 8 lines
drivers/usb/dwc3/dwc3-meson-g12a.c static int dwc3_meson_g12a_probe(struct udevice *dev) · line 415
Quoted 5 lines
drivers/usb/dwc3/dwc3-meson-g12a.c +4
-0+if (!priv->phys[i].dev) +continue ; + + ret =generic_phy_power_on (&priv->phys[i]);Do we really need to turn on all the PHYs ?
Yes
Then should we have something like clk_bulk_*(), but for phys ?
PATCH 1/1 usb: dwc3-meson-g12a: add power-on/off of the PHYs
Quoted 19 lines · Marek Vasut
Quoted 18 lines · Neil Armstrong
Quoted 17 lines · Marek Vasut
Quoted 16 lines · Neil Armstrong
Power on/off the PHYs to enable power to the USB ports, fixing USB support on Khadas VIM3/VIM3L boards.
Signed-off-by Neil Armstrong <[email protected]>--- drivers/usb/dwc3/dwc3-meson-g12a.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/usb/dwc3/dwc3-meson-g12a.c +0
-0@@ -408,6 +408,15 @@ static int dwc3_meson_g12a_probe(struct udevice *dev) goto err_phy_init; }
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
drivers/usb/dwc3/dwc3-meson-g12a.c static int dwc3_meson_g12a_probe(struct udevice *dev) · line 411
Quoted 1 line
drivers/usb/dwc3/dwc3-meson-g12a.c +1
-0+for (i =0 ; i <PHY_COUNT ; ++i) {Doesn't checkpatch complain about this extra space before semicolon ?
Nop, even in --strict
Shouldn't it though ? I thought this extra space was forbidden.
No idea, this line is copied from the for loop doing the phy init, itself copied from the Linux code passing all checkpatch checks.
Quoted 10 lines
Quoted 10 lines
Quoted 9 lines
drivers/usb/dwc3/dwc3-meson-g12a.c static int dwc3_meson_g12a_probe(struct udevice *dev) · line 415
Quoted 6 lines
drivers/usb/dwc3/dwc3-meson-g12a.c +4
-0+if (!priv->phys[i].dev) +continue ; + + ret =generic_phy_power_on (&priv->phys[i]);Do we really need to turn on all the PHYs ?
Quoted 4 lines
Quoted 1 line
Yes
Then should we have something like clk_bulk_*(), but for phys ?
Eventually, yes, but this goes beyond a fix.
Neil
PATCH 1/1 usb: dwc3-meson-g12a: add power-on/off of the PHYs
Quoted 24 lines · Neil Armstrong
Quoted 23 lines · Marek Vasut
Quoted 22 lines · Neil Armstrong
Quoted 20 lines · Marek Vasut
Quoted 13 lines · Neil Armstrong
Power on/off the PHYs to enable power to the USB ports, fixing USB support on Khadas VIM3/VIM3L boards.
Signed-off-by Neil Armstrong <[email protected]>--- drivers/usb/dwc3/dwc3-meson-g12a.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/usb/dwc3/dwc3-meson-g12a.c +0
-0drivers/usb/dwc3/dwc3-meson-g12a.c static int dwc3_meson_g12a_probe(struct udevice *dev) · line 411
Quoted 4 lines
drivers/usb/dwc3/dwc3-meson-g12a.c +1
-0@@ -408,6 +408,15 @@ static int dwc3_meson_g12a_probe(struct udevice *dev) goto err_phy_init; } +for (i =0 ; i <PHY_COUNT ; ++i) {Doesn't checkpatch complain about this extra space before semicolon ?
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Nop, even in --strict
Shouldn't it though ? I thought this extra space was forbidden.
No idea, this line is copied from the for loop doing the phy init, itself copied from the Linux code passing all checkpatch checks.
Could you change it to for (i = 0; i < PHY_COUNT; i++) please ?
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
drivers/usb/dwc3/dwc3-meson-g12a.c static int dwc3_meson_g12a_probe(struct udevice *dev) · line 415
Quoted 5 lines
drivers/usb/dwc3/dwc3-meson-g12a.c +4
-0+if (!priv->phys[i].dev) +continue ; + + ret =generic_phy_power_on (&priv->phys[i]);Do we really need to turn on all the PHYs ?
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Yes
Then should we have something like clk_bulk_*(), but for phys ?
Eventually, yes, but this goes beyond a fix.
The merge window is open for quite a bit longer, so doing this in a generic way would be appreciated.
btw while you're at it, shouldn't the PHY_COUNT be replaced with some PHY count detection by reading the DT ? ( I don't have the hardware and I don't know the amlogic SoCs though )
PATCH 1/1 usb: dwc3-meson-g12a: add power-on/off of the PHYs
Quoted 25 lines · Marek Vasut
Quoted 24 lines · Neil Armstrong
Quoted 23 lines · Marek Vasut
Quoted 22 lines · Neil Armstrong
Quoted 20 lines · Marek Vasut
Quoted 13 lines · Neil Armstrong
Power on/off the PHYs to enable power to the USB ports, fixing USB support on Khadas VIM3/VIM3L boards.
Signed-off-by Neil Armstrong <[email protected]>--- drivers/usb/dwc3/dwc3-meson-g12a.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/usb/dwc3/dwc3-meson-g12a.c +0
-0drivers/usb/dwc3/dwc3-meson-g12a.c static int dwc3_meson_g12a_probe(struct udevice *dev) · line 411
Quoted 4 lines
drivers/usb/dwc3/dwc3-meson-g12a.c +1
-0@@ -408,6 +408,15 @@ static int dwc3_meson_g12a_probe(struct udevice *dev) goto err_phy_init; } +for (i =0 ; i <PHY_COUNT ; ++i) {Doesn't checkpatch complain about this extra space before semicolon ?
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Nop, even in --strict
Shouldn't it though ? I thought this extra space was forbidden.
No idea, this line is copied from the for loop doing the phy init, itself copied from the Linux code passing all checkpatch checks.
Could you change it to for (i = 0; i <
PHY_COUNT; i++) please ?
Sure
Quoted 15 lines
Quoted 15 lines
Quoted 14 lines
Quoted 11 lines
Quoted 9 lines
drivers/usb/dwc3/dwc3-meson-g12a.c static int dwc3_meson_g12a_probe(struct udevice *dev) · line 415
Quoted 6 lines
drivers/usb/dwc3/dwc3-meson-g12a.c +4
-0+if (!priv->phys[i].dev) +continue ; + + ret =generic_phy_power_on (&priv->phys[i]);Do we really need to turn on all the PHYs ?
Yes
Then should we have something like clk_bulk_*(), but for phys ?
Quoted 9 lines
Quoted 1 line
Eventually, yes, but this goes beyond a fix.
The merge window is open for quite a bit longer, so doing this in a generic way would be appreciated.
btw while you're at it, shouldn't the
PHY_COUNTbe replaced with some PHY count detection by reading the DT ? ( I don't have the hardware and I don't know the amlogic SoCs though )
Hmm, the PHYs list can have some holes (i.e only the second PHY could be used on 3), and the name of the PHY determines it's type and position (PHY1 is a special OTG phy) this is why we loop over a fixed array and check if the PHY pointer exists.
This won't match a phy_bulk_code directly, I would still need to map the bulk PHYs to this array for the OTG and USB3 management.
Neil
PATCH 1/1 usb: dwc3-meson-g12a: add power-on/off of the PHYs
On 4/20/20 4:07 PM, Neil Armstrong wrote:
[...]
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
Quoted 1 line
Doesn't checkpatch complain about this extra space before semicolon ?
Nop, even in --strict
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Shouldn't it though ? I thought this extra space was forbidden.
No idea, this line is copied from the for loop doing the phy init, itself copied from the Linux code passing all checkpatch checks.
Could you change it to for (i = 0; i <
PHY_COUNT; i++) please ?Sure
Thank you.
( I'm still surprised checkpatch doesn't warn about it, I was quite sure it was one of the checks at some point, hmmmmm. )
Quoted 19 lines
Quoted 19 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Review
Quoted 5 lines
(quoted diff) +4
-0+ if (!priv->phys[i].dev) + continue; + + ret = generic_phy_power_on(&priv->phys[i]);Do we really need to turn on all the PHYs ?
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Yes
Then should we have something like clk_bulk_*(), but for phys ?
Eventually, yes, but this goes beyond a fix.
The merge window is open for quite a bit longer, so doing this in a generic way would be appreciated.
Quoted 8 lines
Quoted 4 lines
btw while you're at it, shouldn't the
PHY_COUNTbe replaced with some PHY count detection by reading the DT ? ( I don't have the hardware and I don't know the amlogic SoCs though )Hmm, the PHYs list can have some holes (i.e only the second PHY could be used on 3), and the name of the PHY determines it's type and position (PHY1 is a special OTG phy) this is why we loop over a fixed array and check if the PHY pointer exists.
Um, that sounds like a vaguely familiar problem. Is that an issue with mapping between controller and a USB PHY ? Is that mapping fixed or is it configured from DT ? And then, should all PHYs really be powered on, or should only the PHY matching the currently used controller be powered on ?
Quoted 2 lines
This won't match a
phy_bulk_codedirectly, I would still need to map the bulk PHYs to this array for the OTG and USB3 management.
OK
PATCH 1/1 usb: dwc3-meson-g12a: add power-on/off of the PHYs
Quoted 45 lines · Marek Vasut
On 4/20/20 4:07 PM, Neil Armstrong wrote:
[...]Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
Quoted 1 line
Doesn't checkpatch complain about this extra space before semicolon ?
Nop, even in --strict
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Shouldn't it though ? I thought this extra space was forbidden.
No idea, this line is copied from the for loop doing the phy init, itself copied from the Linux code passing all checkpatch checks.
Could you change it to for (i = 0; i <
PHY_COUNT; i++) please ?Sure
Thank you.
( I'm still surprised checkpatch doesn't warn about it, I was quite sure it was one of the checks at some point, hmmmmm. )
Quoted 24 lines
Quoted 23 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Review
Quoted 5 lines
(quoted diff) +4
-0+ if (!priv->phys[i].dev) + continue; + + ret = generic_phy_power_on(&priv->phys[i]);Do we really need to turn on all the PHYs ?
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Yes
Then should we have something like clk_bulk_*(), but for phys ?
Eventually, yes, but this goes beyond a fix.
The merge window is open for quite a bit longer, so doing this in a generic way would be appreciated.
btw while you're at it, shouldn't the
PHY_COUNTbe replaced with some PHY count detection by reading the DT ? ( I don't have the hardware and I don't know the amlogic SoCs though )
Quoted 7 lines
Quoted 3 lines
Hmm, the PHYs list can have some holes (i.e only the second PHY could be used on 3), and the name of the PHY determines it's type and position (PHY1 is a special OTG phy) this is why we loop over a fixed array and check if the PHY pointer exists.
Um, that sounds like a vaguely familiar problem. Is that an issue with mapping between controller and a USB PHY ? Is that mapping fixed or is it configured from DT ?
Mapping is done via DT, all PHYs are optional depending on the board layout.
Quoted 3 lines
And then, should all PHYs really be powered on,
or should only the PHY matching the currently used controller be powered on ?
All PHYs are connected to a glue that muxes 1 PHY between DWC2 and DWC3, and the other USB2 PHYs (for now 1, but previous SoCs had 2) to DWC3, the USB3 PHY is muxed between PCIe to dw-pcie and DWC3.
So we power-on only the PHYs specified in DT, thus the:
if (!priv->phys[i].dev) continue;
I attached the USB complex diagram if you need it.
Neil
Quoted 6 lines
Quoted 3 lines
This won't match a
phy_bulk_codedirectly, I would still need to map the bulk PHYs to this array for the OTG and USB3 management.OK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: G12A USB.svg
Type: image/svg+xml
Size: 51866 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200420/80913a8d/attachment-0001.svg>
PATCH 1/1 usb: dwc3-meson-g12a: add power-on/off of the PHYs
Quoted 64 lines · Neil Armstrong
Quoted 45 lines · Marek Vasut
On 4/20/20 4:07 PM, Neil Armstrong wrote:
[...]Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
Quoted 1 line
Doesn't checkpatch complain about this extra space before semicolon ?
Nop, even in --strict
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Shouldn't it though ? I thought this extra space was forbidden.
No idea, this line is copied from the for loop doing the phy init, itself copied from the Linux code passing all checkpatch checks.
Could you change it to for (i = 0; i <
PHY_COUNT; i++) please ?Sure
Thank you.
( I'm still surprised checkpatch doesn't warn about it, I was quite sure it was one of the checks at some point, hmmmmm. )
Quoted 24 lines
Quoted 23 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Review
Quoted 5 lines
(quoted diff) +4
-0+ if (!priv->phys[i].dev) + continue; + + ret = generic_phy_power_on(&priv->phys[i]);Do we really need to turn on all the PHYs ?
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Yes
Then should we have something like clk_bulk_*(), but for phys ?
Eventually, yes, but this goes beyond a fix.
The merge window is open for quite a bit longer, so doing this in a generic way would be appreciated.
btw while you're at it, shouldn't the
PHY_COUNTbe replaced with some PHY count detection by reading the DT ? ( I don't have the hardware and I don't know the amlogic SoCs though )Quoted 7 lines
Quoted 3 lines
Hmm, the PHYs list can have some holes (i.e only the second PHY could be used on 3), and the name of the PHY determines it's type and position (PHY1 is a special OTG phy) this is why we loop over a fixed array and check if the PHY pointer exists.
Um, that sounds like a vaguely familiar problem. Is that an issue with mapping between controller and a USB PHY ? Is that mapping fixed or is it configured from DT ?
Mapping is done via DT, all PHYs are optional depending on the board layout.
Quoted 3 lines
And then, should all PHYs really be powered on,
or should only the PHY matching the currently used controller be powered on ?All PHYs are connected to a glue that muxes 1 PHY between DWC2 and DWC3, and the other USB2 PHYs (for now 1, but previous SoCs had 2) to DWC3, the USB3 PHY is muxed between PCIe to dw-pcie and DWC3.
Quoted 5 lines
So we power-on only the PHYs specified in DT, thus the:
if (!priv->phys[i].dev) continue;I attached the USB complex diagram if you need it.
OK, thanks for clarifying. Now, can you document this in the commit message, so we have this information stored somewhere for future reference ? This would be real useful.
PATCH 1/1 usb: dwc3-meson-g12a: add power-on/off of the PHYs
Quoted 69 lines · Marek Vasut
Quoted 68 lines · Neil Armstrong
Quoted 45 lines · Marek Vasut
On 4/20/20 4:07 PM, Neil Armstrong wrote:
[...]Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
Quoted 1 line
Doesn't checkpatch complain about this extra space before semicolon ?
Nop, even in --strict
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Shouldn't it though ? I thought this extra space was forbidden.
No idea, this line is copied from the for loop doing the phy init, itself copied from the Linux code passing all checkpatch checks.
Could you change it to for (i = 0; i <
PHY_COUNT; i++) please ?Sure
Thank you.
( I'm still surprised checkpatch doesn't warn about it, I was quite sure it was one of the checks at some point, hmmmmm. )
Quoted 24 lines
Quoted 23 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Review
Quoted 5 lines
(quoted diff) +4
-0+ if (!priv->phys[i].dev) + continue; + + ret = generic_phy_power_on(&priv->phys[i]);Do we really need to turn on all the PHYs ?
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Yes
Then should we have something like clk_bulk_*(), but for phys ?
Eventually, yes, but this goes beyond a fix.
The merge window is open for quite a bit longer, so doing this in a generic way would be appreciated.
btw while you're at it, shouldn't the
PHY_COUNTbe replaced with some PHY count detection by reading the DT ? ( I don't have the hardware and I don't know the amlogic SoCs though )Quoted 7 lines
Quoted 3 lines
Hmm, the PHYs list can have some holes (i.e only the second PHY could be used on 3), and the name of the PHY determines it's type and position (PHY1 is a special OTG phy) this is why we loop over a fixed array and check if the PHY pointer exists.
Um, that sounds like a vaguely familiar problem. Is that an issue with mapping between controller and a USB PHY ? Is that mapping fixed or is it configured from DT ?
Mapping is done via DT, all PHYs are optional depending on the board layout.
Quoted 3 lines
And then, should all PHYs really be powered on,
or should only the PHY matching the currently used controller be powered on ?All PHYs are connected to a glue that muxes 1 PHY between DWC2 and DWC3, and the other USB2 PHYs (for now 1, but previous SoCs had 2) to DWC3, the USB3 PHY is muxed between PCIe to dw-pcie and DWC3.
So we power-on only the PHYs specified in DT, thus the:
if (!priv->phys[i].dev) continue;
Quoted 6 lines
Quoted 1 line
I attached the USB complex diagram if you need it.
OK, thanks for clarifying. Now, can you document this in the commit message, so we have this information stored somewhere for future reference ? This would be real useful.
Yes sure.
Neil
PATCH 1/1 usb: dwc3-meson-g12a: add power-on/off of the PHYs
Quoted 70 lines · Neil Armstrong
Quoted 69 lines · Marek Vasut
Quoted 68 lines · Neil Armstrong
Quoted 45 lines · Marek Vasut
On 4/20/20 4:07 PM, Neil Armstrong wrote:
[...]Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
Quoted 1 line
Doesn't checkpatch complain about this extra space before semicolon ?
Nop, even in --strict
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Shouldn't it though ? I thought this extra space was forbidden.
No idea, this line is copied from the for loop doing the phy init, itself copied from the Linux code passing all checkpatch checks.
Could you change it to for (i = 0; i <
PHY_COUNT; i++) please ?Sure
Thank you.
( I'm still surprised checkpatch doesn't warn about it, I was quite sure it was one of the checks at some point, hmmmmm. )
Quoted 24 lines
Quoted 23 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Review
Quoted 5 lines
(quoted diff) +4
-0+ if (!priv->phys[i].dev) + continue; + + ret = generic_phy_power_on(&priv->phys[i]);Do we really need to turn on all the PHYs ?
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Yes
Then should we have something like clk_bulk_*(), but for phys ?
Eventually, yes, but this goes beyond a fix.
The merge window is open for quite a bit longer, so doing this in a generic way would be appreciated.
btw while you're at it, shouldn't the
PHY_COUNTbe replaced with some PHY count detection by reading the DT ? ( I don't have the hardware and I don't know the amlogic SoCs though )Quoted 7 lines
Quoted 3 lines
Hmm, the PHYs list can have some holes (i.e only the second PHY could be used on 3), and the name of the PHY determines it's type and position (PHY1 is a special OTG phy) this is why we loop over a fixed array and check if the PHY pointer exists.
Um, that sounds like a vaguely familiar problem. Is that an issue with mapping between controller and a USB PHY ? Is that mapping fixed or is it configured from DT ?
Mapping is done via DT, all PHYs are optional depending on the board layout.
Quoted 3 lines
And then, should all PHYs really be powered on,
or should only the PHY matching the currently used controller be powered on ?All PHYs are connected to a glue that muxes 1 PHY between DWC2 and DWC3, and the other USB2 PHYs (for now 1, but previous SoCs had 2) to DWC3, the USB3 PHY is muxed between PCIe to dw-pcie and DWC3.
So we power-on only the PHYs specified in DT, thus the:
if (!priv->phys[i].dev) continue;
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
I attached the USB complex diagram if you need it.
OK, thanks for clarifying. Now, can you document this in the commit message, so we have this information stored somewhere for future reference ? This would be real useful.
Yes sure.
Thanks